-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFR32: Device Attestation Credentials Provider implementation. #20686
Merged
woody-apple
merged 2 commits into
project-chip:master
from
rcasallas-silabs:efr32_dac_provider_v2
Jul 16, 2022
Merged
EFR32: Device Attestation Credentials Provider implementation. #20686
woody-apple
merged 2 commits into
project-chip:master
from
rcasallas-silabs:efr32_dac_provider_v2
Jul 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
July 13, 2022 17:41
pullapprove
bot
requested review from
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 13, 2022 17:41
PR #20686: Size comparison from b682834 to 948e00a Increases (4 builds for cc13x2_26x2, cyw30739)
Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rcasallas-silabs
force-pushed
the
efr32_dac_provider_v2
branch
from
July 14, 2022 12:38
47ec78a
to
1c4b4cc
Compare
PR #20686: Size comparison from ece3732 to 1c4b4cc Increases (3 builds for cc13x2_26x2, esp32)
Decreases (6 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Jul 14, 2022
woody-apple
approved these changes
Jul 16, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2022
* EFR32: Device Attestation Credentials Provider implementation. * EFR32 DAC Provider: Review comments applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
USERDATA is only 1kB in EFR32 Series 2, which left very little space for other manufacturer tokens, if any.
Change overview
EFR32 Attestation credentials moved the last page of main flash.
Testing
Tested on EFR32. This change has no effect on other platforms.