Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Ballast Configuration cluster in controller-clusters. #20685

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Enable Ballast Configuration cluster in controller-clusters. #20685

merged 1 commit into from
Jul 14, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Also aligns the cluster XML with the Matter spec.

Problem

Ballast Configuration XML does not match spec and is not enabled in controller-clusters.

Change overview

Fix both of those.

Testing

Looked at the generated code.

@bzbarsky-apple
Enable Ballast Configuration cluster in controller-clusters.
b3ba853 
Also aligns the cluster XML with the Matter spec.
@bzbarsky-apple bzbarsky-apple force-pushed the enable-ballast-configuration branch from de93954 to b3ba853 Compare July 13, 2022 18:11
@github-actions
Copy link

github-actions bot commented Jul 13, 2022 •
edited
Loading

PR #20685: Size comparison from b682834 to b3ba853

Increases (8 builds for cc13x2_26x2, cyw30739, esp32, linux)
platform target config section b682834 b3ba853 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 618583 618591 8 0.0
.text 541936 541944 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 178080 178088 8 0.0
shell LP_CC2652R7 (read only) 658766 658774 8 0.0
.text 573532 573540 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583010 583018 8 0.0
.app_xip_area 462612 462620 8 0.0
esp32 all-clusters-app m5stack (read only) 1074031 1074051 20 0.0
.flash.text 1068647 1068667 20 0.0
linux chip-tool debug (read only) 10347505 10350889 3384 0.0
(read/write) 621728 621760 32 0.0
.data.rel.ro 587360 587392 32 0.0
.rodata 516533 516917 384 0.1
.text 8400580 8403556 2976 0.0
chip-tool-ipv6only arm64 (read only) 10066476 10069756 3280 0.0
(read/write) 686913 686961 48 0.0
.data.rel.ro 622984 623032 48 0.0
.rodata 479532 479708 176 0.0
.text 8024356 8027444 3088 0.0
tv-casting-app debug (read only) 5563561 5566873 3312 0.1
.rodata 342825 343241 416 0.1
.text 4944082 4946978 2896 0.1
Decreases (3 builds for cc13x2_26x2, telink)
platform target config section b682834 b3ba853 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 664255 664247 -8 -0.0
.text 579208 579200 -8 -0.0
shell LP_CC2652R7 (read/write) 187960 187952 -8 -0.0
telink light-switch-app tlsr9518adk80d text 565734 565732 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b682834 b3ba853 change % change
bl602 lighting-app bl602 (read/write) 1397634 1397634 0 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1058640 1058640 0 0.0
bl602+rpc (read/write) 1443066 1443066 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1090324 1090324 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666275 666275 0 0.0
(read/write) 184948 184948 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88139 88139 0 0.0
.text 577820 577820 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632083 632083 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77379 77379 0 0.0
.text 554380 554380 0 0.0
lock-ftd LP_CC2652R7 (read only) 669183 669183 0 0.0
(read/write) 172184 172184 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76279 76279 0 0.0
.text 592424 592424 0 0.0
lock-mtd LP_CC2652R7 (read only) 618583 618591 8 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76159 76159 0 0.0
.text 541936 541944 8 0.0
pump-app LP_CC2652R7 (read only) 678431 678431 0 0.0
(read/write) 163784 163784 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88703 88703 0 0.0
.text 589244 589244 0 0.0
pump-controller-app LP_CC2652R7 (read only) 664255 664247 -8 -0.0
(read/write) 178080 178088 8 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84567 84567 0 0.0
.text 579208 579200 -8 -0.0
shell LP_CC2652R7 (read only) 658766 658774 8 0.0
(read/write) 187960 187952 -8 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84918 84918 0 0.0
.text 573532 573540 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579622 0 0.0
.app_xip_area 458376 458376 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585574 585574 0 0.0
.app_xip_area 459600 459600 0 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583010 583018 8 0.0
.app_xip_area 462612 462620 8 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081700 1081700 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946636 946636 0 0.0
BRD4161A+rpc (read/write) 1136012 1136012 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 984056 984056 0 0.0
BRD4161A+rs911x (read/write) 948172 948172 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 805336 805336 0 0.0
lock-app BRD4161A+wf200 (read/write) 1129096 1129096 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982828 982828 0 0.0
window-app BRD4161A (read/write) 1075508 1075508 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938940 938940 0 0.0
esp32 all-clusters-app c3devkit (read only) 1020152 1020152 0 0.0
(read/write) 1485842 1485842 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215728 215728 0 0.0
.flash.text 1020152 1020152 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1074031 1074051 20 0.0
(read/write) 487904 487904 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246164 246164 0 0.0
.flash.text 1068647 1068667 20 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658832 658832 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581524 581524 0 0.0
lock k32w061+release (read/write) 685684 685684 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607900 607900 0 0.0
linux all-clusters-app debug (read only) 2961225 2961225 0 0.0
(read/write) 154752 154752 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 263805 263805 0 0.0
.text 2520210 2520210 0 0.0
all-clusters-minimal-app debug (read only) 2813801 2813801 0 0.0
(read/write) 146688 146688 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265533 265533 0 0.0
.text 2373234 2373234 0 0.0
bridge-app debug+rpc (read only) 2315849 2315849 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198208 198208 0 0.0
.text 1955906 1955906 0 0.0
chip-tool debug (read only) 10347505 10350889 3384 0.0
(read/write) 621728 621760 32 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587360 587392 32 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 516533 516917 384 0.1
.text 8400580 8403556 2976 0.0
chip-tool-ipv6only arm64 (read only) 10066476 10069756 3280 0.0
(read/write) 686913 686961 48 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 622984 623032 48 0.0
.dynamic 528 528 0 0.0
.got 13736 13736 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 479532 479708 176 0.0
.text 8024356 8027444 3088 0.0
lighting-app debug+rpc (read only) 2551577 2551577 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213896 213896 0 0.0
.text 2167714 2167714 0 0.0
lock-app debug (read only) 2516313 2516313 0 0.0
(read/write) 124512 124512 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 228936 228936 0 0.0
.text 2122210 2122210 0 0.0
ota-provider-app debug (read only) 2322689 2322689 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203704 203704 0 0.0
.text 1956210 1956210 0 0.0
ota-requestor-app debug (read only) 2439761 2439761 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207488 207488 0 0.0
.text 2061122 2061122 0 0.0
shell debug (read only) 2551569 2551569 0 0.0
(read/write) 141104 141104 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227954 227954 0 0.0
.text 2166514 2166514 0 0.0
thermostat-no-ble arm64 (read only) 2595668 2595668 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165668 165668 0 0.0
.text 2190224 2190224 0 0.0
tv-app debug (read only) 3102609 3102609 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2665490 2665490 0 0.0
tv-casting-app debug (read only) 5563561 5566873 3312 0.1
(read/write) 161456 161456 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102536 102536 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 342825 343241 416 0.1
.text 4944082 4946978 2896 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448312 2448312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410956 1410956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175411 1175411 0 0.0
bss 142900 142900 0 0.0
rodata 142076 142076 0 0.0
text 811544 811544 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155607 1155607 0 0.0
bss 142136 142136 0 0.0
rodata 133608 133608 0 0.0
text 800988 800988 0 0.0
p6 all-clusters-app default (read/write) 2566392 2566392 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1524656 1524656 0 0.0
all-clusters-minimal-app default (read/write) 2511688 2511688 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1469952 1469952 0 0.0
light-app default (read/write) 2441616 2441616 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1399880 1399880 0 0.0
lock-app default (read/write) 2468768 2468768 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1427032 1427032 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797540 797540 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565734 565732 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 817372 817372 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 582058 582058 0 0.0

@andy31415 andy31415 merged commit 56b387d into project-chip:master Jul 14, 2022
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@bzbarsky-apple @web-flow
Enable Ballast Configuration cluster in controller-clusters. (#20685)
d1e2eed 
Also aligns the cluster XML with the Matter spec.
@bzbarsky-apple bzbarsky-apple deleted the enable-ballast-configuration branch July 14, 2022 14:40
woody-apple added a commit that referenced this pull request Jul 16, 2022
@woody-apple @bzbarsky-apple
Enable Ballast Configuration cluster in controller-clusters. (#20685) (…
f01a93f 
…#20728)

Also aligns the cluster XML with the Matter spec.

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehampson tehampson tehampson approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @msandstedt @tehampson @andy31415