-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable darwin framework tool tests. #20648
Merged
woody-apple
merged 1 commit into
project-chip:master
from
krypton36:EnableAndFixTestsOnDarwinFrameworkTool
Jul 14, 2022
Merged
Enable darwin framework tool tests. #20648
woody-apple
merged 1 commit into
project-chip:master
from
krypton36:EnableAndFixTestsOnDarwinFrameworkTool
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
July 12, 2022 20:40
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 12, 2022 20:40
PR #20648: Size comparison from 51decce to 84921a9 Increases (3 builds for cc13x2_26x2, esp32)
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
krypton36
force-pushed
the
EnableAndFixTestsOnDarwinFrameworkTool
branch
from
July 13, 2022 14:23
84921a9
to
15e4689
Compare
PR #20648: Size comparison from a05cc3e to 15e4689 Increases (2 builds for cc13x2_26x2, telink)
Decreases (6 builds for bl602, cc13x2_26x2, cyw30739, esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
EnableAndFixTestsOnDarwinFrameworkTool
branch
from
July 13, 2022 16:28
15e4689
to
7b6bd4a
Compare
PR #20648: Size comparison from b682834 to 7b6bd4a Increases (6 builds for cc13x2_26x2, cyw30739, esp32, telink)
Decreases (3 builds for cc13x2_26x2, nrfconnect)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 14, 2022
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
krypton36
force-pushed
the
EnableAndFixTestsOnDarwinFrameworkTool
branch
from
July 14, 2022 14:10
7b6bd4a
to
ae799d9
Compare
krypton36
force-pushed
the
EnableAndFixTestsOnDarwinFrameworkTool
branch
from
July 14, 2022 14:20
ae799d9
to
b37ac1f
Compare
PR #20648: Size comparison from 4bb1abd to b37ac1f Increases (1 build for esp32)
Decreases (3 builds for bl602, telink)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
pushed a commit
that referenced
this pull request
Jul 15, 2022
Co-authored-by: krypton36 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI tests are not running for darwin-framework-tool.
Change overview
Testing