Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate RCAC Prior to Setting on AddTrustedRootCertificate Command. #20562

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Validate RCAC Prior to Setting on AddTrustedRootCertificate Command. #20562

merged 2 commits into from
Jul 15, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Ticket: #17208

Change overview

Added RCAC validation API.

Testing

Added new tests for ValidateChipRCAC() function.

@boring-cyborg boring-cyborg bot added the app label Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

PR #20562: Size comparison from d271f7b to bc91961

Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d271f7b bc91961 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666227 176 0.0
.text 577668 577844 176 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 632027 168 0.0
.text 554228 554396 168 0.0
lock-ftd LP_CC2652R7 (read only) 668959 669135 176 0.0
.text 592272 592448 176 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618535 168 0.0
.text 541792 541960 168 0.0
pump-app LP_CC2652R7 (read only) 677991 678159 168 0.0
.text 589076 589244 168 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663983 168 0.0
.text 579040 579208 168 0.0
shell LP_CC2652R7 (read only) 658550 658718 168 0.0
.text 573388 573556 168 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579550 579718 168 0.0
.app_xip_area 458304 458472 168 0.0
lock cyw930739m2evb_01 (read/write) 585478 585646 168 0.0
.app_xip_area 459504 459672 168 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582606 582774 168 0.0
.app_xip_area 462208 462376 168 0.0
efr32 lighting-app BRD4161A (read/write) 1081316 1081556 240 0.0
.text 946252 946492 240 0.0
BRD4161A+rpc (read/write) 1135644 1135868 224 0.0
.text 983688 983912 224 0.0
BRD4161A+rs911x (read/write) 947804 948044 240 0.0
.text 804968 805208 240 0.0
lock-app BRD4161A+wf200 (read/write) 1128616 1128792 176 0.0
.text 982348 982524 176 0.0
window-app BRD4161A (read/write) 1075108 1075348 240 0.0
.text 938540 938780 240 0.0
esp32 all-clusters-app c3devkit (read only) 1019992 1020188 196 0.0
.flash.text 1019992 1020188 196 0.0
m5stack (read only) 1073943 1074135 192 0.0
.flash.text 1068559 1068751 192 0.0
k32w light k32w061+release (read/write) 658704 658880 176 0.0
.text 581396 581572 176 0.0
lock k32w061+release (read/write) 685468 685644 176 0.0
.text 607684 607860 176 0.0
linux all-clusters-app debug (read only) 2960481 2961617 1136 0.0
.text 2519746 2520882 1136 0.0
all-clusters-minimal-app debug (read only) 2813025 2814161 1136 0.0
.text 2372770 2373906 1136 0.0
bridge-app debug+rpc (read only) 2315225 2316377 1152 0.0
.text 1955538 1956690 1152 0.1
chip-tool debug (read only) 10316465 10317617 1152 0.0
.text 8369844 8370996 1152 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10008404 10009412 1008 0.0
.text 7970084 7971092 1008 0.0
lighting-app debug+rpc (read only) 2550969 2552105 1136 0.0
.text 2167362 2168498 1136 0.1
lock-app debug (read only) 2515569 2516705 1136 0.0
.text 2121746 2122882 1136 0.1
ota-provider-app debug (read only) 2322049 2323185 1136 0.0
.text 1955858 1956994 1136 0.1
ota-requestor-app debug (read only) 2439169 2440305 1136 0.0
.text 2060818 2061954 1136 0.1
shell debug (read only) 2550825 2551961 1136 0.0
.text 2166050 2167186 1136 0.1
thermostat-no-ble arm64 (read only) 2595076 2596068 992 0.0
.text 2189888 2190880 992 0.0
tv-app debug (read only) 3101969 3103105 1136 0.0
.text 2665138 2666274 1136 0.0
tv-casting-app debug (read only) 5577561 5578697 1136 0.0
.text 4956466 4957602 1136 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447912 2448104 192 0.0
.text 1410556 1410748 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1175111 176 0.0
text 811332 811508 176 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155307 176 0.0
text 800776 800952 176 0.0
p6 all-clusters-app default (read/write) 2565256 2565496 240 0.0
.text 1523520 1523760 240 0.0
all-clusters-minimal-app default (read/write) 2510320 2510560 240 0.0
.text 1468584 1468824 240 0.0
light-app default (read/write) 2440600 2440840 240 0.0
.text 1398864 1399104 240 0.0
lock-app default (read/write) 2467856 2468096 240 0.0
.text 1426120 1426360 240 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797300 208 0.0
text 565564 565776 212 0.0
lighting-app tlsr9518adk80d (read/write) 816924 817132 208 0.0
text 581890 582100 210 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section d271f7b bc91961 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185172 184996 -176 -0.1
lock-ftd LP_CC2652R7 (read/write) 172408 172232 -176 -0.1
pump-app LP_CC2652R7 (read/write) 164224 164056 -168 -0.1
pump-controller-app LP_CC2652R7 (read/write) 178520 178352 -168 -0.1
shell LP_CC2652R7 (read/write) 188176 188008 -168 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d271f7b bc91961 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666227 176 0.0
(read/write) 185172 184996 -176 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577668 577844 176 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 632027 168 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554228 554396 168 0.0
lock-ftd LP_CC2652R7 (read only) 668959 669135 176 0.0
(read/write) 172408 172232 -176 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592272 592448 176 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618535 168 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541792 541960 168 0.0
pump-app LP_CC2652R7 (read only) 677991 678159 168 0.0
(read/write) 164224 164056 -168 -0.1
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589076 589244 168 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663983 168 0.0
(read/write) 178520 178352 -168 -0.1
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579040 579208 168 0.0
shell LP_CC2652R7 (read only) 658550 658718 168 0.0
(read/write) 188176 188008 -168 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573388 573556 168 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579550 579718 168 0.0
.app_xip_area 458304 458472 168 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585478 585646 168 0.0
.app_xip_area 459504 459672 168 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582606 582774 168 0.0
.app_xip_area 462208 462376 168 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081316 1081556 240 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946252 946492 240 0.0
BRD4161A+rpc (read/write) 1135644 1135868 224 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983688 983912 224 0.0
BRD4161A+rs911x (read/write) 947804 948044 240 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 804968 805208 240 0.0
lock-app BRD4161A+wf200 (read/write) 1128616 1128792 176 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982348 982524 176 0.0
window-app BRD4161A (read/write) 1075108 1075348 240 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938540 938780 240 0.0
esp32 all-clusters-app c3devkit (read only) 1019992 1020188 196 0.0
(read/write) 1485570 1485570 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215456 215456 0 0.0
.flash.text 1019992 1020188 196 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073943 1074135 192 0.0
(read/write) 487648 487648 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245908 245908 0 0.0
.flash.text 1068559 1068751 192 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658704 658880 176 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581396 581572 176 0.0
lock k32w061+release (read/write) 685468 685644 176 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607684 607860 176 0.0
linux all-clusters-app debug (read only) 2960481 2961617 1136 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263549 263549 0 0.0
.text 2519746 2520882 1136 0.0
all-clusters-minimal-app debug (read only) 2813025 2814161 1136 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265245 265245 0 0.0
.text 2372770 2373906 1136 0.0
bridge-app debug+rpc (read only) 2315225 2316377 1152 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1955538 1956690 1152 0.1
chip-tool debug (read only) 10316465 10317617 1152 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 514933 514933 0 0.0
.text 8369844 8370996 1152 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10008404 10009412 1008 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477652 477652 0 0.0
.text 7970084 7971092 1008 0.0
lighting-app debug+rpc (read only) 2550969 2552105 1136 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2167362 2168498 1136 0.1
lock-app debug (read only) 2515569 2516705 1136 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228680 228680 0 0.0
.text 2121746 2122882 1136 0.1
ota-provider-app debug (read only) 2322049 2323185 1136 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1955858 1956994 1136 0.1
ota-requestor-app debug (read only) 2439169 2440305 1136 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207200 207200 0 0.0
.text 2060818 2061954 1136 0.1
shell debug (read only) 2550825 2551961 1136 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227698 227698 0 0.0
.text 2166050 2167186 1136 0.1
thermostat-no-ble arm64 (read only) 2595076 2596068 992 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189888 2190880 992 0.0
tv-app debug (read only) 3101969 3103105 1136 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2665138 2666274 1136 0.0
tv-casting-app debug (read only) 5577561 5578697 1136 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343145 343145 0 0.0
.text 4956466 4957602 1136 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2448104 192 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410748 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1175111 176 0.0
bss 142900 142900 0 0.0
rodata 141808 141808 0 0.0
text 811332 811508 176 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155307 176 0.0
bss 142136 142136 0 0.0
rodata 133340 133340 0 0.0
text 800776 800952 176 0.0
p6 all-clusters-app default (read/write) 2565256 2565496 240 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523520 1523760 240 0.0
all-clusters-minimal-app default (read/write) 2510320 2510560 240 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468584 1468824 240 0.0
light-app default (read/write) 2440600 2440840 240 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398864 1399104 240 0.0
lock-app default (read/write) 2467856 2468096 240 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426120 1426360 240 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797300 208 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565564 565776 212 0.0
lighting-app tlsr9518adk80d (read/write) 816924 817132 208 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581890 582100 210 0.0

@emargolis emargolis force-pushed the emargolis/feature/chip-cert-validate-rcac branch from bc91961 to c60ba9e Compare July 12, 2022 00:41
@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

PR #20562: Size comparison from ef1a8fc to c60ba9e

Increases (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ef1a8fc c60ba9e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666243 666475 232 0.0
.text 577788 578020 232 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632051 632259 208 0.0
.text 554348 554556 208 0.0
lock-ftd LP_CC2652R7 (read only) 669151 669367 216 0.0
.text 592392 592608 216 0.0
lock-mtd LP_CC2652R7 (read only) 618551 618783 232 0.0
.text 541904 542136 232 0.0
pump-app LP_CC2652R7 (read only) 678183 678399 216 0.0
.text 589196 589412 216 0.0
pump-controller-app LP_CC2652R7 (read only) 664007 664223 216 0.0
.text 579160 579376 216 0.0
shell LP_CC2652R7 (read only) 658742 658974 232 0.0
.text 573508 573740 232 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579838 216 0.0
.app_xip_area 458376 458592 216 0.0
lock cyw930739m2evb_01 (read/write) 585542 585766 224 0.0
.app_xip_area 459568 459792 224 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582774 582990 216 0.0
.app_xip_area 462376 462592 216 0.0
efr32 lighting-app BRD4161A (read/write) 1081436 1081740 304 0.0
.text 946372 946676 304 0.0
BRD4161A+rpc (read/write) 1135764 1136068 304 0.0
.text 983808 984112 304 0.0
BRD4161A+rs911x (read/write) 947924 948228 304 0.0
.text 805088 805392 304 0.0
lock-app BRD4161A+wf200 (read/write) 1128816 1129040 224 0.0
.text 982548 982772 224 0.0
window-app BRD4161A (read/write) 1075244 1075548 304 0.0
.text 938676 938980 304 0.0
esp32 all-clusters-app c3devkit (read only) 1020100 1020344 244 0.0
.flash.text 1020100 1020344 244 0.0
m5stack (read only) 1073987 1074335 348 0.0
.flash.text 1068603 1068951 348 0.0
k32w light k32w061+release (read/write) 658832 659072 240 0.0
.text 581524 581764 240 0.0
lock k32w061+release (read/write) 685652 685876 224 0.0
.text 607868 608092 224 0.0
linux all-clusters-app debug (read only) 2960705 2961905 1200 0.0
.text 2519906 2521106 1200 0.0
all-clusters-minimal-app debug (read only) 2813281 2814449 1168 0.0
.text 2372930 2374130 1200 0.1
bridge-app debug+rpc (read only) 2315449 2316649 1200 0.1
.text 1955698 1956898 1200 0.1
chip-tool debug (read only) 10345025 10345057 32 0.0
.text 8397476 8397508 32 0.0
lighting-app debug+rpc (read only) 2551193 2552425 1232 0.0
.rodata 213704 213736 32 0.0
.text 2167522 2168722 1200 0.1
lock-app debug (read only) 2515793 2516993 1200 0.0
.text 2121906 2123106 1200 0.1
ota-provider-app debug (read only) 2322305 2323505 1200 0.1
.text 1956018 1957218 1200 0.1
ota-requestor-app debug (read only) 2439361 2440529 1168 0.0
.text 2060914 2062114 1200 0.1
shell debug (read only) 2551049 2552233 1184 0.0
.text 2166210 2167394 1184 0.1
thermostat-no-ble arm64 (read only) 2595316 2596308 992 0.0
.text 2190064 2191088 1024 0.0
tv-app debug (read only) 3102225 3103409 1184 0.0
.text 2665298 2666482 1184 0.0
tv-casting-app debug (read only) 5577785 5578985 1200 0.0
.text 4956626 4957826 1200 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448112 2448120 8 0.0
.text 1410756 1410764 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175119 1175343 224 0.0
text 811448 811672 224 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155315 1155539 224 0.0
text 800892 801116 224 0.0
p6 all-clusters-app default (read/write) 2565392 2565696 304 0.0
.text 1523656 1523960 304 0.0
all-clusters-minimal-app default (read/write) 2510440 2510760 320 0.0
.text 1468704 1469024 320 0.0
light-app default (read/write) 2440736 2441056 320 0.0
.text 1399000 1399320 320 0.0
lock-app default (read/write) 2467992 2468312 320 0.0
.text 1426256 1426576 320 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797268 797532 264 0.0
text 565668 565930 262 0.0
lighting-app tlsr9518adk80d (read/write) 817100 817364 264 0.0
text 581994 582258 264 0.0
Decreases (9 builds for cc13x2_26x2, linux)
platform target config section ef1a8fc c60ba9e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 184980 184748 -232 -0.1
lock-ftd LP_CC2652R7 (read/write) 172216 172000 -216 -0.1
pump-app LP_CC2652R7 (read/write) 164032 163816 -216 -0.1
pump-controller-app LP_CC2652R7 (read/write) 178328 178112 -216 -0.1
shell LP_CC2652R7 (read/write) 187984 187752 -232 -0.1
linux all-clusters-minimal-app debug .rodata 265341 265309 -32 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10031716 1003165 -64 -0.0
(read/write) 684529 684513 -16 -0.0
.data.rel.ro 623432 623408 -24 -0.0
.text 7992788 7992740 -48 -0.0
ota-requestor-app debug .rodata 207296 207264 -32 -0.0
thermostat-no-ble arm64 (read/write) 158289 158257 -32 -0.0
.data.rel.ro 83240 83216 -24 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ef1a8fc c60ba9e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666243 666475 232 0.0
(read/write) 184980 184748 -232 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88139 88139 0 0.0
.text 577788 578020 232 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632051 632259 208 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77379 77379 0 0.0
.text 554348 554556 208 0.0
lock-ftd LP_CC2652R7 (read only) 669151 669367 216 0.0
(read/write) 172216 172000 -216 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76279 76279 0 0.0
.text 592392 592608 216 0.0
lock-mtd LP_CC2652R7 (read only) 618551 618783 232 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76159 76159 0 0.0
.text 541904 542136 232 0.0
pump-app LP_CC2652R7 (read only) 678183 678399 216 0.0
(read/write) 164032 163816 -216 -0.1
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88503 88503 0 0.0
.text 589196 589412 216 0.0
pump-controller-app LP_CC2652R7 (read only) 664007 664223 216 0.0
(read/write) 178328 178112 -216 -0.1
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84367 84367 0 0.0
.text 579160 579376 216 0.0
shell LP_CC2652R7 (read only) 658742 658974 232 0.0
(read/write) 187984 187752 -232 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84918 84918 0 0.0
.text 573508 573740 232 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579838 216 0.0
.app_xip_area 458376 458592 216 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585542 585766 224 0.0
.app_xip_area 459568 459792 224 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582774 582990 216 0.0
.app_xip_area 462376 462592 216 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081436 1081740 304 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946372 946676 304 0.0
BRD4161A+rpc (read/write) 1135764 1136068 304 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983808 984112 304 0.0
BRD4161A+rs911x (read/write) 947924 948228 304 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 805088 805392 304 0.0
lock-app BRD4161A+wf200 (read/write) 1128816 1129040 224 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982548 982772 224 0.0
window-app BRD4161A (read/write) 1075244 1075548 304 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938676 938980 304 0.0
esp32 all-clusters-app c3devkit (read only) 1020100 1020344 244 0.0
(read/write) 1485642 1485642 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215528 215528 0 0.0
.flash.text 1020100 1020344 244 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073987 1074335 348 0.0
(read/write) 487712 487712 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245972 245972 0 0.0
.flash.text 1068603 1068951 348 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658832 659072 240 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581524 581764 240 0.0
lock k32w061+release (read/write) 685652 685876 224 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607868 608092 224 0.0
linux all-clusters-app debug (read only) 2960705 2961905 1200 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263613 263613 0 0.0
.text 2519906 2521106 1200 0.0
all-clusters-minimal-app debug (read only) 2813281 2814449 1168 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265341 265309 -32 -0.0
.text 2372930 2374130 1200 0.1
bridge-app debug+rpc (read only) 2315449 2316649 1200 0.1
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198016 198016 0 0.0
.text 1955698 1956898 1200 0.1
chip-tool debug (read only) 10345025 10345057 32 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 515861 515861 0 0.0
.text 8397476 8397508 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10031716 1003165 -64 -0.0
(read/write) 684529 684513 -16 -0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623408 -24 -0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 478260 478260 0 0.0
.text 7992788 7992740 -48 -0.0
lighting-app debug+rpc (read only) 2551193 2552425 1232 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213704 213736 32 0.0
.text 2167522 2168722 1200 0.1
lock-app debug (read only) 2515793 2516993 1200 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228744 228744 0 0.0
.text 2121906 2123106 1200 0.1
ota-provider-app debug (read only) 2322305 2323505 1200 0.1
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203512 203512 0 0.0
.text 1956018 1957218 1200 0.1
ota-requestor-app debug (read only) 2439361 2440529 1168 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207296 207264 -32 -0.0
.text 2060914 2062114 1200 0.1
shell debug (read only) 2551049 2552233 1184 0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227762 227762 0 0.0
.text 2166210 2167394 1184 0.1
thermostat-no-ble arm64 (read only) 2595316 2596308 992 0.0
(read/write) 158289 158257 -32 -0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83216 -24 -0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165476 165476 0 0.0
.text 2190064 2191088 1024 0.0
tv-app debug (read only) 3102225 3103409 1184 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249024 249024 0 0.0
.text 2665298 2666482 1184 0.0
tv-casting-app debug (read only) 5577785 5578985 1200 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343209 343209 0 0.0
.text 4956626 4957826 1200 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448112 2448120 8 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410756 1410764 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175119 1175343 224 0.0
bss 142900 142900 0 0.0
rodata 141880 141880 0 0.0
text 811448 811672 224 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155315 1155539 224 0.0
bss 142136 142136 0 0.0
rodata 133412 133412 0 0.0
text 800892 801116 224 0.0
p6 all-clusters-app default (read/write) 2565392 2565696 304 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523656 1523960 304 0.0
all-clusters-minimal-app default (read/write) 2510440 2510760 320 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468704 1469024 320 0.0
light-app default (read/write) 2440736 2441056 320 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1399000 1399320 320 0.0
lock-app default (read/write) 2467992 2468312 320 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426256 1426576 320 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797268 797532 264 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565668 565930 262 0.0
lighting-app tlsr9518adk80d (read/write) 817100 817364 264 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581994 582258 264 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jul 15, 2022
View reviewed changes
src/credentials/CHIPCert.h Outdated Show resolved Hide resolved
@emargolis emargolis merged commit ed040c2 into project-chip:master Jul 15, 2022
@emargolis emargolis mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @tcarmelveilleux @bzbarsky-apple