-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting of OTA Provider delegate through the controller #20517
Merged
woody-apple
merged 3 commits into
project-chip:master
from
carol-apple:darwin_framework_ota_delegate_controller_hookup
Jul 9, 2022
Merged
Allow setting of OTA Provider delegate through the controller #20517
woody-apple
merged 3 commits into
project-chip:master
from
carol-apple:darwin_framework_ota_delegate_controller_hookup
Jul 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk and
saurabhst
July 8, 2022 21:41
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 8, 2022 21:41
carol-apple
force-pushed
the
darwin_framework_ota_delegate_controller_hookup
branch
from
July 8, 2022 21:47
005dff8
to
0de6fab
Compare
PR #20517: Size comparison from d23106c to 0de6fab Increases (4 builds for cyw30739, telink)
Decreases (1 build for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes.
woody-apple
approved these changes
Jul 9, 2022
PR #20517: Size comparison from d23106c to 5ad526a Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2022
* Allow setting of OTA Provider delegate through the controller * Update src/darwin/Framework/CHIP/MTRDeviceController.mm * Update src/darwin/Framework/CHIP/MTRDeviceController.h Co-authored-by: Justin Wood <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 13, 2022
#20524) * Allow setting of OTA Provider delegate through the controller * Update src/darwin/Framework/CHIP/MTRDeviceController.mm * Update src/darwin/Framework/CHIP/MTRDeviceController.h Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Carol Yang <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OTA Provider delegate and the bridge exist but there is no hook up for the two that exist.
Change overview
Create a setter in the controller to allow setting of an OTA Provider delegate
Testing
In combination with #20516, able to see that a darwin controller acting as an OTA Provider delegate is getting called when the OTA Provider Cluster commands are issued.