Don't sweat interactive mode in build_examples.py #20389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
|
PR #20389: Size comparison from 3340fc2 to af5074d Increases (1 build for k32w)
Decreases (3 builds for nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 6, 2022
Damian-Nordic
approved these changes
Jul 6, 2022
mspang
force-pushed
the
for-chip/dont-sweat-readline
branch
from
af5074d to
09aef6a
Compare
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
mspang
force-pushed
the
for-chip/dont-sweat-readline
branch
from
09aef6a to
c56ebd1
Compare
|
PR #20389: Size comparison from 9e982ce to c56ebd1 Increases (1 build for esp32)
Decreases (1 build for nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mspang
changed the title
woody-apple
added a commit
that referenced
this pull request
Jul 7, 2022
As of 3340fc2 ("Switch from readline to editline (#20330)") there is no longer an issue with respect to the availability of libreadline. Co-authored-by: Michael Spang <[email protected]>
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 12, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
|
@mspang which CI test covers this? It looks like examples-linux-arm CI test is still using |
This was referenced Jul 12, 2022
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 12, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 13, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 13, 2022
As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline.
andy31415
pushed a commit
that referenced
this pull request
Jul 14, 2022
…20600) * Switch from readline to editline (#20330) Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline. * Don't sweat interactive mode in build_examples.py (#20389) As of 3340fc2 ("Switch from readline to editline (#20330)") there is no longer an issue with respect to the availability of libreadline. * Target non-interactive Linux example build in CI (#20635) Co-authored-by: Michael Spang <[email protected]>
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Sep 9, 2022
…roject-chip#20600) * Switch from readline to editline (project-chip#20330) Readline is GPL'd software and may not be available in the build environment. Vendor editline which is permissively licensed and drop it in as a replacement for readline. * Don't sweat interactive mode in build_examples.py (project-chip#20389) As of 3340fc2 ("Switch from readline to editline (project-chip#20330)") there is no longer an issue with respect to the availability of libreadline. * Target non-interactive Linux example build in CI (project-chip#20635) Co-authored-by: Michael Spang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
build_examples.py tries to avoid interactive mode on certain platforms.
Change overview
As of 3340fc2 ("Switch from readline to editline (#20330)") there is
no longer an issue with respect to the availability of libreadline.
Remove the special handling.
Testing
CI