Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stubbed-out CHIP v1 clusters from SiLabs #2038

Merged
merged 21 commits into from
Aug 31, 2020

Conversation

rwalker-apple
Copy link
Contributor

@rwalker-apple rwalker-apple commented Aug 10, 2020

Problem

CHIP v1 cluster implementations from SiLabs are not incorporated into any builds, although they serve as the baseline for command handling.

Summary of Changes

This PR sets up a framework for pulling these cluster implementations into our favorite sample application

Outstanding (which can be addressed separately):

  • pull in updates to endpoint_config.h (and stub out init functions in clusters-callback-stubs.c)
  • pull in updates to callback-stub.[ch] (where some callbacks know about cluster plugins)
  • pull in updated znet-bookkeeping.[ch] (for reporting)
  • pull in new gen_config.h (is normally named <PROJECT>.h)

NOTE to mergers: please retain all commits, as they contain SiLab's contribution provenance.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking like a great start! Some comments/questions inline.

@rwalker-apple rwalker-apple marked this pull request as ready for review August 10, 2020 22:01
@rwalker-apple rwalker-apple marked this pull request as draft August 10, 2020 23:08
@rwalker-apple rwalker-apple force-pushed the add-CHIPv1Clusters branch 2 times, most recently from 36f714b to aa21955 Compare August 14, 2020 19:19
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
[Unmapped],0,1
.debug_str,0,-1


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_str,0,-1
[Unmapped],0,-7


@rwalker-apple rwalker-apple marked this pull request as ready for review August 29, 2020 02:24
@rwalker-apple
Copy link
Contributor Author

@bzbarsky-apple @jelderton @hawk248 this is ready

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_efr32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-efr32-lock-example.out and ./pull_artifact/chip-efr32-lock-example.out:

sections,vmsize,filesize
.debug_info,0,136
.debug_line,0,115
.debug_str,0,96
[Unmapped],0,1


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_info,0,136
.debug_str,0,96
.debug_line,0,91
[Unmapped],0,-3


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 6784 6784
chip-wifi-echo.elf .flash.rodata 1960 1960
chip-wifi-echo.elf .dram0.bss 0 88
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,23530
.debug_line,0,23132
.debug_loc,0,17396
.flash.text,6784,6784
.debug_str,0,6264
.strtab,0,5311
.debug_frame,0,2704
.flash.rodata,1960,1960
.symtab,0,1936
.debug_abbrev,0,1148
.debug_ranges,0,952
.debug_aranges,0,448
.dram0.bss,88,0
[Unmapped],0,-1961


@rwalker-apple
Copy link
Contributor Author

@bzbarsky-apple @hawk248 ?

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sorting through this!

@@ -89,6 +89,39 @@ EmberAfStatus emberAfClusterSpecificCommandParse(EmberAfClusterCommand * cmd)
{
switch (cmd->apsFrame->clusterId)
{
case ZCL_BASIC_CLUSTER_ID:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add "Metering" (not "Simple Metering") and "Messaging" to the list, but that can happen in a followup....

// User options for plugin Color Control Cluster Server
#define EMBER_AF_PLUGIN_COLOR_CONTROL_SERVER_XY
#define EMBER_AF_PLUGIN_COLOR_CONTROL_SERVER_TEMP
#define EMBER_AF_PLUGIN_COLOR_CONTROL_SERVER_HSV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might cause @bhaskar-apple issues with bringing in the color control cluster. If it does, we can comment these out at that point.

@bzbarsky-apple
Copy link
Contributor

@andy31415 @BroderickCarlin @chrisdecenzo One more approval here, please?

@rwalker-apple
Copy link
Contributor Author

@mspang?

@mspang mspang merged commit 82af56e into project-chip:master Aug 31, 2020
mspang added a commit that referenced this pull request Aug 31, 2020
rwalker-apple pushed a commit that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants