-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stubbed-out CHIP v1 clusters from SiLabs #2038
add stubbed-out CHIP v1 clusters from SiLabs #2038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking like a great start! Some comments/questions inline.
8ede173
to
5727165
Compare
36f714b
to
aa21955
Compare
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
update znet-bookkeeping.c
add copyrights to all the source files
* update boolean -> bool
e460da2
to
2f9a6e7
Compare
@bzbarsky-apple @jelderton @hawk248 this is ready |
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "gn_efr32-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sorting through this!
@@ -89,6 +89,39 @@ EmberAfStatus emberAfClusterSpecificCommandParse(EmberAfClusterCommand * cmd) | |||
{ | |||
switch (cmd->apsFrame->clusterId) | |||
{ | |||
case ZCL_BASIC_CLUSTER_ID: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add "Metering" (not "Simple Metering") and "Messaging" to the list, but that can happen in a followup....
// User options for plugin Color Control Cluster Server | ||
#define EMBER_AF_PLUGIN_COLOR_CONTROL_SERVER_XY | ||
#define EMBER_AF_PLUGIN_COLOR_CONTROL_SERVER_TEMP | ||
#define EMBER_AF_PLUGIN_COLOR_CONTROL_SERVER_HSV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might cause @bhaskar-apple issues with bringing in the color control cluster. If it does, we can comment these out at that point.
@andy31415 @BroderickCarlin @chrisdecenzo One more approval here, please? |
Problem
CHIP v1 cluster implementations from SiLabs are not incorporated into any builds, although they serve as the baseline for command handling.
Summary of Changes
This PR sets up a framework for pulling these cluster implementations into our favorite sample application
Outstanding (which can be addressed separately):
<PROJECT>.h
)NOTE to mergers: please retain all commits, as they contain SiLab's contribution provenance.