-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test to do AddNOC, UpdateNOC, RemoveFabric tests #20327
Adding test to do AddNOC, UpdateNOC, RemoveFabric tests #20327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking testing updates
PR #20327: Size comparison from 770a2e2 to 5c87cc7 Increases (1 build for telink)
Decreases (4 builds for cc13x2_26x2, esp32, k32w, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
self.logger.info("Waiting for attribute read for CommissionedFabrics") | ||
startOfTestFabricCount = await self._GetCommissonedFabricCount(nodeid) | ||
|
||
tempFabric = chip.FabricAdmin.FabricAdmin(fabricId=3, fabricIndex=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should omit specifying a fabricId and index, and let FabricAdmin automatically pick one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #20430
Problem
AddNOC
,UpdateNOC
andRemoveFabric
in some sort of end-to-end integration testChange overview
AddNOC
,UpdateNOC
andRemoveFabric
Testing
run_python_test.py
confirmed test is running