Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python PersistentStorageDelegate to latest API description #20287

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Fix python PersistentStorageDelegate to latest API description #20287

merged 4 commits into from
Jul 5, 2022

Conversation

tehampson
Copy link
Contributor

Problem

  • Python PersistentStorageDelegate was not able to:
    • Store values that were 0 or given a nullptr.
    • Find values with size of 0.

Change overview

  • Fix python PersistentStorageDelegate to adhere to latest API description

Testing

  • Hacking scripts/build_python.sh to compile with chip_support_enable_storage_api_audit=true, and adding call to CHIPDeviceControllerFactory to audit persistent storage, confirmed that chip-repl now passes the audit

@restyled-io restyled-io bot mentioned this pull request Jul 4, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

PR #20287: Size comparison from fa2bf8d to 4078ec0

Increases (6 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section fa2bf8d 4078ec0 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 677367 677375 8 0.0
.text 588444 588452 8 0.0
shell LP_CC2652R7 (read/write) 188920 188928 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578806 578814 8 0.0
.app_xip_area 457576 457584 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154079 1154095 16 0.0
text 799776 799780 4 0.0
telink light-switch-app tlsr9518adk80d text 564980 564984 4 0.0
lighting-app tlsr9518adk80d (read/write) 816308 816316 8 0.0
text 581304 581306 2 0.0
Decreases (3 builds for cc13x2_26x2, esp32)
platform target config section fa2bf8d 4078ec0 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 164848 164840 -8 -0.0
shell LP_CC2652R7 (read only) 657806 657798 -8 -0.0
.text 572644 572636 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1018712 1018710 -2 -0.0
.flash.text 1018712 1018710 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fa2bf8d 4078ec0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665355 665355 0 0.0
(read/write) 185868 185868 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576940 576940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631355 631355 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77339 77339 0 0.0
.text 553692 553692 0 0.0
lock-ftd LP_CC2652R7 (read only) 668015 668015 0 0.0
(read/write) 173352 173352 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591344 591344 0 0.0
lock-mtd LP_CC2652R7 (read only) 617439 617439 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540880 540880 0 0.0
pump-app LP_CC2652R7 (read only) 677367 677375 8 0.0
(read/write) 164848 164840 -8 -0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588444 588452 8 0.0
pump-controller-app LP_CC2652R7 (read only) 663199 663199 0 0.0
(read/write) 179136 179136 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578440 578440 0 0.0
shell LP_CC2652R7 (read only) 657806 657798 -8 -0.0
(read/write) 188920 188928 8 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572644 572636 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578806 578814 8 0.0
.app_xip_area 457576 457584 8 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580470 580470 0 0.0
.app_xip_area 459040 459040 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581886 581886 0 0.0
.app_xip_area 461504 461504 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080252 1080252 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945188 945188 0 0.0
BRD4161A+rpc (read/write) 1134596 1134596 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982640 982640 0 0.0
BRD4161A+rs911x (read/write) 946340 946340 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803504 803504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126984 1126984 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980716 980716 0 0.0
window-app BRD4161A (read/write) 1074052 1074052 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937484 937484 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018712 1018710 -2 -0.0
(read/write) 1484906 1484906 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214792 214792 0 0.0
.flash.text 1018712 1018710 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072747 1072747 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067363 1067363 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658112 658112 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580804 580804 0 0.0
lock k32w061+release (read/write) 684692 684692 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606908 606908 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9923428 9923428 0 0.0
(read/write) 676609 676609 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615592 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470260 470260 0 0.0
.text 7911268 7911268 0 0.0
thermostat-no-ble arm64 (read only) 2591924 2591924 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186800 2186800 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1409956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173243 1173243 0 0.0
bss 142900 142900 0 0.0
rodata 141356 141356 0 0.0
text 810088 810088 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154079 1154095 16 0.0
bss 142136 142136 0 0.0
rodata 133288 133288 0 0.0
text 799776 799780 4 0.0
p6 all-clusters-app default (read/write) 2562896 2562896 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521160 1521160 0 0.0
all-clusters-minimal-app default (read/write) 2508760 2508760 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467024 1467024 0 0.0
light-app default (read/write) 2439128 2439128 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397392 1397392 0 0.0
lock-app default (read/write) 2465560 2465560 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423824 1423824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796480 796480 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 564980 564984 4 0.0
lighting-app tlsr9518adk80d (read/write) 816308 816316 8 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581304 581306 2 0.0

@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

PR #20287: Size comparison from fa2bf8d to 58efc9b

Increases (8 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
platform target config section fa2bf8d 58efc9b change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 677367 677375 8 0.0
.text 588444 588452 8 0.0
shell LP_CC2652R7 (read/write) 188920 188928 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578806 578814 8 0.0
.app_xip_area 457576 457584 8 0.0
esp32 all-clusters-app c3devkit (read only) 1018712 1018724 12 0.0
.flash.text 1018712 1018724 12 0.0
m5stack (read only) 1072747 1072759 12 0.0
.flash.text 1067363 1067375 12 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154079 1154095 16 0.0
text 799776 799780 4 0.0
telink light-switch-app tlsr9518adk80d text 564980 564982 2 0.0
lighting-app tlsr9518adk80d (read/write) 816308 816316 8 0.0
text 581304 581308 4 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section fa2bf8d 58efc9b change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 164848 164840 -8 -0.0
shell LP_CC2652R7 (read only) 657806 657798 -8 -0.0
.text 572644 572636 -8 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fa2bf8d 58efc9b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665355 665355 0 0.0
(read/write) 185868 185868 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576940 576940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631355 631355 0 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77339 77339 0 0.0
.text 553692 553692 0 0.0
lock-ftd LP_CC2652R7 (read only) 668015 668015 0 0.0
(read/write) 173352 173352 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591344 591344 0 0.0
lock-mtd LP_CC2652R7 (read only) 617439 617439 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540880 540880 0 0.0
pump-app LP_CC2652R7 (read only) 677367 677375 8 0.0
(read/write) 164848 164840 -8 -0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588444 588452 8 0.0
pump-controller-app LP_CC2652R7 (read only) 663199 663199 0 0.0
(read/write) 179136 179136 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578440 578440 0 0.0
shell LP_CC2652R7 (read only) 657806 657798 -8 -0.0
(read/write) 188920 188928 8 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572644 572636 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578806 578814 8 0.0
.app_xip_area 457576 457584 8 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580470 580470 0 0.0
.app_xip_area 459040 459040 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581886 581886 0 0.0
.app_xip_area 461504 461504 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080252 1080252 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945188 945188 0 0.0
BRD4161A+rpc (read/write) 1134596 1134596 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982640 982640 0 0.0
BRD4161A+rs911x (read/write) 946340 946340 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803504 803504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126984 1126984 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980716 980716 0 0.0
window-app BRD4161A (read/write) 1074052 1074052 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 937484 937484 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018712 1018724 12 0.0
(read/write) 1484906 1484906 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214792 214792 0 0.0
.flash.text 1018712 1018724 12 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072747 1072759 12 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067363 1067375 12 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658112 658112 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580804 580804 0 0.0
lock k32w061+release (read/write) 684692 684692 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606908 606908 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9923428 9923428 0 0.0
(read/write) 676609 676609 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615592 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470260 470260 0 0.0
.text 7911268 7911268 0 0.0
thermostat-no-ble arm64 (read only) 2591924 2591924 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186800 2186800 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1409956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173243 1173243 0 0.0
bss 142900 142900 0 0.0
rodata 141356 141356 0 0.0
text 810088 810088 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1154079 1154095 16 0.0
bss 142136 142136 0 0.0
rodata 133288 133288 0 0.0
text 799776 799780 4 0.0
p6 all-clusters-app default (read/write) 2562896 2562896 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521160 1521160 0 0.0
all-clusters-minimal-app default (read/write) 2508760 2508760 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467024 1467024 0 0.0
light-app default (read/write) 2439128 2439128 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397392 1397392 0 0.0
lock-app default (read/write) 2465560 2465560 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423824 1423824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796480 796480 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 564980 564982 2 0.0
lighting-app tlsr9518adk80d (read/write) 816308 816316 8 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581304 581308 4 0.0

@andy31415 andy31415 merged commit 777ee25 into project-chip:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@agners agners agners approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tehampson @agners @tcarmelveilleux @msandstedt @woody-apple @andy31415