-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Options to include Device instance information to factory partition #20269
Merged
tehampson
merged 3 commits into
project-chip:master
from
shubhamdp:esp32_factory_partition_generator
Jul 5, 2022
Merged
[ESP32] Options to include Device instance information to factory partition #20269
tehampson
merged 3 commits into
project-chip:master
from
shubhamdp:esp32_factory_partition_generator
Jul 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
July 4, 2022 10:41
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
July 4, 2022 10:41
PR #20269: Size comparison from 08cb351 to a86e267 Increases (4 builds for cc13x2_26x2, cyw30739, telink)
Decreases (3 builds for cc13x2_26x2, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
PR #20269: Size comparison from 08cb351 to 37a062f Increases above 0.2%:
Increases (16 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 5, 2022
dhrishi
approved these changes
Jul 5, 2022
tehampson
reviewed
Jul 5, 2022
Co-authored-by: tehampson <[email protected]>
tehampson
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #19996
Change overview
Added options to include device instance information into factory partition.
Testing
Manually tested: generated the factory partition with using script and verified by reading basic cluster attributes