Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that controllers are inited and shut down with the Matter lock held. #20178

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Assert that controllers are inited and shut down with the Matter lock held. #20178

merged 3 commits into from
Jul 11, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

We were not asserting this, and some consumers were not doing this,
leading to data races.

Problem

See above.

Change overview

Add asserts.

Testing

CI will tell.

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

PR #20178: Size comparison from d6c3519 to 8c46799

Increases (2 builds for linux, telink)
platform target config section d6c3519 8c46799 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893364 32 0.0
.text 7890212 7890244 32 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796292 796300 8 0.0
text 564816 564818 2 0.0
Full report (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d6c3519 8c46799 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665171 665171 0 0.0
(read/write) 186052 186052 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576764 576764 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653947 653947 0 0.0
(read/write) 196572 196572 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 562060 562060 0 0.0
lock-ftd LP_CC2652R7 (read only) 667759 667759 0 0.0
(read/write) 173608 173608 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591088 591088 0 0.0
lock-mtd LP_CC2652R7 (read only) 617175 617175 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540616 540616 0 0.0
pump-app LP_CC2652R7 (read only) 677207 677207 0 0.0
(read/write) 165008 165008 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588300 588300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663047 663047 0 0.0
(read/write) 179288 179288 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84271 84271 0 0.0
.text 578296 578296 0 0.0
shell LP_CC2652R7 (read only) 657622 657622 0 0.0
(read/write) 189104 189104 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84838 84838 0 0.0
.text 572468 572468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578662 578662 0 0.0
.app_xip_area 457440 457440 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580238 580238 0 0.0
.app_xip_area 458824 458824 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658040 658040 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580732 0 0.0
lock k32w061+release (read/write) 684524 684524 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606740 606740 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893364 32 0.0
(read/write) 671793 671793 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610816 610816 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7890212 7890244 32 0.0
thermostat-no-ble arm64 (read only) 2591604 2591604 0 0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186624 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172931 1172931 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809780 809780 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799488 799488 0 0.0
p6 all-clusters-app default (read/write) 2562688 2562688 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1520952 1520952 0 0.0
all-clusters-minimal-app default (read/write) 2508552 2508552 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1466816 1466816 0 0.0
light-app default (read/write) 2439048 2439048 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397312 1397312 0 0.0
lock-app default (read/write) 2465328 2465328 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423592 1423592 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796292 796300 8 0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564816 564818 2 0.0
lighting-app tlsr9518adk80d (read/write) 816160 816160 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581170 581170 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

PR #20178: Size comparison from d6c3519 to c1989fd

Increases (4 builds for k32w, linux, telink)
platform target config section d6c3519 c1989fd change % change
k32w light k32w061+release (read/write) 658040 658264 224 0.0
.text 580732 580956 224 0.0
lock k32w061+release (read/write) 684524 684748 224 0.0
.text 606740 606964 224 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893348 16 0.0
.text 7890212 7890228 16 0.0
telink lighting-app tlsr9518adk80d text 581170 581172 2 0.0
Decreases (3 builds for linux, nrfconnect, telink)
platform target config section d6c3519 c1989fd change % change
linux thermostat-no-ble arm64 (read only) 2591604 2591588 -16 -0.0
.text 2186624 2186608 -16 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 799488 799484 -4 -0.0
telink light-switch-app tlsr9518adk80d text 564816 564814 -2 -0.0
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section d6c3519 c1989fd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578662 578662 0 0.0
.app_xip_area 457440 457440 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580238 580238 0 0.0
.app_xip_area 458824 458824 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658040 658264 224 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580956 224 0.0
lock k32w061+release (read/write) 684524 684748 224 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606740 606964 224 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893348 16 0.0
(read/write) 671793 671793 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610816 610816 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7890212 7890228 16 0.0
thermostat-no-ble arm64 (read only) 2591604 2591588 -16 -0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186608 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172931 1172931 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809780 809780 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799488 799484 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 796292 796292 0 0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564816 564814 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816160 816160 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581170 581172 2 0.0

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

PR #20178: Size comparison from d6c3519 to 5a870e4

Increases above 0.2%:

platform target config section d6c3519 5a870e4 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1119568 1123992 4424 0.4
.bss 139144 142128 2984 2.1
Increases (4 builds for cc13x2_26x2, efr32, linux)
platform target config section d6c3519 5a870e4 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 657622 657630 8 0.0
.text 572468 572476 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1119568 1123992 4424 0.4
.bss 139144 142128 2984 2.1
.text 978344 979784 1440 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893348 16 0.0
.text 7890212 7890228 16 0.0
tv-app debug (read only) 3098121 3098137 16 0.0
.text 2661266 2661282 16 0.0
Decreases (11 builds for cc13x2_26x2, cyw30739, linux)
platform target config section d6c3519 5a870e4 change % change
cc13x2_26x2 shell LP_CC2652R7 (read/write) 189104 189096 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 580238 580230 -8 -0.0
.app_xip_area 458824 458816 -8 -0.0
linux all-clusters-app debug (read only) 2954289 2954273 -16 -0.0
.text 2514018 2514002 -16 -0.0
all-clusters-minimal-app debug (read only) 2808401 2808385 -16 -0.0
.text 2368642 2368626 -16 -0.0
bridge-app debug+rpc (read only) 2311801 2311785 -16 -0.0
.text 1952418 1952402 -16 -0.0
lighting-app debug+rpc (read only) 2547705 2547689 -16 -0.0
.text 2164210 2164194 -16 -0.0
lock-app debug (read only) 2509537 2509521 -16 -0.0
.text 2116242 2116226 -16 -0.0
ota-provider-app debug (read only) 2318625 2318609 -16 -0.0
.text 1952610 1952594 -16 -0.0
ota-requestor-app debug (read only) 2435809 2435793 -16 -0.0
.text 2057378 2057362 -16 -0.0
shell debug (read only) 2543921 2543889 -32 -0.0
.text 2160386 2160354 -32 -0.0
thermostat-no-ble arm64 (read only) 2591604 2591588 -16 -0.0
.text 2186624 2186608 -16 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d6c3519 5a870e4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665171 665171 0 0.0
(read/write) 186052 186052 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576764 576764 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653947 653947 0 0.0
(read/write) 196572 196572 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 562060 562060 0 0.0
lock-ftd LP_CC2652R7 (read only) 667759 667759 0 0.0
(read/write) 173608 173608 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591088 591088 0 0.0
lock-mtd LP_CC2652R7 (read only) 617175 617175 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540616 540616 0 0.0
pump-app LP_CC2652R7 (read only) 677207 677207 0 0.0
(read/write) 165008 165008 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588300 588300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663047 663047 0 0.0
(read/write) 179288 179288 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84271 84271 0 0.0
.text 578296 578296 0 0.0
shell LP_CC2652R7 (read only) 657622 657630 8 0.0
(read/write) 189104 189096 -8 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84838 84838 0 0.0
.text 572468 572476 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578662 578662 0 0.0
.app_xip_area 457440 457440 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580238 580230 -8 -0.0
.app_xip_area 458824 458816 -8 -0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080092 1080092 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945028 945028 0 0.0
BRD4161A+rpc (read/write) 1134388 1134388 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982432 982432 0 0.0
BRD4161A+rs911x (read/write) 942556 942556 0 0.0
.bss 138712 138712 0 0.0
.data 2048 2048 0 0.0
.text 801776 801776 0 0.0
lock-app BRD4161A+wf200 (read/write) 1119568 1123992 4424 0.4
.bss 139144 142128 2984 2.1
.data 2060 2060 0 0.0
.text 978344 979784 1440 0.1
window-app BRD4161A (read/write) 1065324 1065324 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930148 930148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018490 1018490 0 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214784 214784 0 0.0
.flash.text 1018490 1018490 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072583 1072583 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067199 1067199 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658040 658040 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580732 0 0.0
lock k32w061+release (read/write) 684524 684524 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606740 606740 0 0.0
linux all-clusters-app debug (read only) 2954289 2954273 -16 -0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84952 84952 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2514018 2514002 -16 -0.0
all-clusters-minimal-app debug (read only) 2808401 2808385 -16 -0.0
(read/write) 146648 146648 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77592 77592 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264797 264797 0 0.0
.text 2368642 2368626 -16 -0.0
bridge-app debug+rpc (read only) 2311801 2311785 -16 -0.0
(read/write) 125472 125472 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66968 66968 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197696 197696 0 0.0
.text 1952418 1952402 -16 -0.0
chip-tool debug (read only) 10161437 10161437 0 0.0
(read/write) 607016 607016 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575248 575248 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509317 509317 0 0.0
.text 8252293 8252293 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893348 16 0.0
(read/write) 671793 671793 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610816 610816 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7890212 7890228 16 0.0
lighting-app debug+rpc (read only) 2547705 2547689 -16 -0.0
(read/write) 129496 129496 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72104 72104 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213576 213576 0 0.0
.text 2164210 2164194 -16 -0.0
lock-app debug (read only) 2509537 2509521 -16 -0.0
(read/write) 124472 124472 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228200 228200 0 0.0
.text 2116242 2116226 -16 -0.0
ota-provider-app debug (read only) 2318625 2318609 -16 -0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63080 63080 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203288 203288 0 0.0
.text 1952610 1952594 -16 -0.0
ota-requestor-app debug (read only) 2435809 2435793 -16 -0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207328 207328 0 0.0
.text 2057378 2057362 -16 -0.0
shell debug (read only) 2543921 2543889 -32 -0.0
(read/write) 141032 141032 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227218 227218 0 0.0
.text 2160386 2160354 -32 -0.0
thermostat-no-ble arm64 (read only) 2591604 2591588 -16 -0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186608 -16 -0.0
tv-app debug (read only) 3098121 3098137 16 0.0
(read/write) 257672 257672 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249024 249024 0 0.0
.text 2661266 2661282 16 0.0
tv-casting-app debug (read only) 5555481 5555481 0 0.0
(read/write) 161680 161680 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343113 343113 0 0.0
.text 4935490 4935490 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172931 1172931 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809780 809780 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799488 799488 0 0.0
p6 all-clusters-app default (read/write) 2562688 2562688 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1520952 1520952 0 0.0
all-clusters-minimal-app default (read/write) 2508552 2508552 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1466816 1466816 0 0.0
light-app default (read/write) 2439048 2439048 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397312 1397312 0 0.0
lock-app default (read/write) 2465328 2465328 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423592 1423592 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796292 796292 0 0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564816 564816 0 0.0
lighting-app tlsr9518adk80d (read/write) 816160 816160 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581170 581170 0 0.0

This was referenced Jul 1, 2022
Closed
Merged
@woody-apple woody-apple mentioned this pull request Jul 7, 2022
Merged
@stale
Copy link

stale bot commented Jul 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 8, 2022
@bzbarsky-apple bzbarsky-apple force-pushed the assert-controller-correct branch from 5a870e4 to 6fa69e7 Compare July 11, 2022 05:54
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

PR #20178: Size comparison from 776c06d to 6fa69e7

Increases (3 builds for linux, telink)
platform target config section 776c06d 6fa69e7 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9997684 9997700 16 0.0
.text 7959236 7959252 16 0.0
tv-app debug (read only) 3101905 3101937 32 0.0
.text 2665074 2665106 32 0.0
telink lighting-app tlsr9518adk80d text 581886 581888 2 0.0
Decreases (14 builds for cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, telink)
platform target config section 776c06d 6fa69e7 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631851 -8 -0.0
.text 554228 554220 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 585470 585462 -8 -0.0
.app_xip_area 459504 459496 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1019958 1019956 -2 -0.0
.flash.text 1019958 1019956 -2 -0.0
linux all-clusters-app debug (read only) 2960497 2960481 -16 -0.0
.text 2519730 2519714 -16 -0.0
all-clusters-minimal-app debug (read only) 2813041 2813025 -16 -0.0
.text 2372754 2372738 -16 -0.0
bridge-app debug+rpc (read only) 2315209 2315193 -16 -0.0
.text 1955522 1955506 -16 -0.0
lighting-app debug+rpc (read only) 2550953 2550937 -16 -0.0
.text 2167346 2167330 -16 -0.0
lock-app debug (read only) 2515553 2515537 -16 -0.0
.text 2121730 2121714 -16 -0.0
ota-provider-app debug (read only) 2322033 2322017 -16 -0.0
.text 1955842 1955826 -16 -0.0
ota-requestor-app debug (read only) 2439185 2439169 -16 -0.0
.text 2060802 2060786 -16 -0.0
shell debug (read only) 2550809 2550793 -16 -0.0
.text 2166034 2166018 -16 -0.0
thermostat-no-ble arm64 (read only) 2595044 2595028 -16 -0.0
.text 2189856 2189840 -16 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 800776 800772 -4 -0.0
telink light-switch-app tlsr9518adk80d text 565564 565562 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 776c06d 6fa69e7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666051 0 0.0
(read/write) 185172 185172 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577668 577668 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631851 -8 -0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554228 554220 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 668959 668959 0 0.0
(read/write) 172408 172408 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592272 592272 0 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618367 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541792 541792 0 0.0
pump-app LP_CC2652R7 (read only) 677991 677991 0 0.0
(read/write) 164224 164224 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589076 589076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663815 0 0.0
(read/write) 178520 178520 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579040 579040 0 0.0
shell LP_CC2652R7 (read only) 658550 658550 0 0.0
(read/write) 188176 188176 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573388 573388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579534 579534 0 0.0
.app_xip_area 458304 458304 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585470 585462 -8 -0.0
.app_xip_area 459504 459496 -8 -0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582590 582590 0 0.0
.app_xip_area 462208 462208 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081212 1081212 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946148 946148 0 0.0
BRD4161A+rpc (read/write) 1135516 1135516 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983560 983560 0 0.0
BRD4161A+rs911x (read/write) 947692 947692 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 804856 804856 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128496 1128496 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982228 982228 0 0.0
window-app BRD4161A (read/write) 1075012 1075012 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938444 938444 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019958 1019956 -2 -0.0
(read/write) 1485490 1485490 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215376 215376 0 0.0
.flash.text 1019958 1019956 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073899 1073899 0 0.0
(read/write) 487568 487568 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245828 245828 0 0.0
.flash.text 1068515 1068515 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658592 658592 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581284 581284 0 0.0
lock k32w061+release (read/write) 685348 685348 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607564 607564 0 0.0
linux all-clusters-app debug (read only) 2960497 2960481 -16 -0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263581 263581 0 0.0
.text 2519730 2519714 -16 -0.0
all-clusters-minimal-app debug (read only) 2813041 2813025 -16 -0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265277 265277 0 0.0
.text 2372754 2372738 -16 -0.0
bridge-app debug+rpc (read only) 2315209 2315193 -16 -0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1955522 1955506 -16 -0.0
chip-tool debug (read only) 10303697 10303697 0 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 515061 515061 0 0.0
.text 8356948 8356948 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9997684 9997700 16 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477780 477780 0 0.0
.text 7959236 7959252 16 0.0
lighting-app debug+rpc (read only) 2550953 2550937 -16 -0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2167346 2167330 -16 -0.0
lock-app debug (read only) 2515553 2515537 -16 -0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228680 228680 0 0.0
.text 2121730 2121714 -16 -0.0
ota-provider-app debug (read only) 2322033 2322017 -16 -0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1955842 1955826 -16 -0.0
ota-requestor-app debug (read only) 2439185 2439169 -16 -0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2060802 2060786 -16 -0.0
shell debug (read only) 2550809 2550793 -16 -0.0
(read/write) 141096 141096 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227698 227698 0 0.0
.text 2166034 2166018 -16 -0.0
thermostat-no-ble arm64 (read only) 2595044 2595028 -16 -0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189856 2189840 -16 -0.0
tv-app debug (read only) 3101905 3101937 32 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2665074 2665106 32 0.0
tv-casting-app debug (read only) 5565689 5565689 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343273 343273 0 0.0
.text 4944466 4944466 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2447912 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174935 0 0.0
bss 142900 142900 0 0.0
rodata 141808 141808 0 0.0
text 811332 811332 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155131 0 0.0
bss 142136 142136 0 0.0
rodata 133340 133340 0 0.0
text 800776 800772 -4 -0.0
p6 all-clusters-app default (read/write) 2565152 2565152 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523416 1523416 0 0.0
all-clusters-minimal-app default (read/write) 2510192 2510192 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468456 1468456 0 0.0
light-app default (read/write) 2440496 2440496 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398760 1398760 0 0.0
lock-app default (read/write) 2467760 2467760 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426024 1426024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797092 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565564 565562 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816916 816916 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581886 581888 2 0.0

@andy31415 andy31415 merged commit 0ca7902 into project-chip:master Jul 11, 2022
@bzbarsky-apple bzbarsky-apple deleted the assert-controller-correct branch July 11, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
controller review - approved stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzbarsky-apple @tcarmelveilleux @andy31415 @msandstedt @mrjerryjohns @woody-apple