-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bootstrap Matter logo 72-column safe #20162
Merged
tcarmelveilleux
merged 5 commits into
project-chip:master
from
tcarmelveilleux:fix-logo-72
Jun 30, 2022
Merged
Make bootstrap Matter logo 72-column safe #20162
tcarmelveilleux
merged 5 commits into
project-chip:master
from
tcarmelveilleux:fix-logo-72
Jun 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previous bootstrap Matter logo was 93 columns and not 80/72 column terminal-safe This PR updates the logot to 72-columns max Testing done: - Can see new logo on bootstrap
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda and
mlepage-google
June 30, 2022 14:54
pullapprove
bot
requested review from
msandstedt,
mspang,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 30, 2022 14:54
PR #20162: Size comparison from 31ddf98 to c3830e6 Increases (4 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
cecille
approved these changes
Jun 30, 2022
andy31415
approved these changes
Jun 30, 2022
PR #20162: Size comparison from 31ddf98 to 62bbf4b Increases (3 builds for nrfconnect, telink)
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
msandstedt
approved these changes
Jun 30, 2022
PR #20162: Size comparison from 31ddf98 to 5686a3e Increases (3 builds for cc13x2_26x2, nrfconnect)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmeg-sfy
reviewed
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
terminal-safe
Change overview
This PR updates the logo to 72-columns max
Testing