Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reboot command will not be applicable to certification of DUTs adding user prompt to manually reboot the DUT #20153

Merged
merged 4 commits into from
Jul 2, 2022
Merged

Reboot command will not be applicable to certification of DUTs adding user prompt to manually reboot the DUT #20153

merged 4 commits into from
Jul 2, 2022

Conversation

manjunath-grl
Copy link
Contributor

The reboot mechanism we have in YAML might work for our SDK CI , since its based on opening a socket on port 9000 and doing a xpc connection but don't think it will be applicable to certification of DUTs, removing reboot command all steps where we use reboot to a user prompt to manually reboot
TC-BINFO-2.2
TC-DGEN-2.1
TC-WNCV-4.5
Modified scripts
TC-MF-1.3
TC-MF-1.4
TC-MF-1.5
TC-MF-1.6
TC-MF-1.9
TC-MF-1.10
TC-MF-1.15
added auto generated files

Attached execution logs for reference:
Execution_log.txt

@boring-cyborg boring-cyborg bot added the app label Jun 30, 2022
@manjunath-grl manjunath-grl changed the title Removing reboot command step instead adding user prompt to manually reboot the DUT Reboot command will not be applicable to certification of DUTs adding user prompt to manually reboot the DUT Jun 30, 2022
@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

PR #20153: Size comparison from a45d571 to 525aee9

Increases (6 builds for cc13x2_26x2, esp32, linux, nrfconnect)
platform target config section a45d571 525aee9 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 653939 653947 8 0.0
.text 562052 562060 8 0.0
pump-app LP_CC2652R7 (read/write) 165008 165016 8 0.0
esp32 all-clusters-app c3devkit (read only) 1018482 1018486 4 0.0
.flash.text 1018482 1018486 4 0.0
linux chip-tool debug (read only) 10161437 10162045 608 0.0
.rodata 509317 509381 64 0.0
.text 8252293 8252837 544 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893684 352 0.0
.rodata 472548 472612 64 0.0
.text 7890212 7890500 288 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809772 809776 4 0.0
Decreases (3 builds for cc13x2_26x2, telink)
platform target config section a45d571 525aee9 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read/write) 196580 196572 -8 -0.0
pump-app LP_CC2652R7 (read only) 677207 677199 -8 -0.0
.text 588300 588292 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 796300 796292 -8 -0.0
text 564818 564816 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a45d571 525aee9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665171 665171 0 0.0
(read/write) 186052 186052 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576764 576764 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653939 653947 8 0.0
(read/write) 196580 196572 -8 -0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 562052 562060 8 0.0
lock-ftd LP_CC2652R7 (read only) 667743 667743 0 0.0
(read/write) 173624 173624 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591072 591072 0 0.0
lock-mtd LP_CC2652R7 (read only) 617159 617159 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540600 540600 0 0.0
pump-app LP_CC2652R7 (read only) 677207 677199 -8 -0.0
(read/write) 165008 165016 8 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588300 588292 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 663047 663047 0 0.0
(read/write) 179288 179288 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84271 84271 0 0.0
.text 578296 578296 0 0.0
shell LP_CC2652R7 (read only) 657614 657614 0 0.0
(read/write) 189112 189112 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84838 84838 0 0.0
.text 572460 572460 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578654 578654 0 0.0
.app_xip_area 457432 457432 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580222 580222 0 0.0
.app_xip_area 458808 458808 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080060 1080060 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 944996 944996 0 0.0
BRD4161A+rpc (read/write) 1134356 1134356 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982400 982400 0 0.0
BRD4161A+rs911x (read/write) 942524 942524 0 0.0
.bss 138712 138712 0 0.0
.data 2048 2048 0 0.0
.text 801744 801744 0 0.0
lock-app BRD4161A+wf200 (read/write) 1119568 1119568 0 0.0
.bss 139144 139144 0 0.0
.data 2060 2060 0 0.0
.text 978344 978344 0 0.0
window-app BRD4161A (read/write) 1065324 1065324 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930148 930148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018482 1018486 4 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214784 214784 0 0.0
.flash.text 1018482 1018486 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072575 1072575 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067191 1067191 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658040 658040 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580732 0 0.0
lock k32w061+release (read/write) 684508 684508 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606724 606724 0 0.0
linux all-clusters-app debug (read only) 2954225 2954225 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84952 84952 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2513954 2513954 0 0.0
all-clusters-minimal-app debug (read only) 2808321 2808321 0 0.0
(read/write) 146648 146648 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77592 77592 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264797 264797 0 0.0
.text 2368562 2368562 0 0.0
bridge-app debug+rpc (read only) 2311737 2311737 0 0.0
(read/write) 125472 125472 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66968 66968 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197696 197696 0 0.0
.text 1952354 1952354 0 0.0
chip-tool debug (read only) 10161437 10162045 608 0.0
(read/write) 607016 607016 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575248 575248 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509317 509381 64 0.0
.text 8252293 8252837 544 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893684 352 0.0
(read/write) 671793 671793 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610816 610816 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472612 64 0.0
.text 7890212 7890500 288 0.0
lighting-app debug+rpc (read only) 2547641 2547641 0 0.0
(read/write) 129496 129496 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72104 72104 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213576 213576 0 0.0
.text 2164146 2164146 0 0.0
lock-app debug (read only) 2509489 2509489 0 0.0
(read/write) 124472 124472 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228200 228200 0 0.0
.text 2116194 2116194 0 0.0
ota-provider-app debug (read only) 2318625 2318625 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63080 63080 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203288 203288 0 0.0
.text 1952610 1952610 0 0.0
ota-requestor-app debug (read only) 2435809 2435809 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207328 207328 0 0.0
.text 2057378 2057378 0 0.0
shell debug (read only) 2543857 2543857 0 0.0
(read/write) 141032 141032 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227218 227218 0 0.0
.text 2160322 2160322 0 0.0
thermostat-no-ble arm64 (read only) 2591604 2591604 0 0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186624 0 0.0
tv-app debug (read only) 3097513 3097513 0 0.0
(read/write) 255880 255880 0 0.0
.bss 165224 165224 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248832 248832 0 0.0
.text 2660850 2660850 0 0.0
tv-casting-app debug (read only) 5555417 5555417 0 0.0
(read/write) 161680 161680 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343113 343113 0 0.0
.text 4935426 4935426 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172915 1172915 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809772 809776 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799484 799484 0 0.0
p6 all-clusters-app default (read/write) 2562640 2562640 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1520904 1520904 0 0.0
all-clusters-minimal-app default (read/write) 2508504 2508504 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1466768 1466768 0 0.0
light-app default (read/write) 2439016 2439016 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397280 1397280 0 0.0
lock-app default (read/write) 2465312 2465312 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423576 1423576 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796300 796292 -8 -0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564818 564816 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816152 816152 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581166 581166 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

PR #20153: Size comparison from 39a8af0 to 5d4af54

Increases (3 builds for cc13x2_26x2, linux, nrfconnect)
platform target config section 39a8af0 5d4af54 change % change
cc13x2_26x2 shell LP_CC2652R7 (read/write) 189112 189120 8 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893684 352 0.0
.rodata 472548 472612 64 0.0
.text 7890212 7890500 288 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 799480 799484 4 0.0
Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 39a8af0 5d4af54 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 657614 657606 -8 -0.0
.text 572460 572452 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809776 809772 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 796300 796292 -8 -0.0
text 564818 564814 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 816160 816152 -8 -0.0
text 581170 581166 -4 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 39a8af0 5d4af54 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665171 665171 0 0.0
(read/write) 186052 186052 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576764 576764 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653947 653947 0 0.0
(read/write) 196572 196572 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 562060 562060 0 0.0
lock-ftd LP_CC2652R7 (read only) 667743 667743 0 0.0
(read/write) 173624 173624 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591072 591072 0 0.0
lock-mtd LP_CC2652R7 (read only) 617159 617159 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540600 540600 0 0.0
pump-app LP_CC2652R7 (read only) 677207 677207 0 0.0
(read/write) 165008 165008 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588300 588300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663047 663047 0 0.0
(read/write) 179288 179288 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84271 84271 0 0.0
.text 578296 578296 0 0.0
shell LP_CC2652R7 (read only) 657614 657606 -8 -0.0
(read/write) 189112 189120 8 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84838 84838 0 0.0
.text 572460 572452 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578654 578654 0 0.0
.app_xip_area 457432 457432 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580222 580222 0 0.0
.app_xip_area 458808 458808 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080060 1080060 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 944996 944996 0 0.0
BRD4161A+rpc (read/write) 1134356 1134356 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982400 982400 0 0.0
BRD4161A+rs911x (read/write) 942524 942524 0 0.0
.bss 138712 138712 0 0.0
.data 2048 2048 0 0.0
.text 801744 801744 0 0.0
lock-app BRD4161A+wf200 (read/write) 1119568 1119568 0 0.0
.bss 139144 139144 0 0.0
.data 2060 2060 0 0.0
.text 978344 978344 0 0.0
window-app BRD4161A (read/write) 1065324 1065324 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930148 930148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018484 1018484 0 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214784 214784 0 0.0
.flash.text 1018484 1018484 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072575 1072575 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067191 1067191 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658040 658040 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580732 0 0.0
lock k32w061+release (read/write) 684508 684508 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606724 606724 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9893332 9893684 352 0.0
(read/write) 671793 671793 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610816 610816 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472612 64 0.0
.text 7890212 7890500 288 0.0
thermostat-no-ble arm64 (read only) 2591604 2591604 0 0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186624 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172915 1172915 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809776 809772 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799480 799484 4 0.0
p6 all-clusters-app default (read/write) 2562640 2562640 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1520904 1520904 0 0.0
all-clusters-minimal-app default (read/write) 2508504 2508504 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1466768 1466768 0 0.0
light-app default (read/write) 2439016 2439016 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397280 1397280 0 0.0
lock-app default (read/write) 2465312 2465312 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423576 1423576 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796300 796292 -8 -0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564818 564814 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 816160 816152 -8 -0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581170 581166 -4 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right fix is to leave Reboot for CI, but have a prompt when not in CI.

@raju-apple
Copy link
Contributor

The right fix is to leave Reboot for CI, but have a prompt when not in CI.

Makes sense actually , why remove some of the functionality we already have :) @manjunath-grl lets do this , for every step for reboot that we just disabled lets do this instead :

  1. Have both methods to reboot , for CI and the manual user prompt. Lets just have 2 PICS in there to differentiate.
  2. So for the steps with reboot using manual user prompt , use the PICS_SKIP_SAMPLE_APP condition to make sure it gets skipped in CI but gets picked up by the TH.
  3. For the existing steps which we just disabled in this PR , create a new PICS_SDK_CI_ONLY and add it to the ci-pics-value as well and make it default to 1. That way it will run in CI , I will file and issue once you PR is up on the TH to make sure to skip the automated reboot steps when TH runs it.

Let me know if this makes sense and update the PR.

@manjunath-grl manjunath-grl force-pushed the Addressing_Issue_74 branch from 5d4af54 to 19d7c3a Compare July 1, 2022 08:15
@github-actions
Copy link

github-actions bot commented Jul 1, 2022 •
edited
Loading

PR #20153: Size comparison from 6c6dca3 to 19d7c3a

Increases (5 builds for cc13x2_26x2, linux, telink)
platform target config section 6c6dca3 19d7c3a change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 654131 654139 8 0.0
.text 562236 562244 8 0.0
pump-app LP_CC2652R7 (read only) 677287 677295 8 0.0
.text 588364 588372 8 0.0
linux chip-tool debug (read only) 10171941 10176853 4912 0.0
.rodata 509093 509189 96 0.0
.text 8251813 8256629 4816 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9903748 9907620 3872 0.0
.rodata 471764 471860 96 0.0
.text 7890084 7893860 3776 0.0
telink lighting-app tlsr9518adk80d text 581258 581260 2 0.0
Decreases (3 builds for cc13x2_26x2, nrfconnect)
platform target config section 6c6dca3 19d7c3a change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read/write) 196388 196380 -8 -0.0
pump-app LP_CC2652R7 (read/write) 164928 164920 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809976 809972 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6c6dca3 19d7c3a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665363 665363 0 0.0
(read/write) 185860 185860 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88099 88099 0 0.0
.text 576948 576948 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 654131 654139 8 0.0
(read/write) 196388 196380 -8 -0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91579 91579 0 0.0
.text 562236 562244 8 0.0
lock-ftd LP_CC2652R7 (read only) 667943 667943 0 0.0
(read/write) 173424 173424 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591272 591272 0 0.0
lock-mtd LP_CC2652R7 (read only) 617359 617359 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540800 540800 0 0.0
pump-app LP_CC2652R7 (read only) 677287 677295 8 0.0
(read/write) 164928 164920 -8 -0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88439 88439 0 0.0
.text 588364 588372 8 0.0
pump-controller-app LP_CC2652R7 (read only) 663127 663127 0 0.0
(read/write) 179208 179208 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84279 84279 0 0.0
.text 578368 578368 0 0.0
shell LP_CC2652R7 (read only) 657806 657806 0 0.0
(read/write) 188920 188920 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 572644 572644 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578750 578750 0 0.0
.app_xip_area 457528 457528 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580398 580398 0 0.0
.app_xip_area 458984 458984 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581814 581814 0 0.0
.app_xip_area 461440 461440 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080172 1080172 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945108 945108 0 0.0
BRD4161A+rpc (read/write) 1134532 1134532 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982576 982576 0 0.0
BRD4161A+rs911x (read/write) 946276 946276 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 803440 803440 0 0.0
lock-app BRD4161A+wf200 (read/write) 1126920 1126920 0 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 980652 980652 0 0.0
window-app BRD4161A (read/write) 1065436 1065436 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930260 930260 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018702 1018702 0 0.0
(read/write) 1484906 1484906 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 214792 214792 0 0.0
.flash.text 1018702 1018702 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072735 1072735 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067351 1067351 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658112 658112 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580804 580804 0 0.0
lock k32w061+release (read/write) 684692 684692 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606908 606908 0 0.0
linux all-clusters-app debug (read only) 2955297 2955297 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263229 263229 0 0.0
.text 2514882 2514882 0 0.0
all-clusters-minimal-app debug (read only) 2809441 2809441 0 0.0
(read/write) 146680 146680 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264925 264925 0 0.0
.text 2369506 2369506 0 0.0
bridge-app debug+rpc (read only) 2312409 2312409 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1952722 1952722 0 0.0
chip-tool debug (read only) 10171941 10176853 4912 0.0
(read/write) 611816 611816 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580032 580032 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509093 509189 96 0.0
.text 8251813 8256629 4816 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9903748 9907620 3872 0.0
(read/write) 676609 676609 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615592 615592 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471764 471860 96 0.0
.text 7890084 7893860 3776 0.0
lighting-app debug+rpc (read only) 2548185 2548185 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2164578 2164578 0 0.0
lock-app debug (read only) 2510577 2510577 0 0.0
(read/write) 124504 124504 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228328 228328 0 0.0
.text 2117106 2117106 0 0.0
ota-provider-app debug (read only) 2319089 2319089 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1952898 1952898 0 0.0
ota-requestor-app debug (read only) 2436257 2436257 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207424 207424 0 0.0
.text 2057682 2057682 0 0.0
shell debug (read only) 2544961 2544961 0 0.0
(read/write) 141064 141064 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227346 227346 0 0.0
.text 2161250 2161250 0 0.0
thermostat-no-ble arm64 (read only) 2591988 2591988 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165348 165348 0 0.0
.text 2186864 2186864 0 0.0
tv-app debug (read only) 3098689 3098689 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2661570 2661570 0 0.0
tv-casting-app debug (read only) 5556057 5556057 0 0.0
(read/write) 161712 161712 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102824 102824 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343337 343337 0 0.0
.text 4935794 4935794 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447312 2447312 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409956 1409956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1173131 1173131 0 0.0
bss 142884 142884 0 0.0
rodata 141356 141356 0 0.0
text 809976 809972 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153983 1153983 0 0.0
bss 142120 142120 0 0.0
rodata 133288 133288 0 0.0
text 799672 799672 0 0.0
p6 all-clusters-app default (read/write) 2562928 2562928 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1521192 1521192 0 0.0
all-clusters-minimal-app default (read/write) 2508792 2508792 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1467056 1467056 0 0.0
light-app default (read/write) 2439160 2439160 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397424 1397424 0 0.0
lock-app default (read/write) 2465576 2465576 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423840 1423840 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796384 796384 0 0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564904 564904 0 0.0
lighting-app tlsr9518adk80d (read/write) 816252 816252 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581258 581260 2 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the TC_MF scripts that are having the stop/start removed have been run using the CI harness script and pass.

@woody-apple
Copy link
Contributor

Fast tracking test updates.

@woody-apple woody-apple merged commit 19d0f52 into project-chip:master Jul 2, 2022
@manjunath-grl manjunath-grl deleted the Addressing_Issue_74 branch July 5, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-apple raju-apple raju-apple left review comments

@bauerschwan bauerschwan bauerschwan approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manjunath-grl @raju-apple @woody-apple @bzbarsky-apple @bauerschwan