-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch nrf5 example apps away from the dotdot code #2014
Switch nrf5 example apps away from the dotdot code #2014
Conversation
5ab315f
to
1ea919e
Compare
58940fb
to
5cd8a57
Compare
…s on-off cluster implementation. The files in the "gen" directories are generated on a per-app basis by Simplicity Studio and are identical for the three apps for now, but will likely diverge once we pull more clusters into the apps.
5cd8a57
to
450fa73
Compare
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this change is too large to actually review. Adding 'approve' for moving away from dotdot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a broad request, can we make an attempt to start referring to ZCL versions by their spec revision numbers rather than marketing names? The naming for ZCL has recently become very cloudy with ZCL, DotDot, and WWAH all having a bit of overlap across R6, R7, and R8 of the ZCL spec.
For what it's worth, the only part that needs to get reviewed, really, are the changes to these files:
Everything else is generated code that doesn't need separate review, though we will want to review the generator inputs once we start getting those into the tree. @andy31415 I appreciate the approval, and if you want to look over the files listed above and let me know if you see any problems I'd be happy to fix them as a followup. @BroderickCarlin For extra confusion, "dotdot" and "zigbeepro" here refers not to ZCL versions at all, but to Silicon Labs codebases. The actual code being contributed by Silicon Labs that we are switching to is their implementation of something in the R6-R7 range, but not precisely matching either one, is my understanding. The code we are switching away from was an early implementation of what I think is meant to be R8, but one that was pretty far from complete. |
Problem
We are planning to use the Silicon Labs "zigbeepro" implementation of ZCL, not their "dotdot" implementation.
Summary of Changes
Switch the nrf5 example apps to the "zigbeepro" implementation.
fixes #2013