Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nrf5 example apps away from the dotdot code #2014

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We are planning to use the Silicon Labs "zigbeepro" implementation of ZCL, not their "dotdot" implementation.

Summary of Changes

Switch the nrf5 example apps to the "zigbeepro" implementation.

fixes #2013

…s on-off cluster implementation.

The files in the "gen" directories are generated on a per-app basis by
Simplicity Studio and are identical for the three apps for now, but will
likely diverge once we pull more clusters into the apps.
@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 5500 5500
chip-nrf52840-lock-example.out .data 4 4
chip-nrf52840-lock-example.out .bss 0 -184
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_str,0,588337
.debug_info,0,108461
.debug_macro,0,62258
.debug_line,0,32088
.debug_loc,0,18831
.debug_abbrev,0,9177
.debug_frame,0,6660
.text,5500,5500
.symtab,0,4064
.strtab,0,3230
.debug_aranges,0,1984
.debug_ranges,0,1776
.data,4,4
.bss,-184,0
[Unmapped],0,-5494


@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf text 4142 4142
chip-nrf52840-lock-example.elf [LOAD #3 [RW]] 0 8
chip-nrf52840-lock-example.elf datas 3 3
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] 2 2
chip-nrf52840-lock-example.elf [LOAD #2 [RW]] -3 -3
chip-nrf52840-lock-example.elf bss 0 -200
chip-nrf52840-lock-example.elf rodata -520 -520
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_info,0,123050
.debug_loc,0,34244
.debug_line,0,24422
.debug_str,0,19587
.debug_abbrev,0,10845
.debug_frame,0,4688
text,4142,4142
.debug_ranges,0,3760
.symtab,0,2672
.strtab,0,1937
.debug_aranges,0,1704
[LOAD #3 [RW]],8,0
datas,3,3
[LOAD #1 [RWX]],2,2
[LOAD #2 [RW]],-3,-3
[Unmapped],0,-13
bss,-200,0
rodata,-520,-520


@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is too large to actually review. Adding 'approve' for moving away from dotdot.

Copy link
Contributor

@BroderickCarlin BroderickCarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a broad request, can we make an attempt to start referring to ZCL versions by their spec revision numbers rather than marketing names? The naming for ZCL has recently become very cloudy with ZCL, DotDot, and WWAH all having a bit of overlap across R6, R7, and R8 of the ZCL spec.

@woody-apple woody-apple merged commit 0403833 into project-chip:master Aug 10, 2020
@bzbarsky-apple
Copy link
Contributor Author

I believe this change is too large to actually review

For what it's worth, the only part that needs to get reviewed, really, are the changes to these files:

config/nrf5/nrf5-chip.mk
examples/lighting-app/nrf5/BUILD.gn
examples/lighting-app/nrf5/Makefile
examples/lighting-app/nrf5/main/DataModelHandler.cpp
examples/lock-app/nrf5/BUILD.gn
examples/lock-app/nrf5/Makefile
examples/lock-app/nrf5/main/DataModelHandler.cpp
examples/lock-app/nrfconnect/CMakeLists.txt
examples/lock-app/nrfconnect/main/DataModelHandler.cpp
examples/lock-app/nrfconnect/main/Server.cpp
examples/platform/nrf528xx/app/Server.cpp

Everything else is generated code that doesn't need separate review, though we will want to review the generator inputs once we start getting those into the tree. @andy31415 I appreciate the approval, and if you want to look over the files listed above and let me know if you see any problems I'd be happy to fix them as a followup.

@BroderickCarlin For extra confusion, "dotdot" and "zigbeepro" here refers not to ZCL versions at all, but to Silicon Labs codebases. The actual code being contributed by Silicon Labs that we are switching to is their implementation of something in the R6-R7 range, but not precisely matching either one, is my understanding. The code we are switching away from was an early implementation of what I think is meant to be R8, but one that was pretty far from complete.

@bzbarsky-apple bzbarsky-apple deleted the switch-nrf5-to-new-setup branch August 10, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using the Silicon Labs dotdot implementation in nrf5 sample apps
6 participants