-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch for OTA for all-clusters/shell #20130
Merged
woody-apple
merged 1 commit into
project-chip:master
from
adabreuti:reenableOtaAllClusters
Jul 2, 2022
Merged
Add switch for OTA for all-clusters/shell #20130
woody-apple
merged 1 commit into
project-chip:master
from
adabreuti:reenableOtaAllClusters
Jul 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
rgoliver
June 29, 2022 19:22
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 29, 2022 19:22
@bzbarsky-apple Is there a simple way to re-run failed workflows from the PR interface? |
PR #20130: Size comparison from f03b9ae to 693a825 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
adabreuti
force-pushed
the
reenableOtaAllClusters
branch
from
June 30, 2022 15:48
693a825
to
58b1a17
Compare
PR #20130: Size comparison from 31ddf98 to 58b1a17 Increases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 1, 2022
@woody-apple any other actions items on my end needed before this can be merged? Thanks! |
woody-apple
approved these changes
Jul 2, 2022
Fast tracking, given this has had enough time for review (> 3 days) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #20129
Change overview
Update applications to enable/disable OTA requestor based on args.gni
Testing
Verified OTA builds and basic commissioning via all-clusters app.