Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BLE manager to use indications #20113

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Update BLE manager to use indications #20113

merged 1 commit into from
Jun 29, 2022

Conversation

adabreuti
Copy link
Contributor

Problem

Fixes #20084

Change overview

Update BLEManager/CHIPoBLE layer to use indications/callbacks at the app layer rather than notifications.

Testing

Verified all-clusters application is able to be commissioned via BLE.

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited
Loading

PR #20113: Size comparison from c971f25 to ac76ff4

Increases (6 builds for cc13x2_26x2)
platform target config section c971f25 ac76ff4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 188068 188092 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read/write) 198588 198620 32 0.0
lock-ftd LP_CC2652R7 (read/write) 175656 175680 24 0.0
pump-app LP_CC2652R7 (read/write) 167024 167064 40 0.0
pump-controller-app LP_CC2652R7 (read/write) 181328 181352 24 0.0
shell LP_CC2652R7 (read/write) 191128 191160 32 0.0
Decreases (8 builds for cc13x2_26x2, telink)
platform target config section c971f25 ac76ff4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664931 664907 -24 -0.0
.text 576532 576508 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653707 653675 -32 -0.0
.text 561828 561796 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 667487 667463 -24 -0.0
.text 590824 590800 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 616903 616863 -40 -0.0
.text 540352 540312 -40 -0.0
pump-app LP_CC2652R7 (read only) 676967 676927 -40 -0.0
.text 588068 588028 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 662783 662759 -24 -0.0
.text 578040 578016 -24 -0.0
shell LP_CC2652R7 (read only) 657374 657342 -32 -0.0
.text 572228 572196 -32 -0.0
telink lighting-app tlsr9518adk80d text 580872 580870 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c971f25 ac76ff4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664931 664907 -24 -0.0
(read/write) 188068 188092 24 0.0
.bss 75892 75892 0 0.0
.data 3356 3356 0 0.0
.rodata 88083 88083 0 0.0
.text 576532 576508 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653707 653675 -32 -0.0
(read/write) 198588 198620 32 0.0
.bss 75188 75188 0 0.0
.data 3356 3356 0 0.0
.rodata 91563 91563 0 0.0
.text 561828 561796 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 667487 667463 -24 -0.0
(read/write) 175656 175680 24 0.0
.bss 72924 72924 0 0.0
.data 3280 3280 0 0.0
.rodata 76183 76183 0 0.0
.text 590824 590800 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 616903 616863 -40 -0.0
(read/write) 146040 146040 0 0.0
.bss 68644 68644 0 0.0
.data 3280 3280 0 0.0
.rodata 76063 76063 0 0.0
.text 540352 540312 -40 -0.0
pump-app LP_CC2652R7 (read only) 676967 676927 -40 -0.0
(read/write) 167024 167064 40 0.0
.bss 73004 73004 0 0.0
.data 3280 3280 0 0.0
.rodata 88415 88415 0 0.0
.text 588068 588028 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 662783 662759 -24 -0.0
(read/write) 181328 181352 24 0.0
.bss 73124 73124 0 0.0
.data 3276 3276 0 0.0
.rodata 84263 84263 0 0.0
.text 578040 578016 -24 -0.0
shell LP_CC2652R7 (read only) 657374 657342 -32 -0.0
(read/write) 191128 191160 32 0.0
.bss 78196 78196 0 0.0
.data 3360 3360 0 0.0
.rodata 84830 84830 0 0.0
.text 572228 572196 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580174 580174 0 0.0
.app_xip_area 457176 457176 0 0.0
.bss 65960 65960 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 458544 458544 0 0.0
.bss 66152 66152 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583230 583230 0 0.0
.app_xip_area 461080 461080 0 0.0
.bss 65168 65168 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081420 1081420 0 0.0
.bss 134772 134772 0 0.0
.data 2048 2048 0 0.0
.text 944580 944580 0 0.0
BRD4161A+rpc (read/write) 1135684 1135684 0 0.0
.bss 151452 151452 0 0.0
.data 2260 2260 0 0.0
.text 981952 981952 0 0.0
BRD4161A+rs911x (read/write) 943884 943884 0 0.0
.bss 140488 140488 0 0.0
.data 2048 2048 0 0.0
.text 801328 801328 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121048 1121048 0 0.0
.bss 140920 140920 0 0.0
.data 2060 2060 0 0.0
.text 978048 978048 0 0.0
window-app BRD4161A (read/write) 1066700 1066700 0 0.0
.bss 134852 134852 0 0.0
.data 2076 2076 0 0.0
.text 929748 929748 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018218 1018218 0 0.0
(read/write) 1486650 1486650 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214776 214776 0 0.0
.flash.text 1018218 1018218 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072315 1072315 0 0.0
(read/write) 488752 488752 0 0.0
.dram0.bss 77376 77376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245236 245236 0 0.0
.flash.text 1066931 1066931 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659520 659520 0 0.0
.bss 71292 71292 0 0.0
.data 1992 1992 0 0.0
.text 580436 580436 0 0.0
lock k32w061+release (read/write) 685988 685988 0 0.0
.bss 71756 71756 0 0.0
.data 2004 2004 0 0.0
.text 606428 606428 0 0.0
linux all-clusters-app debug (read only) 2952673 2952673 0 0.0
(read/write) 155288 155288 0 0.0
.bss 62144 62144 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84904 84904 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2512546 2512546 0 0.0
all-clusters-minimal-app debug (read only) 2806769 2806769 0 0.0
(read/write) 147224 147224 0 0.0
.bss 61472 61472 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264797 264797 0 0.0
.text 2367154 2367154 0 0.0
bridge-app debug+rpc (read only) 2310201 2310201 0 0.0
(read/write) 126048 126048 0 0.0
.bss 49536 49536 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66920 66920 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197696 197696 0 0.0
.text 1950962 1950962 0 0.0
chip-tool debug (read only) 10159629 10159629 0 0.0
(read/write) 606984 606984 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575216 575216 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509317 509317 0 0.0
.text 8250581 8250581 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9891076 9891076 0 0.0
(read/write) 671761 671761 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610784 610784 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7888052 7888052 0 0.0
lighting-app debug+rpc (read only) 2546105 2546105 0 0.0
(read/write) 130040 130040 0 0.0
.bss 50048 50048 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72056 72056 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213576 213576 0 0.0
.text 2162754 2162754 0 0.0
lock-app debug (read only) 2507953 2507953 0 0.0
(read/write) 125048 125048 0 0.0
.bss 48448 48448 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69032 69032 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228200 228200 0 0.0
.text 2114802 2114802 0 0.0
ota-provider-app debug (read only) 2317089 2317089 0 0.0
(read/write) 118856 118856 0 0.0
.bss 48096 48096 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63032 63032 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203288 203288 0 0.0
.text 1951218 1951218 0 0.0
ota-requestor-app debug (read only) 2434241 2434241 0 0.0
(read/write) 125760 125760 0 0.0
.bss 50464 50464 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67224 67224 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207328 207328 0 0.0
.text 2055954 2055954 0 0.0
shell debug (read only) 2542401 2542401 0 0.0
(read/write) 141608 141608 0 0.0
.bss 58056 58056 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76640 76640 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227218 227218 0 0.0
.text 2158962 2158962 0 0.0
thermostat-no-ble arm64 (read only) 2589940 2589940 0 0.0
(read/write) 158833 158833 0 0.0
.bss 65857 65857 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83184 83184 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2185104 2185104 0 0.0
tv-app debug (read only) 3095641 3095641 0 0.0
(read/write) 256424 256424 0 0.0
.bss 165832 165832 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248832 248832 0 0.0
.text 2659122 2659122 0 0.0
tv-casting-app debug (read only) 5553801 5553801 0 0.0
(read/write) 162256 162256 0 0.0
.bss 50856 50856 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102744 102744 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343113 343113 0 0.0
.text 4933954 4933954 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446592 2446592 0 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409236 1409236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174459 1174459 0 0.0
bss 144660 144660 0 0.0
rodata 141340 141340 0 0.0
text 809524 809524 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155311 1155311 0 0.0
bss 143896 143896 0 0.0
rodata 133272 133272 0 0.0
text 799228 799228 0 0.0
p6 all-clusters-app default (read/write) 2562256 2562256 0 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1520520 1520520 0 0.0
all-clusters-minimal-app default (read/write) 2508136 2508136 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1466400 1466400 0 0.0
light-app default (read/write) 2438648 2438648 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1396912 1396912 0 0.0
lock-app default (read/write) 2464928 2464928 0 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1423192 1423192 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797756 797756 0 0.0
bss 72336 72336 0 0.0
noinit 40416 40416 0 0.0
text 564510 564510 0 0.0
lighting-app tlsr9518adk80d (read/write) 817624 817624 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 580872 580870 -2 -0.0

@adabreuti adabreuti force-pushed the UseIndiciations_20084 branch from ac76ff4 to 992e207 Compare June 29, 2022 17:35
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited
Loading

PR #20113: Size comparison from c971f25 to 992e207

Increases (6 builds for cc13x2_26x2)
platform target config section c971f25 992e207 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 188068 188092 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read/write) 198588 198620 32 0.0
lock-ftd LP_CC2652R7 (read/write) 175656 175680 24 0.0
pump-app LP_CC2652R7 (read/write) 167024 167064 40 0.0
pump-controller-app LP_CC2652R7 (read/write) 181328 181352 24 0.0
shell LP_CC2652R7 (read/write) 191128 191160 32 0.0
Decreases (8 builds for cc13x2_26x2, esp32)
platform target config section c971f25 992e207 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664931 664907 -24 -0.0
.text 576532 576508 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653707 653675 -32 -0.0
.text 561828 561796 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 667487 667463 -24 -0.0
.text 590824 590800 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 616903 616863 -40 -0.0
.text 540352 540312 -40 -0.0
pump-app LP_CC2652R7 (read only) 676967 676927 -40 -0.0
.text 588068 588028 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 662783 662759 -24 -0.0
.text 578040 578016 -24 -0.0
shell LP_CC2652R7 (read only) 657374 657342 -32 -0.0
.text 572228 572196 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1018218 1018216 -2 -0.0
.flash.text 1018218 1018216 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c971f25 992e207 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664931 664907 -24 -0.0
(read/write) 188068 188092 24 0.0
.bss 75892 75892 0 0.0
.data 3356 3356 0 0.0
.rodata 88083 88083 0 0.0
.text 576532 576508 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653707 653675 -32 -0.0
(read/write) 198588 198620 32 0.0
.bss 75188 75188 0 0.0
.data 3356 3356 0 0.0
.rodata 91563 91563 0 0.0
.text 561828 561796 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 667487 667463 -24 -0.0
(read/write) 175656 175680 24 0.0
.bss 72924 72924 0 0.0
.data 3280 3280 0 0.0
.rodata 76183 76183 0 0.0
.text 590824 590800 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 616903 616863 -40 -0.0
(read/write) 146040 146040 0 0.0
.bss 68644 68644 0 0.0
.data 3280 3280 0 0.0
.rodata 76063 76063 0 0.0
.text 540352 540312 -40 -0.0
pump-app LP_CC2652R7 (read only) 676967 676927 -40 -0.0
(read/write) 167024 167064 40 0.0
.bss 73004 73004 0 0.0
.data 3280 3280 0 0.0
.rodata 88415 88415 0 0.0
.text 588068 588028 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 662783 662759 -24 -0.0
(read/write) 181328 181352 24 0.0
.bss 73124 73124 0 0.0
.data 3276 3276 0 0.0
.rodata 84263 84263 0 0.0
.text 578040 578016 -24 -0.0
shell LP_CC2652R7 (read only) 657374 657342 -32 -0.0
(read/write) 191128 191160 32 0.0
.bss 78196 78196 0 0.0
.data 3360 3360 0 0.0
.rodata 84830 84830 0 0.0
.text 572228 572196 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580174 580174 0 0.0
.app_xip_area 457176 457176 0 0.0
.bss 65960 65960 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 458544 458544 0 0.0
.bss 66152 66152 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583230 583230 0 0.0
.app_xip_area 461080 461080 0 0.0
.bss 65168 65168 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081420 1081420 0 0.0
.bss 134772 134772 0 0.0
.data 2048 2048 0 0.0
.text 944580 944580 0 0.0
BRD4161A+rpc (read/write) 1135684 1135684 0 0.0
.bss 151452 151452 0 0.0
.data 2260 2260 0 0.0
.text 981952 981952 0 0.0
BRD4161A+rs911x (read/write) 943884 943884 0 0.0
.bss 140488 140488 0 0.0
.data 2048 2048 0 0.0
.text 801328 801328 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121048 1121048 0 0.0
.bss 140920 140920 0 0.0
.data 2060 2060 0 0.0
.text 978048 978048 0 0.0
window-app BRD4161A (read/write) 1066700 1066700 0 0.0
.bss 134852 134852 0 0.0
.data 2076 2076 0 0.0
.text 929748 929748 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018218 1018216 -2 -0.0
(read/write) 1486650 1486650 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214776 214776 0 0.0
.flash.text 1018218 1018216 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072315 1072315 0 0.0
(read/write) 488752 488752 0 0.0
.dram0.bss 77376 77376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245236 245236 0 0.0
.flash.text 1066931 1066931 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659520 659520 0 0.0
.bss 71292 71292 0 0.0
.data 1992 1992 0 0.0
.text 580436 580436 0 0.0
lock k32w061+release (read/write) 685988 685988 0 0.0
.bss 71756 71756 0 0.0
.data 2004 2004 0 0.0
.text 606428 606428 0 0.0
linux all-clusters-app debug (read only) 2952673 2952673 0 0.0
(read/write) 155288 155288 0 0.0
.bss 62144 62144 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84904 84904 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2512546 2512546 0 0.0
all-clusters-minimal-app debug (read only) 2806769 2806769 0 0.0
(read/write) 147224 147224 0 0.0
.bss 61472 61472 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264797 264797 0 0.0
.text 2367154 2367154 0 0.0
bridge-app debug+rpc (read only) 2310201 2310201 0 0.0
(read/write) 126048 126048 0 0.0
.bss 49536 49536 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66920 66920 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197696 197696 0 0.0
.text 1950962 1950962 0 0.0
chip-tool debug (read only) 10159629 10159629 0 0.0
(read/write) 606984 606984 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575216 575216 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509317 509317 0 0.0
.text 8250581 8250581 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9891076 9891076 0 0.0
(read/write) 671761 671761 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610784 610784 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7888052 7888052 0 0.0
lighting-app debug+rpc (read only) 2546105 2546105 0 0.0
(read/write) 130040 130040 0 0.0
.bss 50048 50048 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72056 72056 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213576 213576 0 0.0
.text 2162754 2162754 0 0.0
lock-app debug (read only) 2507953 2507953 0 0.0
(read/write) 125048 125048 0 0.0
.bss 48448 48448 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69032 69032 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228200 228200 0 0.0
.text 2114802 2114802 0 0.0
ota-provider-app debug (read only) 2317089 2317089 0 0.0
(read/write) 118856 118856 0 0.0
.bss 48096 48096 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63032 63032 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203288 203288 0 0.0
.text 1951218 1951218 0 0.0
ota-requestor-app debug (read only) 2434241 2434241 0 0.0
(read/write) 125760 125760 0 0.0
.bss 50464 50464 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67224 67224 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207328 207328 0 0.0
.text 2055954 2055954 0 0.0
shell debug (read only) 2542401 2542401 0 0.0
(read/write) 141608 141608 0 0.0
.bss 58056 58056 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76640 76640 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227218 227218 0 0.0
.text 2158962 2158962 0 0.0
thermostat-no-ble arm64 (read only) 2589940 2589940 0 0.0
(read/write) 158833 158833 0 0.0
.bss 65857 65857 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83184 83184 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2185104 2185104 0 0.0
tv-app debug (read only) 3095641 3095641 0 0.0
(read/write) 256424 256424 0 0.0
.bss 165832 165832 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248832 248832 0 0.0
.text 2659122 2659122 0 0.0
tv-casting-app debug (read only) 5553801 5553801 0 0.0
(read/write) 162256 162256 0 0.0
.bss 50856 50856 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102744 102744 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343113 343113 0 0.0
.text 4933954 4933954 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446592 2446592 0 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409236 1409236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174459 1174459 0 0.0
bss 144660 144660 0 0.0
rodata 141340 141340 0 0.0
text 809524 809524 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155311 1155311 0 0.0
bss 143896 143896 0 0.0
rodata 133272 133272 0 0.0
text 799228 799228 0 0.0
p6 all-clusters-app default (read/write) 2562256 2562256 0 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1520520 1520520 0 0.0
all-clusters-minimal-app default (read/write) 2508136 2508136 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1466400 1466400 0 0.0
light-app default (read/write) 2438648 2438648 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1396912 1396912 0 0.0
lock-app default (read/write) 2464928 2464928 0 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1423192 1423192 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797756 797756 0 0.0
bss 72336 72336 0 0.0
noinit 40416 40416 0 0.0
text 564510 564510 0 0.0
lighting-app tlsr9518adk80d (read/write) 817624 817624 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 580872 580872 0 0.0

@adabreuti adabreuti force-pushed the UseIndiciations_20084 branch from 992e207 to 33a5683 Compare June 29, 2022 19:05
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited
Loading

PR #20113: Size comparison from f03b9ae to 33a5683

Increases (9 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section f03b9ae 33a5683 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 186020 186052 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read/write) 196556 196572 16 0.0
lock-ftd LP_CC2652R7 (read/write) 173592 173624 32 0.0
pump-app LP_CC2652R7 (read/write) 164976 165016 40 0.0
pump-controller-app LP_CC2652R7 (read/write) 179256 179288 32 0.0
shell LP_CC2652R7 (read/write) 189080 189112 32 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 580214 580222 8 0.0
.app_xip_area 458800 458808 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 799480 799484 4 0.0
telink light-switch-app tlsr9518adk80d text 564814 564816 2 0.0
Decreases (9 builds for cc13x2_26x2, k32w, nrfconnect)
platform target config section f03b9ae 33a5683 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665203 665171 -32 -0.0
.text 576796 576764 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653963 653947 -16 -0.0
.text 562076 562060 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 667775 667743 -32 -0.0
.text 591104 591072 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 617191 617151 -40 -0.0
.text 540632 540592 -40 -0.0
pump-app LP_CC2652R7 (read only) 677239 677199 -40 -0.0
.text 588332 588292 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 663079 663047 -32 -0.0
.text 578328 578296 -32 -0.0
shell LP_CC2652R7 (read only) 657646 657614 -32 -0.0
.text 572492 572460 -32 -0.0
k32w light k32w061+release (read/write) 658040 658024 -16 -0.0
.text 580732 580716 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 809776 809772 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f03b9ae 33a5683 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665203 665171 -32 -0.0
(read/write) 186020 186052 32 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576796 576764 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653963 653947 -16 -0.0
(read/write) 196556 196572 16 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 562076 562060 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 667775 667743 -32 -0.0
(read/write) 173592 173624 32 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591104 591072 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 617191 617151 -40 -0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540632 540592 -40 -0.0
pump-app LP_CC2652R7 (read only) 677239 677199 -40 -0.0
(read/write) 164976 165016 40 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588332 588292 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 663079 663047 -32 -0.0
(read/write) 179256 179288 32 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84271 84271 0 0.0
.text 578328 578296 -32 -0.0
shell LP_CC2652R7 (read only) 657646 657614 -32 -0.0
(read/write) 189080 189112 32 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84838 84838 0 0.0
.text 572492 572460 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578654 578654 0 0.0
.app_xip_area 457432 457432 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580214 580222 8 0.0
.app_xip_area 458800 458808 8 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080060 1080060 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 944996 944996 0 0.0
BRD4161A+rpc (read/write) 1134356 1134356 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982400 982400 0 0.0
BRD4161A+rs911x (read/write) 942524 942524 0 0.0
.bss 138712 138712 0 0.0
.data 2048 2048 0 0.0
.text 801744 801744 0 0.0
lock-app BRD4161A+wf200 (read/write) 1119568 1119568 0 0.0
.bss 139144 139144 0 0.0
.data 2060 2060 0 0.0
.text 978344 978344 0 0.0
window-app BRD4161A (read/write) 1065324 1065324 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930148 930148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018484 1018484 0 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214784 214784 0 0.0
.flash.text 1018484 1018484 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072575 1072575 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067191 1067191 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658040 658024 -16 -0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580716 -16 -0.0
lock k32w061+release (read/write) 684508 684508 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606724 606724 0 0.0
linux all-clusters-app debug (read only) 2954225 2954225 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84952 84952 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2513954 2513954 0 0.0
all-clusters-minimal-app debug (read only) 2808321 2808321 0 0.0
(read/write) 146648 146648 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77592 77592 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264797 264797 0 0.0
.text 2368562 2368562 0 0.0
bridge-app debug+rpc (read only) 2311737 2311737 0 0.0
(read/write) 125472 125472 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66968 66968 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197696 197696 0 0.0
.text 1952354 1952354 0 0.0
chip-tool debug (read only) 10161405 10161405 0 0.0
(read/write) 607016 607016 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575248 575248 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509317 509317 0 0.0
.text 8252261 8252261 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9893316 9893316 0 0.0
(read/write) 671793 671793 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610816 610816 0 0.0
.dynamic 528 528 0 0.0
.got 13408 13408 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472548 472548 0 0.0
.text 7890196 7890196 0 0.0
lighting-app debug+rpc (read only) 2547641 2547641 0 0.0
(read/write) 129496 129496 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72104 72104 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213576 213576 0 0.0
.text 2164146 2164146 0 0.0
lock-app debug (read only) 2509489 2509489 0 0.0
(read/write) 124472 124472 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228200 228200 0 0.0
.text 2116194 2116194 0 0.0
ota-provider-app debug (read only) 2318625 2318625 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63080 63080 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203288 203288 0 0.0
.text 1952610 1952610 0 0.0
ota-requestor-app debug (read only) 2435809 2435809 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207328 207328 0 0.0
.text 2057378 2057378 0 0.0
shell debug (read only) 2543857 2543857 0 0.0
(read/write) 141032 141032 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227218 227218 0 0.0
.text 2160322 2160322 0 0.0
thermostat-no-ble arm64 (read only) 2591604 2591604 0 0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186624 0 0.0
tv-app debug (read only) 3097481 3097481 0 0.0
(read/write) 255880 255880 0 0.0
.bss 165224 165224 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248832 248832 0 0.0
.text 2660818 2660818 0 0.0
tv-casting-app debug (read only) 5555385 5555385 0 0.0
(read/write) 161680 161680 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343113 343113 0 0.0
.text 4935394 4935394 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447080 2447080 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409724 1409724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172915 1172915 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809776 809772 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799480 799484 4 0.0
p6 all-clusters-app default (read/write) 2562640 2562640 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1520904 1520904 0 0.0
all-clusters-minimal-app default (read/write) 2508504 2508504 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1466768 1466768 0 0.0
light-app default (read/write) 2439016 2439016 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397280 1397280 0 0.0
lock-app default (read/write) 2465312 2465312 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423576 1423576 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796292 796292 0 0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564814 564816 2 0.0
lighting-app tlsr9518adk80d (read/write) 816152 816152 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581168 581168 0 0.0

@andy31415 andy31415 merged commit 9d2eeb0 into project-chip:master Jun 29, 2022
woody-apple pushed a commit to woody-apple/connectedhomeip that referenced this pull request Jun 29, 2022
@adabreuti @woody-apple
Update BLE manager to use indications (project-chip#20113)
d7f6062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The TI CC13x2 implementation should use indications for the BLE Manager implementation
3 participants
@adabreuti @andy31415 @turon