-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase session pool size on Darwin so we don't run out of sessions. #20086
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:bump-session-pool-size
Jun 29, 2022
Merged
Increase session pool size on Darwin so we don't run out of sessions. #20086
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:bump-session-pool-size
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to have enough sessions for all the subscriptions we will want to have.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
isiu-apple
June 28, 2022 23:15
pullapprove
bot
requested review from
mrjerryjohns,
tecimovic,
msandstedt,
tehampson,
saurabhst,
vijs,
selissia,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 28, 2022 23:15
PR #20086: Size comparison from d4bb6ee to 2b68cf8 Increases (5 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 29, 2022
andy31415
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have enough sessions for all the subscriptions we will want
to have.
Problem
Default pool size is too small for the number of devices we might want simultaneous subscriptions to.
Change overview
Bump the size.