Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported CastingServerBridge implementation to MatterTvCastingBridge.Framework #20022

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

sharadb-amazon
Copy link
Contributor

Problem

The CastingServerBridge (and related Objective C bridge code) needs to be consumable in other apps (besides the reference implementation of the TvCasting example app).

Change overview

This PR has NO code changes. Files have been moved and the pbxproj files have been reconfigured to reflect the corresponding changes in the directory and build structure. In this PR, the CastingServerBridge and related Obj-C code has been moved to a MatterTvCastingBridge.Framework

Testing

Tested on a real iPhone that the E2E customer journey through the casting experience is unaffected.

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

PR #20022: Size comparison from 6efefe3 to e8367d7

Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 6efefe3 e8367d7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667447 667455 8 0.0
.text 590984 590992 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 799412 799416 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797712 797720 8 0.0
text 564552 564554 2 0.0
lighting-app tlsr9518adk80d (read/write) 817780 817788 8 0.0
text 581096 581100 4 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 6efefe3 e8367d7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 175680 175672 -8 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6efefe3 e8367d7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 664915 664915 0 0.0
(read/write) 188068 188068 0 0.0
.bss 75876 75876 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576708 576708 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653655 653655 0 0.0
(read/write) 198624 198624 0 0.0
.bss 75172 75172 0 0.0
.data 3356 3356 0 0.0
.rodata 91359 91359 0 0.0
.text 561980 561980 0 0.0
lock-ftd LP_CC2652R7 (read only) 667447 667455 8 0.0
(read/write) 175680 175672 -8 -0.0
.bss 72908 72908 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 590984 590992 8 0.0
lock-mtd LP_CC2652R7 (read only) 616871 616871 0 0.0
(read/write) 146024 146024 0 0.0
.bss 68628 68628 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540520 540520 0 0.0
pump-app LP_CC2652R7 (read only) 677023 677023 0 0.0
(read/write) 166960 166960 0 0.0
.bss 72996 72996 0 0.0
.data 3280 3280 0 0.0
.rodata 88367 88367 0 0.0
.text 588172 588172 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662927 662927 0 0.0
(read/write) 181176 181176 0 0.0
.bss 73116 73116 0 0.0
.data 3276 3276 0 0.0
.rodata 84215 84215 0 0.0
.text 578232 578232 0 0.0
shell LP_CC2652R7 (read only) 657370 657370 0 0.0
(read/write) 191116 191116 0 0.0
.bss 78180 78180 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572404 572404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580462 580462 0 0.0
.app_xip_area 457472 457472 0 0.0
.bss 65952 65952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582030 582030 0 0.0
.app_xip_area 458848 458848 0 0.0
.bss 66144 66144 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583502 583502 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 65160 65160 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081412 1081412 0 0.0
.bss 134756 134756 0 0.0
.data 2048 2048 0 0.0
.text 944588 944588 0 0.0
BRD4161A+rpc (read/write) 1135684 1135684 0 0.0
.bss 151444 151444 0 0.0
.data 2260 2260 0 0.0
.text 981960 981960 0 0.0
BRD4161A+rs911x (read/write) 946552 946552 0 0.0
.bss 140472 140472 0 0.0
.data 2048 2048 0 0.0
.text 804012 804012 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121280 1121280 0 0.0
.bss 140920 140920 0 0.0
.data 2060 2060 0 0.0
.text 978280 978280 0 0.0
window-app BRD4161A (read/write) 1066676 1066676 0 0.0
.bss 134836 134836 0 0.0
.data 2076 2076 0 0.0
.text 929740 929740 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018712 1018712 0 0.0
(read/write) 1486498 1486498 0 0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214624 214624 0 0.0
.flash.text 1018712 1018712 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072927 1072927 0 0.0
(read/write) 488600 488600 0 0.0
.dram0.bss 77344 77344 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245116 245116 0 0.0
.flash.text 1067543 1067543 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659704 659704 0 0.0
.bss 71276 71276 0 0.0
.data 1992 1992 0 0.0
.text 580636 580636 0 0.0
lock k32w061+release (read/write) 685960 685960 0 0.0
.bss 71748 71748 0 0.0
.data 2004 2004 0 0.0
.text 606408 606408 0 0.0
linux all-clusters-app debug (read only) 2954457 2954457 0 0.0
(read/write) 178136 178136 0 0.0
.bss 84960 84960 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263037 263037 0 0.0
.text 2514354 2514354 0 0.0
all-clusters-minimal-app debug (read only) 2808553 2808553 0 0.0
(read/write) 170072 170072 0 0.0
.bss 84288 84288 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264701 264701 0 0.0
.text 2368962 2368962 0 0.0
bridge-app debug+rpc (read only) 2310961 2310961 0 0.0
(read/write) 148896 148896 0 0.0
.bss 72352 72352 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197632 197632 0 0.0
.text 1951714 1951714 0 0.0
chip-tool debug (read only) 10184693 10184693 0 0.0
(read/write) 610824 610824 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579056 579056 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509189 509189 0 0.0
.text 8266773 8266773 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9920132 9920132 0 0.0
(read/write) 675649 675649 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614616 614616 0 0.0
.dynamic 528 528 0 0.0
.got 13440 13440 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472260 472260 0 0.0
.text 7908292 7908292 0 0.0
lighting-app debug+rpc (read only) 2548473 2548473 0 0.0
(read/write) 152952 152952 0 0.0
.bss 72896 72896 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213416 213416 0 0.0
.text 2164850 2164850 0 0.0
lock-app debug (read only) 2509705 2509705 0 0.0
(read/write) 147896 147896 0 0.0
.bss 71264 71264 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228104 228104 0 0.0
.text 2116578 2116578 0 0.0
ota-provider-app debug (read only) 2318825 2318825 0 0.0
(read/write) 141736 141736 0 0.0
.bss 70944 70944 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203256 203256 0 0.0
.text 1952914 1952914 0 0.0
ota-requestor-app debug (read only) 2436073 2436073 0 0.0
(read/write) 148608 148608 0 0.0
.bss 73280 73280 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207264 207264 0 0.0
.text 2057778 2057778 0 0.0
shell debug (read only) 2544233 2544233 0 0.0
(read/write) 164488 164488 0 0.0
.bss 80904 80904 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227250 227250 0 0.0
.text 2160690 2160690 0 0.0
thermostat-no-ble arm64 (read only) 2591212 2591212 0 0.0
(read/write) 181761 181761 0 0.0
.bss 88705 88705 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165036 165036 0 0.0
.text 2186448 2186448 0 0.0
tv-app debug (read only) 3099041 3099041 0 0.0
(read/write) 279240 279240 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248992 248992 0 0.0
.text 2662290 2662290 0 0.0
tv-casting-app debug (read only) 5555681 5555681 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102776 102776 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343177 343177 0 0.0
.text 4935698 4935698 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2446928 2446928 0 0.0
.bss 215716 215716 0 0.0
.data 5872 5872 0 0.0
.text 1409572 1409572 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174579 1174579 0 0.0
bss 144650 144650 0 0.0
rodata 141284 141284 0 0.0
text 809712 809712 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155447 1155447 0 0.0
bss 143886 143886 0 0.0
rodata 133216 133216 0 0.0
text 799412 799416 4 0.0
p6 all-clusters-app default (read/write) 2565240 2565240 0 0.0
.bss 150896 150896 0 0.0
.data 2776 2776 0 0.0
.text 1523504 1523504 0 0.0
all-clusters-minimal-app default (read/write) 2511104 2511104 0 0.0
.bss 150176 150176 0 0.0
.data 2776 2776 0 0.0
.text 1469368 1469368 0 0.0
light-app default (read/write) 2441240 2441240 0 0.0
.bss 142232 142232 0 0.0
.data 2592 2592 0 0.0
.text 1399504 1399504 0 0.0
lock-app default (read/write) 2467528 2467528 0 0.0
.bss 142080 142080 0 0.0
.data 2600 2600 0 0.0
.text 1425792 1425792 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797712 797720 8 0.0
bss 72344 72344 0 0.0
noinit 40416 40416 0 0.0
text 564552 564554 2 0.0
lighting-app tlsr9518adk80d (read/write) 817780 817788 8 0.0
bss 73164 73164 0 0.0
noinit 40416 40416 0 0.0
text 581096 581100 4 0.0

@woody-apple woody-apple merged commit c239114 into project-chip:master Jun 28, 2022
@sharadb-amazon sharadb-amazon deleted the ios-20220627 branch June 28, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants