Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shell cmd_ping/cmd_send that were obsolete #19987

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Remove shell cmd_ping/cmd_send that were obsolete #19987

merged 2 commits into from
Jun 27, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • Both cmd_send and cmd_ping used pre-spec internal test-level
    APIs which have grown stale and no longer function. They showed API
    usage that was both incorrect and dangerous. They are were also
    no longer used.

Fixes #19889
Fixes #6293

Change overview

This PR removes vestiges of the already deleted commands, which already had become
empty in a prior PR since the way they used FabricTable was
also incorrect (and this had been corrected at the time).

Testing

  • Unit tests still pass
  • Integration tests still pass

@tcarmelveilleux
Remove shell cmd_ping/cmd_send that were obsolete
23f4fdb 
- Both cmd_send and cmd_ping used pre-spec internal test-level
  APIs which have grown stale and no longer function. They showed API
  usage that was both incorrect and dangerous. They are were also
  no longer used.

Fixes project-chip#19889
Fixes project-chip#6293

This PR removes these stale commands, which already had become
empty in a prior PR since the way they used FabricTable was
also incorrect (and this had been corrected at the time).

Testing done:
- Unit tests still pass
- Integration tests still pass
@github-actions
Copy link

PR #19987: Size comparison from 98f5271 to 23f4fdb

Increases (2 builds for telink)
platform target config section 98f5271 23f4fdb change % change
telink light-switch-app tlsr9518adk80d (read/write) 799080 799088 8 0.0
text 565510 565514 4 0.0
lighting-app tlsr9518adk80d text 581950 581952 2 0.0
Full report (2 builds for telink)
platform target config section 98f5271 23f4fdb change % change
telink light-switch-app tlsr9518adk80d (read/write) 799080 799088 8 0.0
bss 72360 72360 0 0.0
noinit 40416 40416 0 0.0
text 565510 565514 4 0.0
lighting-app tlsr9518adk80d (read/write) 819044 819044 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 581950 581952 2 0.0

@github-actions
Copy link

github-actions bot commented Jun 26, 2022 •
edited
Loading

PR #19987: Size comparison from 98f5271 to 61bb5a9

Increases (4 builds for nrfconnect, telink)
platform target config section 98f5271 61bb5a99 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 810552 810556 4 0.0
lighting-app nrf52840dongle_nrf52840 text 747348 747352 4 0.0
pump-app nrf52840dk_nrf52840 text 748648 748652 4 0.0
telink light-switch-app tlsr9518adk80d text 565510 565512 2 0.0
Decreases (6 builds for cyw30739, esp32, linux, nrfconnect)
platform target config section 98f5271 61bb5a99 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580830 580822 -8 -0.0
.app_xip_area 457824 457816 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1019320 1019318 -2 -0.0
.flash.text 1019320 1019318 -2 -0.0
linux shell debug (read only) 2550537 2550505 -32 -0.0
.text 2166482 2166450 -32 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc (read/write) 1138327 1138311 -16 -0.0
text 796764 796760 -4 -0.0
lock-app nrf5340dk_nrf5340_cpuapp text 682240 682236 -4 -0.0
shell nrf52840dk_nrf52840 (read/write) 779023 779007 -16 -0.0
text 515276 515260 -16 -0.0
Full report (54 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 98f5271 61bb5a99 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665755 665755 0 0.0
(read/write) 187244 187244 0 0.0
.bss 75892 75892 0 0.0
.data 3356 3356 0 0.0
.rodata 88059 88059 0 0.0
.text 577380 577380 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 654531 654531 0 0.0
(read/write) 197764 197764 0 0.0
.bss 75188 75188 0 0.0
.data 3356 3356 0 0.0
.rodata 91563 91563 0 0.0
.text 562652 562652 0 0.0
lock-ftd LP_CC2652R7 (read only) 668291 668291 0 0.0
(read/write) 174852 174852 0 0.0
.bss 72924 72924 0 0.0
.data 3280 3280 0 0.0
.rodata 76147 76147 0 0.0
.text 591664 591664 0 0.0
lock-mtd LP_CC2652R7 (read only) 617699 617699 0 0.0
(read/write) 146040 146040 0 0.0
.bss 68644 68644 0 0.0
.data 3280 3280 0 0.0
.rodata 76027 76027 0 0.0
.text 541184 541184 0 0.0
pump-app LP_CC2652R7 (read only) 678111 678111 0 0.0
(read/write) 165888 165888 0 0.0
.bss 73012 73012 0 0.0
.data 3280 3280 0 0.0
.rodata 88711 88711 0 0.0
.text 588916 588916 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663991 663991 0 0.0
(read/write) 180128 180128 0 0.0
.bss 73132 73132 0 0.0
.data 3276 3276 0 0.0
.rodata 84551 84551 0 0.0
.text 578960 578960 0 0.0
shell LP_CC2652R7 (read only) 658206 658206 0 0.0
(read/write) 190296 190296 0 0.0
.bss 78196 78196 0 0.0
.data 3360 3360 0 0.0
.rodata 84814 84814 0 0.0
.text 573076 573076 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580830 580822 -8 -0.0
.app_xip_area 457824 457816 -8 -0.0
.bss 65968 65968 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582390 582390 0 0.0
.app_xip_area 459192 459192 0 0.0
.bss 66160 66160 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584582 584582 0 0.0
.app_xip_area 462424 462424 0 0.0
.bss 65176 65176 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1082704 1082704 0 0.0
.bss 134772 134772 0 0.0
.data 2048 2048 0 0.0
.text 945864 945864 0 0.0
BRD4161A+rpc (read/write) 1137020 1137020 0 0.0
.bss 151460 151460 0 0.0
.data 2260 2260 0 0.0
.text 983276 983276 0 0.0
BRD4161A+rs911x (read/write) 945656 945656 0 0.0
.bss 140488 140488 0 0.0
.data 2048 2048 0 0.0
.text 803100 803100 0 0.0
lock-app BRD4161A+wf200 (read/write) 1122544 1122544 0 0.0
.bss 140936 140936 0 0.0
.data 2060 2060 0 0.0
.text 979528 979528 0 0.0
window-app BRD4161A (read/write) 1067980 1067980 0 0.0
.bss 134852 134852 0 0.0
.data 2076 2076 0 0.0
.text 931032 931032 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019320 1019318 -2 -0.0
(read/write) 1487018 1487018 0 0.0
.dram0.bss 71840 71840 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 215128 215128 0 0.0
.flash.text 1019320 1019318 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073427 1073427 0 0.0
(read/write) 489152 489152 0 0.0
.dram0.bss 77360 77360 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245652 245652 0 0.0
.flash.text 1068043 1068043 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660424 660424 0 0.0
.bss 71292 71292 0 0.0
.data 1992 1992 0 0.0
.text 581340 581340 0 0.0
lock k32w061+release (read/write) 686832 686832 0 0.0
.bss 71764 71764 0 0.0
.data 2004 2004 0 0.0
.text 607264 607264 0 0.0
linux all-clusters-app debug (read only) 2960409 2960409 0 0.0
(read/write) 178200 178200 0 0.0
.bss 85024 85024 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263549 263549 0 0.0
.text 2519794 2519794 0 0.0
all-clusters-minimal-app debug (read only) 2814473 2814473 0 0.0
(read/write) 170136 170136 0 0.0
.bss 84352 84352 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265181 265181 0 0.0
.text 2374402 2374402 0 0.0
bridge-app debug+rpc (read only) 2316913 2316913 0 0.0
(read/write) 148928 148928 0 0.0
.bss 72384 72384 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198144 198144 0 0.0
.text 1957154 1957154 0 0.0
chip-tool debug (read only) 10194293 10194293 0 0.0
(read/write) 610856 610856 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579064 579064 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510085 510085 0 0.0
.text 8275429 8275429 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9928900 9928900 0 0.0
(read/write) 675697 675697 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614632 614632 0 0.0
.dynamic 528 528 0 0.0
.got 13456 13456 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473380 473380 0 0.0
.text 7915844 7915844 0 0.0
lighting-app debug+rpc (read only) 2553801 2553801 0 0.0
(read/write) 152984 152984 0 0.0
.bss 72928 72928 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213864 213864 0 0.0
.text 2169730 2169730 0 0.0
lock-app debug (read only) 2515753 2515753 0 0.0
(read/write) 147928 147928 0 0.0
.bss 71296 71296 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228712 228712 0 0.0
.text 2122018 2122018 0 0.0
ota-provider-app debug (read only) 2324777 2324777 0 0.0
(read/write) 141768 141768 0 0.0
.bss 70976 70976 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203736 203736 0 0.0
.text 1958386 1958386 0 0.0
ota-requestor-app debug (read only) 2441929 2441929 0 0.0
(read/write) 148640 148640 0 0.0
.bss 73312 73312 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207680 207680 0 0.0
.text 2063218 2063218 0 0.0
shell debug (read only) 2550537 2550505 -32 -0.0
(read/write) 164520 164520 0 0.0
.bss 80936 80936 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227762 227762 0 0.0
.text 2166482 2166450 -32 -0.0
thermostat-no-ble arm64 (read only) 2597460 2597460 0 0.0
(read/write) 181793 181793 0 0.0
.bss 88721 88721 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 166148 166148 0 0.0
.text 2191536 2191536 0 0.0
tv-app debug (read only) 3108129 3108129 0 0.0
(read/write) 279304 279304 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249696 249696 0 0.0
.text 2670626 2670626 0 0.0
tv-casting-app debug (read only) 5592401 5592401 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343657 343657 0 0.0
.text 4971890 4971890 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2517684 2517684 0 0.0
.bss 223496 223496 0 0.0
.data 5584 5584 0 0.0
.text 1480300 1480300 0 0.0
all-clusters-minimal-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466528 2466528 0 0.0
.bss 222792 222792 0 0.0
.data 5560 5560 0 0.0
.text 1429124 1429124 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456540 2456540 0 0.0
.bss 216876 216876 0 0.0
.data 5840 5840 0 0.0
.text 1419156 1419156 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448040 2448040 0 0.0
.bss 215732 215732 0 0.0
.data 5872 5872 0 0.0
.text 1410684 1410684 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2397188 2397188 0 0.0
.bss 215608 215608 0 0.0
.data 5712 5712 0 0.0
.text 1359804 1359804 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175867 1175867 0 0.0
bss 144666 144666 0 0.0
rodata 141724 141724 0 0.0
text 810552 810556 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156735 1156735 0 0.0
bss 143902 143902 0 0.0
rodata 133656 133656 0 0.0
text 800260 800260 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1168159 1168159 0 0.0
bss 146229 146229 0 0.0
rodata 124104 124104 0 0.0
text 818956 818956 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1138327 1138311 -16 -0.0
bss 146674 146674 0 0.0
rodata 115648 115648 0 0.0
text 796764 796760 -4 -0.0
nrf52840dongle_nrf52840 (read/write) 1074979 1074979 0 0.0
bss 153460 153460 0 0.0
rodata 93148 93148 0 0.0
text 747348 747352 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1071850 1071850 0 0.0
bss 142600 142600 0 0.0
rodata 116512 116512 0 0.0
text 731672 731672 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1125815 1125815 0 0.0
bss 136205 136205 0 0.0
rodata 141288 141288 0 0.0
text 769460 769460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1029678 1029678 0 0.0
bss 132608 132608 0 0.0
rodata 133756 133756 0 0.0
text 682240 682236 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1081107 1081107 0 0.0
bss 136124 136124 0 0.0
rodata 117484 117484 0 0.0
text 748648 748652 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1069011 1069011 0 0.0
bss 135919 135919 0 0.0
rodata 114268 114268 0 0.0
text 740032 740032 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779023 779007 -16 -0.0
bss 120391 120391 0 0.0
rodata 69512 69512 0 0.0
text 515276 515260 -16 -0.0
p6 all-clusters-app default (read/write) 2564496 2564496 0 0.0
.bss 150912 150912 0 0.0
.data 2776 2776 0 0.0
.text 1522760 1522760 0 0.0
all-clusters-minimal-app default (read/write) 2510360 2510360 0 0.0
.bss 150192 150192 0 0.0
.data 2776 2776 0 0.0
.text 1468624 1468624 0 0.0
light-app default (read/write) 2440504 2440504 0 0.0
.bss 142248 142248 0 0.0
.data 2592 2592 0 0.0
.text 1398768 1398768 0 0.0
lock-app default (read/write) 2466776 2466776 0 0.0
.bss 142096 142096 0 0.0
.data 2600 2600 0 0.0
.text 1425040 1425040 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799080 799080 0 0.0
bss 72360 72360 0 0.0
noinit 40416 40416 0 0.0
text 565510 565512 2 0.0
lighting-app tlsr9518adk80d (read/write) 819044 819044 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 581950 581950 0 0.0

@Damian-Nordic Damian-Nordic merged commit 012ec2e into project-chip:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@tehampson tehampson Awaiting requested review from tehampson

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd_ping/cmd_send in Shell are obsolete ping run via ./chip-shell is not able to get the ping response back
3 participants
@tcarmelveilleux @tehampson @Damian-Nordic