-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we don't run slow YAML tests in CI. #19975
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:no-ci-slow-tests
Jun 25, 2022
Merged
Ensure we don't run slow YAML tests in CI. #19975
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:no-ci-slow-tests
Jun 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran and
hawk248
June 25, 2022 01:13
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 25, 2022 01:13
tcarmelveilleux
approved these changes
Jun 25, 2022
PR #19975: Size comparison from 8aeb73c to cea374c Increases (3 builds for linux, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
* Move some existing slow YAML tests to the "manual" list. * Modify the test runner script so it can run manual tests if you explicitly tell it to. * Add a way to specify a per-YAML-file timeout to the runner script. * Use a 2-minute timeout in CI so that any YAML file that takes longer than that will fail.
bzbarsky-apple
force-pushed
the
no-ci-slow-tests
branch
from
June 25, 2022 03:22
cea374c
to
66edf76
Compare
PR #19975: Size comparison from 8aeb73c to 66edf76 Increases (3 builds for linux, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tell it to.
that will fail.
Problem
We had CI YAML tests that took many minutes each.
Change overview
Don't allow that.
Testing
Ran locally with
--test-timeout-seconds 4
and saw tests fail if they took longer than 4 secods.