Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add featureflags to content app (dynamic) endpoints #19930

Merged
merged 5 commits into from
Jun 24, 2022

Conversation

chrisdecenzo
Copy link
Contributor

@chrisdecenzo chrisdecenzo commented Jun 24, 2022

Problem

Change overview

Add ability for delegates used by tv-app to set feature flags

TODO: still need to make the same change to other media clusters

Testing

  • tested using tv-app and tv-casting-app

@github-actions
Copy link

PR #19930: Size comparison from bb47380 to 1150d25

Increases (2 builds for nrfconnect)
platform target config section bb47380 1150d25 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203259 1203307 48 0.0
text 824268 824324 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150607 1150655 48 0.0
text 796064 796116 52 0.0
Full report (3 builds for mbed, nrfconnect)
platform target config section bb47380 1150d25 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2444192 2444192 0 0.0
.bss 214724 214724 0 0.0
.data 5872 5872 0 0.0
.text 1406836 1406836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203259 1203307 48 0.0
bss 143646 143646 0 0.0
rodata 156436 156436 0 0.0
text 824268 824324 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150607 1150655 48 0.0
bss 142882 142882 0 0.0
rodata 132768 132768 0 0.0
text 796064 796116 52 0.0

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

PR #19930: Size comparison from bb47380 to d20c1b0

Increases above 0.2%:

platform target config section bb47380 d20c1b09 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .bss 74964 75580 616 0.8
all-clusters-minimal-app LP_CC2652R7 (read/write) 158520 159136 616 0.4
.bss 74252 74868 616 0.8
lock-ftd LP_CC2652R7 (read/write) 178692 179292 600 0.3
.bss 71996 72596 600 0.8
lock-mtd LP_CC2652R7 (read/write) 145124 145724 600 0.4
.bss 67732 68332 600 0.9
pump-app LP_CC2652R7 (read/write) 169640 170240 600 0.4
.bss 72092 72692 600 0.8
pump-controller-app LP_CC2652R7 (read/write) 183872 184472 600 0.3
.bss 72204 72804 600 0.8
shell LP_CC2652R7 .bss 77268 77884 616 0.8
k32w light k32w061+release .bss 70396 70988 592 0.8
lock k32w061+release .bss 70868 71460 592 0.8
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 143646 144262 616 0.4
all-clusters-minimal-app nrf52840dk_nrf52840 bss 142882 143498 616 0.4
p6 all-clusters-app default .data 2768 2776 8 0.3
all-clusters-minimal-app default .data 2768 2776 8 0.3
Increases (16 builds for cc13x2_26x2, esp32, k32w, linux, nrfconnect, p6)
platform target config section bb47380 d20c1b09 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660539 660899 360 0.1
(read/write) 191532 191788 256 0.1
.bss 74964 75580 616 0.8
.rodata 87059 87091 32 0.0
.text 573168 573492 324 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 649431 649831 400 0.1
(read/write) 158520 159136 616 0.4
.bss 74252 74868 616 0.8
.rodata 90671 90711 40 0.0
.text 558440 558796 356 0.1
lock-ftd LP_CC2652R7 (read/write) 178692 179292 600 0.3
.bss 71996 72596 600 0.8
lock-mtd LP_CC2652R7 (read/write) 145124 145724 600 0.4
.bss 67732 68332 600 0.9
pump-app LP_CC2652R7 (read/write) 169640 170240 600 0.4
.bss 72092 72692 600 0.8
pump-controller-app LP_CC2652R7 (read/write) 183872 184472 600 0.3
.bss 72204 72804 600 0.8
shell LP_CC2652R7 (read only) 690378 690770 392 0.1
(read/write) 157196 157420 224 0.1
.bss 77268 77884 616 0.8
.rodata 109922 109954 32 0.0
.text 580144 580500 356 0.1
esp32 all-clusters-app c3devkit (read only) 1014322 1014688 366 0.0
(read/write) 1485698 1485754 56 0.0
.dram0.bss 71424 71440 16 0.0
.flash.rodata 214224 214264 40 0.0
.flash.text 1014322 1014688 366 0.0
m5stack (read only) 1068575 1068967 392 0.0
(read/write) 487800 487908 108 0.0
.dram0.bss 76936 76952 16 0.0
.flash.rodata 244724 244816 92 0.0
.flash.text 1063191 1063583 392 0.0
k32w light k32w061+release (read/write) 662232 662824 592 0.1
.bss 70396 70988 592 0.8
lock k32w061+release (read/write) 694512 695120 608 0.1
.bss 70868 71460 592 0.8
.text 615844 615860 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 .rodata 471452 471484 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203259 1204315 1056 0.1
bss 143646 144262 616 0.4
rodata 156436 156468 32 0.0
text 824268 824656 388 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150607 1151663 1056 0.1
bss 142882 143498 616 0.4
rodata 132768 132800 32 0.0
text 796064 796448 384 0.0
p6 all-clusters-app default (read/write) 2556024 2556600 576 0.0
.bss 149872 149888 16 0.0
.data 2768 2776 8 0.3
.text 1514288 1514864 576 0.0
all-clusters-minimal-app default (read/write) 2501872 2502464 592 0.0
.bss 149152 149168 16 0.0
.data 2768 2776 8 0.3
.text 1460136 1460728 592 0.0
Decreases (1 build for linux)
platform target config section bb47380 d20c1b09 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9904764 9903788 -976 -0.0
(read/write) 675281 675249 -32 -0.0
.data.rel.ro 614200 614176 -24 -0.0
.text 7894404 7893428 -976 -0.0
Full report (20 builds for cc13x2_26x2, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section bb47380 d20c1b09 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660539 660899 360 0.1
(read/write) 191532 191788 256 0.1
.bss 74964 75580 616 0.8
.data 3352 3352 0 0.0
.rodata 87059 87091 32 0.0
.text 573168 573492 324 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 649431 649831 400 0.1
(read/write) 158520 159136 616 0.4
.bss 74252 74868 616 0.8
.data 3352 3352 0 0.0
.rodata 90671 90711 40 0.0
.text 558440 558796 356 0.1
lock-ftd LP_CC2652R7 (read only) 663523 663523 0 0.0
(read/write) 178692 179292 600 0.3
.bss 71996 72596 600 0.8
.data 3276 3276 0 0.0
.rodata 75179 75179 0 0.0
.text 587864 587864 0 0.0
lock-mtd LP_CC2652R7 (read only) 612939 612939 0 0.0
(read/write) 145124 145724 600 0.4
.bss 67732 68332 600 0.9
.data 3276 3276 0 0.0
.rodata 75059 75059 0 0.0
.text 537392 537392 0 0.0
pump-app LP_CC2652R7 (read only) 673439 673439 0 0.0
(read/write) 169640 170240 600 0.4
.bss 72092 72692 600 0.8
.data 3276 3276 0 0.0
.rodata 87831 87831 0 0.0
.text 585124 585124 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659319 659319 0 0.0
(read/write) 183872 184472 600 0.3
.bss 72204 72804 600 0.8
.data 3272 3272 0 0.0
.rodata 83671 83671 0 0.0
.text 575168 575168 0 0.0
shell LP_CC2652R7 (read only) 690378 690770 392 0.1
(read/write) 157196 157420 224 0.1
.bss 77268 77884 616 0.8
.data 3356 3356 0 0.0
.rodata 109922 109954 32 0.0
.text 580144 580500 356 0.1
esp32 all-clusters-app c3devkit (read only) 1014322 1014688 366 0.0
(read/write) 1485698 1485754 56 0.0
.dram0.bss 71424 71440 16 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214224 214264 40 0.0
.flash.text 1014322 1014688 366 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068575 1068967 392 0.0
(read/write) 487800 487908 108 0.0
.dram0.bss 76936 76952 16 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244724 244816 92 0.0
.flash.text 1063191 1063583 392 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 662232 662824 592 0.1
.bss 70396 70988 592 0.8
.data 1988 1988 0 0.0
.text 584048 584048 0 0.0
lock k32w061+release (read/write) 694512 695120 608 0.1
.bss 70868 71460 592 0.8
.data 2000 2000 0 0.0
.text 615844 615860 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9904764 9903788 -976 -0.0
(read/write) 675281 675249 -32 -0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614200 614176 -24 -0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471452 471484 32 0.0
.text 7894404 7893428 -976 -0.0
thermostat-no-ble arm64 (read only) 2579164 2579164 0 0.0
(read/write) 180593 180593 0 0.0
.bss 87905 87905 0 0.0
.data 1696 1696 0 0.0
.data.rel.ro 82888 82888 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164812 164812 0 0.0
.text 2175296 2175296 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2444192 2444192 0 0.0
.bss 214724 214724 0 0.0
.data 5872 5872 0 0.0
.text 1406836 1406836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203259 1204315 1056 0.1
bss 143646 144262 616 0.4
rodata 156436 156468 32 0.0
text 824268 824656 388 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150607 1151663 1056 0.1
bss 142882 143498 616 0.4
rodata 132768 132800 32 0.0
text 796064 796448 384 0.0
p6 all-clusters-app default (read/write) 2556024 2556600 576 0.0
.bss 149872 149888 16 0.0
.data 2768 2776 8 0.3
.text 1514288 1514864 576 0.0
all-clusters-minimal-app default (read/write) 2501872 2502464 592 0.0
.bss 149152 149168 16 0.0
.data 2768 2776 8 0.3
.text 1460136 1460728 592 0.0
light-app default (read/write) 2432632 2432632 0 0.0
.bss 141232 141232 0 0.0
.data 2584 2584 0 0.0
.text 1390896 1390896 0 0.0
lock-app default (read/write) 2458896 2458896 0 0.0
.bss 141080 141080 0 0.0
.data 2600 2600 0 0.0
.text 1417160 1417160 0 0.0

@chrisdecenzo chrisdecenzo changed the title In-dev: Add featureflags to content app (dynamic) endpoints Add featureflags to content app (dynamic) endpoints Jun 24, 2022
@chrisdecenzo chrisdecenzo merged commit 8aeb73c into master Jun 24, 2022
@chrisdecenzo chrisdecenzo deleted the tvapps-android14 branch June 24, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants