-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenThread] Increase SRP service count #19900
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
Damian-Nordic:srp-service-number
Jun 24, 2022
Merged
[OpenThread] Increase SRP service count #19900
Damian-Nordic
merged 1 commit into
project-chip:master
from
Damian-Nordic:srp-service-number
Jun 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
June 23, 2022 15:16
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
June 23, 2022 15:16
andy31415
reviewed
Jun 23, 2022
woody-apple
approved these changes
Jun 23, 2022
Damian-Nordic
force-pushed
the
srp-service-number
branch
from
June 23, 2022 15:30
87319c1
to
617a144
Compare
woody-apple
approved these changes
Jun 23, 2022
PR #19900: Size comparison from 1381c8e to 617a144 Increases above 0.2%:
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
LuDuda
approved these changes
Jun 23, 2022
bzbarsky-apple
approved these changes
Jun 23, 2022
We assumed that MAX_FABRICS + 1 slots for SRP services is enough, but to pass Pre-SVE tests it must be possible to open the commissioning window after having been commissioned to MAX_FABRICS fabrics, and the commissionable instance name changes on opening the window. Therefore, if the extended discovery is enabled, two slots for the commissionable services are needed for a short time: the old service to be removed and the new service to be added. Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic
force-pushed
the
srp-service-number
branch
from
June 24, 2022 06:31
617a144
to
ce16220
Compare
PR #19900: Size comparison from 47c9ea5 to ce16220 Increases above 0.2%:
Increases (16 builds for cc13x2_26x2, efr32, k32w, nrfconnect, telink)
Decreases (1 build for esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We assumed that MAX_FABRICS + 1 slots for SRP services is enough, but to pass Pre-SVE tests it must be possible to open the commissioning window after having been commissioned to MAX_FABRICS fabrics, and the commissionable instance name changes on opening the window.
Therefore, if the extended discovery is enabled, two slots for the commissionable services are needed for a short time:
Change overview
Increase SRP service count for the extended discovery case.
Fixes #19774
Testing
Verified on nRF Connect examples that the maximum number of fabrics can be added and then the commissioning window can be open.