-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] android app supports Thread Commissioning #1988
[android] android app supports Thread Commissioning #1988
Conversation
@vidhis88 Could you help review this PR? |
@woody-apple Sure, will do! |
src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/CHIPToolActivity.kt
Outdated
Show resolved
Hide resolved
...oid/CHIPTool/app/src/main/java/com/google/chip/chiptool/commissioner/CommissionerWorker.java
Show resolved
Hide resolved
.../CHIPTool/app/src/main/java/com/google/chip/chiptool/commissioner/SelectNetworkFragment.java
Outdated
Show resolved
Hide resolved
.../CHIPTool/app/src/main/java/com/google/chip/chiptool/commissioner/CommissioningFragment.java
Outdated
Show resolved
Hide resolved
.../CHIPTool/app/src/main/java/com/google/chip/chiptool/commissioner/CommissioningFragment.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making most of the changes!
.../CHIPTool/app/src/main/java/com/google/chip/chiptool/commissioner/CommissioningFragment.java
Outdated
Show resolved
Hide resolved
.../CHIPTool/app/src/main/java/com/google/chip/chiptool/commissioner/CommissioningFragment.java
Outdated
Show resolved
Hide resolved
src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/CHIPToolActivity.kt
Outdated
Show resolved
Hide resolved
@vidhis88 can you re-review please? |
@wgtdkp Could you please restyle this? |
@woody-apple Thanks for remidning, we have one last comment (#1988 (comment)) to resolve before accepting this PR and it is still in progress. I will convert this PR to draft and convert back when it is ready. |
Will do. |
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together.
Looks good.
This PR adds Thread Commissioner to the Android demo App to support commissioning.
The Commissioner Activity scans CHIP QR code to extract device information and scans local Thread Network to join. After connecting to the selected Thread Network, the Thread Commissioner waits a while for a new device to pair. See the demo vedio: https://www.youtube.com/watch?v=nU0aj9_lBKU.
The Thread Commissioner depends on ot-commissioner so it is added as a 3rd party. Instructions to setup ot-commissioner has been updated in
src/android/CHIPTool/README.md
.Addresses #1979.