Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] android app supports Thread Commissioning #1988

Merged
merged 11 commits into from
Aug 13, 2020

Conversation

wgtdkp
Copy link
Contributor

@wgtdkp wgtdkp commented Aug 6, 2020

This PR adds Thread Commissioner to the Android demo App to support commissioning.

The Commissioner Activity scans CHIP QR code to extract device information and scans local Thread Network to join. After connecting to the selected Thread Network, the Thread Commissioner waits a while for a new device to pair. See the demo vedio: https://www.youtube.com/watch?v=nU0aj9_lBKU.

The Thread Commissioner depends on ot-commissioner so it is added as a 3rd party. Instructions to setup ot-commissioner has been updated in src/android/CHIPTool/README.md.

Addresses #1979.

@wgtdkp
Copy link
Contributor Author

wgtdkp commented Aug 6, 2020

@vidhis88 Could you help review this PR?

@woody-apple
Copy link
Contributor

Awesome!!!!

@wgtdkp can you restyle this please? Instructions are here: #1989

@wgtdkp
Copy link
Contributor Author

wgtdkp commented Aug 6, 2020

Awesome!!!!

@wgtdkp can you restyle this please? Instructions are here: #1989

@woody-apple Sure, will do!

Copy link
Contributor

@vidhis88 vidhis88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making most of the changes!

@woody-apple
Copy link
Contributor

@vidhis88 can you re-review please?

@woody-apple
Copy link
Contributor

@wgtdkp Could you please restyle this?

@wgtdkp
Copy link
Contributor Author

wgtdkp commented Aug 12, 2020

@vidhis88 can you re-review please?

@woody-apple Thanks for remidning, we have one last comment (#1988 (comment)) to resolve before accepting this PR and it is still in progress. I will convert this PR to draft and convert back when it is ready.

@wgtdkp
Copy link
Contributor Author

wgtdkp commented Aug 12, 2020

@wgtdkp Could you please restyle this?

Will do.

@wgtdkp wgtdkp marked this pull request as draft August 12, 2020 02:07
@wgtdkp wgtdkp marked this pull request as ready for review August 13, 2020 11:00
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 11156 11156
chip-nrf52840-lock-example.out .data 4 4
chip-nrf52840-lock-example.out .bss 0 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_str,0,589601
.debug_info,0,129828
.debug_macro,0,63597
.debug_line,0,35532
.debug_loc,0,21345
.text,11156,11156
.debug_abbrev,0,10435
.strtab,0,7610
.debug_frame,0,7120
.symtab,0,6336
.debug_aranges,0,2040
.debug_ranges,0,2040
.data,4,4
.bss,-8,0
[Unmapped],0,-11148


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf text 4378 4378
chip-nrf52840-lock-example.elf [LOAD #3 [RW]] 0 8
chip-nrf52840-lock-example.elf datas 3 3
chip-nrf52840-lock-example.elf [LOAD #2 [RW]] -3 -3
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] -10 -10
chip-nrf52840-lock-example.elf bss 0 -200
chip-nrf52840-lock-example.elf rodata -456 -456
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_info,0,124464
.debug_loc,0,34256
.debug_line,0,24720
.debug_str,0,19977
.debug_abbrev,0,10843
.debug_frame,0,4800
text,4378,4378
.debug_ranges,0,3784
.symtab,0,2704
.strtab,0,1990
.debug_aranges,0,1728
[LOAD #3 [RW]],8,0
datas,3,3
[Unmapped],0,-2
[LOAD #2 [RW]],-3,-3
[LOAD #1 [RWX]],-10,-10
bss,-200,0
rodata,-456,-456


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: integer overflow


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 208 208
chip-wifi-echo.elf .flash.rodata 68 68
chip-wifi-echo.elf .dram0.bss 0 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
[Unmapped],0,4027
.debug_info,0,1933
.debug_line,0,1391
.debug_str,0,901
.flash.text,208,208
.debug_frame,0,72
.flash.rodata,68,68
.strtab,0,53
.debug_loc,0,41
.debug_aranges,0,24
.debug_ranges,0,24
.symtab,0,16
.debug_abbrev,0,10
.dram0.bss,8,0


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


Copy link
Contributor

@vidhis88 vidhis88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together.
Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants