Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef - Fix broken esp32 RPC build caused by #18621 #19876

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Chef - Fix broken esp32 RPC build caused by #18621 #19876

merged 2 commits into from
Jun 23, 2022

Conversation

cpagravel
Copy link
Contributor

@cpagravel cpagravel commented Jun 23, 2022 •
edited
Loading

Problem

  • esp32 RPC build is broken in Chef. It wasn't correctly building the RPC version of the app.

Change overview

  • Fix esp32 RPC build so it does build the RPC version of the app.
  • Fix esp32 RPC build issue caused by pigweed update.

Testing

  • Tested RPC calls manually

@woody-apple
Copy link
Contributor

@cpagravel Thanks for spotting this. Can you add this into CI somehow so it gets caught?

@woody-apple
Copy link
Contributor

Fast tracking build updates

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19876: Size comparison from 777d72d to 20657e7

Increases (1 build for esp32)
platform target config section 777d72d 20657e7 change % change
esp32 all-clusters-app c3devkit (read only) 1014134 1014136 2 0.0
.flash.text 1014134 1014136 2 0.0
Decreases (1 build for cyw30739)
platform target config section 777d72d 20657e7 change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 589122 589114 -8 -0.0
.app_xip_area 459844 459836 -8 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 777d72d 20657e7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660447 660447 0 0.0
(read/write) 191160 191160 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 87007 87007 0 0.0
.text 573128 573128 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649347 649347 0 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90619 90619 0 0.0
.text 558408 558408 0 0.0
lock-ftd LP_CC2652R7 (read only) 692095 692095 0 0.0
(read/write) 149624 149624 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99463 99463 0 0.0
.text 592148 592148 0 0.0
lock-mtd LP_CC2652R7 (read only) 641511 641511 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673327 673327 0 0.0
(read/write) 169288 169288 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87775 87775 0 0.0
.text 585068 585068 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659219 659219 0 0.0
(read/write) 183508 183508 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83619 83619 0 0.0
.text 575120 575120 0 0.0
shell LP_CC2652R7 (read only) 690286 690286 0 0.0
(read/write) 156824 156824 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109862 109862 0 0.0
.text 580112 580112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 591738 0 0.0
.app_xip_area 462636 462636 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589122 589114 -8 -0.0
.app_xip_area 459844 459836 -8 -0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594258 594258 0 0.0
.app_xip_area 466028 466028 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1071000 1071000 0 0.0
.bss 132932 132932 0 0.0
.data 2048 2048 0 0.0
.text 936000 936000 0 0.0
BRD4161A+rpc (read/write) 1125060 1125060 0 0.0
.bss 149620 149620 0 0.0
.data 2260 2260 0 0.0
.text 973160 973160 0 0.0
BRD4161A+rs911x (read/write) 935672 935672 0 0.0
.bss 139304 139304 0 0.0
.data 2048 2048 0 0.0
.text 794300 794300 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111348 1111348 0 0.0
.bss 139720 139720 0 0.0
.data 2056 2056 0 0.0
.text 969552 969552 0 0.0
window-app BRD4161A (read/write) 1056252 1056252 0 0.0
.bss 133004 133004 0 0.0
.data 2076 2076 0 0.0
.text 921152 921152 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014136 2 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214176 0 0.0
.flash.text 1014134 1014136 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068475 0 0.0
(read/write) 486960 486960 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244668 244668 0 0.0
.flash.text 1063091 1063091 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661556 661556 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 584008 584008 0 0.0
lock k32w061+release (read/write) 723540 723540 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645536 645536 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439536 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202383 1202383 0 0.0
bss 142862 142862 0 0.0
rodata 156368 156368 0 0.0
text 824228 824228 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149731 1149731 0 0.0
bss 142098 142098 0 0.0
rodata 132700 132700 0 0.0
text 796020 796020 0 0.0
p6 all-clusters-app default (read/write) 2555936 2555936 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514200 1514200 0 0.0
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432536 2432536 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390800 1390800 0 0.0
lock-app default (read/write) 2453256 2453256 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411520 1411520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792204 792204 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561074 561074 0 0.0
lighting-app tlsr9518adk80d (read/write) 811908 811908 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577532 577532 0 0.0

@MtTsai
Copy link
Contributor

MtTsai commented Jun 23, 2022

Hi Chris,

I found it would build fail for the following build command ./chef.py -cbr --use_zzz -d rootnode_dimmablelight_gY80DaqEUL -t esp32
Full log is here: https://github.com/project-chip/connectedhomeip/runs/7017861600?check_suite_focus=true

I also tried to add the path as below.

+++ b/examples/chef/esp32/main/CMakeLists.txt
@@ -154,7 +154,7 @@ pw_proto_library(descriptor_service
   STRIP_PREFIX
     ${CHIP_ROOT}/examples/common/pigweed/protos
   DEPS
-    pw_protobuf.common_protos
+    pw_protobuf.common_proto
 )
 
 pw_proto_library(device_service
@@ -178,7 +178,7 @@ pw_proto_library(wifi_service
   PREFIX
     wifi_service
   DEPS
-    pw_protobuf.common_protos
+    pw_protobuf.common_proto
   STRIP_PREFIX
     ${CHIP_ROOT}/examples/common/pigweed/protos
 )

It face another build error

In file included from ../third_party/connectedhomeip/third_party/pigweed/repo/pw_rpc/public/pw_rpc/internal/lock.h:23,
                from ../third_party/connectedhomeip/third_party/pigweed/repo/pw_rpc/public/pw_rpc/channel.h:24,
                from ../third_party/connectedhomeip/third_party/pigweed/repo/pw_hdlc/public/pw_hdlc/rpc_packets.h:19,
                from ../third_party/connectedhomeip/third_party/pigweed/repo/pw_hdlc/rpc_packets.cc:15:
../third_party/connectedhomeip/third_party/pigweed/repo/pw_sync/public/pw_sync/mutex.h:24:10: fatal error: pw_sync_backend/mutex_native.h: No such file or directory
#include "pw_sync_backend/mutex_native.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I guess it should set the backend of pw_sync for it.
pw_set_backend(pw_sync.mutex, pw_sync_stl.mutex_backend) could make it build pass.
However, the device will keep reboot continuously after powering on.
I feel the reason is that the stl backend is not a right backend for esp32.

Do you have any idea to solve this issue?

@rgoliver
Copy link

@MtTsai You can disable the global mutex backend as was done in the all-clusters app: https://github.com/project-chip/connectedhomeip/blob/master/examples/all-clusters-app/esp32/CMakeLists.txt#L53

pw_set_module_config(pw_rpc_CONFIG pw_rpc.disable_global_mutex_config)

@cpagravel
Copy link
Contributor Author

It looks like this change uncovers an error that was introduced in building esp32 with RPC on master. I'll do some additional digging. The reason this error went undetected before is because esp32 wasn't actually building the RPC build (which is the affected build) in the CI test.

@cpagravel
Copy link
Contributor Author

It looks like this change uncovers an error that was introduced in building esp32 with RPC on master. I'll do some additional digging. The reason this error went undetected before is because esp32 wasn't actually building the RPC build (which is the affected build) in the CI test.

Found the issue for RPC build after esp32 was correctly building the RPC version. Included change in this PR.

@woody-apple woody-apple merged commit 77cf796 into project-chip:master Jun 23, 2022
cpagravel added a commit to cpagravel/connectedhomeip that referenced this pull request Jun 25, 2022
@cpagravel
Chef - Fix broken esp32 RPC build caused by project-chip#18621 (proje…
90cb228 
…ct-chip#19876)

* Chef - Fix broken esp32 RPC build caused by project-chip#18621

* Chef - Fix esp32 RPC build issue caused by pigweed update
cpagravel added a commit to cpagravel/connectedhomeip that referenced this pull request Jun 25, 2022
@cpagravel
Chef - Fix broken esp32 RPC build caused by project-chip#18621 (proje…
97a65e0 
…ct-chip#19876)

* Chef - Fix broken esp32 RPC build caused by project-chip#18621

* Chef - Fix esp32 RPC build issue caused by pigweed update
@cpagravel cpagravel mentioned this pull request Jun 25, 2022
Closed
cpagravel added a commit to cpagravel/connectedhomeip that referenced this pull request Jun 25, 2022
@cpagravel
Chef - Fix broken esp32 RPC build caused by project-chip#18621 (proje…
2811140 
…ct-chip#19876)

* Chef - Fix broken esp32 RPC build caused by project-chip#18621

* Chef - Fix esp32 RPC build issue caused by pigweed update
@cpagravel cpagravel mentioned this pull request Jun 25, 2022
Merged
andy31415 pushed a commit that referenced this pull request Jun 27, 2022
@cpagravel @rochaferraz
@mauimauer @MtTsai @vinitg1 @restyled-commits @mspang @aBozowski @jepenven-silabs
Cherry pick - Chef CD, sample apps, esp32 rpc fix, to interop branch (#…
5092282 
…19979)

* Pigweed: Update to 67bc89cdda8c (#19560)

* Fix esp32 wifi and add RPC support on linux (#19260)

* Chef - Extended Pigweed RPC support (#17781)

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Fix nrfconnect compilation errors (#17713)

* Fix nrfconnect compilation errors

* Chef: fix arguments for clean build

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Restyled by gn

* Restyled by autopep8

* Restyled by gn

Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3

* fix: added initialization to platform wifi network commissioning instance (#17983)

Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964

* Chef - Revert changes on lighting-app that separate wifi and thread

Co-authored-by: Douglas Rocha Ferraz <[email protected]>
Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* Support to return software_version_string with <branch>:<commit_id> on linux platform (#19710)

* Chef - Add 13 sample apps (#19663)

* Chef - Remove redundant hash_string in sample_app_util rename func

* Chef - Add debugg output on exception to stateful_shell

* Chef - Add choices for device arg

* Chef - Add 13 sample apps

* Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (#19710)" (#19786)

This reverts commit 8da6fc8.

* Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (#19788)

Make the filling of software version string with <branch>:<commit_id> as
an option.
The new option for it is '-a' or '--automated_test_stamp'.

* Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (#19478)

* Squashed commit of the following:

commit b5d5920
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 18:17:34 2022 +0000

    [no ci] comment

commit 7c5fb08
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 18:15:37 2022 +0000

    [no ci] Make border nice

commit d67a7bc
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 18:09:29 2022 +0000

    [no ci] restyle

commit 5783829
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 17:48:39 2022 +0000

    Add error handling to build all

commit 083b072
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 17:15:33 2022 +0000

    [no ci] update build image version

commit 48805a8
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 08:20:49 2022 +0000

    [no ci] minor

commit 3cae95c
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 08:15:22 2022 +0000

    [no ci] Minor

commit df929b2
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 07:37:49 2022 +0000

    Minor

commit 759ddb0
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 07:28:36 2022 +0000

    Minor

commit d9ca2a6
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 07:22:03 2022 +0000

    Style

commit dbb9b30
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 06:50:11 2022 +0000

    Style

commit 3daff46
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 02:58:43 2022 +0000

    nrf bundle

commit 7d38eb4
Author: Austin Bozowski <[email protected]>
Date:   Wed Jun 8 16:34:57 2022 +0000

    Linux bundle

commit fd5689e
Author: Austin Bozowski <[email protected]>
Date:   Wed Jun 8 09:08:42 2022 +0000

    Make esp32 generic

commit 1af3a2e
Author: Austin Bozowski <[email protected]>
Date:   Tue Jun 7 08:35:52 2022 +0000

    Missed comment

commit 5f7c41c
Author: Austin Bozowski <[email protected]>
Date:   Tue Jun 7 08:32:07 2022 +0000

    Example bundle function

* Bundle .matter, metadata & ensure .matter commit

* Add partial check for .matter regen

* Restyle and spelling

* Address comments

* Remove reflection

* Generate zzz, .MATTERMD5 should go away in future

* Temp del workflows

* Remove chef exclusion from regen

* Make regen all put chef exs in individual dirs

* Remove validate zzz

* Remove unused code from chef, change use_zzz

* Skip util test files in gen all

* Commit chef in root zzz

* Delete chef zzz

* Clean chef .matter files

* Add post build for chef

* Change .matter bundle rc to oot zzz

* Generated files

* Restore workflows

* Change open to with

* Restyle

* Chef - Fix broken esp32 RPC build caused by #18621 (#19876)

* Chef - Fix broken esp32 RPC build caused by #18621

* Chef - Fix esp32 RPC build issue caused by pigweed update

* Make Scenes name support dependent on FeatureMap attribute (#18667)

* Make Scenes name support dependent on FeatureMap attribute

* Fix CI

* Rebuild Zap generated files

* Fix CI for ipv6only/esp32 example build

* Fix errors regarding ownership of repo. (Taken from #18302)

* Bump chef.yaml platform containers to 0.5.75

Co-authored-by: rgoliver <[email protected]>
Co-authored-by: Douglas Rocha Ferraz <[email protected]>
Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: MtTsai <[email protected]>
Co-authored-by: Michael Spang <[email protected]>
Co-authored-by: Austin Bozowski <[email protected]>
Co-authored-by: Jean-Francois Penven <[email protected]>
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Sep 9, 2022
@cpagravel @rochaferraz
@mauimauer @MtTsai @vinitg1 @restyled-commits @mspang @aBozowski @jepenven-silabs @danielsilabs
Cherry pick - Chef CD, sample apps, esp32 rpc fix, to interop branch (p…
8a4d2a8 
…roject-chip#19979)

* Pigweed: Update to 67bc89cdda8c (project-chip#19560)

* Fix esp32 wifi and add RPC support on linux (project-chip#19260)

* Chef - Extended Pigweed RPC support (project-chip#17781)

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Fix nrfconnect compilation errors (project-chip#17713)

* Fix nrfconnect compilation errors

* Chef: fix arguments for clean build

* Build flash_script package for ESP32

Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520
Reviewed-by: Doug Ferraz <[email protected]>

* new: Wifi and Descriptor clusters on ESP32

Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359
Reviewed-by: Rob Oliver <[email protected]>
Reviewed-by: Kevin Cheung <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* new: added stub file. Included callbacks for successful operation of lock/unlock commands

Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Jerry Lee <[email protected]>

* Enable PW RPC server on chef-built virtual device app

Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b
Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979
Reviewed-by: Doug Ferraz <[email protected]>

* cosmetic change

Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57

* changes to linux pigweed dependencies. Still has issues building Pigweed

Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206

* Restyled by gn

* Restyled by autopep8

* Restyled by gn

Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3

* fix: added initialization to platform wifi network commissioning instance (project-chip#17983)

Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964

* Chef - Revert changes on lighting-app that separate wifi and thread

Co-authored-by: Douglas Rocha Ferraz <[email protected]>
Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710)

* Chef - Add 13 sample apps (project-chip#19663)

* Chef - Remove redundant hash_string in sample_app_util rename func

* Chef - Add debugg output on exception to stateful_shell

* Chef - Add choices for device arg

* Chef - Add 13 sample apps

* Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710)" (project-chip#19786)

This reverts commit 8da6fc8.

* Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (project-chip#19788)

Make the filling of software version string with <branch>:<commit_id> as
an option.
The new option for it is '-a' or '--automated_test_stamp'.

* Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (project-chip#19478)

* Squashed commit of the following:

commit b5d5920
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 18:17:34 2022 +0000

    [no ci] comment

commit 7c5fb08
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 18:15:37 2022 +0000

    [no ci] Make border nice

commit d67a7bc
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 18:09:29 2022 +0000

    [no ci] restyle

commit 5783829
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 17:48:39 2022 +0000

    Add error handling to build all

commit 083b072
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 17:15:33 2022 +0000

    [no ci] update build image version

commit 48805a8
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 08:20:49 2022 +0000

    [no ci] minor

commit 3cae95c
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 08:15:22 2022 +0000

    [no ci] Minor

commit df929b2
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 07:37:49 2022 +0000

    Minor

commit 759ddb0
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 07:28:36 2022 +0000

    Minor

commit d9ca2a6
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 07:22:03 2022 +0000

    Style

commit dbb9b30
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 06:50:11 2022 +0000

    Style

commit 3daff46
Author: Austin Bozowski <[email protected]>
Date:   Fri Jun 10 02:58:43 2022 +0000

    nrf bundle

commit 7d38eb4
Author: Austin Bozowski <[email protected]>
Date:   Wed Jun 8 16:34:57 2022 +0000

    Linux bundle

commit fd5689e
Author: Austin Bozowski <[email protected]>
Date:   Wed Jun 8 09:08:42 2022 +0000

    Make esp32 generic

commit 1af3a2e
Author: Austin Bozowski <[email protected]>
Date:   Tue Jun 7 08:35:52 2022 +0000

    Missed comment

commit 5f7c41c
Author: Austin Bozowski <[email protected]>
Date:   Tue Jun 7 08:32:07 2022 +0000

    Example bundle function

* Bundle .matter, metadata & ensure .matter commit

* Add partial check for .matter regen

* Restyle and spelling

* Address comments

* Remove reflection

* Generate zzz, .MATTERMD5 should go away in future

* Temp del workflows

* Remove chef exclusion from regen

* Make regen all put chef exs in individual dirs

* Remove validate zzz

* Remove unused code from chef, change use_zzz

* Skip util test files in gen all

* Commit chef in root zzz

* Delete chef zzz

* Clean chef .matter files

* Add post build for chef

* Change .matter bundle rc to oot zzz

* Generated files

* Restore workflows

* Change open to with

* Restyle

* Chef - Fix broken esp32 RPC build caused by project-chip#18621 (project-chip#19876)

* Chef - Fix broken esp32 RPC build caused by project-chip#18621

* Chef - Fix esp32 RPC build issue caused by pigweed update

* Make Scenes name support dependent on FeatureMap attribute (project-chip#18667)

* Make Scenes name support dependent on FeatureMap attribute

* Fix CI

* Rebuild Zap generated files

* Fix CI for ipv6only/esp32 example build

* Fix errors regarding ownership of repo. (Taken from project-chip#18302)

* Bump chef.yaml platform containers to 0.5.75

Co-authored-by: rgoliver <[email protected]>
Co-authored-by: Douglas Rocha Ferraz <[email protected]>
Co-authored-by: Sebastian Mauer <[email protected]>
Co-authored-by: MT Tsai <[email protected]>
Co-authored-by: vinitg1 <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: MtTsai <[email protected]>
Co-authored-by: Michael Spang <[email protected]>
Co-authored-by: Austin Bozowski <[email protected]>
Co-authored-by: Jean-Francois Penven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgoliver rgoliver rgoliver approved these changes

@mspang mspang mspang approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cpagravel @woody-apple @MtTsai @rgoliver @mspang @bzbarsky-apple