-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the QR code link to the project-chip gh-pages branch #19873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing and
franck-apple
June 23, 2022 05:30
pullapprove
bot
requested review from
msandstedt,
xylophone21,
robszewczyk,
yufengwangca,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller and
woody-apple
June 23, 2022 05:30
This depends on #19874 |
Thank you! |
dhrishi
changed the title
Move the QR code link to the project-chip gh-pages branch
Draft: Move the QR code link to the project-chip gh-pages branch
Jun 23, 2022
dhrishi
changed the title
Draft: Move the QR code link to the project-chip gh-pages branch
Move the QR code link to the project-chip gh-pages branch
Jun 23, 2022
woody-apple
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking documentation changes
@dhrishi Page is deployed, please mark as ready for review whenever you're ready! |
woody-apple
approved these changes
Jun 23, 2022
PR #19873: Size comparison from 777d72d to 0a62bfd Increases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
Decreases (7 builds for cc13x2_26x2, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
@woody-apple Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #3266
Change overview
Replace all occurrences with of the QR code link with the one in the chip repository
Testing
NA