Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate CASE resumption storage when UpdateNOC is called #19860

Merged
merged 9 commits into from
Jun 24, 2022
Merged

Invalidate CASE resumption storage when UpdateNOC is called #19860

merged 9 commits into from
Jun 24, 2022

Conversation

tehampson
Copy link
Contributor

Problem

Change overview

  • Using FabricTable::Delegate call back we clean up CASE resumption storage for associated fabric index

Testing

  • Using chip-repl manual tested out UpdateNOC to confirm that CASE resumption storage

@boring-cyborg boring-cyborg bot added the app label Jun 22, 2022
msandstedt
msandstedt reviewed Jun 22, 2022
View reviewed changes
src/app/server/Server.h Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #19860: Size comparison from 57169fc to 7c89dc4

Increases (24 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 57169fc 7c89dc4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660431 660455 24 0.0
.text 573144 573168 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649243 649267 24 0.0
.text 558416 558440 24 0.0
lock-ftd LP_CC2652R7 (read only) 691991 692015 24 0.0
.text 592156 592180 24 0.0
lock-mtd LP_CC2652R7 (read only) 641407 641431 24 0.0
.text 541676 541700 24 0.0
pump-app LP_CC2652R7 (read only) 673223 673247 24 0.0
.text 585076 585100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659139 24 0.0
.text 575128 575152 24 0.0
shell LP_CC2652R7 (read only) 690182 690214 32 0.0
.text 580112 580144 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591754 24 0.0
.app_xip_area 462628 462652 24 0.0
lock cyw930739m2evb_01 (read/write) 589106 589138 32 0.0
.app_xip_area 459828 459860 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594274 24 0.0
.app_xip_area 466020 466044 24 0.0
esp32 all-clusters-app c3devkit (read only) 1014132 1014170 38 0.0
.flash.text 1014132 1014170 38 0.0
m5stack (read only) 1068459 1068499 40 0.0
.flash.text 1063075 1063115 40 0.0
k32w light k32w061+release (read/write) 661524 661540 16 0.0
.text 583976 583992 16 0.0
lock k32w061+release (read/write) 723452 723468 16 0.0
.text 645448 645464 16 0.0
linux thermostat-no-ble arm64 (read only) 2578428 2578492 64 0.0
.text 2174816 2174880 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439432 2439496 64 0.0
.text 1402076 1402140 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1201899 16 0.0
text 823980 824004 24 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149655 16 0.0
text 796028 796052 24 0.0
p6 all-clusters-app default (read/write) 2555776 2555840 64 0.0
.text 1514040 1514104 64 0.0
all-clusters-minimal-app default (read/write) 2501624 2501688 64 0.0
.text 1459888 1459952 64 0.0
light-app default (read/write) 2432384 2432448 64 0.0
.text 1390648 1390712 64 0.0
lock-app default (read/write) 2453096 2453160 64 0.0
.text 1411360 1411424 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792072 792112 40 0.0
text 561056 561096 40 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811824 40 0.0
text 577518 577556 38 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 57169fc 7c89dc4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191176 191152 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 149728 149704 -24 -0.0
pump-app LP_CC2652R7 (read/write) 169392 169368 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 183612 183588 -24 -0.0
shell LP_CC2652R7 (read/write) 156928 156896 -32 -0.0
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 57169fc 7c89dc4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660431 660455 24 0.0
(read/write) 191176 191152 -24 -0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573144 573168 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649243 649267 24 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558416 558440 24 0.0
lock-ftd LP_CC2652R7 (read only) 691991 692015 24 0.0
(read/write) 149728 149704 -24 -0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 592156 592180 24 0.0
lock-mtd LP_CC2652R7 (read only) 641407 641431 24 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99239 0 0.0
.text 541676 541700 24 0.0
pump-app LP_CC2652R7 (read only) 673223 673247 24 0.0
(read/write) 169392 169368 -24 -0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585076 585100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659139 24 0.0
(read/write) 183612 183588 -24 -0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575128 575152 24 0.0
shell LP_CC2652R7 (read only) 690182 690214 32 0.0
(read/write) 156928 156896 -32 -0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109758 0 0.0
.text 580112 580144 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591754 24 0.0
.app_xip_area 462628 462652 24 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589138 32 0.0
.app_xip_area 459828 459860 32 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594274 24 0.0
.app_xip_area 466020 466044 24 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014132 1014170 38 0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014132 1014170 38 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068499 40 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063075 1063115 40 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661540 16 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583992 16 0.0
lock k32w061+release (read/write) 723452 723468 16 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645464 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925532 9925532 0 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473932 473932 0 0.0
.text 7910628 7910628 0 0.0
thermostat-no-ble arm64 (read only) 2578428 2578492 64 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174816 2174880 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439496 64 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402140 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1201899 16 0.0
bss 142862 142862 0 0.0
rodata 156108 156108 0 0.0
text 823980 824004 24 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149655 16 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796028 796052 24 0.0
p6 all-clusters-app default (read/write) 2555776 2555840 64 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514104 64 0.0
all-clusters-minimal-app default (read/write) 2501624 2501688 64 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1459952 64 0.0
light-app default (read/write) 2432384 2432448 64 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390712 64 0.0
lock-app default (read/write) 2453096 2453160 64 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411424 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792072 792112 40 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561056 561096 40 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811824 40 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577518 577556 38 0.0

msandstedt
msandstedt reviewed Jun 22, 2022
View reviewed changes
src/app/server/Server.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 22, 2022 •
edited
Loading

PR #19860: Size comparison from 57169fc to 6c59f6c

Increases (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 57169fc 6c59f6c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660431 660575 144 0.0
.bss 74500 74508 8 0.0
.rodata 86975 87023 48 0.1
.text 573144 573240 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649243 649371 128 0.0
(read/write) 158060 158068 8 0.0
.bss 73788 73796 8 0.0
.rodata 90507 90555 48 0.1
.text 558416 558496 80 0.0
lock-ftd LP_CC2652R7 (read only) 691991 692127 136 0.0
.bss 71500 71508 8 0.0
.rodata 99351 99399 48 0.0
.text 592156 592244 88 0.0
lock-mtd LP_CC2652R7 (read only) 641407 641543 136 0.0
(read/write) 144632 144640 8 0.0
.bss 67236 67244 8 0.0
.rodata 99239 99287 48 0.0
.text 541676 541764 88 0.0
pump-app LP_CC2652R7 (read only) 673223 673375 152 0.0
.bss 71628 71636 8 0.0
.rodata 87663 87711 48 0.1
.text 585076 585180 104 0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659267 152 0.0
.bss 71740 71748 8 0.0
.rodata 83507 83555 48 0.1
.text 575128 575232 104 0.0
shell LP_CC2652R7 (read only) 690182 690334 152 0.0
.bss 76804 76812 8 0.0
.rodata 109758 109806 48 0.0
.text 580112 580216 104 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591890 160 0.0
.app_xip_area 462628 462772 144 0.0
.bss 72064 72080 16 0.0
lock cyw930739m2evb_01 (read/write) 589106 589274 168 0.0
.app_xip_area 459828 459980 152 0.0
.bss 72240 72256 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594426 176 0.0
.app_xip_area 466020 466180 160 0.0
.bss 71248 71264 16 0.0
esp32 all-clusters-app c3devkit (read only) 1014132 1014248 116 0.0
(read/write) 1484770 1484834 64 0.0
.dram0.bss 70640 70648 8 0.0
.flash.rodata 214064 214112 48 0.0
.flash.text 1014132 1014248 116 0.0
m5stack (read only) 1068459 1068603 144 0.0
(read/write) 486856 486912 56 0.0
.dram0.bss 76152 76160 8 0.0
.flash.rodata 244564 244612 48 0.0
.flash.text 1063075 1063219 144 0.0
k32w light k32w061+release (read/write) 661524 661676 152 0.0
.bss 69756 69764 8 0.0
.text 583976 584120 144 0.0
lock k32w061+release (read/write) 723452 723604 152 0.0
.bss 70204 70212 8 0.0
.text 645448 645592 144 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925532 9927004 1472 0.0
(read/write) 676161 676257 96 0.0
.data.rel.ro 615080 615176 96 0.0
.rodata 473932 474252 320 0.1
.text 7910628 7911540 912 0.0
thermostat-no-ble arm64 (read only) 2578428 2579196 768 0.0
(read/write) 180609 180721 112 0.1
.bss 87905 87921 16 0.0
.data.rel.ro 82896 82992 96 0.1
.text 2174816 2175344 528 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439432 2439608 176 0.0
.bss 212180 212188 8 0.0
.text 1402076 1402252 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1202467 584 0.0
bss 142862 142870 8 0.0
rodata 156108 156308 200 0.1
text 823980 824360 380 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149815 176 0.0
bss 142098 142106 8 0.0
rodata 132592 132640 48 0.0
text 796028 796152 124 0.0
p6 all-clusters-app default (read/write) 2555776 2555936 160 0.0
.bss 147360 147368 8 0.0
.text 1514040 1514200 160 0.0
all-clusters-minimal-app default (read/write) 2501624 2501800 176 0.0
.bss 146640 146648 8 0.0
.text 1459888 1460064 176 0.0
light-app default (read/write) 2432384 2432544 160 0.0
.bss 138720 138728 8 0.0
.text 1390648 1390808 160 0.0
lock-app default (read/write) 2453096 2453256 160 0.0
.bss 138544 138552 8 0.0
.text 1411360 1411520 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792072 792240 168 0.0
bss 71140 71148 8 0.0
text 561056 561168 112 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811952 168 0.0
bss 71388 71396 8 0.0
text 577518 577626 108 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 57169fc 6c59f6c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191176 191040 -136 -0.1
lock-ftd LP_CC2652R7 (read/write) 149728 149600 -128 -0.1
pump-app LP_CC2652R7 (read/write) 169392 169248 -144 -0.1
pump-controller-app LP_CC2652R7 (read/write) 183612 183468 -144 -0.1
shell LP_CC2652R7 (read/write) 156928 156784 -144 -0.1
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 57169fc 6c59f6c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660431 660575 144 0.0
(read/write) 191176 191040 -136 -0.1
.bss 74500 74508 8 0.0
.data 3356 3356 0 0.0
.rodata 86975 87023 48 0.1
.text 573144 573240 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649243 649371 128 0.0
(read/write) 158060 158068 8 0.0
.bss 73788 73796 8 0.0
.data 3356 3356 0 0.0
.rodata 90507 90555 48 0.1
.text 558416 558496 80 0.0
lock-ftd LP_CC2652R7 (read only) 691991 692127 136 0.0
(read/write) 149728 149600 -128 -0.1
.bss 71500 71508 8 0.0
.data 3280 3280 0 0.0
.rodata 99351 99399 48 0.0
.text 592156 592244 88 0.0
lock-mtd LP_CC2652R7 (read only) 641407 641543 136 0.0
(read/write) 144632 144640 8 0.0
.bss 67236 67244 8 0.0
.data 3280 3280 0 0.0
.rodata 99239 99287 48 0.0
.text 541676 541764 88 0.0
pump-app LP_CC2652R7 (read only) 673223 673375 152 0.0
(read/write) 169392 169248 -144 -0.1
.bss 71628 71636 8 0.0
.data 3280 3280 0 0.0
.rodata 87663 87711 48 0.1
.text 585076 585180 104 0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659267 152 0.0
(read/write) 183612 183468 -144 -0.1
.bss 71740 71748 8 0.0
.data 3276 3276 0 0.0
.rodata 83507 83555 48 0.1
.text 575128 575232 104 0.0
shell LP_CC2652R7 (read only) 690182 690334 152 0.0
(read/write) 156928 156784 -144 -0.1
.bss 76804 76812 8 0.0
.data 3360 3360 0 0.0
.rodata 109758 109806 48 0.0
.text 580112 580216 104 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591890 160 0.0
.app_xip_area 462628 462772 144 0.0
.bss 72064 72080 16 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589274 168 0.0
.app_xip_area 459828 459980 152 0.0
.bss 72240 72256 16 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594426 176 0.0
.app_xip_area 466020 466180 160 0.0
.bss 71248 71264 16 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014132 1014248 116 0.0
(read/write) 1484770 1484834 64 0.0
.dram0.bss 70640 70648 8 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214112 48 0.0
.flash.text 1014132 1014248 116 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068603 144 0.0
(read/write) 486856 486912 56 0.0
.dram0.bss 76152 76160 8 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244612 48 0.0
.flash.text 1063075 1063219 144 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661676 152 0.0
.bss 69756 69764 8 0.0
.data 1992 1992 0 0.0
.text 583976 584120 144 0.0
lock k32w061+release (read/write) 723452 723604 152 0.0
.bss 70204 70212 8 0.0
.data 2000 2000 0 0.0
.text 645448 645592 144 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925532 9927004 1472 0.0
(read/write) 676161 676257 96 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615176 96 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473932 474252 320 0.1
.text 7910628 7911540 912 0.0
thermostat-no-ble arm64 (read only) 2578428 2579196 768 0.0
(read/write) 180609 180721 112 0.1
.bss 87905 87921 16 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82992 96 0.1
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174816 2175344 528 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439608 176 0.0
.bss 212180 212188 8 0.0
.data 5864 5864 0 0.0
.text 1402076 1402252 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1202467 584 0.0
bss 142862 142870 8 0.0
rodata 156108 156308 200 0.1
text 823980 824360 380 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149815 176 0.0
bss 142098 142106 8 0.0
rodata 132592 132640 48 0.0
text 796028 796152 124 0.0
p6 all-clusters-app default (read/write) 2555776 2555936 160 0.0
.bss 147360 147368 8 0.0
.data 2776 2776 0 0.0
.text 1514040 1514200 160 0.0
all-clusters-minimal-app default (read/write) 2501624 2501800 176 0.0
.bss 146640 146648 8 0.0
.data 2776 2776 0 0.0
.text 1459888 1460064 176 0.0
light-app default (read/write) 2432384 2432544 160 0.0
.bss 138720 138728 8 0.0
.data 2592 2592 0 0.0
.text 1390648 1390808 160 0.0
lock-app default (read/write) 2453096 2453256 160 0.0
.bss 138544 138552 8 0.0
.data 2600 2600 0 0.0
.text 1411360 1411520 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792072 792240 168 0.0
bss 71140 71148 8 0.0
noinit 40416 40416 0 0.0
text 561056 561168 112 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811952 168 0.0
bss 71388 71396 8 0.0
noinit 40416 40416 0 0.0
text 577518 577626 108 0.0

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19860: Size comparison from 777d72d to d438f48

Increases (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 777d72d d438f48 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660447 660599 152 0.0
.bss 74500 74508 8 0.0
.rodata 87007 87055 48 0.1
.text 573128 573232 104 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649347 649491 144 0.0
(read/write) 158060 158068 8 0.0
.bss 73788 73796 8 0.0
.rodata 90619 90667 48 0.1
.text 558408 558504 96 0.0
lock-ftd LP_CC2652R7 (read only) 692095 692239 144 0.0
.bss 71500 71508 8 0.0
.rodata 99463 99511 48 0.0
.text 592148 592244 96 0.0
lock-mtd LP_CC2652R7 (read only) 641511 641655 144 0.0
(read/write) 144632 144640 8 0.0
.bss 67236 67244 8 0.0
.rodata 99351 99399 48 0.0
.text 541668 541764 96 0.0
pump-app LP_CC2652R7 (read only) 673327 673479 152 0.0
.bss 71628 71636 8 0.0
.rodata 87775 87823 48 0.1
.text 585068 585172 104 0.0
pump-controller-app LP_CC2652R7 (read only) 659219 659371 152 0.0
.bss 71740 71748 8 0.0
.rodata 83619 83667 48 0.1
.text 575120 575224 104 0.0
shell LP_CC2652R7 (read only) 690286 690438 152 0.0
.bss 76804 76812 8 0.0
.rodata 109862 109910 48 0.0
.text 580112 580216 104 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 591906 168 0.0
.app_xip_area 462636 462788 152 0.0
.bss 72064 72080 16 0.0
lock cyw930739m2evb_01 (read/write) 589122 589290 168 0.0
.app_xip_area 459844 459996 152 0.0
.bss 72240 72256 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594258 594434 176 0.0
.app_xip_area 466028 466188 160 0.0
.bss 71248 71264 16 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014248 114 0.0
(read/write) 1484882 1484946 64 0.0
.dram0.bss 70640 70648 8 0.0
.flash.rodata 214176 214224 48 0.0
.flash.text 1014134 1014248 114 0.0
m5stack (read only) 1068475 1068623 148 0.0
(read/write) 486960 487016 56 0.0
.dram0.bss 76152 76160 8 0.0
.flash.rodata 244668 244716 48 0.0
.flash.text 1063091 1063239 148 0.0
k32w light k32w061+release (read/write) 661556 661708 152 0.0
.bss 69756 69764 8 0.0
.text 584008 584152 144 0.0
lock k32w061+release (read/write) 723540 723708 168 0.0
.bss 70204 70212 8 0.0
.text 645536 645696 160 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9903332 688 0.0
(read/write) 675265 675361 96 0.0
.data.rel.ro 614184 614280 96 0.0
.text 7892292 7892740 448 0.0
thermostat-no-ble arm64 (read only) 2579044 2579828 784 0.0
(read/write) 180673 180785 112 0.1
.bss 87905 87921 16 0.0
.data.rel.ro 82952 83048 96 0.1
.text 2175104 2175648 544 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439536 2439712 176 0.0
.bss 212180 212188 8 0.0
.text 1402180 1402356 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202383 1202559 176 0.0
bss 142862 142870 8 0.0
rodata 156368 156416 48 0.0
text 824228 824356 128 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149731 1149907 176 0.0
bss 142098 142106 8 0.0
rodata 132700 132748 48 0.0
text 796020 796148 128 0.0
p6 all-clusters-app default (read/write) 2555936 2556112 176 0.0
.bss 147360 147368 8 0.0
.text 1514200 1514376 176 0.0
all-clusters-minimal-app default (read/write) 2501800 2501960 160 0.0
.bss 146640 146648 8 0.0
.text 1460064 1460224 160 0.0
light-app default (read/write) 2432536 2432712 176 0.0
.bss 138720 138728 8 0.0
.text 1390800 1390976 176 0.0
lock-app default (read/write) 2453256 2453432 176 0.0
.bss 138544 138552 8 0.0
.text 1411520 1411696 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792204 792364 160 0.0
bss 71140 71148 8 0.0
text 561074 561180 106 0.0
lighting-app tlsr9518adk80d (read/write) 811908 812068 160 0.0
bss 71388 71396 8 0.0
text 577532 577638 106 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 777d72d d438f48 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191160 191016 -144 -0.1
lock-ftd LP_CC2652R7 (read/write) 149624 149488 -136 -0.1
pump-app LP_CC2652R7 (read/write) 169288 169144 -144 -0.1
pump-controller-app LP_CC2652R7 (read/write) 183508 183364 -144 -0.1
shell LP_CC2652R7 (read/write) 156824 156680 -144 -0.1
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 777d72d d438f48 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660447 660599 152 0.0
(read/write) 191160 191016 -144 -0.1
.bss 74500 74508 8 0.0
.data 3356 3356 0 0.0
.rodata 87007 87055 48 0.1
.text 573128 573232 104 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649347 649491 144 0.0
(read/write) 158060 158068 8 0.0
.bss 73788 73796 8 0.0
.data 3356 3356 0 0.0
.rodata 90619 90667 48 0.1
.text 558408 558504 96 0.0
lock-ftd LP_CC2652R7 (read only) 692095 692239 144 0.0
(read/write) 149624 149488 -136 -0.1
.bss 71500 71508 8 0.0
.data 3280 3280 0 0.0
.rodata 99463 99511 48 0.0
.text 592148 592244 96 0.0
lock-mtd LP_CC2652R7 (read only) 641511 641655 144 0.0
(read/write) 144632 144640 8 0.0
.bss 67236 67244 8 0.0
.data 3280 3280 0 0.0
.rodata 99351 99399 48 0.0
.text 541668 541764 96 0.0
pump-app LP_CC2652R7 (read only) 673327 673479 152 0.0
(read/write) 169288 169144 -144 -0.1
.bss 71628 71636 8 0.0
.data 3280 3280 0 0.0
.rodata 87775 87823 48 0.1
.text 585068 585172 104 0.0
pump-controller-app LP_CC2652R7 (read only) 659219 659371 152 0.0
(read/write) 183508 183364 -144 -0.1
.bss 71740 71748 8 0.0
.data 3276 3276 0 0.0
.rodata 83619 83667 48 0.1
.text 575120 575224 104 0.0
shell LP_CC2652R7 (read only) 690286 690438 152 0.0
(read/write) 156824 156680 -144 -0.1
.bss 76804 76812 8 0.0
.data 3360 3360 0 0.0
.rodata 109862 109910 48 0.0
.text 580112 580216 104 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 591906 168 0.0
.app_xip_area 462636 462788 152 0.0
.bss 72064 72080 16 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589122 589290 168 0.0
.app_xip_area 459844 459996 152 0.0
.bss 72240 72256 16 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594258 594434 176 0.0
.app_xip_area 466028 466188 160 0.0
.bss 71248 71264 16 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014248 114 0.0
(read/write) 1484882 1484946 64 0.0
.dram0.bss 70640 70648 8 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214224 48 0.0
.flash.text 1014134 1014248 114 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068623 148 0.0
(read/write) 486960 487016 56 0.0
.dram0.bss 76152 76160 8 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244668 244716 48 0.0
.flash.text 1063091 1063239 148 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661556 661708 152 0.0
.bss 69756 69764 8 0.0
.data 1992 1992 0 0.0
.text 584008 584152 144 0.0
lock k32w061+release (read/write) 723540 723708 168 0.0
.bss 70204 70212 8 0.0
.data 2000 2000 0 0.0
.text 645536 645696 160 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9903332 688 0.0
(read/write) 675265 675361 96 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614280 96 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892740 448 0.0
thermostat-no-ble arm64 (read only) 2579044 2579828 784 0.0
(read/write) 180673 180785 112 0.1
.bss 87905 87921 16 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 83048 96 0.1
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175648 544 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439712 176 0.0
.bss 212180 212188 8 0.0
.data 5864 5864 0 0.0
.text 1402180 1402356 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202383 1202559 176 0.0
bss 142862 142870 8 0.0
rodata 156368 156416 48 0.0
text 824228 824356 128 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149731 1149907 176 0.0
bss 142098 142106 8 0.0
rodata 132700 132748 48 0.0
text 796020 796148 128 0.0
p6 all-clusters-app default (read/write) 2555936 2556112 176 0.0
.bss 147360 147368 8 0.0
.data 2776 2776 0 0.0
.text 1514200 1514376 176 0.0
all-clusters-minimal-app default (read/write) 2501800 2501960 160 0.0
.bss 146640 146648 8 0.0
.data 2776 2776 0 0.0
.text 1460064 1460224 160 0.0
light-app default (read/write) 2432536 2432712 176 0.0
.bss 138720 138728 8 0.0
.data 2592 2592 0 0.0
.text 1390800 1390976 176 0.0
lock-app default (read/write) 2453256 2453432 176 0.0
.bss 138544 138552 8 0.0
.data 2600 2600 0 0.0
.text 1411520 1411696 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792204 792364 160 0.0
bss 71140 71148 8 0.0
noinit 40416 40416 0 0.0
text 561074 561180 106 0.0
lighting-app tlsr9518adk80d (read/write) 811908 812068 160 0.0
bss 71388 71396 8 0.0
noinit 40416 40416 0 0.0
text 577532 577638 106 0.0

@restyled-io restyled-io bot mentioned this pull request Jun 23, 2022
Closed
@tehampson tehampson merged commit 2502b78 into project-chip:master Jun 24, 2022
@tehampson tehampson deleted the invalidate-all-case-resumption-state-17221 branch June 28, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the NOC for a fabric changes, we need to invalidate all CASE resumption state for the fabric.
6 participants
@tehampson @tcarmelveilleux @msandstedt @mrjerryjohns @woody-apple @bzbarsky-apple