-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up minor changes to OpCertStore #19828
Merged
woody-apple
merged 3 commits into
project-chip:master
from
tcarmelveilleux:opcert-followup
Jun 22, 2022
Merged
Follow-up minor changes to OpCertStore #19828
woody-apple
merged 3 commits into
project-chip:master
from
tcarmelveilleux:opcert-followup
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After PR project-chip#19643 was merge, @bzbarsky-apple had several minor editorial comments. - This PR applies the comments from project-chip#19643 (review) Testing: - Unit tests still pass - No integration yet, so unit tests passing is enough
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
June 21, 2022 20:57
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 21, 2022 20:57
woody-apple
approved these changes
Jun 21, 2022
tehampson
approved these changes
Jun 21, 2022
PR #19828: Size comparison from a1f5426 to 6015ce5 Increases (1 build for cc13x2_26x2)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
commented
Jun 22, 2022
PR #19828: Size comparison from a1f5426 to 1e2b0e7 Increases above 0.2%:
Increases (36 builds for cc13x2_26x2, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (28 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect, p6)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
force-pushed
the
opcert-followup
branch
from
June 22, 2022 02:54
4c6aca0
to
6015ce5
Compare
PR #19828: Size comparison from 45e042f to 6015ce5 Increases (4 builds for cc13x2_26x2, nrfconnect)
Decreases (2 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 22, 2022
PR #19828: Size comparison from 45e042f to 0926b2e Increases (5 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (5 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
editorial comments.
Change overview
Introduce fail-safe compliant Operational Cert storage #19643 (review)
Testing