-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Initialize OTA only when Thread or WiFi connectivity is established #19823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new manual scripts * Added Auto generated File
* [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <[email protected]>
pullapprove
bot
requested review from
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 21, 2022 19:15
jmartinez-silabs
approved these changes
Jun 21, 2022
woody-apple
approved these changes
Jun 21, 2022
PR #19823: Size comparison from 19a6269 to 334452f Increases (8 builds for cc13x2_26x2, efr32, esp32, nrfconnect)
Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NotifyUpdateApplied is not sent out after a successful OTA transfer
Change overview
Initialize OTA only when Thread or WiFi connectivity is established. This way by the time DefaultOTARequestor attempts to send out NotifyUpdateApplied the local node has already joined the fabric.
Unrelated to the above, remove the EFR32 version of the ota-requestor-app as it is no longer in use.
Testing
Verified NotifyUpdateApplied after a successful OTA transfer on BRD4186A and BRD4161A