-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove event-loop variant to Darwin/Linux tests #19809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
June 21, 2022 14:06
pullapprove
bot
requested review from
lazarkov,
LuDuda,
msandstedt,
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
June 21, 2022 14:06
mrjerryjohns
force-pushed
the
darwin-tests
branch
from
June 21, 2022 14:06
c0b7180
to
d8e4e97
Compare
tcarmelveilleux
approved these changes
Jun 21, 2022
Damian-Nordic
approved these changes
Jun 21, 2022
andy31415
approved these changes
Jun 21, 2022
PR #19809: Size comparison from c6724a0 to d8e4e97 Increases (2 builds for nrfconnect, telink)
Decreases (1 build for efr32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 21, 2022
woody-apple
approved these changes
Jun 21, 2022
bzbarsky-apple
approved these changes
Jun 22, 2022
Bypassing known cirque issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Darwin and Linux tests both run tests on two variants of chip-tool - one that has everything running on the same event-loop and one that has it running on separate event/threading contexts.
Doing both is overkill, and for the purposes of TSAN, just having the one with separate threading contexts is sufficient.
Solution
Remove the
-same-event-loop
matrix variant.