Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing a comment left from previous pr #19390 #19734

Merged
merged 4 commits into from
Jun 18, 2022
Merged

Addressing a comment left from previous pr #19390 #19734

merged 4 commits into from
Jun 18, 2022

Conversation

rochaferraz
Copy link
Contributor

Change overview

Follow up to comment on PR #19392 / PR #19390
@bzbarsky-apple

@boring-cyborg boring-cyborg bot added the app label Jun 17, 2022
@github-actions
Copy link

PR #19734: Size comparison from 147cab2 to da771b1

Full report (1 build for mbed)
platform target config section 147cab2 da771b1 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2437720 2437720 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400364 1400364 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jun 17, 2022
View reviewed changes
src/app/clusters/level-control/level-control.cpp Outdated Show resolved Hide resolved
src/app/clusters/level-control/level-control.cpp Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Jun 17, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 17, 2022 •
edited
Loading

PR #19734: Size comparison from 147cab2 to 91788f9

Increases (3 builds for cc13x2_26x2, telink)
platform target config section 147cab2 91788f9 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 150508 150516 8 0.0
shell LP_CC2652R7 (read only) 688938 688946 8 0.0
.text 578968 578976 8 0.0
telink light-switch-app tlsr9518adk80d text 559626 559630 4 0.0
Decreases (8 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
platform target config section 147cab2 91788f9 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 647999 647991 -8 -0.0
.text 557272 557264 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 690467 690459 -8 -0.0
.text 590820 590812 -8 -0.0
shell LP_CC2652R7 (read/write) 157420 157412 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616070 616062 -8 -0.0
.app_xip_area 473624 473616 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1012646 1012644 -2 -0.0
.flash.text 1012646 1012644 -2 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198699 1198683 -16 -0.0
text 822504 822500 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 794724 794720 -4 -0.0
telink lighting-app tlsr9518adk80d text 576080 576078 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 147cab2 91788f9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659531 659531 0 0.0
(read/write) 191332 191332 0 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87083 87083 0 0.0
.text 572136 572136 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 647999 647991 -8 -0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90407 0 0.0
.text 557272 557264 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 690467 690459 -8 -0.0
(read/write) 150508 150516 8 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 99163 0 0.0
.text 590820 590812 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 639875 639875 0 0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 99043 0 0.0
.text 540340 540340 0 0.0
pump-app LP_CC2652R7 (read only) 671419 671419 0 0.0
(read/write) 170444 170444 0 0.0
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 87259 0 0.0
.text 583676 583676 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662415 662415 0 0.0
(read/write) 179576 179576 0 0.0
.bss 71004 71004 0 0.0
.data 3276 3276 0 0.0
.rodata 85183 85183 0 0.0
.text 576748 576748 0 0.0
shell LP_CC2652R7 (read only) 688938 688946 8 0.0
(read/write) 157420 157412 -8 -0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109658 0 0.0
.text 578968 578976 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612738 612738 0 0.0
.app_xip_area 469404 469404 0 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610062 610062 0 0.0
.app_xip_area 466552 466552 0 0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616070 616062 -8 -0.0
.app_xip_area 473624 473616 -8 -0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 924024 924024 0 0.0
(read/write) 132416 132416 0 0.0
.bss 130336 130336 0 0.0
.data 2080 2080 0 0.0
.text 924016 924016 0 0.0
BRD4161A+rpc (read only) 959728 959728 0 0.0
(read/write) 149296 149296 0 0.0
.bss 147008 147008 0 0.0
.data 2284 2284 0 0.0
.text 959720 959720 0 0.0
BRD4161A+rs911x (read only) 799108 799108 0 0.0
(read/write) 128692 128692 0 0.0
.bss 126604 126604 0 0.0
.data 2088 2088 0 0.0
.text 799100 799100 0 0.0
lock-app BRD4161A+wf200 (read only) 965540 965540 0 0.0
(read/write) 129068 129068 0 0.0
.bss 126980 126980 0 0.0
.data 2088 2088 0 0.0
.text 965532 965532 0 0.0
window-app BRD4161A (read only) 909136 909136 0 0.0
(read/write) 132520 132520 0 0.0
.bss 130408 130408 0 0.0
.data 2108 2108 0 0.0
.text 909128 909128 0 0.0
esp32 all-clusters-app c3devkit (read only) 1012646 1012644 -2 -0.0
(read/write) 1482898 1482898 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213440 213440 0 0.0
.flash.text 1012646 1012644 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1067167 1067167 0 0.0
(read/write) 485016 485016 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243964 243964 0 0.0
.flash.text 1061783 1061783 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658876 658876 0 0.0
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582328 582328 0 0.0
lock k32w061+release (read/write) 720864 720864 0 0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643868 643868 0 0.0
linux all-clusters-app debug (read only) 2929673 2929673 0 0.0
(read/write) 188656 188656 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259421 259421 0 0.0
.text 2493810 2493810 0 0.0
all-clusters-minimal-app debug (read only) 2783385 2783385 0 0.0
(read/write) 180560 180560 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260957 260957 0 0.0
.text 2348162 2348162 0 0.0
bridge-app debug+rpc (read only) 2286033 2286033 0 0.0
(read/write) 159424 159424 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194304 194304 0 0.0
.text 1930642 1930642 0 0.0
chip-tool debug (read only) 10140301 10140301 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508757 508757 0 0.0
.text 8225813 8225813 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9881868 9881868 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472300 472300 0 0.0
.text 7873140 7873140 0 0.0
lighting-app debug+rpc (read only) 2518753 2518753 0 0.0
(read/write) 163448 163448 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210056 210056 0 0.0
.text 2138994 2138994 0 0.0
lock-app debug (read only) 2457497 2457497 0 0.0
(read/write) 158096 158096 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 223752 223752 0 0.0
.text 2069442 2069442 0 0.0
ota-provider-app debug (read only) 2295377 2295377 0 0.0
(read/write) 152232 152232 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 199928 199928 0 0.0
.text 1933298 1933298 0 0.0
ota-requestor-app debug (read only) 2411105 2411105 0 0.0
(read/write) 158976 158976 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 203616 203616 0 0.0
.text 2037106 2037106 0 0.0
shell debug (read only) 2603217 2603217 0 0.0
(read/write) 219288 219288 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229746 229746 0 0.0
.text 2213714 2213714 0 0.0
thermostat-no-ble arm64 (read only) 2570748 2570748 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163324 163324 0 0.0
.text 2168304 2168304 0 0.0
tv-app debug (read only) 3067249 3067249 0 0.0
(read/write) 289352 289352 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 245664 245664 0 0.0
.text 2634722 2634722 0 0.0
tv-casting-app debug (read only) 5532881 5532881 0 0.0
(read/write) 195664 195664 0 0.0
.bss 84424 84424 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339593 339593 0 0.0
.text 4917058 4917058 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2437720 2437720 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400364 1400364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198699 1198683 -16 -0.0
bss 141598 141598 0 0.0
rodata 155676 155676 0 0.0
text 822504 822500 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146655 1146655 0 0.0
bss 140850 140850 0 0.0
rodata 132200 132200 0 0.0
text 794724 794720 -4 -0.0
p6 all-clusters-app default (read/write) 2553584 2553584 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1511848 1511848 0 0.0
all-clusters-minimal-app default (read/write) 2499448 2499448 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1457712 1457712 0 0.0
light-app default (read/write) 2430176 2430176 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388440 1388440 0 0.0
lock-app default (read/write) 2450832 2450832 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409096 1409096 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789040 789040 0 0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559626 559630 4 0.0
lighting-app tlsr9518adk80d (read/write) 808736 808736 0 0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576080 576078 -2 -0.0

@andy31415 andy31415 merged commit b2c0907 into project-chip:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@andy31415 andy31415 Awaiting requested review from andy31415

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rochaferraz @andy31415 @bzbarsky-apple @restyled-commits