-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC: Add linux light rpc to build script #19719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13 and
harimau-qirex
June 17, 2022 14:17
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 17, 2022 14:17
rgoliver
force-pushed
the
linux-arm64-rpc
branch
from
June 17, 2022 14:21
7a706fe
to
7f4511a
Compare
PR #19719: Size comparison from 5ea0ca6 to 7f4511a Increases (3 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Jun 17, 2022
Add a target for building the linux lighting app with RPCs enabled.
rgoliver
force-pushed
the
linux-arm64-rpc
branch
from
June 17, 2022 17:26
7f4511a
to
668c46d
Compare
PR #19719: Size comparison from 5ded490 to 668c46d Increases (2 builds for cc13x2_26x2, esp32)
Decreases (2 builds for cc13x2_26x2, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 17, 2022
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 4, 2022
Add a target for building the linux lighting app with RPCs enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need RPi linux RPC enabled builds for testing.
Change overview
Add a target to build the linux lighting app with RPCs enabled.
Testing
Built both arm64 and x64 linux lighting apps, and verified RPC worked:
./scripts/build/build_examples.py --target-glob 'linux*rpc' build