Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing tv-casting-app cluster definitions up to spec #19656

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Bringing tv-casting-app cluster definitions up to spec #19656

merged 2 commits into from
Jun 16, 2022

Conversation

sharadb-amazon
Copy link
Contributor

Problem

Fixing lint errors called out in #19172

Change overview

Updates to the .zap file and the subsequently generated files

Testing

Checked that the following command no longer produced any errors:

% ./scripts/idl_lint.py --log-level warn ./examples/tv-casting-app/tv-casting-common/tv-casting-app.matter

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

PR #19656: Size comparison from 1e3f120 to a7a81b3

Increases above 0.2%:

platform target config section 1e3f120 a7a81b3 change % change
linux tv-casting-app debug (read only) 5543801 5559113 15312 0.3
(read/write) 199832 202552 2720 1.4
.bss 88072 89288 1216 1.4
.data.rel.ro 103048 104552 1504 1.5
.text 4926562 4940738 14176 0.3
Increases (5 builds for cc13x2_26x2, esp32, linux)
platform target config section 1e3f120 a7a81b3 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 638559 638567 8 0.0
.text 539116 539124 8 0.0
pump-app LP_CC2652R7 (read only) 670127 670135 8 0.0
.text 582476 582484 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 180852 180860 8 0.0
esp32 all-clusters-app c3devkit (read only) 1011250 1011252 2 0.0
.flash.text 1011250 1011252 2 0.0
linux tv-casting-app debug (read only) 5543801 5559113 15312 0.3
(read/write) 199832 202552 2720 1.4
.bss 88072 89288 1216 1.4
.data.rel.ro 103048 104552 1504 1.5
.rodata 341129 341545 416 0.1
.text 4926562 4940738 14176 0.3
Decreases (6 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section 1e3f120 a7a81b3 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 171712 171704 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 661115 661107 -8 -0.0
.text 575540 575532 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 608750 608742 -8 -0.0
.app_xip_area 465264 465256 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 821356 821352 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 787564 787556 -8 -0.0
text 558266 558264 -2 -0.0
lighting-app tlsr9518adk80d text 574728 574726 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1e3f120 a7a81b3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658255 658255 0 0.0
(read/write) 192584 192584 0 0.0
.bss 73732 73732 0 0.0
.data 3356 3356 0 0.0
.rodata 86983 86983 0 0.0
.text 570960 570960 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646731 646731 0 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90315 90315 0 0.0
.text 556096 556096 0 0.0
lock-ftd LP_CC2652R7 (read only) 689151 689151 0 0.0
(read/write) 151800 151800 0 0.0
.bss 70732 70732 0 0.0
.data 3280 3280 0 0.0
.rodata 99071 99071 0 0.0
.text 589596 589596 0 0.0
lock-mtd LP_CC2652R7 (read only) 638559 638567 8 0.0
(read/write) 143864 143864 0 0.0
.bss 66468 66468 0 0.0
.data 3280 3280 0 0.0
.rodata 98951 98951 0 0.0
.text 539116 539124 8 0.0
pump-app LP_CC2652R7 (read only) 670127 670135 8 0.0
(read/write) 171712 171704 -8 -0.0
.bss 70852 70852 0 0.0
.data 3280 3280 0 0.0
.rodata 87167 87167 0 0.0
.text 582476 582484 8 0.0
pump-controller-app LP_CC2652R7 (read only) 661115 661107 -8 -0.0
(read/write) 180852 180860 8 0.0
.bss 70980 70980 0 0.0
.data 3276 3276 0 0.0
.rodata 85091 85091 0 0.0
.text 575540 575532 -8 -0.0
shell LP_CC2652R7 (read only) 687654 687654 0 0.0
(read/write) 158680 158680 0 0.0
.bss 76028 76028 0 0.0
.data 3360 3360 0 0.0
.rodata 109566 109566 0 0.0
.text 577776 577776 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611434 611434 0 0.0
.app_xip_area 468124 468124 0 0.0
.bss 86264 86264 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608750 608742 -8 -0.0
.app_xip_area 465264 465256 -8 -0.0
.bss 86440 86440 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614770 614770 0 0.0
.app_xip_area 472348 472348 0 0.0
.bss 85432 85432 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921948 921948 0 0.0
(read/write) 132392 132392 0 0.0
.bss 130312 130312 0 0.0
.data 2080 2080 0 0.0
.text 921940 921940 0 0.0
BRD4161A+rpc (read only) 957652 957652 0 0.0
(read/write) 149268 149268 0 0.0
.bss 146984 146984 0 0.0
.data 2284 2284 0 0.0
.text 957644 957644 0 0.0
BRD4161A+rs911x (read only) 796984 796984 0 0.0
(read/write) 128668 128668 0 0.0
.bss 126580 126580 0 0.0
.data 2088 2088 0 0.0
.text 796976 796976 0 0.0
lock-app BRD4161A+wf200 (read only) 964264 964264 0 0.0
(read/write) 129044 129044 0 0.0
.bss 126956 126956 0 0.0
.data 2088 2088 0 0.0
.text 964256 964256 0 0.0
window-app BRD4161A (read only) 907044 907044 0 0.0
(read/write) 132492 132492 0 0.0
.bss 130384 130384 0 0.0
.data 2108 2108 0 0.0
.text 907036 907036 0 0.0
esp32 all-clusters-app c3devkit (read only) 1011250 1011252 2 0.0
(read/write) 1482786 1482786 0 0.0
.dram0.bss 69368 69368 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213344 213344 0 0.0
.flash.text 1011250 1011252 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065595 1065595 0 0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74888 74888 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243868 243868 0 0.0
.flash.text 1060211 1060211 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657616 657616 0 0.0
.bss 68732 68732 0 0.0
.data 1992 1992 0 0.0
.text 581092 581092 0 0.0
lock k32w061+release (read/write) 719564 719564 0 0.0
.bss 69172 69172 0 0.0
.data 2000 2000 0 0.0
.text 642592 642592 0 0.0
linux all-clusters-app debug (read only) 2923265 2923265 0 0.0
(read/write) 188528 188528 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84536 84536 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259357 259357 0 0.0
.text 2487826 2487826 0 0.0
all-clusters-minimal-app debug (read only) 2776977 2776977 0 0.0
(read/write) 180432 180432 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77176 77176 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260893 260893 0 0.0
.text 2342178 2342178 0 0.0
bridge-app debug+rpc (read only) 2279705 2279705 0 0.0
(read/write) 159296 159296 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66600 66600 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194240 194240 0 0.0
.text 1924690 1924690 0 0.0
chip-tool debug (read only) 10082645 10082645 0 0.0
(read/write) 610376 610376 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578656 578656 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 503829 503829 0 0.0
.text 8171141 8171141 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9827772 9827772 0 0.0
(read/write) 675041 675041 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614024 614024 0 0.0
.dynamic 528 528 0 0.0
.got 13424 13424 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467708 467708 0 0.0
.text 7821684 7821684 0 0.0
lighting-app debug+rpc (read only) 2512441 2512441 0 0.0
(read/write) 163320 163320 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71752 71752 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 209992 209992 0 0.0
.text 2133058 2133058 0 0.0
lock-app debug (read only) 2451113 2451113 0 0.0
(read/write) 157968 157968 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68440 68440 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 223688 223688 0 0.0
.text 2063458 2063458 0 0.0
ota-provider-app debug (read only) 2289049 2289049 0 0.0
(read/write) 152136 152136 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62728 62728 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 199864 199864 0 0.0
.text 1927346 1927346 0 0.0
ota-requestor-app debug (read only) 2404777 2404777 0 0.0
(read/write) 158848 158848 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66808 66808 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 203552 203552 0 0.0
.text 2031154 2031154 0 0.0
shell debug (read only) 2596777 2596777 0 0.0
(read/write) 219192 219192 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229650 229650 0 0.0
.text 2207730 2207730 0 0.0
thermostat-no-ble arm64 (read only) 2564460 2564460 0 0.0
(read/write) 192033 192033 0 0.0
.bss 99473 99473 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82776 82776 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163244 163244 0 0.0
.text 2162448 2162448 0 0.0
tv-app debug (read only) 3060985 3060985 0 0.0
(read/write) 289224 289224 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78880 78880 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 245600 245600 0 0.0
.text 2628882 2628882 0 0.0
tv-casting-app debug (read only) 5543801 5559113 15312 0.3
(read/write) 199832 202552 2720 1.4
.bss 88072 89288 1216 1.4
.data 2480 2480 0 0.0
.data.rel.ro 103048 104552 1504 1.5
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 341129 341545 416 0.1
.text 4926562 4940738 14176 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2436264 2436264 0 0.0
.bss 208180 208180 0 0.0
.data 5864 5864 0 0.0
.text 1398908 1398908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197451 1197451 0 0.0
bss 141574 141574 0 0.0
rodata 155580 155580 0 0.0
text 821356 821352 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1145423 1145423 0 0.0
bss 140826 140826 0 0.0
rodata 132104 132104 0 0.0
text 793576 793576 0 0.0
p6 all-clusters-app default (read/write) 2551576 2551576 0 0.0
.bss 143360 143360 0 0.0
.data 2776 2776 0 0.0
.text 1509840 1509840 0 0.0
all-clusters-minimal-app default (read/write) 2497424 2497424 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1455688 1455688 0 0.0
light-app default (read/write) 2428160 2428160 0 0.0
.bss 134720 134720 0 0.0
.data 2592 2592 0 0.0
.text 1386424 1386424 0 0.0
lock-app default (read/write) 2448800 2448800 0 0.0
.bss 134544 134544 0 0.0
.data 2600 2600 0 0.0
.text 1407064 1407064 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787564 787556 -8 -0.0
bss 69868 69868 0 0.0
noinit 40416 40416 0 0.0
text 558266 558264 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 807268 807268 0 0.0
bss 70116 70116 0 0.0
noinit 40416 40416 0 0.0
text 574728 574726 -2 -0.0

andy31415
andy31415 requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TV casting app should not include the test cluster.

@sharadb-amazon
Copy link
Contributor Author

TV casting app should not include the test cluster.

Removed it.

@sharadb-amazon sharadb-amazon requested a review from andy31415 June 16, 2022 14:15
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

PR #19656: Size comparison from 1e3f120 to 0cb093a

Increases above 0.2%:

platform target config section 1e3f120 0cb093a3 change % change
efr32 lighting-app BRD4161A+rs911x (read only) 796984 798680 1696 0.2
.text 796976 798672 1696 0.2
Increases (24 builds for cc13x2_26x2, cyw30739, efr32, mbed, nrfconnect, p6, telink)
platform target config section 1e3f120 0cb093a3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658255 659159 904 0.1
.text 570960 571864 904 0.2
all-clusters-minimal-app LP_CC2652R7 (read only) 646731 647635 904 0.1
.text 556096 557000 904 0.2
lock-ftd LP_CC2652R7 (read only) 689151 690055 904 0.1
.text 589596 590500 904 0.2
lock-mtd LP_CC2652R7 (read only) 638559 639463 904 0.1
.text 539116 540020 904 0.2
pump-app LP_CC2652R7 (read only) 670127 671023 896 0.1
.text 582476 583372 896 0.2
pump-controller-app LP_CC2652R7 (read only) 661115 662011 896 0.1
.text 575540 576436 896 0.2
shell LP_CC2652R7 (read only) 687654 688558 904 0.1
.text 577776 578680 904 0.2
cyw30739 light cyw930739m2evb_01 (read/write) 611434 612346 912 0.1
.app_xip_area 468124 469036 912 0.2
lock cyw930739m2evb_01 (read/write) 608750 609654 904 0.1
.app_xip_area 465264 466168 904 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614770 615666 896 0.1
.app_xip_area 472348 473244 896 0.2
efr32 lighting-app BRD4161A (read only) 921948 923628 1680 0.2
.text 921940 923620 1680 0.2
BRD4161A+rpc (read only) 957652 959348 1696 0.2
.text 957644 959340 1696 0.2
BRD4161A+rs911x (read only) 796984 798680 1696 0.2
.text 796976 798672 1696 0.2
lock-app BRD4161A+wf200 (read only) 964264 965144 880 0.1
.text 964256 965136 880 0.1
window-app BRD4161A (read only) 907044 908724 1680 0.2
.text 907036 908716 1680 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2436264 2437160 896 0.0
.text 1398908 1399804 896 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197451 1198347 896 0.1
text 821356 822248 892 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1145423 1146303 880 0.1
text 793576 794464 888 0.1
p6 all-clusters-app default (read/write) 2551576 2553272 1696 0.1
.text 1509840 1511536 1696 0.1
all-clusters-minimal-app default (read/write) 2497424 2499120 1696 0.1
.text 1455688 1457384 1696 0.1
light-app default (read/write) 2428160 2429856 1696 0.1
.text 1386424 1388120 1696 0.1
lock-app default (read/write) 2448800 2450480 1680 0.1
.text 1407064 1408744 1680 0.1
telink light-switch-app tlsr9518adk80d (read/write) 787564 788540 976 0.1
text 558266 559244 978 0.2
lighting-app tlsr9518adk80d (read/write) 807268 808252 984 0.1
text 574728 575710 982 0.2
Decreases (5 builds for cc13x2_26x2)
platform target config section 1e3f120 0cb093a3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 192584 191680 -904 -0.5
lock-ftd LP_CC2652R7 (read/write) 151800 150896 -904 -0.6
pump-app LP_CC2652R7 (read/write) 171712 170816 -896 -0.5
pump-controller-app LP_CC2652R7 (read/write) 180852 179956 -896 -0.5
shell LP_CC2652R7 (read/write) 158680 157776 -904 -0.6
Full report (24 builds for cc13x2_26x2, cyw30739, efr32, mbed, nrfconnect, p6, telink)
platform target config section 1e3f120 0cb093a3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658255 659159 904 0.1
(read/write) 192584 191680 -904 -0.5
.bss 73732 73732 0 0.0
.data 3356 3356 0 0.0
.rodata 86983 86983 0 0.0
.text 570960 571864 904 0.2
all-clusters-minimal-app LP_CC2652R7 (read only) 646731 647635 904 0.1
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90315 90315 0 0.0
.text 556096 557000 904 0.2
lock-ftd LP_CC2652R7 (read only) 689151 690055 904 0.1
(read/write) 151800 150896 -904 -0.6
.bss 70732 70732 0 0.0
.data 3280 3280 0 0.0
.rodata 99071 99071 0 0.0
.text 589596 590500 904 0.2
lock-mtd LP_CC2652R7 (read only) 638559 639463 904 0.1
(read/write) 143864 143864 0 0.0
.bss 66468 66468 0 0.0
.data 3280 3280 0 0.0
.rodata 98951 98951 0 0.0
.text 539116 540020 904 0.2
pump-app LP_CC2652R7 (read only) 670127 671023 896 0.1
(read/write) 171712 170816 -896 -0.5
.bss 70852 70852 0 0.0
.data 3280 3280 0 0.0
.rodata 87167 87167 0 0.0
.text 582476 583372 896 0.2
pump-controller-app LP_CC2652R7 (read only) 661115 662011 896 0.1
(read/write) 180852 179956 -896 -0.5
.bss 70980 70980 0 0.0
.data 3276 3276 0 0.0
.rodata 85091 85091 0 0.0
.text 575540 576436 896 0.2
shell LP_CC2652R7 (read only) 687654 688558 904 0.1
(read/write) 158680 157776 -904 -0.6
.bss 76028 76028 0 0.0
.data 3360 3360 0 0.0
.rodata 109566 109566 0 0.0
.text 577776 578680 904 0.2
cyw30739 light cyw930739m2evb_01 (read/write) 611434 612346 912 0.1
.app_xip_area 468124 469036 912 0.2
.bss 86264 86264 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608750 609654 904 0.1
.app_xip_area 465264 466168 904 0.2
.bss 86440 86440 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614770 615666 896 0.1
.app_xip_area 472348 473244 896 0.2
.bss 85432 85432 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921948 923628 1680 0.2
(read/write) 132392 132392 0 0.0
.bss 130312 130312 0 0.0
.data 2080 2080 0 0.0
.text 921940 923620 1680 0.2
BRD4161A+rpc (read only) 957652 959348 1696 0.2
(read/write) 149268 149268 0 0.0
.bss 146984 146984 0 0.0
.data 2284 2284 0 0.0
.text 957644 959340 1696 0.2
BRD4161A+rs911x (read only) 796984 798680 1696 0.2
(read/write) 128668 128668 0 0.0
.bss 126580 126580 0 0.0
.data 2088 2088 0 0.0
.text 796976 798672 1696 0.2
lock-app BRD4161A+wf200 (read only) 964264 965144 880 0.1
(read/write) 129044 129044 0 0.0
.bss 126956 126956 0 0.0
.data 2088 2088 0 0.0
.text 964256 965136 880 0.1
window-app BRD4161A (read only) 907044 908724 1680 0.2
(read/write) 132492 132492 0 0.0
.bss 130384 130384 0 0.0
.data 2108 2108 0 0.0
.text 907036 908716 1680 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2436264 2437160 896 0.0
.bss 208180 208180 0 0.0
.data 5864 5864 0 0.0
.text 1398908 1399804 896 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197451 1198347 896 0.1
bss 141574 141574 0 0.0
rodata 155580 155580 0 0.0
text 821356 822248 892 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1145423 1146303 880 0.1
bss 140826 140826 0 0.0
rodata 132104 132104 0 0.0
text 793576 794464 888 0.1
p6 all-clusters-app default (read/write) 2551576 2553272 1696 0.1
.bss 143360 143360 0 0.0
.data 2776 2776 0 0.0
.text 1509840 1511536 1696 0.1
all-clusters-minimal-app default (read/write) 2497424 2499120 1696 0.1
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1455688 1457384 1696 0.1
light-app default (read/write) 2428160 2429856 1696 0.1
.bss 134720 134720 0 0.0
.data 2592 2592 0 0.0
.text 1386424 1388120 1696 0.1
lock-app default (read/write) 2448800 2450480 1680 0.1
.bss 134544 134544 0 0.0
.data 2600 2600 0 0.0
.text 1407064 1408744 1680 0.1
telink light-switch-app tlsr9518adk80d (read/write) 787564 788540 976 0.1
bss 69868 69868 0 0.0
noinit 40416 40416 0 0.0
text 558266 559244 978 0.2
lighting-app tlsr9518adk80d (read/write) 807268 808252 984 0.1
bss 70116 70116 0 0.0
noinit 40416 40416 0 0.0
text 574728 575710 982 0.2

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

PR #19656: Size comparison from 0a90632 to a575b16

Increases (4 builds for cc13x2_26x2, cyw30739, efr32, telink)
platform target config section 0a90632 a575b16 change % change
cc13x2_26x2 shell LP_CC2652R7 (read/write) 157412 157420 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616046 616054 8 0.0
.app_xip_area 473600 473608 8 0.0
efr32 lock-app BRD4161A+wf200 (read only) 965508 965524 16 0.0
.text 965500 965516 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789008 789016 8 0.0
text 559600 559604 4 0.0
Decreases (2 builds for cc13x2_26x2, linux)
platform target config section 0a90632 a575b16 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 688946 688938 -8 -0.0
.text 578976 578968 -8 -0.0
linux tv-casting-app debug (read only) 5549993 5532785 -17208 -0.3
(read/write) 199960 195664 -4296 -2.1
.bss 88072 84424 -3648 -4.1
.data 2480 2448 -32 -1.3
.data.rel.ro 103184 102576 -608 -0.6
.init_array 872 864 -8 -0.9
.rodata 341193 339593 -1600 -0.5
.text 4932354 4916962 -15392 -0.3
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0a90632 a575b16 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659531 659531 0 0.0
(read/write) 191332 191332 0 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87083 87083 0 0.0
.text 572136 572136 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 647999 647999 0 0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90407 0 0.0
.text 557272 557272 0 0.0
lock-ftd LP_CC2652R7 (read only) 690451 690451 0 0.0
(read/write) 150524 150524 0 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 99163 0 0.0
.text 590804 590804 0 0.0
lock-mtd LP_CC2652R7 (read only) 639859 639859 0 0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 99043 0 0.0
.text 540324 540324 0 0.0
pump-app LP_CC2652R7 (read only) 671403 671403 0 0.0
(read/write) 170460 170460 0 0.0
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 87259 0 0.0
.text 583660 583660 0 0.0
pump-controller-app LP_CC2652R7 (read only) 662399 662399 0 0.0
(read/write) 179592 179592 0 0.0
.bss 71004 71004 0 0.0
.data 3276 3276 0 0.0
.rodata 85183 85183 0 0.0
.text 576732 576732 0 0.0
shell LP_CC2652R7 (read only) 688946 688938 -8 -0.0
(read/write) 157412 157420 8 0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109658 0 0.0
.text 578976 578968 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612738 612738 0 0.0
.app_xip_area 469404 469404 0 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610046 610046 0 0.0
.app_xip_area 466536 466536 0 0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616046 616054 8 0.0
.app_xip_area 473600 473608 8 0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 924008 924008 0 0.0
(read/write) 132416 132416 0 0.0
.bss 130336 130336 0 0.0
.data 2080 2080 0 0.0
.text 924000 924000 0 0.0
BRD4161A+rpc (read only) 959712 959712 0 0.0
(read/write) 149296 149296 0 0.0
.bss 147008 147008 0 0.0
.data 2284 2284 0 0.0
.text 959704 959704 0 0.0
BRD4161A+rs911x (read only) 799092 799092 0 0.0
(read/write) 128692 128692 0 0.0
.bss 126604 126604 0 0.0
.data 2088 2088 0 0.0
.text 799084 799084 0 0.0
lock-app BRD4161A+wf200 (read only) 965508 965524 16 0.0
(read/write) 129068 129068 0 0.0
.bss 126980 126980 0 0.0
.data 2088 2088 0 0.0
.text 965500 965516 16 0.0
window-app BRD4161A (read only) 909104 909104 0 0.0
(read/write) 132520 132520 0 0.0
.bss 130408 130408 0 0.0
.data 2108 2108 0 0.0
.text 909096 909096 0 0.0
esp32 all-clusters-app c3devkit (read only) 1012634 1012634 0 0.0
(read/write) 1482898 1482898 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213440 213440 0 0.0
.flash.text 1012634 1012634 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1067171 1067171 0 0.0
(read/write) 485016 485016 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243964 243964 0 0.0
.flash.text 1061787 1061787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658876 658876 0 0.0
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582328 582328 0 0.0
lock k32w061+release (read/write) 720848 720848 0 0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643852 643852 0 0.0
linux all-clusters-app debug (read only) 2929593 2929593 0 0.0
(read/write) 188656 188656 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259421 259421 0 0.0
.text 2493730 2493730 0 0.0
all-clusters-minimal-app debug (read only) 2783305 2783305 0 0.0
(read/write) 180560 180560 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260957 260957 0 0.0
.text 2348082 2348082 0 0.0
bridge-app debug+rpc (read only) 2285921 2285921 0 0.0
(read/write) 159424 159424 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194304 194304 0 0.0
.text 1930530 1930530 0 0.0
chip-tool debug (read only) 10140045 10140045 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508725 508725 0 0.0
.text 8225589 8225589 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9881788 9881788 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472300 472300 0 0.0
.text 7873060 7873060 0 0.0
lighting-app debug+rpc (read only) 2518673 2518673 0 0.0
(read/write) 163448 163448 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210056 210056 0 0.0
.text 2138914 2138914 0 0.0
lock-app debug (read only) 2457401 2457401 0 0.0
(read/write) 158096 158096 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 223752 223752 0 0.0
.text 2069346 2069346 0 0.0
ota-provider-app debug (read only) 2295281 2295281 0 0.0
(read/write) 152232 152232 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 199928 199928 0 0.0
.text 1933202 1933202 0 0.0
ota-requestor-app debug (read only) 2411009 2411009 0 0.0
(read/write) 158976 158976 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 203616 203616 0 0.0
.text 2037010 2037010 0 0.0
shell debug (read only) 2603137 2603137 0 0.0
(read/write) 219288 219288 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229746 229746 0 0.0
.text 2213634 2213634 0 0.0
thermostat-no-ble arm64 (read only) 2570668 2570668 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163324 163324 0 0.0
.text 2168224 2168224 0 0.0
tv-app debug (read only) 3067137 3067137 0 0.0
(read/write) 289352 289352 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 245664 245664 0 0.0
.text 2634610 2634610 0 0.0
tv-casting-app debug (read only) 5549993 5532785 -17208 -0.3
(read/write) 199960 195664 -4296 -2.1
.bss 88072 84424 -3648 -4.1
.data 2480 2448 -32 -1.3
.data.rel.ro 103184 102576 -608 -0.6
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 864 -8 -0.9
.rodata 341193 339593 -1600 -0.5
.text 4932354 4916962 -15392 -0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2437720 2437720 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400364 1400364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198699 1198699 0 0.0
bss 141598 141598 0 0.0
rodata 155676 155676 0 0.0
text 822504 822504 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146655 1146655 0 0.0
bss 140850 140850 0 0.0
rodata 132200 132200 0 0.0
text 794724 794724 0 0.0
p6 all-clusters-app default (read/write) 2553568 2553568 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1511832 1511832 0 0.0
all-clusters-minimal-app default (read/write) 2499416 2499416 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1457680 1457680 0 0.0
light-app default (read/write) 2430160 2430160 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388424 1388424 0 0.0
lock-app default (read/write) 2450784 2450784 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409048 1409048 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789008 789016 8 0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559600 559604 4 0.0
lighting-app tlsr9518adk80d (read/write) 808728 808728 0 0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576066 576066 0 0.0

@chrisdecenzo chrisdecenzo merged commit 26d6c54 into project-chip:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharadb-amazon @andy31415 @chrisdecenzo @bzbarsky-apple