[nrfconnect] Added factory data accessor implementation. #19614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
kkasperczyk-no
force-pushed
the
factory_data_support
branch
2 times, most recently
from
ea78f54 to
d77b9eb
Compare
|
PR #19614: Size comparison from 09f3e4a to d77b9eb Increases (2 builds for cyw30739, telink)
Full report (8 builds for cyw30739, linux, mbed, telink)
|
Damian-Nordic
approved these changes
Jun 15, 2022
kkasperczyk-no
force-pushed
the
factory_data_support
branch
from
c0507c4 to
163f3b7
Compare
|
PR #19614: Size comparison from b6954c0 to 163f3b7 Increases (12 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for cc13x2_26x2)
Full report (51 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Jun 15, 2022
woody-apple
approved these changes
Jun 16, 2022
woody-apple
approved these changes
Jun 16, 2022
bzbarsky-apple
approved these changes
Jun 16, 2022
The nrfconnect uses test values defined in the header files for the factory data purpose. The data belonging to factory data should be read from dedicated location in flash memory. * Added FactoryDataProvider class that overrides API to get factory data elements. * Added FactoryDataParser module that read factory data partition from flash and parses cbor format to get raw data.
In particular, don't continue booting an app if mandatory factory data fields are missing.
Damian-Nordic
force-pushed
the
factory_data_support
branch
from
163f3b7 to
7b3d39f
Compare
|
PR #19614: Size comparison from 5ea0ca6 to f16aa18 Increases (13 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (8 builds for cc13x2_26x2, esp32, k32w, nrfconnect)
Full report (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #19614: Size comparison from 29451fb to cf410a3 Increases (11 builds for cyw30739, esp32, nrfconnect)
Decreases (3 builds for cc13x2_26x2, nrfconnect, telink)
Full report (46 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The nrfconnect uses test values defined in the header files for the factory data purpose. The data belonging
to factory data should be read from dedicated location in flash memory.
Change overview
Testing
Performed manual testing.