Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow UDP listening port selection for Android #19596

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Allow UDP listening port selection for Android #19596

merged 3 commits into from
Jun 23, 2022

Conversation

gmarcosb
Copy link
Contributor

Problem

Testing

Manually tested on android

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

PR #19596: Size comparison from c5b26a5 to d37a5cd

Increases above 0.2%:

platform target config section c5b26a5 d37a5cd change % change
linux bridge-app debug+rpc .text 1924754 1928674 3920 0.2
chip-tool debug (read only) 10082677 10138093 55416 0.5
.rodata 503861 508725 4864 1.0
.text 8171141 8223925 52784 0.6
chip-tool-no-interactive-ipv6only arm64 (read only) 9827772 9879708 51936 0.5
.rodata 467708 472300 4592 1.0
.text 7821684 7871284 49600 0.6
ota-provider-app debug .text 1927426 1931346 3920 0.2
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c5b26a5 d37a5cd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658255 659159 904 0.1
.text 570960 571864 904 0.2
all-clusters-minimal-app LP_CC2652R7 (read only) 646731 647635 904 0.1
.text 556096 557000 904 0.2
lock-ftd LP_CC2652R7 (read only) 689151 690055 904 0.1
.text 589596 590500 904 0.2
lock-mtd LP_CC2652R7 (read only) 638567 639463 896 0.1
.text 539124 540020 896 0.2
pump-app LP_CC2652R7 (read only) 670135 671023 888 0.1
.text 582484 583372 888 0.2
pump-controller-app LP_CC2652R7 (read only) 661107 662011 904 0.1
.text 575532 576436 904 0.2
shell LP_CC2652R7 (read only) 687654 688558 904 0.1
.text 577776 578680 904 0.2
cyw30739 light cyw930739m2evb_01 (read/write) 611434 612346 912 0.1
.app_xip_area 468124 469036 912 0.2
lock cyw930739m2evb_01 (read/write) 608750 609654 904 0.1
.app_xip_area 465264 466168 904 0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614770 615666 896 0.1
.app_xip_area 472348 473244 896 0.2
efr32 lighting-app BRD4161A (read only) 921948 923628 1680 0.2
.text 921940 923620 1680 0.2
BRD4161A+rpc (read only) 957652 959348 1696 0.2
.text 957644 959340 1696 0.2
BRD4161A+rs911x (read only) 796984 798680 1696 0.2
.text 796976 798672 1696 0.2
lock-app BRD4161A+wf200 (read only) 964264 965144 880 0.1
.text 964256 965136 880 0.1
window-app BRD4161A (read only) 907044 908724 1680 0.2
.text 907036 908716 1680 0.2
esp32 all-clusters-app c3devkit (read only) 1011250 1012272 1022 0.1
.flash.text 1011250 1012272 1022 0.1
m5stack (read only) 1065595 1066723 1128 0.1
.flash.text 1060211 1061339 1128 0.1
k32w light k32w061+release (read/write) 657616 658512 896 0.1
.text 581092 581988 896 0.2
lock k32w061+release (read/write) 719564 720460 896 0.1
.text 642592 643488 896 0.1
linux all-clusters-app debug (read only) 2923377 2927329 3952 0.1
.rodata 259389 259421 32 0.0
.text 2487906 2491826 3920 0.2
all-clusters-minimal-app debug (read only) 2777089 2781041 3952 0.1
.rodata 260925 260957 32 0.0
.text 2342258 2346178 3920 0.2
bridge-app debug+rpc (read only) 2279801 2283753 3952 0.2
.rodata 194272 194304 32 0.0
.text 1924754 1928674 3920 0.2
chip-tool debug (read only) 10082677 10138093 55416 0.5
.rodata 503861 508725 4864 1.0
.text 8171141 8223925 52784 0.6
chip-tool-no-interactive-ipv6only arm64 (read only) 9827772 9879708 51936 0.5
.bss 42625 42641 16 0.0
.rodata 467708 472300 4592 1.0
.text 7821684 7871284 49600 0.6
lighting-app debug+rpc (read only) 2512553 2516505 3952 0.2
.rodata 210024 210056 32 0.0
.text 2133138 2137058 3920 0.2
lock-app debug (read only) 2451225 2455177 3952 0.2
.rodata 223720 223752 32 0.0
.text 2063538 2067458 3920 0.2
ota-provider-app debug (read only) 2289161 2293113 3952 0.2
.rodata 199896 199928 32 0.0
.text 1927426 1931346 3920 0.2
ota-requestor-app debug (read only) 2404889 2408825 3936 0.2
.rodata 203584 203616 32 0.0
.text 2031234 2035138 3904 0.2
shell debug (read only) 2596905 2600857 3952 0.2
.rodata 229714 229746 32 0.0
.text 2207794 2211714 3920 0.2
thermostat-no-ble arm64 (read only) 2564588 2568268 3680 0.1
.rodata 163292 163324 32 0.0
.text 2162528 2166176 3648 0.2
tv-app debug (read only) 3061097 3065033 3936 0.1
.rodata 245632 245664 32 0.0
.text 2628962 2632866 3904 0.1
tv-casting-app debug (read only) 5543833 5547785 3952 0.1
.rodata 341161 341193 32 0.0
.text 4926562 4930482 3920 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2436264 2437160 896 0.0
.text 1398908 1399804 896 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197451 1198347 896 0.1
text 821356 822248 892 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1145423 1146303 880 0.1
text 793576 794468 892 0.1
p6 all-clusters-app default (read/write) 2551576 2553272 1696 0.1
.text 1509840 1511536 1696 0.1
all-clusters-minimal-app default (read/write) 2497424 2499120 1696 0.1
.text 1455688 1457384 1696 0.1
light-app default (read/write) 2428160 2429856 1696 0.1
.text 1386424 1388120 1696 0.1
lock-app default (read/write) 2448800 2450480 1680 0.1
.text 1407064 1408744 1680 0.1
telink light-switch-app tlsr9518adk80d (read/write) 787556 788540 984 0.1
text 558262 559244 982 0.2
lighting-app tlsr9518adk80d (read/write) 807268 808252 984 0.1
text 574726 575708 982 0.2
Decreases (7 builds for cc13x2_26x2, linux)
platform target config section c5b26a5 d37a5cd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 192584 191680 -904 -0.5
lock-ftd LP_CC2652R7 (read/write) 151800 150896 -904 -0.6
pump-app LP_CC2652R7 (read/write) 171704 170816 -888 -0.5
pump-controller-app LP_CC2652R7 (read/write) 180860 179956 -904 -0.5
shell LP_CC2652R7 (read/write) 158680 157776 -904 -0.6
linux chip-tool debug (read/write) 610376 609416 -960 -0.2
.data.rel.ro 578656 577696 -960 -0.2
chip-tool-no-interactive-ipv6only arm64 (read/write) 675041 674097 -944 -0.1
.data.rel.ro 614024 613072 -952 -0.2
.got 13424 13416 -8 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c5b26a5 d37a5cd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658255 659159 904 0.1
(read/write) 192584 191680 -904 -0.5
.bss 73732 73732 0 0.0
.data 3356 3356 0 0.0
.rodata 86983 86983 0 0.0
.text 570960 571864 904 0.2
all-clusters-minimal-app LP_CC2652R7 (read only) 646731 647635 904 0.1
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90315 90315 0 0.0
.text 556096 557000 904 0.2
lock-ftd LP_CC2652R7 (read only) 689151 690055 904 0.1
(read/write) 151800 150896 -904 -0.6
.bss 70732 70732 0 0.0
.data 3280 3280 0 0.0
.rodata 99071 99071 0 0.0
.text 589596 590500 904 0.2
lock-mtd LP_CC2652R7 (read only) 638567 639463 896 0.1
(read/write) 143864 143864 0 0.0
.bss 66468 66468 0 0.0
.data 3280 3280 0 0.0
.rodata 98951 98951 0 0.0
.text 539124 540020 896 0.2
pump-app LP_CC2652R7 (read only) 670135 671023 888 0.1
(read/write) 171704 170816 -888 -0.5
.bss 70852 70852 0 0.0
.data 3280 3280 0 0.0
.rodata 87167 87167 0 0.0
.text 582484 583372 888 0.2
pump-controller-app LP_CC2652R7 (read only) 661107 662011 904 0.1
(read/write) 180860 179956 -904 -0.5
.bss 70980 70980 0 0.0
.data 3276 3276 0 0.0
.rodata 85091 85091 0 0.0
.text 575532 576436 904 0.2
shell LP_CC2652R7 (read only) 687654 688558 904 0.1
(read/write) 158680 157776 -904 -0.6
.bss 76028 76028 0 0.0
.data 3360 3360 0 0.0
.rodata 109566 109566 0 0.0
.text 577776 578680 904 0.2
cyw30739 light cyw930739m2evb_01 (read/write) 611434 612346 912 0.1
.app_xip_area 468124 469036 912 0.2
.bss 86264 86264 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608750 609654 904 0.1
.app_xip_area 465264 466168 904 0.2
.bss 86440 86440 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614770 615666 896 0.1
.app_xip_area 472348 473244 896 0.2
.bss 85432 85432 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921948 923628 1680 0.2
(read/write) 132392 132392 0 0.0
.bss 130312 130312 0 0.0
.data 2080 2080 0 0.0
.text 921940 923620 1680 0.2
BRD4161A+rpc (read only) 957652 959348 1696 0.2
(read/write) 149268 149268 0 0.0
.bss 146984 146984 0 0.0
.data 2284 2284 0 0.0
.text 957644 959340 1696 0.2
BRD4161A+rs911x (read only) 796984 798680 1696 0.2
(read/write) 128668 128668 0 0.0
.bss 126580 126580 0 0.0
.data 2088 2088 0 0.0
.text 796976 798672 1696 0.2
lock-app BRD4161A+wf200 (read only) 964264 965144 880 0.1
(read/write) 129044 129044 0 0.0
.bss 126956 126956 0 0.0
.data 2088 2088 0 0.0
.text 964256 965136 880 0.1
window-app BRD4161A (read only) 907044 908724 1680 0.2
(read/write) 132492 132492 0 0.0
.bss 130384 130384 0 0.0
.data 2108 2108 0 0.0
.text 907036 908716 1680 0.2
esp32 all-clusters-app c3devkit (read only) 1011250 1012272 1022 0.1
(read/write) 1482786 1482786 0 0.0
.dram0.bss 69368 69368 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213344 213344 0 0.0
.flash.text 1011250 1012272 1022 0.1
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065595 1066723 1128 0.1
(read/write) 484896 484896 0 0.0
.dram0.bss 74888 74888 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243868 243868 0 0.0
.flash.text 1060211 1061339 1128 0.1
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657616 658512 896 0.1
.bss 68732 68732 0 0.0
.data 1992 1992 0 0.0
.text 581092 581988 896 0.2
lock k32w061+release (read/write) 719564 720460 896 0.1
.bss 69172 69172 0 0.0
.data 2000 2000 0 0.0
.text 642592 643488 896 0.1
linux all-clusters-app debug (read only) 2923377 2927329 3952 0.1
(read/write) 188528 188528 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84536 84536 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259389 259421 32 0.0
.text 2487906 2491826 3920 0.2
all-clusters-minimal-app debug (read only) 2777089 2781041 3952 0.1
(read/write) 180432 180432 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77176 77176 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260925 260957 32 0.0
.text 2342258 2346178 3920 0.2
bridge-app debug+rpc (read only) 2279801 2283753 3952 0.2
(read/write) 159296 159296 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66600 66600 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194272 194304 32 0.0
.text 1924754 1928674 3920 0.2
chip-tool debug (read only) 10082677 10138093 55416 0.5
(read/write) 610376 609416 -960 -0.2
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578656 577696 -960 -0.2
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 503861 508725 4864 1.0
.text 8171141 8223925 52784 0.6
chip-tool-no-interactive-ipv6only arm64 (read only) 9827772 9879708 51936 0.5
(read/write) 675041 674097 -944 -0.1
.bss 42625 42641 16 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614024 613072 -952 -0.2
.dynamic 528 528 0 0.0
.got 13424 13416 -8 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467708 472300 4592 1.0
.text 7821684 7871284 49600 0.6
lighting-app debug+rpc (read only) 2512553 2516505 3952 0.2
(read/write) 163320 163320 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71752 71752 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210024 210056 32 0.0
.text 2133138 2137058 3920 0.2
lock-app debug (read only) 2451225 2455177 3952 0.2
(read/write) 157968 157968 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68440 68440 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 223720 223752 32 0.0
.text 2063538 2067458 3920 0.2
ota-provider-app debug (read only) 2289161 2293113 3952 0.2
(read/write) 152136 152136 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62728 62728 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 199896 199928 32 0.0
.text 1927426 1931346 3920 0.2
ota-requestor-app debug (read only) 2404889 2408825 3936 0.2
(read/write) 158848 158848 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66808 66808 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 203584 203616 32 0.0
.text 2031234 2035138 3904 0.2
shell debug (read only) 2596905 2600857 3952 0.2
(read/write) 219192 219192 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229714 229746 32 0.0
.text 2207794 2211714 3920 0.2
thermostat-no-ble arm64 (read only) 2564588 2568268 3680 0.1
(read/write) 192033 192033 0 0.0
.bss 99473 99473 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82776 82776 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163292 163324 32 0.0
.text 2162528 2166176 3648 0.2
tv-app debug (read only) 3061097 3065033 3936 0.1
(read/write) 289224 289224 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78880 78880 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 245632 245664 32 0.0
.text 2628962 2632866 3904 0.1
tv-casting-app debug (read only) 5543833 5547785 3952 0.1
(read/write) 199832 199832 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 341161 341193 32 0.0
.text 4926562 4930482 3920 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2436264 2437160 896 0.0
.bss 208180 208180 0 0.0
.data 5864 5864 0 0.0
.text 1398908 1399804 896 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1197451 1198347 896 0.1
bss 141574 141574 0 0.0
rodata 155580 155580 0 0.0
text 821356 822248 892 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1145423 1146303 880 0.1
bss 140826 140826 0 0.0
rodata 132104 132104 0 0.0
text 793576 794468 892 0.1
p6 all-clusters-app default (read/write) 2551576 2553272 1696 0.1
.bss 143360 143360 0 0.0
.data 2776 2776 0 0.0
.text 1509840 1511536 1696 0.1
all-clusters-minimal-app default (read/write) 2497424 2499120 1696 0.1
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1455688 1457384 1696 0.1
light-app default (read/write) 2428160 2429856 1696 0.1
.bss 134720 134720 0 0.0
.data 2592 2592 0 0.0
.text 1386424 1388120 1696 0.1
lock-app default (read/write) 2448800 2450480 1680 0.1
.bss 134544 134544 0 0.0
.data 2600 2600 0 0.0
.text 1407064 1408744 1680 0.1
telink light-switch-app tlsr9518adk80d (read/write) 787556 788540 984 0.1
bss 69868 69868 0 0.0
noinit 40416 40416 0 0.0
text 558262 559244 982 0.2
lighting-app tlsr9518adk80d (read/write) 807268 808252 984 0.1
bss 70116 70116 0 0.0
noinit 40416 40416 0 0.0
text 574726 575708 982 0.2

@restyled-io restyled-io bot mentioned this pull request Jun 16, 2022
Closed
jepenven-silabs
jepenven-silabs previously requested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@jepenven-silabs jepenven-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be way too many changes in this PR. Some of them doesn't even seems related to the initial bugfix. For examples why did the EFR32 ota-requestor app was added again ? We at silabs explicitly removed it since we don't support it anymore.

It seems that this branch wasn't rebased on master properly multiples times. Please fix this.

@gmarcosb gmarcosb closed this Jun 22, 2022
@gmarcosb gmarcosb reopened this Jun 22, 2022
@restyled-io restyled-io bot mentioned this pull request Jun 22, 2022
Closed
@gmarcosb
Copy link
Contributor Author

Yup, apologies, still getting the hang of git/github, keep wanting it to be like perforce; I think a reset did the trick

@github-actions
Copy link

github-actions bot commented Jun 22, 2022 •
edited
Loading

PR #19596: Size comparison from 6231ccc to cddf06a

Increases (3 builds for esp32, telink)
platform target config section 6231ccc cddf06a change % change
esp32 all-clusters-app c3devkit (read only) 1014134 1014136 2 0.0
.flash.text 1014134 1014136 2 0.0
telink light-switch-app tlsr9518adk80d text 561060 561064 4 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811792 8 0.0
text 577520 577524 4 0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6231ccc cddf06a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660423 660423 0 0.0
(read/write) 191184 191184 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573136 573136 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649235 649235 0 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558408 558408 0 0.0
lock-ftd LP_CC2652R7 (read only) 691983 691983 0 0.0
(read/write) 149736 149736 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 592148 592148 0 0.0
lock-mtd LP_CC2652R7 (read only) 641399 641399 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99239 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673223 673223 0 0.0
(read/write) 169392 169392 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585076 585076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659115 0 0.0
(read/write) 183612 183612 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575128 575128 0 0.0
shell LP_CC2652R7 (read only) 690182 690182 0 0.0
(read/write) 156928 156928 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109758 0 0.0
.text 580112 580112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591722 591722 0 0.0
.app_xip_area 462620 462620 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589106 0 0.0
.app_xip_area 459828 459828 0 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594250 0 0.0
.app_xip_area 466020 466020 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1070848 1070848 0 0.0
.bss 132932 132932 0 0.0
.data 2048 2048 0 0.0
.text 935848 935848 0 0.0
BRD4161A+rpc (read/write) 1124900 1124900 0 0.0
.bss 149620 149620 0 0.0
.data 2260 2260 0 0.0
.text 973000 973000 0 0.0
BRD4161A+rs911x (read/write) 935520 935520 0 0.0
.bss 139304 139304 0 0.0
.data 2048 2048 0 0.0
.text 794148 794148 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111260 1111260 0 0.0
.bss 139720 139720 0 0.0
.data 2056 2056 0 0.0
.text 969464 969464 0 0.0
window-app BRD4161A (read/write) 1056116 1056116 0 0.0
.bss 133004 133004 0 0.0
.data 2076 2076 0 0.0
.text 921016 921016 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014136 2 0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014134 1014136 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068459 0 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063075 1063075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661524 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583976 0 0.0
lock k32w061+release (read/write) 723452 723452 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645448 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9926284 9926284 0 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 474252 474252 0 0.0
.text 7911060 7911060 0 0.0
thermostat-no-ble arm64 (read only) 2578428 2578428 0 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174816 2174816 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439432 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202291 1202291 0 0.0
bss 142862 142862 0 0.0
rodata 156260 156260 0 0.0
text 824232 824232 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149639 0 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796024 796024 0 0.0
p6 all-clusters-app default (read/write) 2555776 2555776 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514040 0 0.0
all-clusters-minimal-app default (read/write) 2501624 2501624 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1459888 0 0.0
light-app default (read/write) 2432384 2432384 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390648 0 0.0
lock-app default (read/write) 2453096 2453096 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792080 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561060 561064 4 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811792 8 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577520 577524 4 0.0

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19596: Size comparison from 6231ccc to 980dbe7

Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6231ccc 980dbe7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660423 660447 24 0.0
.rodata 86975 87007 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649235 649347 112 0.0
.rodata 90507 90619 112 0.1
lock-ftd LP_CC2652R7 (read only) 691983 692095 112 0.0
.rodata 99351 99463 112 0.1
lock-mtd LP_CC2652R7 (read only) 641399 641511 112 0.0
.rodata 99239 99351 112 0.1
pump-app LP_CC2652R7 (read only) 673223 673327 104 0.0
.rodata 87663 87775 112 0.1
pump-controller-app LP_CC2652R7 (read only) 659115 659211 96 0.0
.rodata 83507 83619 112 0.1
shell LP_CC2652R7 (read only) 690182 690286 104 0.0
.rodata 109758 109862 104 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 591722 591738 16 0.0
.app_xip_area 462620 462636 16 0.0
lock cyw930739m2evb_01 (read/write) 589106 589122 16 0.0
.app_xip_area 459828 459844 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594258 8 0.0
.app_xip_area 466020 466028 8 0.0
efr32 lighting-app BRD4161A (read/write) 1070848 1071000 152 0.0
.text 935848 936000 152 0.0
BRD4161A+rpc (read/write) 1124900 1125060 160 0.0
.text 973000 973160 160 0.0
BRD4161A+rs911x (read/write) 935520 935672 152 0.0
.text 794148 794300 152 0.0
lock-app BRD4161A+wf200 (read/write) 1111260 1111348 88 0.0
.text 969464 969552 88 0.0
window-app BRD4161A (read/write) 1056116 1056252 136 0.0
.text 921016 921152 136 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014138 4 0.0
(read/write) 1484770 1484882 112 0.0
.flash.rodata 214064 214176 112 0.1
.flash.text 1014134 1014138 4 0.0
m5stack (read only) 1068459 1068475 16 0.0
(read/write) 486856 486960 104 0.0
.flash.rodata 244564 244668 104 0.0
.flash.text 1063075 1063091 16 0.0
k32w light k32w061+release (read/write) 661524 661556 32 0.0
.text 583976 584008 32 0.0
lock k32w061+release (read/write) 723452 723540 88 0.0
.text 645448 645536 88 0.0
linux thermostat-no-ble arm64 (read only) 2578428 2579044 616 0.0
(read/write) 180609 180673 64 0.0
.data.rel.ro 82896 82952 56 0.1
.got 5080 5088 8 0.2
.rodata 164540 164724 184 0.1
.text 2174816 2175104 288 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439432 2439536 104 0.0
.text 1402076 1402180 104 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202291 1202383 92 0.0
rodata 156260 156368 108 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149731 92 0.0
rodata 132592 132700 108 0.1
p6 all-clusters-app default (read/write) 2555776 2555936 160 0.0
.text 1514040 1514200 160 0.0
all-clusters-minimal-app default (read/write) 2501624 2501800 176 0.0
.text 1459888 1460064 176 0.0
light-app default (read/write) 2432384 2432536 152 0.0
.text 1390648 1390800 152 0.0
lock-app default (read/write) 2453096 2453256 160 0.0
.text 1411360 1411520 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792204 124 0.0
text 561060 561074 14 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811908 124 0.0
text 577520 577534 14 0.0
Decreases (8 builds for cc13x2_26x2, linux, nrfconnect)
platform target config section 6231ccc 980dbe7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191184 191160 -24 -0.0
.text 573136 573128 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 149736 149624 -112 -0.1
pump-app LP_CC2652R7 (read/write) 169392 169288 -104 -0.1
.text 585076 585068 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 183612 183516 -96 -0.1
.text 575128 575112 -16 -0.0
shell LP_CC2652R7 (read/write) 156928 156824 -104 -0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9926284 9907540 -18744 -0.2
(read/write) 676161 675265 -896 -0.1
.data.rel.ro 615080 614184 -896 -0.1
.rodata 474252 471092 -3160 -0.7
.text 7911060 7897588 -13472 -0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 824232 824224 -8 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 796024 796020 -4 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6231ccc 980dbe7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660423 660447 24 0.0
(read/write) 191184 191160 -24 -0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 87007 32 0.0
.text 573136 573128 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649235 649347 112 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90619 112 0.1
.text 558408 558408 0 0.0
lock-ftd LP_CC2652R7 (read only) 691983 692095 112 0.0
(read/write) 149736 149624 -112 -0.1
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99463 112 0.1
.text 592148 592148 0 0.0
lock-mtd LP_CC2652R7 (read only) 641399 641511 112 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99351 112 0.1
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673223 673327 104 0.0
(read/write) 169392 169288 -104 -0.1
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87775 112 0.1
.text 585076 585068 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 659115 659211 96 0.0
(read/write) 183612 183516 -96 -0.1
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83619 112 0.1
.text 575128 575112 -16 -0.0
shell LP_CC2652R7 (read only) 690182 690286 104 0.0
(read/write) 156928 156824 -104 -0.1
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109862 104 0.1
.text 580112 580112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591722 591738 16 0.0
.app_xip_area 462620 462636 16 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589122 16 0.0
.app_xip_area 459828 459844 16 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594258 8 0.0
.app_xip_area 466020 466028 8 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1070848 1071000 152 0.0
.bss 132932 132932 0 0.0
.data 2048 2048 0 0.0
.text 935848 936000 152 0.0
BRD4161A+rpc (read/write) 1124900 1125060 160 0.0
.bss 149620 149620 0 0.0
.data 2260 2260 0 0.0
.text 973000 973160 160 0.0
BRD4161A+rs911x (read/write) 935520 935672 152 0.0
.bss 139304 139304 0 0.0
.data 2048 2048 0 0.0
.text 794148 794300 152 0.0
lock-app BRD4161A+wf200 (read/write) 1111260 1111348 88 0.0
.bss 139720 139720 0 0.0
.data 2056 2056 0 0.0
.text 969464 969552 88 0.0
window-app BRD4161A (read/write) 1056116 1056252 136 0.0
.bss 133004 133004 0 0.0
.data 2076 2076 0 0.0
.text 921016 921152 136 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014138 4 0.0
(read/write) 1484770 1484882 112 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214176 112 0.1
.flash.text 1014134 1014138 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068475 16 0.0
(read/write) 486856 486960 104 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244668 104 0.0
.flash.text 1063075 1063091 16 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661556 32 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 584008 32 0.0
lock k32w061+release (read/write) 723452 723540 88 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645536 88 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9926284 9907540 -18744 -0.2
(read/write) 676161 675265 -896 -0.1
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 614184 -896 -0.1
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 474252 471092 -3160 -0.7
.text 7911060 7897588 -13472 -0.2
thermostat-no-ble arm64 (read only) 2578428 2579044 616 0.0
(read/write) 180609 180673 64 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82952 56 0.1
.dynamic 528 528 0 0.0
.got 5080 5088 8 0.2
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164724 184 0.1
.text 2174816 2175104 288 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439536 104 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402180 104 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202291 1202383 92 0.0
bss 142862 142862 0 0.0
rodata 156260 156368 108 0.1
text 824232 824224 -8 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149731 92 0.0
bss 142098 142098 0 0.0
rodata 132592 132700 108 0.1
text 796024 796020 -4 -0.0
p6 all-clusters-app default (read/write) 2555776 2555936 160 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514200 160 0.0
all-clusters-minimal-app default (read/write) 2501624 2501800 176 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1460064 176 0.0
light-app default (read/write) 2432384 2432536 152 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390800 152 0.0
lock-app default (read/write) 2453096 2453256 160 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411520 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792204 124 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561060 561074 14 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811908 124 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577520 577534 14 0.0

@woody-apple woody-apple merged commit fd2e975 into project-chip:master Jun 23, 2022
@gmarcosb gmarcosb deleted the 14542_changes branch June 23, 2022 18:00
@joonhaengHeo joonhaengHeo mentioned this pull request Jun 29, 2022
Merged
@gmarcosb gmarcosb mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

Assignees
No one assigned
Labels
config controller examples github lib review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow UDP listening port selection for Android
6 participants
@gmarcosb @andy31415 @woody-apple @bzbarsky-apple @jepenven-silabs @restyled-commits