-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comments around X.509/RFC5280 99991231235959Z time value #19572
Merged
andy31415
merged 1 commit into
project-chip:master
from
msandstedt:fix-NotBefore-comments
Jun 15, 2022
Merged
Fix comments around X.509/RFC5280 99991231235959Z time value #19572
andy31415
merged 1 commit into
project-chip:master
from
msandstedt:fix-NotBefore-comments
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X.509/RFC5280 defines the special time 99991231235959Z to mean 'no well-defined expiration date'. Comments in the code implied this was also relevant for NotBefore, but it's not. This is only a NotAfter concept. However, the code does have reasonable behavior for both cases. This commit amends comments to spell out exactly what this behavior is.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda and
mspang
June 14, 2022 16:27
pullapprove
bot
requested review from
rgoliver,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
June 14, 2022 16:27
PR #19572: Size comparison from 4b6fc80 to dab1852 Increases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (1 build for cyw30739)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 14, 2022
emargolis
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
X.509/RFC5280 defines the special time 99991231235959Z to mean 'no
well-defined expiration date'. Comments in the code implied this was
also relevant for NotBefore, but it's not. This is only a NotAfter
concept.
Change overview
In spite of the misleading comments, the code does have reasonable behavior for both the NotBefore and NotAfter cases. This commit amends comments to spell out exactly what this behavior is.
Testing
Tested to build without error.