-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Fixed auto relock attribute and Lock Operation event #19562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #19562: Size comparison from efc2109 to 2ebbb51 Increases (4 builds for cyw30739, esp32, nrfconnect)
Decreases (7 builds for cc13x2_26x2, nrfconnect)
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
kkasperczyk-no
force-pushed
the
auto_relock
branch
from
June 14, 2022 19:23
2ebbb51
to
b5c26d4
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
June 14, 2022 19:23
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 14, 2022 19:23
PR #19562: Size comparison from b006bab to b5c26d4 Increases (4 builds for nrfconnect, telink)
Decreases (6 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 14, 2022
LuDuda
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There are two issues with the nrfconnect door lock: * It has auto-relock-time value set to 60, while it should be 0 * It emits Lock Operation event on init, while no operation was done. * Set auto relock time to 0 * Added invoking lock/unlock operation only if lock state is not null (uninitialized) * By the way of this change aligned lighting app extended discovery timeout to other nrfconnect examples
kkasperczyk-no
force-pushed
the
auto_relock
branch
from
June 15, 2022 08:47
b5c26d4
to
0dca5fb
Compare
Damian-Nordic
approved these changes
Jun 15, 2022
PR #19562: Size comparison from 09f3e4a to 0dca5fb Increases (4 builds for cc13x2_26x2, cyw30739, nrfconnect)
Decreases (8 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Full report (36 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are two issues with the nrfconnect door lock:
Change overview
Testing
Manual testing was done.