Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Fixed auto relock attribute and Lock Operation event #19562

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

There are two issues with the nrfconnect door lock:

  • It has auto-relock-time value set to 60, while it should be 0
  • It emits Lock Operation event on init, while no operation was done.

Change overview

  • Set auto relock time to 0
  • Added invoking lock/unlock operation only if lock state is not null (uninitialized)
  • By the way of this change aligned lighting app extended discovery timeout to other nrfconnect examples

Testing

Manual testing was done.

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

PR #19562: Size comparison from efc2109 to 2ebbb51

Increases (4 builds for cyw30739, esp32, nrfconnect)
platform target config section efc2109 2ebbb51 change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 609310 609318 8 0.0
.app_xip_area 464800 464808 8 0.0
esp32 all-clusters-app c3devkit (read only) 1013762 1013764 2 0.0
.flash.text 1013762 1013764 2 0.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1109559 1109719 160 0.0
text 757680 757836 156 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1013518 1013678 160 0.0
text 670472 670628 156 0.0
Decreases (7 builds for cc13x2_26x2, nrfconnect)
platform target config section efc2109 2ebbb51 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645659 -8 -0.0
.text 555280 555272 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 637947 637939 -8 -0.0
.text 538692 538684 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1157767 1157595 -172 -0.0
rodata 122384 122340 -44 -0.0
text 812304 812172 -132 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1126991 1126803 -188 -0.0
rodata 114136 114092 -44 -0.0
text 788956 788824 -132 -0.0
nrf52840dongle_nrf52840 (read/write) 1064803 1064631 -172 -0.0
rodata 91532 91488 -44 -0.0
text 740816 740684 -132 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061474 1061306 -168 -0.0
rodata 114792 114752 -40 -0.0
text 725036 724908 -128 -0.0
pump-app nrf52840dk_nrf52840 text 741912 741908 -4 -0.0
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section efc2109 2ebbb51 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659119 0 0.0
(read/write) 191784 191784 0 0.0
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87047 87047 0 0.0
.text 571760 571760 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645659 -8 -0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90067 90067 0 0.0
.text 555280 555272 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637947 637939 -8 -0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538692 538684 -8 -0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689270 689270 0 0.0
(read/write) 157128 157128 0 0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110126 110126 0 0.0
.text 578832 578832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609310 609318 8 0.0
.app_xip_area 464800 464808 8 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133528 0 0.0
.bss 131416 131416 0 0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013762 1013764 2 0.0
(read/write) 1483522 1483522 0 0.0
.dram0.bss 69424 69424 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213968 213968 0 0.0
.flash.text 1013762 1013764 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068011 1068011 0 0.0
(read/write) 485616 485616 0 0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244444 244444 0 0.0
.flash.text 1062627 1062627 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux all-clusters-app debug (read only) 2926137 2926137 0 0.0
(read/write) 188624 188624 0 0.0
.bss 95808 95808 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84552 84552 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 258205 0 0.0
.text 2492162 2492162 0 0.0
all-clusters-minimal-app debug (read only) 2771713 2771713 0 0.0
(read/write) 179984 179984 0 0.0
.bss 94976 94976 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76936 76936 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 258621 0 0.0
.text 2339858 2339858 0 0.0
bridge-app debug+rpc (read only) 2252593 2252593 0 0.0
(read/write) 158880 158880 0 0.0
.bss 83008 83008 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66344 66344 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191584 191584 0 0.0
.text 1900834 1900834 0 0.0
chip-tool debug (read only) 9817989 9817989 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7870565 7870565 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9565628 9565628 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468812 468812 0 0.0
.text 7520724 7520724 0 0.0
lighting-app debug+rpc (read only) 2507953 2507953 0 0.0
(read/write) 163960 163960 0 0.0
.bss 84576 84576 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 71496 71496 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207432 207432 0 0.0
.text 2131730 2131730 0 0.0
lock-app debug (read only) 2446641 2446641 0 0.0
(read/write) 158584 158584 0 0.0
.bss 82976 82976 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68184 68184 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221288 221288 0 0.0
.text 2062034 2062034 0 0.0
ota-provider-app debug (read only) 2284417 2284417 0 0.0
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197368 197368 0 0.0
.text 1925858 1925858 0 0.0
ota-requestor-app debug (read only) 2400177 2400177 0 0.0
(read/write) 159464 159464 0 0.0
.bss 84960 84960 0 0.0
.data 2072 2072 0 0.0
.data.rel.ro 66568 66568 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 201088 201088 0 0.0
.text 2029666 2029666 0 0.0
shell debug (read only) 2608505 2608505 0 0.0
(read/write) 219544 219544 0 0.0
.bss 134600 134600 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77800 77800 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230226 230226 0 0.0
.text 2218770 2218770 0 0.0
thermostat-no-ble arm64 (read only) 2560628 2560628 0 0.0
(read/write) 191489 191489 0 0.0
.bss 99393 99393 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161356 161356 0 0.0
.text 2161472 2161472 0 0.0
tv-app debug (read only) 3055801 3055801 0 0.0
(read/write) 289992 289992 0 0.0
.bss 200232 200232 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78624 78624 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 243136 243136 0 0.0
.text 2626690 2626690 0 0.0
tv-casting-app debug (read only) 5354041 5354041 0 0.0
(read/write) 232440 232440 0 0.0
.bss 88104 88104 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135624 135624 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342912 342912 0 0.0
.text 4659666 4659666 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199111 0 0.0
bss 141633 141633 0 0.0
rodata 156128 156128 0 0.0
text 822412 822412 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144347 0 0.0
bss 140824 140824 0 0.0
rodata 131860 131860 0 0.0
text 792756 792756 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1157767 1157595 -172 -0.0
bss 144181 144181 0 0.0
rodata 122384 122340 -44 -0.0
text 812304 812172 -132 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1126991 1126803 -188 -0.0
bss 144626 144626 0 0.0
rodata 114136 114092 -44 -0.0
text 788956 788824 -132 -0.0
nrf52840dongle_nrf52840 (read/write) 1064803 1064631 -172 -0.0
bss 151412 151412 0 0.0
rodata 91532 91488 -44 -0.0
text 740816 740684 -132 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061474 1061306 -168 -0.0
bss 140552 140552 0 0.0
rodata 114792 114752 -40 -0.0
text 725036 724908 -128 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1109559 1109719 160 0.0
bss 134109 134109 0 0.0
rodata 138984 138984 0 0.0
text 757680 757836 156 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1013518 1013678 160 0.0
bss 130512 130512 0 0.0
rodata 131452 131452 0 0.0
text 670472 670628 156 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1070595 1070595 0 0.0
bss 134076 134076 0 0.0
rodata 115724 115724 0 0.0
text 741912 741908 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1063351 1063351 0 0.0
bss 133869 133869 0 0.0
rodata 114624 114624 0 0.0
text 736048 736048 0 0.0
p6 all-clusters-app default (read/write) 2552984 2552984 0 0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511248 1511248 0 0.0
all-clusters-minimal-app default (read/write) 2495472 2495472 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1453736 1453736 0 0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 787840 0 0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557712 557712 0 0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574404 574404 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

PR #19562: Size comparison from b006bab to b5c26d4

Increases (4 builds for nrfconnect, telink)
platform target config section b006bab b5c26d4 change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 792752 792756 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1109559 1109735 176 0.0
text 757680 757852 172 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1013518 1013694 176 0.0
text 670472 670648 176 0.0
telink lighting-app tlsr9518adk80d text 574402 574404 2 0.0
Decreases (6 builds for cc13x2_26x2, esp32, nrfconnect)
platform target config section b006bab b5c26d4 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645659 -8 -0.0
.text 555280 555272 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1013902 1013900 -2 -0.0
.flash.text 1013902 1013900 -2 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1157767 1157595 -172 -0.0
rodata 122384 122340 -44 -0.0
text 812304 812172 -132 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1126991 1126803 -188 -0.0
rodata 114136 114092 -44 -0.0
text 788956 788824 -132 -0.0
nrf52840dongle_nrf52840 (read/write) 1064819 1064631 -188 -0.0
rodata 91532 91488 -44 -0.0
text 740820 740688 -132 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061474 1061306 -168 -0.0
rodata 114792 114752 -40 -0.0
text 725036 724908 -128 -0.0
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b006bab b5c26d4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659119 0 0.0
(read/write) 191784 191784 0 0.0
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87047 87047 0 0.0
.text 571760 571760 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645659 -8 -0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90067 90067 0 0.0
.text 555280 555272 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637947 637947 0 0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538692 538692 0 0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689270 689270 0 0.0
(read/write) 157128 157128 0 0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110126 110126 0 0.0
.text 578832 578832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 609318 0 0.0
.app_xip_area 464808 464808 0 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133528 0 0.0
.bss 131416 131416 0 0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013902 1013900 -2 -0.0
(read/write) 1483522 1483522 0 0.0
.dram0.bss 69424 69424 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213968 213968 0 0.0
.flash.text 1013902 1013900 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068115 1068115 0 0.0
(read/write) 485616 485616 0 0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244444 244444 0 0.0
.flash.text 1062731 1062731 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux all-clusters-app debug (read only) 2931153 2931153 0 0.0
(read/write) 188720 188720 0 0.0
.bss 95808 95808 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 84552 84552 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259325 259325 0 0.0
.text 2495890 2495890 0 0.0
all-clusters-minimal-app debug (read only) 2776713 2776713 0 0.0
(read/write) 180080 180080 0 0.0
.bss 94976 94976 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 76936 76936 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259741 259741 0 0.0
.text 2343570 2343570 0 0.0
bridge-app debug+rpc (read only) 2258121 2258121 0 0.0
(read/write) 158976 158976 0 0.0
.bss 83008 83008 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 66344 66344 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 193120 193120 0 0.0
.text 1904658 1904658 0 0.0
chip-tool debug (read only) 9821557 9821557 0 0.0
(read/write) 623688 623688 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590856 590856 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508469 508469 0 0.0
.text 7872149 7872149 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9580956 9580956 0 0.0
(read/write) 690049 690049 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626288 626288 0 0.0
.dynamic 528 528 0 0.0
.got 15104 15104 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470924 470924 0 0.0
.text 7533428 7533428 0 0.0
lighting-app debug+rpc (read only) 2513449 2513449 0 0.0
(read/write) 164088 164088 0 0.0
.bss 84608 84608 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 71496 71496 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 208968 208968 0 0.0
.text 2135522 2135522 0 0.0
lock-app debug (read only) 2452057 2452057 0 0.0
(read/write) 158680 158680 0 0.0
.bss 82976 82976 0 0.0
.data 1648 1648 0 0.0
.data.rel.ro 68184 68184 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 222824 222824 0 0.0
.text 2065746 2065746 0 0.0
ota-provider-app debug (read only) 2289961 2289961 0 0.0
(read/write) 152784 152784 0 0.0
.bss 82624 82624 0 0.0
.data 1880 1880 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 198904 198904 0 0.0
.text 1929698 1929698 0 0.0
ota-requestor-app debug (read only) 2405705 2405705 0 0.0
(read/write) 159560 159560 0 0.0
.bss 84960 84960 0 0.0
.data 2168 2168 0 0.0
.data.rel.ro 66568 66568 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 202624 202624 0 0.0
.text 2033490 2033490 0 0.0
shell debug (read only) 2608505 2608505 0 0.0
(read/write) 219544 219544 0 0.0
.bss 134600 134600 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77800 77800 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230226 230226 0 0.0
.text 2218770 2218770 0 0.0
thermostat-no-ble arm64 (read only) 2564852 2564852 0 0.0
(read/write) 191617 191617 0 0.0
.bss 99409 99409 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162668 162668 0 0.0
.text 2164224 2164224 0 0.0
tv-app debug (read only) 3061473 3061473 0 0.0
(read/write) 290088 290088 0 0.0
.bss 200232 200232 0 0.0
.data 4784 4784 0 0.0
.data.rel.ro 78624 78624 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 244640 244640 0 0.0
.text 2630690 2630690 0 0.0
tv-casting-app debug (read only) 5359745 5359745 0 0.0
(read/write) 232536 232536 0 0.0
.bss 88104 88104 0 0.0
.data 2576 2576 0 0.0
.data.rel.ro 135624 135624 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 344448 344448 0 0.0
.text 4663666 4663666 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199111 0 0.0
bss 141633 141633 0 0.0
rodata 156128 156128 0 0.0
text 822412 822412 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144347 0 0.0
bss 140824 140824 0 0.0
rodata 131860 131860 0 0.0
text 792752 792756 4 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1157767 1157595 -172 -0.0
bss 144181 144181 0 0.0
rodata 122384 122340 -44 -0.0
text 812304 812172 -132 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1126991 1126803 -188 -0.0
bss 144626 144626 0 0.0
rodata 114136 114092 -44 -0.0
text 788956 788824 -132 -0.0
nrf52840dongle_nrf52840 (read/write) 1064819 1064631 -188 -0.0
bss 151412 151412 0 0.0
rodata 91532 91488 -44 -0.0
text 740820 740688 -132 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061474 1061306 -168 -0.0
bss 140552 140552 0 0.0
rodata 114792 114752 -40 -0.0
text 725036 724908 -128 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1109559 1109735 176 0.0
bss 134109 134109 0 0.0
rodata 138984 138984 0 0.0
text 757680 757852 172 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1013518 1013694 176 0.0
bss 130512 130512 0 0.0
rodata 131452 131452 0 0.0
text 670472 670648 176 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1070595 1070595 0 0.0
bss 134076 134076 0 0.0
rodata 115724 115724 0 0.0
text 741908 741908 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1063351 1063351 0 0.0
bss 133869 133869 0 0.0
rodata 114624 114624 0 0.0
text 736048 736048 0 0.0
p6 all-clusters-app default (read/write) 2552984 2552984 0 0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511248 1511248 0 0.0
all-clusters-minimal-app default (read/write) 2495472 2495472 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1453736 1453736 0 0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787848 787848 0 0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557714 557714 0 0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574402 574404 2 0.0

Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

There are two issues with the nrfconnect door lock:
* It has auto-relock-time value set to 60, while it should be 0
* It emits Lock Operation event on init, while no operation
was done.

* Set auto relock time to 0
* Added invoking lock/unlock operation only if lock state is not
null (uninitialized)
* By the way of this change aligned lighting app extended discovery
timeout to other nrfconnect examples
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

PR #19562: Size comparison from 09f3e4a to 0dca5fb

Increases (4 builds for cc13x2_26x2, cyw30739, nrfconnect)
platform target config section 09f3e4a 0dca5fb change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 181492 181500 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 608174 608182 8 0.0
.app_xip_area 464720 464728 8 0.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1108499 1108643 144 0.0
text 757612 757764 152 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012426 1012586 160 0.0
text 670404 670556 152 0.0
Decreases (8 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section 09f3e4a 0dca5fb change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 660443 660435 -8 -0.0
.text 575028 575020 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614274 614266 -8 -0.0
.app_xip_area 471884 471876 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1156707 1156535 -172 -0.0
rodata 122412 122368 -44 -0.0
text 812236 812104 -132 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1125915 1125743 -172 -0.0
rodata 114164 114120 -44 -0.0
text 788888 788756 -132 -0.0
nrf52840dongle_nrf52840 (read/write) 1063743 1063571 -172 -0.0
rodata 91560 91516 -44 -0.0
text 740752 740620 -132 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060382 1060214 -168 -0.0
rodata 114820 114780 -40 -0.0
text 724968 724840 -128 -0.0
pump-controller-app nrf52840dk_nrf52840 text 735980 735976 -4 -0.0
telink light-switch-app tlsr9518adk80d text 557630 557628 -2 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 09f3e4a 0dca5fb change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657531 657531 0 0.0
(read/write) 193284 193284 0 0.0
.bss 73708 73708 0 0.0
.data 3380 3380 0 0.0
.rodata 86883 86883 0 0.0
.text 570336 570336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646063 646063 0 0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90191 90191 0 0.0
.text 555552 555552 0 0.0
lock-ftd LP_CC2652R7 (read only) 688495 688495 0 0.0
(read/write) 152424 152424 0 0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589100 589100 0 0.0
lock-mtd LP_CC2652R7 (read only) 637903 637903 0 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538620 538620 0 0.0
pump-app LP_CC2652R7 (read only) 669719 669719 0 0.0
(read/write) 172088 172088 0 0.0
.bss 70820 70820 0 0.0
.data 3316 3316 0 0.0
.rodata 87007 87007 0 0.0
.text 582228 582228 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660443 660435 -8 -0.0
(read/write) 181492 181500 8 0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575028 575020 -8 -0.0
shell LP_CC2652R7 (read only) 686890 686890 0 0.0
(read/write) 159420 159420 0 0.0
.bss 76004 76004 0 0.0
.data 3384 3384 0 0.0
.rodata 109442 109442 0 0.0
.text 577136 577136 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611090 611090 0 0.0
.app_xip_area 467780 467780 0 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608174 608182 8 0.0
.app_xip_area 464720 464728 8 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614274 614266 -8 -0.0
.app_xip_area 471884 471876 -8 -0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920548 920548 0 0.0
(read/write) 132396 132396 0 0.0
.bss 130280 130280 0 0.0
.data 2116 2116 0 0.0
.text 920540 920540 0 0.0
BRD4161A+rpc (read only) 956188 956188 0 0.0
(read/write) 149272 149272 0 0.0
.bss 146952 146952 0 0.0
.data 2320 2320 0 0.0
.text 956180 956180 0 0.0
BRD4161A+rs911x (read only) 795648 795648 0 0.0
(read/write) 128676 128676 0 0.0
.bss 126548 126548 0 0.0
.data 2124 2124 0 0.0
.text 795640 795640 0 0.0
lock-app BRD4161A+wf200 (read only) 963576 963576 0 0.0
(read/write) 129012 129012 0 0.0
.bss 126924 126924 0 0.0
.data 2088 2088 0 0.0
.text 963568 963568 0 0.0
window-app BRD4161A (read only) 905420 905420 0 0.0
(read/write) 132468 132468 0 0.0
.bss 130360 130360 0 0.0
.data 2108 2108 0 0.0
.text 905412 905412 0 0.0
k32w light k32w061+release (read/write) 657192 657192 0 0.0
.bss 68708 68708 0 0.0
.data 2028 2028 0 0.0
.text 580656 580656 0 0.0
lock k32w061+release (read/write) 718848 718848 0 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 641908 641908 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9513132 9513132 0 0.0
(read/write) 685601 685601 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623104 623104 0 0.0
.dynamic 528 528 0 0.0
.got 14904 14904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468156 468156 0 0.0
.text 7476692 7476692 0 0.0
thermostat-no-ble arm64 (read only) 2563180 2563180 0 0.0
(read/write) 191505 191505 0 0.0
.bss 99361 99361 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82416 82416 0 0.0
.dynamic 528 528 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162828 162828 0 0.0
.text 2162592 2162592 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434912 2434912 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397556 1397556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196567 1196567 0 0.0
bss 141554 141554 0 0.0
rodata 155456 155456 0 0.0
text 820700 820700 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144615 1144615 0 0.0
bss 140794 140794 0 0.0
rodata 131984 131984 0 0.0
text 793020 793020 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156707 1156535 -172 -0.0
bss 143125 143125 0 0.0
rodata 122412 122368 -44 -0.0
text 812236 812104 -132 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1125915 1125743 -172 -0.0
bss 143570 143570 0 0.0
rodata 114164 114120 -44 -0.0
text 788888 788756 -132 -0.0
nrf52840dongle_nrf52840 (read/write) 1063743 1063571 -172 -0.0
bss 150356 150356 0 0.0
rodata 91560 91516 -44 -0.0
text 740752 740620 -132 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060382 1060214 -168 -0.0
bss 139496 139496 0 0.0
rodata 114820 114780 -40 -0.0
text 724968 724840 -128 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1108499 1108643 144 0.0
bss 133053 133053 0 0.0
rodata 139012 139012 0 0.0
text 757612 757764 152 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012426 1012586 160 0.0
bss 129456 129456 0 0.0
rodata 131480 131480 0 0.0
text 670404 670556 152 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1069535 1069535 0 0.0
bss 133020 133020 0 0.0
rodata 115752 115752 0 0.0
text 741844 741844 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062291 1062291 0 0.0
bss 132813 132813 0 0.0
rodata 114652 114652 0 0.0
text 735980 735976 -4 -0.0
p6 all-clusters-app default (read/write) 2549968 2549968 0 0.0
.bss 143344 143344 0 0.0
.data 2800 2800 0 0.0
.text 1508232 1508232 0 0.0
all-clusters-minimal-app default (read/write) 2495912 2495912 0 0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454176 1454176 0 0.0
light-app default (read/write) 2426776 2426776 0 0.0
.bss 134688 134688 0 0.0
.data 2624 2624 0 0.0
.text 1385040 1385040 0 0.0
lock-app default (read/write) 2447192 2447192 0 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405456 1405456 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786732 0 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557630 557628 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 806720 806720 0 0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574322 574322 0 0.0

@Damian-Nordic Damian-Nordic merged commit b6954c0 into project-chip:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants