-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added handling Identify TriggerEffect command #19522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All-clusters-app for nrfconnect doesn't support handling TriggerEffect command, despite it is enabled in the .zap configuration. Added method that handles TriggerEffect callback.
Damian-Nordic
approved these changes
Jun 13, 2022
PR #19522: Size comparison from c1e1d01 to 82517ee Increases (5 builds for efr32, esp32, nrfconnect, telink)
Decreases (2 builds for cyw30739, nrfconnect)
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All-clusters-app for nrfconnect doesn't support handling TriggerEffect command, despite it is enabled in the .zap
configuration.
Change overview
Added method that handles TriggerEffect callback.
Testing
Tested manually following the procedure from: #19419.
Fixes: #19419