Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS TvCasting app: Implemented commissioner discovery and UDC requests #19491

Merged
merged 2 commits into from
Jun 15, 2022
Merged

iOS TvCasting app: Implemented commissioner discovery and UDC requests #19491

merged 2 commits into from
Jun 15, 2022

Conversation

sharadb-amazon
Copy link
Contributor

@sharadb-amazon sharadb-amazon commented Jun 11, 2022 •
edited
Loading

Problem

The iOS TvCasting app does not support commissioner discovery or sending User directed commissioning requests. This PR addresses #14561 and #14560

Change overview

  1. New SwiftUI views and their respective view models for CommissionerDiscovery and Commissioning flows.
  2. New methods in CastingServerBridge.h/mm to discover commissioners and send UDC requests that talk to CastingServer.cpp (in libTvCastingCommon.a). + CHIP app server initialization in CastingServerBridge.init()
  3. Updates to build scripts so that tv-casting-common/CHIPProjectAppConfig.h overrides are picked up. Note the subsequent edit to config/ios/CHIPProjectConfig.h

TBD: call to openBasicCommissioningWindow or show Onboarding payload will be added in future PR.

Testing

  • Tested on the iPhone simulator in Xcode against a tv-app running on a RasPi and verified that the TV commissioner is discovered and shown to the user.
  • The user is able to click the button for the discovered commissioner and a UDC request is sent out from the iOS TvCasting app.
  • Screenshots below:

@github-actions
Copy link

github-actions bot commented Jun 11, 2022 •
edited
Loading

PR #19491: Size comparison from d1d5ca8 to ceea1a8

Increases (3 builds for cyw30739, nrfconnect, telink)
platform target config section d1d5ca8 ceea1a81 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606570 8 0.0
.app_xip_area 465068 465076 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 819936 819940 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786804 8 0.0
text 556712 556716 4 0.0
Decreases (2 builds for esp32, nrfconnect)
platform target config section d1d5ca8 ceea1a81 change % change
esp32 all-clusters-app c3devkit (read only) 1011026 1011022 -4 -0.0
.flash.text 1011026 1011022 -4 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 792020 792016 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1d5ca8 ceea1a81 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656351 656351 0 0.0
(read/write) 194536 194536 0 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 86527 86527 0 0.0
.text 569512 569512 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644851 644851 0 0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554496 554496 0 0.0
lock-ftd LP_CC2652R7 (read only) 687715 687715 0 0.0
(read/write) 154244 154244 0 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588372 588372 0 0.0
lock-mtd LP_CC2652R7 (read only) 637115 637115 0 0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537884 0 0.0
pump-app LP_CC2652R7 (read only) 669075 669075 0 0.0
(read/write) 173796 173796 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581612 581612 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659655 0 0.0
(read/write) 183320 183320 0 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574292 0 0.0
shell LP_CC2652R7 (read only) 686478 686478 0 0.0
(read/write) 159904 159904 0 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 109598 109598 0 0.0
.text 576568 576568 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606570 8 0.0
.app_xip_area 465068 465076 8 0.0
.bss 84424 84424 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603670 603670 0 0.0
.app_xip_area 462032 462032 0 0.0
.bss 84600 84600 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611390 0 0.0
.app_xip_area 470824 470824 0 0.0
.bss 83608 83608 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919312 919312 0 0.0
(read/write) 133432 133432 0 0.0
.bss 131320 131320 0 0.0
.data 2112 2112 0 0.0
.text 919304 919304 0 0.0
BRD4161A+rpc (read only) 953492 953492 0 0.0
(read/write) 150124 150124 0 0.0
.bss 147808 147808 0 0.0
.data 2316 2316 0 0.0
.text 953484 953484 0 0.0
BRD4161A+rs911x (read only) 794396 794396 0 0.0
(read/write) 129716 129716 0 0.0
.bss 127596 127596 0 0.0
.data 2120 2120 0 0.0
.text 794388 794388 0 0.0
lock-app BRD4161A+wf200 (read only) 962700 962700 0 0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962692 962692 0 0.0
window-app BRD4161A (read only) 904368 904368 0 0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904360 904360 0 0.0
esp32 all-clusters-app c3devkit (read only) 1011026 1011022 -4 -0.0
(read/write) 1482794 1482794 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213240 213240 0 0.0
.flash.text 1011026 1011022 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065471 1065471 0 0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243740 243740 0 0.0
.flash.text 1060087 1060087 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657304 657304 0 0.0
.bss 69740 69740 0 0.0
.data 2028 2028 0 0.0
.text 579736 579736 0 0.0
lock k32w061+release (read/write) 718916 718916 0 0.0
.bss 70172 70172 0 0.0
.data 2000 2000 0 0.0
.text 640944 640944 0 0.0
linux all-clusters-app debug (read only) 2919449 2919449 0 0.0
(read/write) 188560 188560 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84520 84520 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258269 258269 0 0.0
.text 2485554 2485554 0 0.0
all-clusters-minimal-app debug (read only) 2769785 2769785 0 0.0
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337986 2337986 0 0.0
bridge-app debug+rpc (read only) 2248145 2248145 0 0.0
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1897058 1897058 0 0.0
chip-tool debug (read only) 9816789 9816789 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7869301 7869301 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9564452 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519604 7519604 0 0.0
lighting-app debug+rpc (read only) 2498073 2498073 0 0.0
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122706 2122706 0 0.0
lock-app debug (read only) 2444073 2444073 0 0.0
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059618 2059618 0 0.0
ota-provider-app debug (read only) 2282321 2282321 0 0.0
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923730 1923730 0 0.0
ota-requestor-app debug (read only) 2329849 2329849 0 0.0
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1965266 1965266 0 0.0
shell debug (read only) 2600209 2600209 0 0.0
(read/write) 219416 219416 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2211074 2211074 0 0.0
thermostat-no-ble arm64 (read only) 2558364 2558364 0 0.0
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2159376 2159376 0 0.0
tv-app debug (read only) 3051705 3051705 0 0.0
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2623138 2623138 0 0.0
tv-casting-app debug (read only) 5350793 5350793 0 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4657090 4657090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195819 1195819 0 0.0
bss 141591 141591 0 0.0
rodata 155316 155316 0 0.0
text 819936 819940 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143579 1143579 0 0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 792020 792016 -4 -0.0
p6 all-clusters-app default (read/write) 2549376 2549376 0 0.0
.bss 143416 143416 0 0.0
.data 2832 2832 0 0.0
.text 1507640 1507640 0 0.0
all-clusters-minimal-app default (read/write) 2494176 2494176 0 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452440 1452440 0 0.0
light-app default (read/write) 2425608 2425608 0 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383872 1383872 0 0.0
lock-app default (read/write) 2446016 2446016 0 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404280 1404280 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786804 8 0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556712 556716 4 0.0
lighting-app tlsr9518adk80d (read/write) 806808 806808 0 0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573428 573428 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

PR #19491: Size comparison from b006bab to 188406b

Increases (2 builds for nrfconnect, telink)
platform target config section b006bab 188406b change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 792752 792756 4 0.0
telink lighting-app tlsr9518adk80d text 574402 574406 4 0.0
Decreases (1 build for telink)
platform target config section b006bab 188406b change % change
telink light-switch-app tlsr9518adk80d (read/write) 787848 787840 -8 -0.0
text 557714 557712 -2 -0.0
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b006bab 188406b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 659119 0 0.0
(read/write) 191784 191784 0 0.0
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87047 87047 0 0.0
.text 571760 571760 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645667 0 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90067 90067 0 0.0
.text 555280 555280 0 0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637947 637947 0 0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538692 538692 0 0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689270 689270 0 0.0
(read/write) 157128 157128 0 0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110126 110126 0 0.0
.text 578832 578832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 609318 0 0.0
.app_xip_area 464808 464808 0 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133528 0 0.0
.bss 131416 131416 0 0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux all-clusters-app debug (read only) 2931153 2931153 0 0.0
(read/write) 188720 188720 0 0.0
.bss 95808 95808 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 84552 84552 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259325 259325 0 0.0
.text 2495890 2495890 0 0.0
all-clusters-minimal-app debug (read only) 2776713 2776713 0 0.0
(read/write) 180080 180080 0 0.0
.bss 94976 94976 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 76936 76936 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259741 259741 0 0.0
.text 2343570 2343570 0 0.0
bridge-app debug+rpc (read only) 2258121 2258121 0 0.0
(read/write) 158976 158976 0 0.0
.bss 83008 83008 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 66344 66344 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 193120 193120 0 0.0
.text 1904658 1904658 0 0.0
chip-tool debug (read only) 9821557 9821557 0 0.0
(read/write) 623688 623688 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590856 590856 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508469 508469 0 0.0
.text 7872149 7872149 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9580956 9580956 0 0.0
(read/write) 690049 690049 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626288 626288 0 0.0
.dynamic 528 528 0 0.0
.got 15104 15104 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470924 470924 0 0.0
.text 7533428 7533428 0 0.0
lighting-app debug+rpc (read only) 2513449 2513449 0 0.0
(read/write) 164088 164088 0 0.0
.bss 84608 84608 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 71496 71496 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 208968 208968 0 0.0
.text 2135522 2135522 0 0.0
lock-app debug (read only) 2452057 2452057 0 0.0
(read/write) 158680 158680 0 0.0
.bss 82976 82976 0 0.0
.data 1648 1648 0 0.0
.data.rel.ro 68184 68184 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 222824 222824 0 0.0
.text 2065746 2065746 0 0.0
ota-provider-app debug (read only) 2289961 2289961 0 0.0
(read/write) 152784 152784 0 0.0
.bss 82624 82624 0 0.0
.data 1880 1880 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 198904 198904 0 0.0
.text 1929698 1929698 0 0.0
ota-requestor-app debug (read only) 2405705 2405705 0 0.0
(read/write) 159560 159560 0 0.0
.bss 84960 84960 0 0.0
.data 2168 2168 0 0.0
.data.rel.ro 66568 66568 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 202624 202624 0 0.0
.text 2033490 2033490 0 0.0
shell debug (read only) 2608505 2608505 0 0.0
(read/write) 219544 219544 0 0.0
.bss 134600 134600 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77800 77800 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230226 230226 0 0.0
.text 2218770 2218770 0 0.0
thermostat-no-ble arm64 (read only) 2564852 2564852 0 0.0
(read/write) 191617 191617 0 0.0
.bss 99409 99409 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162668 162668 0 0.0
.text 2164224 2164224 0 0.0
tv-app debug (read only) 3061473 3061473 0 0.0
(read/write) 290088 290088 0 0.0
.bss 200232 200232 0 0.0
.data 4784 4784 0 0.0
.data.rel.ro 78624 78624 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 244640 244640 0 0.0
.text 2630690 2630690 0 0.0
tv-casting-app debug (read only) 5359745 5359745 0 0.0
(read/write) 232536 232536 0 0.0
.bss 88104 88104 0 0.0
.data 2576 2576 0 0.0
.data.rel.ro 135624 135624 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 344448 344448 0 0.0
.text 4663666 4663666 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1199111 0 0.0
bss 141633 141633 0 0.0
rodata 156128 156128 0 0.0
text 822412 822412 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144347 0 0.0
bss 140824 140824 0 0.0
rodata 131860 131860 0 0.0
text 792752 792756 4 0.0
p6 all-clusters-app default (read/write) 2552984 2552984 0 0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511248 1511248 0 0.0
all-clusters-minimal-app default (read/write) 2495472 2495472 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1453736 1453736 0 0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787848 787840 -8 -0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557714 557712 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574402 574406 4 0.0

@sharadb-amazon
Addressing review comments, adding Discover button to Commissioner Di…
b84bab9 
…scovery UI, using optional Bools to denote the state of the CommissioningView
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

PR #19491: Size comparison from f961ae1 to b84bab9

Increases (2 builds for cc13x2_26x2, telink)
platform target config section f961ae1 b84bab9 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
.text 538684 538692 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 787848 8 0.0
text 557710 557714 4 0.0
Decreases (2 builds for esp32, telink)
platform target config section f961ae1 b84bab9 change % change
esp32 all-clusters-app c3devkit (read only) 1014178 1014176 -2 -0.0
.flash.text 1014178 1014176 -2 -0.0
telink lighting-app tlsr9518adk80d text 574406 574404 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f961ae1 b84bab9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659551 659551 0 0.0
(read/write) 191352 191352 0 0.0
.bss 73796 73796 0 0.0
.data 3416 3416 0 0.0
.rodata 87143 87143 0 0.0
.text 572096 572096 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646099 646099 0 0.0
(read/write) 157292 157292 0 0.0
.bss 73020 73020 0 0.0
.data 3356 3356 0 0.0
.rodata 90163 90163 0 0.0
.text 555616 555616 0 0.0
lock-ftd LP_CC2652R7 (read only) 688531 688531 0 0.0
(read/write) 153444 153444 0 0.0
.bss 71756 71756 0 0.0
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589164 0 0.0
lock-mtd LP_CC2652R7 (read only) 637939 637947 8 0.0
(read/write) 144888 144888 0 0.0
.bss 67492 67492 0 0.0
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538684 538692 8 0.0
pump-app LP_CC2652R7 (read only) 669747 669747 0 0.0
(read/write) 173124 173124 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660471 0 0.0
(read/write) 182520 182520 0 0.0
.bss 72004 72004 0 0.0
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575084 0 0.0
shell LP_CC2652R7 (read only) 689702 689702 0 0.0
(read/write) 156696 156696 0 0.0
.bss 76092 76092 0 0.0
.data 3420 3420 0 0.0
.rodata 110222 110222 0 0.0
.text 579168 579168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612202 612202 0 0.0
.app_xip_area 467836 467836 0 0.0
.bss 87288 87288 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 609318 0 0.0
.app_xip_area 464808 464808 0 0.0
.bss 87464 87464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 615382 0 0.0
.app_xip_area 471928 471928 0 0.0
.bss 86464 86464 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920584 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131336 131336 0 0.0
.data 2116 2116 0 0.0
.text 920576 920576 0 0.0
BRD4161A+rpc (read only) 956240 956240 0 0.0
(read/write) 150328 150328 0 0.0
.bss 148008 148008 0 0.0
.data 2320 2320 0 0.0
.text 956232 956232 0 0.0
BRD4161A+rs911x (read only) 795700 795700 0 0.0
(read/write) 129736 129736 0 0.0
.bss 127612 127612 0 0.0
.data 2124 2124 0 0.0
.text 795692 795692 0 0.0
lock-app BRD4161A+wf200 (read only) 963596 963596 0 0.0
(read/write) 130076 130076 0 0.0
.bss 127988 127988 0 0.0
.data 2088 2088 0 0.0
.text 963588 963588 0 0.0
window-app BRD4161A (read only) 905472 905472 0 0.0
(read/write) 133528 133528 0 0.0
.bss 131416 131416 0 0.0
.data 2108 2108 0 0.0
.text 905464 905464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014178 1014176 -2 -0.0
(read/write) 1483618 1483618 0 0.0
.dram0.bss 69424 69424 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014178 1014176 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068395 1068395 0 0.0
(read/write) 485712 485712 0 0.0
.dram0.bss 74952 74952 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 244540 244540 0 0.0
.flash.text 1063011 1063011 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 658328 0 0.0
.bss 69764 69764 0 0.0
.data 2028 2028 0 0.0
.text 580736 580736 0 0.0
lock k32w061+release (read/write) 719940 719940 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 641944 641944 0 0.0
linux all-clusters-app debug (read only) 2931153 2931153 0 0.0
(read/write) 188720 188720 0 0.0
.bss 95808 95808 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 84552 84552 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259325 259325 0 0.0
.text 2495890 2495890 0 0.0
all-clusters-minimal-app debug (read only) 2776713 2776713 0 0.0
(read/write) 180080 180080 0 0.0
.bss 94976 94976 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 76936 76936 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 259741 259741 0 0.0
.text 2343570 2343570 0 0.0
bridge-app debug+rpc (read only) 2258121 2258121 0 0.0
(read/write) 158976 158976 0 0.0
.bss 83008 83008 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 66344 66344 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 193120 193120 0 0.0
.text 1904658 1904658 0 0.0
chip-tool debug (read only) 9818421 9818421 0 0.0
(read/write) 623688 623688 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590856 590856 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508245 508245 0 0.0
.text 7869237 7869237 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9577772 9577772 0 0.0
(read/write) 690049 690049 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626288 626288 0 0.0
.dynamic 528 528 0 0.0
.got 15104 15104 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470700 470700 0 0.0
.text 7530468 7530468 0 0.0
lighting-app debug+rpc (read only) 2513449 2513449 0 0.0
(read/write) 164088 164088 0 0.0
.bss 84608 84608 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 71496 71496 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 208968 208968 0 0.0
.text 2135522 2135522 0 0.0
lock-app debug (read only) 2452057 2452057 0 0.0
(read/write) 158680 158680 0 0.0
.bss 82976 82976 0 0.0
.data 1648 1648 0 0.0
.data.rel.ro 68184 68184 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 222824 222824 0 0.0
.text 2065746 2065746 0 0.0
ota-provider-app debug (read only) 2289961 2289961 0 0.0
(read/write) 152784 152784 0 0.0
.bss 82624 82624 0 0.0
.data 1880 1880 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 198904 198904 0 0.0
.text 1929698 1929698 0 0.0
ota-requestor-app debug (read only) 2405705 2405705 0 0.0
(read/write) 159560 159560 0 0.0
.bss 84960 84960 0 0.0
.data 2168 2168 0 0.0
.data.rel.ro 66568 66568 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 202624 202624 0 0.0
.text 2033490 2033490 0 0.0
shell debug (read only) 2608505 2608505 0 0.0
(read/write) 219544 219544 0 0.0
.bss 134600 134600 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77800 77800 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230226 230226 0 0.0
.text 2218770 2218770 0 0.0
thermostat-no-ble arm64 (read only) 2564868 2564868 0 0.0
(read/write) 191617 191617 0 0.0
.bss 99409 99409 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162668 162668 0 0.0
.text 2164240 2164240 0 0.0
tv-app debug (read only) 3061473 3061473 0 0.0
(read/write) 290088 290088 0 0.0
.bss 200232 200232 0 0.0
.data 4784 4784 0 0.0
.data.rel.ro 78624 78624 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 244640 244640 0 0.0
.text 2630690 2630690 0 0.0
tv-casting-app debug (read only) 5359745 5359745 0 0.0
(read/write) 232536 232536 0 0.0
.bss 88104 88104 0 0.0
.data 2576 2576 0 0.0
.data.rel.ro 135624 135624 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 344448 344448 0 0.0
.text 4663666 4663666 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434816 0 0.0
.bss 209212 209212 0 0.0
.data 5864 5864 0 0.0
.text 1397460 1397460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199543 1199543 0 0.0
bss 141633 141633 0 0.0
rodata 156224 156224 0 0.0
text 822744 822744 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144779 1144779 0 0.0
bss 140824 140824 0 0.0
rodata 131956 131956 0 0.0
text 793088 793088 0 0.0
p6 all-clusters-app default (read/write) 2553480 2553480 0 0.0
.bss 143424 143424 0 0.0
.data 2832 2832 0 0.0
.text 1511744 1511744 0 0.0
all-clusters-minimal-app default (read/write) 2495968 2495968 0 0.0
.bss 142640 142640 0 0.0
.data 2776 2776 0 0.0
.text 1454232 1454232 0 0.0
light-app default (read/write) 2426848 2426848 0 0.0
.bss 135752 135752 0 0.0
.data 2624 2624 0 0.0
.text 1385112 1385112 0 0.0
lock-app default (read/write) 2447256 2447256 0 0.0
.bss 135576 135576 0 0.0
.data 2600 2600 0 0.0
.text 1405520 1405520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 787848 8 0.0
bss 70892 70892 0 0.0
noinit 40416 40416 0 0.0
text 557710 557714 4 0.0
lighting-app tlsr9518adk80d (read/write) 807828 807828 0 0.0
bss 71144 71144 0 0.0
noinit 40416 40416 0 0.0
text 574406 574404 -2 -0.0

@chrisdecenzo chrisdecenzo merged commit 2d440f0 into project-chip:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
config examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharadb-amazon @chrisdecenzo @bzbarsky-apple