Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OnOff cmd OffWithEffect action order #19483

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix OnOff cmd OffWithEffect action order #19483

merged 1 commit into from
Jun 13, 2022

Conversation

jmartinez-silabs
Copy link
Member

Problem

fixes #15991

Change overview

  • Call the OffEffect callback before setting the attribute OnOff to false
  • Basic application implementation that can deal with executing the off effect as a demo of how it can be done. (efr32 dev board currently does not handle dimming of the physical led)

Testing

Build and commission the lighting app on efr32
send chip-tool onoff off-with-effect <0|1> <0|1|2> <node> 1

@jmartinez-silabs
call the OffEffect callback before setting the attribut OnOff to fals…
e3d59fe 
…e. Basic application implementation that can deal with executing the off effect

Change action actor to timer. Fix when cancelling offeffect when we on is received during offeffect
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19483: Size comparison from d1d5ca8 to e3d59fe

Increases (6 builds for cc13x2_26x2, efr32, telink)
platform target config section d1d5ca8 e3d59fe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 194536 194552 16 0.0
shell LP_CC2652R7 (read/write) 159904 159920 16 0.0
efr32 lighting-app BRD4161A (read only) 919312 919480 168 0.0
(read/write) 133432 133440 8 0.0
.data 2112 2116 4 0.2
.text 919304 919472 168 0.0
BRD4161A+rpc (read only) 953492 953652 160 0.0
(read/write) 150124 150128 4 0.0
.data 2316 2320 4 0.2
.text 953484 953644 160 0.0
BRD4161A+rs911x (read only) 794396 794556 160 0.0
(read/write) 129716 129720 4 0.0
.data 2120 2124 4 0.2
.text 794388 794548 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786804 8 0.0
text 556712 556714 2 0.0
Decreases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section d1d5ca8 e3d59fe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656351 656335 -16 -0.0
.text 569512 569496 -16 -0.0
shell LP_CC2652R7 (read only) 686478 686462 -16 -0.0
.text 576568 576552 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606554 -8 -0.0
.app_xip_area 465068 465060 -8 -0.0
lock cyw930739m2evb_01 (read/write) 603670 603662 -8 -0.0
.app_xip_area 462032 462024 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611382 -8 -0.0
.app_xip_area 470824 470816 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read only) 962700 962684 -16 -0.0
.text 962692 962676 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1011026 1011002 -24 -0.0
.flash.text 1011026 1011002 -24 -0.0
m5stack (read only) 1065471 1065459 -12 -0.0
.flash.text 1060087 1060075 -12 -0.0
k32w light k32w061+release (read/write) 657304 657288 -16 -0.0
.text 579736 579720 -16 -0.0
linux all-clusters-app debug (read only) 2919449 2919417 -32 -0.0
.text 2485554 2485522 -32 -0.0
lighting-app debug+rpc (read only) 2498073 2498041 -32 -0.0
.text 2122706 2122674 -32 -0.0
shell debug (read only) 2600209 2600177 -32 -0.0
.text 2211074 2211042 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 819936 819928 -8 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 792020 792016 -4 -0.0
p6 all-clusters-app default (read/write) 2549376 2549360 -16 -0.0
.text 1507640 1507624 -16 -0.0
light-app default (read/write) 2425608 2425592 -16 -0.0
.text 1383872 1383856 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 806808 806784 -24 -0.0
text 573428 573404 -24 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1d5ca8 e3d59fe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656351 656335 -16 -0.0
(read/write) 194536 194552 16 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 86527 86527 0 0.0
.text 569512 569496 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644851 644851 0 0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554496 554496 0 0.0
lock-ftd LP_CC2652R7 (read only) 687715 687715 0 0.0
(read/write) 154244 154244 0 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588372 588372 0 0.0
lock-mtd LP_CC2652R7 (read only) 637115 637115 0 0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537884 0 0.0
pump-app LP_CC2652R7 (read only) 669075 669075 0 0.0
(read/write) 173796 173796 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581612 581612 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659655 0 0.0
(read/write) 183320 183320 0 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574292 0 0.0
shell LP_CC2652R7 (read only) 686478 686462 -16 -0.0
(read/write) 159904 159920 16 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 109598 109598 0 0.0
.text 576568 576552 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606554 -8 -0.0
.app_xip_area 465068 465060 -8 -0.0
.bss 84424 84424 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603670 603662 -8 -0.0
.app_xip_area 462032 462024 -8 -0.0
.bss 84600 84600 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611382 -8 -0.0
.app_xip_area 470824 470816 -8 -0.0
.bss 83608 83608 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919312 919480 168 0.0
(read/write) 133432 133440 8 0.0
.bss 131320 131320 0 0.0
.data 2112 2116 4 0.2
.text 919304 919472 168 0.0
BRD4161A+rpc (read only) 953492 953652 160 0.0
(read/write) 150124 150128 4 0.0
.bss 147808 147808 0 0.0
.data 2316 2320 4 0.2
.text 953484 953644 160 0.0
BRD4161A+rs911x (read only) 794396 794556 160 0.0
(read/write) 129716 129720 4 0.0
.bss 127596 127596 0 0.0
.data 2120 2124 4 0.2
.text 794388 794548 160 0.0
lock-app BRD4161A+wf200 (read only) 962700 962684 -16 -0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962692 962676 -16 -0.0
window-app BRD4161A (read only) 904368 904368 0 0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904360 904360 0 0.0
esp32 all-clusters-app c3devkit (read only) 1011026 1011002 -24 -0.0
(read/write) 1482794 1482794 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213240 213240 0 0.0
.flash.text 1011026 1011002 -24 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065471 1065459 -12 -0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243740 243740 0 0.0
.flash.text 1060087 1060075 -12 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657304 657288 -16 -0.0
.bss 69740 69740 0 0.0
.data 2028 2028 0 0.0
.text 579736 579720 -16 -0.0
lock k32w061+release (read/write) 718916 718916 0 0.0
.bss 70172 70172 0 0.0
.data 2000 2000 0 0.0
.text 640944 640944 0 0.0
linux all-clusters-app debug (read only) 2919449 2919417 -32 -0.0
(read/write) 188560 188560 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84520 84520 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258269 258269 0 0.0
.text 2485554 2485522 -32 -0.0
all-clusters-minimal-app debug (read only) 2769785 2769785 0 0.0
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337986 2337986 0 0.0
bridge-app debug+rpc (read only) 2248145 2248145 0 0.0
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1897058 1897058 0 0.0
chip-tool debug (read only) 9816789 9816789 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7869301 7869301 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9564452 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519604 7519604 0 0.0
lighting-app debug+rpc (read only) 2498073 2498041 -32 -0.0
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122706 2122674 -32 -0.0
lock-app debug (read only) 2444073 2444073 0 0.0
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059618 2059618 0 0.0
ota-provider-app debug (read only) 2282321 2282321 0 0.0
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923730 1923730 0 0.0
ota-requestor-app debug (read only) 2329849 2329849 0 0.0
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1965266 1965266 0 0.0
shell debug (read only) 2600209 2600177 -32 -0.0
(read/write) 219416 219416 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2211074 2211042 -32 -0.0
thermostat-no-ble arm64 (read only) 2558364 2558364 0 0.0
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2159376 2159376 0 0.0
tv-app debug (read only) 3051705 3051705 0 0.0
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2623138 2623138 0 0.0
tv-casting-app debug (read only) 5350793 5350793 0 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4657090 4657090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195819 1195819 0 0.0
bss 141591 141591 0 0.0
rodata 155316 155316 0 0.0
text 819936 819928 -8 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143579 1143579 0 0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 792020 792016 -4 -0.0
p6 all-clusters-app default (read/write) 2549376 2549360 -16 -0.0
.bss 143416 143416 0 0.0
.data 2832 2832 0 0.0
.text 1507640 1507624 -16 -0.0
all-clusters-minimal-app default (read/write) 2494176 2494176 0 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452440 1452440 0 0.0
light-app default (read/write) 2425608 2425592 -16 -0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383872 1383856 -16 -0.0
lock-app default (read/write) 2446016 2446016 0 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404280 1404280 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786804 8 0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556712 556714 2 0.0
lighting-app tlsr9518adk80d (read/write) 806808 806784 -24 -0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573428 573404 -24 -0.0

@andy31415 andy31415 merged commit edcf360 into project-chip:master Jun 13, 2022
@jmartinez-silabs jmartinez-silabs deleted the onoff_opt branch July 18, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On/Off Cluster: command order issue in cmd OffWithEffect
3 participants
@jmartinez-silabs @andy31415 @bzbarsky-apple