Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small doc editorial fixes after #19277 #19465

Merged
merged 4 commits into from
Jun 11, 2022
Merged

Small doc editorial fixes after #19277 #19465

merged 4 commits into from
Jun 11, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

During review of #19277, 3x small editorial comments came at last minute.
Decided to defer them to save round-trip time

Change overview

  • Fix some comments in method docs

Testing

Non-functional change

@tcarmelveilleux
Small doc editorial fixes after project-chip#19277
b955f3a 
- Leftover comments follow-up in method docs
@boring-cyborg boring-cyborg bot added the crypto label Jun 10, 2022
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19465: Size comparison from 7addc16 to 1b03ac8

Increases (1 build for nrfconnect)
platform target config section 7addc16 1b03ac8 change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 791904 791908 4 0.0
Decreases (1 build for telink)
platform target config section 7addc16 1b03ac8 change % change
telink light-switch-app tlsr9518adk80d text 556566 556564 -2 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7addc16 1b03ac8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606426 606426 0 0.0
.app_xip_area 464940 464940 0 0.0
.bss 84416 84416 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603526 603526 0 0.0
.app_xip_area 461896 461896 0 0.0
.bss 84592 84592 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611246 611246 0 0.0
.app_xip_area 470688 470688 0 0.0
.bss 83600 83600 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919184 919184 0 0.0
(read/write) 133424 133424 0 0.0
.bss 131312 131312 0 0.0
.data 2112 2112 0 0.0
.text 919176 919176 0 0.0
BRD4161A+rpc (read only) 953364 953364 0 0.0
(read/write) 150116 150116 0 0.0
.bss 147800 147800 0 0.0
.data 2316 2316 0 0.0
.text 953356 953356 0 0.0
BRD4161A+rs911x (read only) 794260 794260 0 0.0
(read/write) 129708 129708 0 0.0
.bss 127588 127588 0 0.0
.data 2120 2120 0 0.0
.text 794252 794252 0 0.0
lock-app BRD4161A+wf200 (read only) 962620 962620 0 0.0
(read/write) 130052 130052 0 0.0
.bss 127964 127964 0 0.0
.data 2088 2088 0 0.0
.text 962612 962612 0 0.0
window-app BRD4161A (read only) 904240 904240 0 0.0
(read/write) 133504 133504 0 0.0
.bss 131392 131392 0 0.0
.data 2108 2108 0 0.0
.text 904232 904232 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010890 1010890 0 0.0
(read/write) 1482754 1482754 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213216 213216 0 0.0
.flash.text 1010890 1010890 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065335 1065335 0 0.0
(read/write) 484864 484864 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243724 243724 0 0.0
.flash.text 1059951 1059951 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657216 657216 0 0.0
.bss 69732 69732 0 0.0
.data 2028 2028 0 0.0
.text 579656 579656 0 0.0
lock k32w061+release (read/write) 718804 718804 0 0.0
.bss 70164 70164 0 0.0
.data 2000 2000 0 0.0
.text 640840 640840 0 0.0
linux all-clusters-app debug (read only) 2907689 2907689 0 0.0
(read/write) 188240 188240 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84200 84200 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 257341 257341 0 0.0
.text 2475298 2475298 0 0.0
all-clusters-minimal-app debug (read only) 2769233 2769233 0 0.0
(read/write) 179856 179856 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76824 76824 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337506 2337506 0 0.0
bridge-app debug+rpc (read only) 2247593 2247593 0 0.0
(read/write) 158688 158688 0 0.0
.bss 82944 82944 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66200 66200 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1896578 1896578 0 0.0
chip-tool debug (read only) 9816357 9816357 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7868869 7868869 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563956 9563956 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519108 7519108 0 0.0
lighting-app debug+rpc (read only) 2497505 2497505 0 0.0
(read/write) 163384 163384 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71128 71128 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122210 2122210 0 0.0
lock-app debug (read only) 2443505 2443505 0 0.0
(read/write) 158456 158456 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68088 68088 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059122 2059122 0 0.0
ota-provider-app debug (read only) 2281753 2281753 0 0.0
(read/write) 152656 152656 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62424 62424 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923234 1923234 0 0.0
ota-requestor-app debug (read only) 2329281 2329281 0 0.0
(read/write) 155440 155440 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64344 64344 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1964770 1964770 0 0.0
shell debug (read only) 2599705 2599705 0 0.0
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77664 77664 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2210642 2210642 0 0.0
thermostat-no-ble arm64 (read only) 2557628 2557628 0 0.0
(read/write) 191329 191329 0 0.0
.bss 99361 99361 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82336 82336 0 0.0
.dynamic 528 528 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2158800 2158800 0 0.0
tv-app debug (read only) 3051137 3051137 0 0.0
(read/write) 289800 289800 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78472 78472 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2622642 2622642 0 0.0
tv-casting-app debug (read only) 5350289 5350289 0 0.0
(read/write) 232248 232248 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135472 135472 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4656658 4656658 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2433320 2433320 0 0.0
.bss 208980 208980 0 0.0
.data 5896 5896 0 0.0
.text 1395964 1395964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195687 1195687 0 0.0
bss 141583 141583 0 0.0
rodata 155296 155296 0 0.0
text 819828 819828 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143319 1143319 0 0.0
bss 140800 140800 0 0.0
rodata 131808 131808 0 0.0
text 791904 791908 4 0.0
p6 all-clusters-app default (read/write) 2549176 2549176 0 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1507440 1507440 0 0.0
all-clusters-minimal-app default (read/write) 2493976 2493976 0 0.0
.bss 142616 142616 0 0.0
.data 2776 2776 0 0.0
.text 1452240 1452240 0 0.0
light-app default (read/write) 2425368 2425368 0 0.0
.bss 135728 135728 0 0.0
.data 2624 2624 0 0.0
.text 1383632 1383632 0 0.0
lock-app default (read/write) 2445760 2445760 0 0.0
.bss 135552 135552 0 0.0
.data 2600 2600 0 0.0
.text 1404024 1404024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786616 786616 0 0.0
bss 70860 70860 0 0.0
noinit 40416 40416 0 0.0
text 556566 556564 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 806636 806636 0 0.0
bss 71120 71120 0 0.0
noinit 40416 40416 0 0.0
text 573282 573282 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19465: Size comparison from 287e47a to 9e2483b

Increases (1 build for k32w)
platform target config section 287e47a 9e2483b change % change
k32w light k32w061+release (read/write) 657232 657248 16 0.0
.text 579672 579688 16 0.0
Decreases (2 builds for nrfconnect, telink)
platform target config section 287e47a 9e2483b change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 819852 819848 -4 -0.0
telink lighting-app tlsr9518adk80d text 573320 573318 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 287e47a 9e2483b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656295 656295 0 0.0
(read/write) 194584 194584 0 0.0
.bss 73772 73772 0 0.0
.data 3416 3416 0 0.0
.rodata 86511 86511 0 0.0
.text 569472 569472 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644779 644779 0 0.0
(read/write) 157268 157268 0 0.0
.bss 72996 72996 0 0.0
.data 3356 3356 0 0.0
.rodata 90019 90019 0 0.0
.text 554440 554440 0 0.0
lock-ftd LP_CC2652R7 (read only) 687651 687651 0 0.0
(read/write) 154300 154300 0 0.0
.bss 71732 71732 0 0.0
.data 3280 3280 0 0.0
.rodata 98843 98843 0 0.0
.text 588324 588324 0 0.0
lock-mtd LP_CC2652R7 (read only) 637059 637059 0 0.0
(read/write) 144864 144864 0 0.0
.bss 67468 67468 0 0.0
.data 3280 3280 0 0.0
.rodata 98723 98723 0 0.0
.text 537844 537844 0 0.0
pump-app LP_CC2652R7 (read only) 669011 669011 0 0.0
(read/write) 173852 173852 0 0.0
.bss 71876 71876 0 0.0
.data 3316 3316 0 0.0
.rodata 86955 86955 0 0.0
.text 581572 581572 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659575 659575 0 0.0
(read/write) 183392 183392 0 0.0
.bss 71980 71980 0 0.0
.data 3276 3276 0 0.0
.rodata 84855 84855 0 0.0
.text 574236 574236 0 0.0
shell LP_CC2652R7 (read only) 686422 686422 0 0.0
(read/write) 159952 159952 0 0.0
.bss 76068 76068 0 0.0
.data 3420 3420 0 0.0
.rodata 109582 109582 0 0.0
.text 576528 576528 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606450 606450 0 0.0
.app_xip_area 464964 464964 0 0.0
.bss 84416 84416 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603550 603550 0 0.0
.app_xip_area 461920 461920 0 0.0
.bss 84592 84592 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611270 611270 0 0.0
.app_xip_area 470712 470712 0 0.0
.bss 83600 83600 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919200 919200 0 0.0
(read/write) 133424 133424 0 0.0
.bss 131312 131312 0 0.0
.data 2112 2112 0 0.0
.text 919192 919192 0 0.0
BRD4161A+rpc (read only) 953380 953380 0 0.0
(read/write) 150116 150116 0 0.0
.bss 147800 147800 0 0.0
.data 2316 2316 0 0.0
.text 953372 953372 0 0.0
BRD4161A+rs911x (read only) 794276 794276 0 0.0
(read/write) 129708 129708 0 0.0
.bss 127588 127588 0 0.0
.data 2120 2120 0 0.0
.text 794268 794268 0 0.0
lock-app BRD4161A+wf200 (read only) 962636 962636 0 0.0
(read/write) 130052 130052 0 0.0
.bss 127964 127964 0 0.0
.data 2088 2088 0 0.0
.text 962628 962628 0 0.0
window-app BRD4161A (read only) 904256 904256 0 0.0
(read/write) 133504 133504 0 0.0
.bss 131392 131392 0 0.0
.data 2108 2108 0 0.0
.text 904248 904248 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010926 1010926 0 0.0
(read/write) 1482754 1482754 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213216 213216 0 0.0
.flash.text 1010926 1010926 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065355 1065355 0 0.0
(read/write) 484864 484864 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243724 243724 0 0.0
.flash.text 1059971 1059971 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657232 657248 16 0.0
.bss 69732 69732 0 0.0
.data 2028 2028 0 0.0
.text 579672 579688 16 0.0
lock k32w061+release (read/write) 718820 718820 0 0.0
.bss 70164 70164 0 0.0
.data 2000 2000 0 0.0
.text 640856 640856 0 0.0
linux all-clusters-app debug (read only) 2907801 2907801 0 0.0
(read/write) 188240 188240 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84200 84200 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 257341 257341 0 0.0
.text 2475410 2475410 0 0.0
all-clusters-minimal-app debug (read only) 2769345 2769345 0 0.0
(read/write) 179856 179856 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76824 76824 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337618 2337618 0 0.0
bridge-app debug+rpc (read only) 2247705 2247705 0 0.0
(read/write) 158688 158688 0 0.0
.bss 82944 82944 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66200 66200 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1896690 1896690 0 0.0
chip-tool debug (read only) 9816405 9816405 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7868917 7868917 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564036 9564036 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519188 7519188 0 0.0
lighting-app debug+rpc (read only) 2497617 2497617 0 0.0
(read/write) 163384 163384 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71128 71128 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122322 2122322 0 0.0
lock-app debug (read only) 2443617 2443617 0 0.0
(read/write) 158456 158456 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68088 68088 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059234 2059234 0 0.0
ota-provider-app debug (read only) 2281881 2281881 0 0.0
(read/write) 152656 152656 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62424 62424 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923362 1923362 0 0.0
ota-requestor-app debug (read only) 2329409 2329409 0 0.0
(read/write) 155440 155440 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64344 64344 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1964898 1964898 0 0.0
shell debug (read only) 2599753 2599753 0 0.0
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77664 77664 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2210690 2210690 0 0.0
thermostat-no-ble arm64 (read only) 2557804 2557804 0 0.0
(read/write) 191329 191329 0 0.0
.bss 99361 99361 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82336 82336 0 0.0
.dynamic 528 528 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2158976 2158976 0 0.0
tv-app debug (read only) 3051249 3051249 0 0.0
(read/write) 289800 289800 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78472 78472 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2622754 2622754 0 0.0
tv-casting-app debug (read only) 5350353 5350353 0 0.0
(read/write) 232248 232248 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135472 135472 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4656722 4656722 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2433320 2433320 0 0.0
.bss 208980 208980 0 0.0
.data 5896 5896 0 0.0
.text 1395964 1395964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195719 1195719 0 0.0
bss 141583 141583 0 0.0
rodata 155296 155296 0 0.0
text 819852 819848 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143351 0 0.0
bss 140800 140800 0 0.0
rodata 131808 131808 0 0.0
text 791928 791928 0 0.0
p6 all-clusters-app default (read/write) 2549208 2549208 0 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1507472 1507472 0 0.0
all-clusters-minimal-app default (read/write) 2494008 2494008 0 0.0
.bss 142616 142616 0 0.0
.data 2776 2776 0 0.0
.text 1452272 1452272 0 0.0
light-app default (read/write) 2425440 2425440 0 0.0
.bss 135728 135728 0 0.0
.data 2624 2624 0 0.0
.text 1383704 1383704 0 0.0
lock-app default (read/write) 2445848 2445848 0 0.0
.bss 135552 135552 0 0.0
.data 2600 2600 0 0.0
.text 1404112 1404112 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786648 786648 0 0.0
bss 70860 70860 0 0.0
noinit 40416 40416 0 0.0
text 556600 556600 0 0.0
lighting-app tlsr9518adk80d (read/write) 806668 806668 0 0.0
bss 71120 71120 0 0.0
noinit 40416 40416 0 0.0
text 573320 573318 -2 -0.0

@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19465: Size comparison from d1d5ca8 to 6ed3c41

Increases (3 builds for cyw30739, nrfconnect, telink)
platform target config section d1d5ca8 6ed3c41 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606570 8 0.0
.app_xip_area 465068 465076 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 819936 819940 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786804 8 0.0
text 556712 556714 2 0.0
Decreases (2 builds for esp32, telink)
platform target config section d1d5ca8 6ed3c41 change % change
esp32 all-clusters-app c3devkit (read only) 1011026 1011022 -4 -0.0
.flash.text 1011026 1011022 -4 -0.0
telink lighting-app tlsr9518adk80d text 573428 573426 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1d5ca8 6ed3c41 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656351 656351 0 0.0
(read/write) 194536 194536 0 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 86527 86527 0 0.0
.text 569512 569512 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644851 644851 0 0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554496 554496 0 0.0
lock-ftd LP_CC2652R7 (read only) 687715 687715 0 0.0
(read/write) 154244 154244 0 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588372 588372 0 0.0
lock-mtd LP_CC2652R7 (read only) 637115 637115 0 0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537884 0 0.0
pump-app LP_CC2652R7 (read only) 669075 669075 0 0.0
(read/write) 173796 173796 0 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581612 581612 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659655 0 0.0
(read/write) 183320 183320 0 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574292 0 0.0
shell LP_CC2652R7 (read only) 686478 686478 0 0.0
(read/write) 159904 159904 0 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 109598 109598 0 0.0
.text 576568 576568 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606570 8 0.0
.app_xip_area 465068 465076 8 0.0
.bss 84424 84424 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603670 603670 0 0.0
.app_xip_area 462032 462032 0 0.0
.bss 84600 84600 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611390 0 0.0
.app_xip_area 470824 470824 0 0.0
.bss 83608 83608 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919312 919312 0 0.0
(read/write) 133432 133432 0 0.0
.bss 131320 131320 0 0.0
.data 2112 2112 0 0.0
.text 919304 919304 0 0.0
BRD4161A+rpc (read only) 953492 953492 0 0.0
(read/write) 150124 150124 0 0.0
.bss 147808 147808 0 0.0
.data 2316 2316 0 0.0
.text 953484 953484 0 0.0
BRD4161A+rs911x (read only) 794396 794396 0 0.0
(read/write) 129716 129716 0 0.0
.bss 127596 127596 0 0.0
.data 2120 2120 0 0.0
.text 794388 794388 0 0.0
lock-app BRD4161A+wf200 (read only) 962700 962700 0 0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962692 962692 0 0.0
window-app BRD4161A (read only) 904368 904368 0 0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904360 904360 0 0.0
esp32 all-clusters-app c3devkit (read only) 1011026 1011022 -4 -0.0
(read/write) 1482794 1482794 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213240 213240 0 0.0
.flash.text 1011026 1011022 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065471 1065471 0 0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243740 243740 0 0.0
.flash.text 1060087 1060087 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657304 657304 0 0.0
.bss 69740 69740 0 0.0
.data 2028 2028 0 0.0
.text 579736 579736 0 0.0
lock k32w061+release (read/write) 718916 718916 0 0.0
.bss 70172 70172 0 0.0
.data 2000 2000 0 0.0
.text 640944 640944 0 0.0
linux all-clusters-app debug (read only) 2919449 2919449 0 0.0
(read/write) 188560 188560 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84520 84520 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258269 258269 0 0.0
.text 2485554 2485554 0 0.0
all-clusters-minimal-app debug (read only) 2769785 2769785 0 0.0
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337986 2337986 0 0.0
bridge-app debug+rpc (read only) 2248145 2248145 0 0.0
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1897058 1897058 0 0.0
chip-tool debug (read only) 9816789 9816789 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7869301 7869301 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9564452 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519604 7519604 0 0.0
lighting-app debug+rpc (read only) 2498073 2498073 0 0.0
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122706 2122706 0 0.0
lock-app debug (read only) 2444073 2444073 0 0.0
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059618 2059618 0 0.0
ota-provider-app debug (read only) 2282321 2282321 0 0.0
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923730 1923730 0 0.0
ota-requestor-app debug (read only) 2329849 2329849 0 0.0
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1965266 1965266 0 0.0
shell debug (read only) 2600209 2600209 0 0.0
(read/write) 219416 219416 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2211074 2211074 0 0.0
thermostat-no-ble arm64 (read only) 2558364 2558364 0 0.0
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2159376 2159376 0 0.0
tv-app debug (read only) 3051705 3051705 0 0.0
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2623138 2623138 0 0.0
tv-casting-app debug (read only) 5350793 5350793 0 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4657090 4657090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195819 1195819 0 0.0
bss 141591 141591 0 0.0
rodata 155316 155316 0 0.0
text 819936 819940 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143579 1143579 0 0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 792020 792020 0 0.0
p6 all-clusters-app default (read/write) 2549376 2549376 0 0.0
.bss 143416 143416 0 0.0
.data 2832 2832 0 0.0
.text 1507640 1507640 0 0.0
all-clusters-minimal-app default (read/write) 2494176 2494176 0 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452440 1452440 0 0.0
light-app default (read/write) 2425608 2425608 0 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383872 1383872 0 0.0
lock-app default (read/write) 2446016 2446016 0 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404280 1404280 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786804 8 0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556712 556714 2 0.0
lighting-app tlsr9518adk80d (read/write) 806808 806808 0 0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573428 573426 -2 -0.0

@bzbarsky-apple bzbarsky-apple merged commit 9fbc5a5 into project-chip:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@emargolis emargolis emargolis approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
crypto review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcarmelveilleux @msandstedt @emargolis @bzbarsky-apple