Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StandaloneAck handling: Untangle code path for UMH and StandaloneAck #19443

Merged
merged 3 commits into from
Jun 10, 2022
Merged

StandaloneAck handling: Untangle code path for UMH and StandaloneAck #19443

merged 3 commits into from
Jun 10, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Jun 10, 2022 •
edited
Loading

Problem

The original implementation in PR #19398 is too tricky

Change overview

  • Untangle code path for UMH and StandaloneAck
    • Revert UMH path, but only for UMH != nullptr case
    • Add a new branch for generating StandaloneAck
  • Add EpheremalExchangeDispatch for helping generating StandaloneAck
  • Add kFlagEpheremalExchange flag for exchange, to help go through StandaloneAck processing

Although the code is a bit tedious, but the logic is more clear, and more robust.

Testing

Reusing current unit-tests for regression

@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 10, 2022
Closed
bzbarsky-apple
bzbarsky-apple approved these changes Jun 10, 2022
View reviewed changes
src/messaging/EphemeralExchangeDispatch.h Outdated Show resolved Hide resolved
src/messaging/EphemeralExchangeDispatch.h Outdated Show resolved Hide resolved
src/messaging/ExchangeMgr.cpp Show resolved Hide resolved
src/messaging/ExchangeMgr.cpp Outdated Show resolved Hide resolved
src/messaging/ExchangeMgr.cpp Outdated Show resolved Hide resolved
src/messaging/ExchangeMgr.cpp Outdated Show resolved Hide resolved
src/messaging/ExchangeMgr.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19443: Size comparison from 10a5389 to 01d544b

Increases above 0.2%:

platform target config section 10a5389 01d544b change % change
linux thermostat-no-ble arm64 .got 4992 5024 32 0.6
Increases (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section 10a5389 01d544b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604074 604394 320 0.1
.app_xip_area 462644 462956 312 0.1
.bss 84384 84392 8 0.0
lock cyw930739m2evb_01 (read/write) 601174 601494 320 0.1
.app_xip_area 459608 459920 312 0.1
.bss 84552 84560 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600966 601422 456 0.1
.app_xip_area 460516 460964 448 0.1
.bss 83516 83524 8 0.0
k32w light k32w061+release (read/write) 654656 655040 384 0.1
.bss 69700 69708 8 0.0
.text 577152 577528 376 0.1
lock k32w061+release (read/write) 715892 716284 392 0.1
.bss 70140 70148 8 0.0
.text 637976 638360 384 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9558604 9560700 2096 0.0
(read/write) 689553 689665 112 0.0
.bss 43681 43697 16 0.0
.data.rel.ro 625888 625944 56 0.0
.got 15032 15064 32 0.2
.rodata 468860 468956 96 0.0
.text 7514340 7516132 1792 0.0
thermostat-no-ble arm64 (read only) 2545180 2547292 2112 0.1
(read/write) 190961 191057 96 0.1
.bss 99313 99329 16 0.0
.data.rel.ro 82120 82176 56 0.1
.got 4992 5024 32 0.6
.rodata 160564 160660 96 0.1
.text 2147760 2149552 1792 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2430168 2430592 424 0.0
.bss 208956 208964 8 0.0
.text 1392812 1393236 424 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192767 1193155 388 0.0
bss 141554 141562 8 0.0
rodata 154768 154804 36 0.0
text 817576 817932 356 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1140511 1140879 368 0.0
bss 140771 140779 8 0.0
rodata 131264 131296 32 0.0
text 789656 790004 348 0.0
telink light-switch-app tlsr9518adk80d (read/write) 783144 783608 464 0.1
bss 70828 70836 8 0.0
text 553718 554144 426 0.1
lighting-app tlsr9518adk80d (read/write) 803156 803628 472 0.1
bss 71080 71096 16 0.0
text 570436 570864 428 0.1
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section 10a5389 01d544b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604074 604394 320 0.1
.app_xip_area 462644 462956 312 0.1
.bss 84384 84392 8 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 601174 601494 320 0.1
.app_xip_area 459608 459920 312 0.1
.bss 84552 84560 8 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600966 601422 456 0.1
.app_xip_area 460516 460964 448 0.1
.bss 83516 83524 8 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 654656 655040 384 0.1
.bss 69700 69708 8 0.0
.data 2004 2004 0 0.0
.text 577152 577528 376 0.1
lock k32w061+release (read/write) 715892 716284 392 0.1
.bss 70140 70148 8 0.0
.data 1976 1976 0 0.0
.text 637976 638360 384 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9558604 9560700 2096 0.0
(read/write) 689553 689665 112 0.0
.bss 43681 43697 16 0.0
.data 1152 1152 0 0.0
.data.rel.ro 625888 625944 56 0.0
.dynamic 528 528 0 0.0
.got 15032 15064 32 0.2
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468860 468956 96 0.0
.text 7514340 7516132 1792 0.0
thermostat-no-ble arm64 (read only) 2545180 2547292 2112 0.1
(read/write) 190961 191057 96 0.1
.bss 99313 99329 16 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82176 56 0.1
.dynamic 528 528 0 0.0
.got 4992 5024 32 0.6
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160564 160660 96 0.1
.text 2147760 2149552 1792 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430168 2430592 424 0.0
.bss 208956 208964 8 0.0
.data 5872 5872 0 0.0
.text 1392812 1393236 424 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192767 1193155 388 0.0
bss 141554 141562 8 0.0
rodata 154768 154804 36 0.0
text 817576 817932 356 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1140511 1140879 368 0.0
bss 140771 140779 8 0.0
rodata 131264 131296 32 0.0
text 789656 790004 348 0.0
telink light-switch-app tlsr9518adk80d (read/write) 783144 783608 464 0.1
bss 70828 70836 8 0.0
noinit 40416 40416 0 0.0
text 553718 554144 426 0.1
lighting-app tlsr9518adk80d (read/write) 803156 803628 472 0.1
bss 71080 71096 16 0.0
noinit 40416 40416 0 0.0
text 570436 570864 428 0.1

@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19443: Size comparison from 10a5389 to 124d909

Increases above 0.2%:

platform target config section 10a5389 124d9091 change % change
linux thermostat-no-ble arm64 .got 4992 5024 32 0.6
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 10a5389 124d9091 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691239 691487 248 0.0
.bss 73748 73756 8 0.0
.text 578496 578752 256 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641895 642135 240 0.0
(read/write) 157220 157228 8 0.0
.bss 72972 72980 8 0.0
.text 552096 552352 256 0.0
lock-ftd LP_CC2652R7 (read only) 684751 684999 248 0.0
.bss 71700 71708 8 0.0
.text 585972 586228 256 0.0
lock-mtd LP_CC2652R7 (read only) 634175 634423 248 0.0
(read/write) 144808 144816 8 0.0
.bss 67436 67444 8 0.0
.text 535500 535756 256 0.0
pump-app LP_CC2652R7 (read only) 666083 666427 344 0.1
.bss 71844 71852 8 0.0
.rodata 86403 86435 32 0.0
.text 579196 579508 312 0.1
pump-controller-app LP_CC2652R7 (read only) 656651 656987 336 0.1
.bss 71948 71956 8 0.0
.rodata 84291 84323 32 0.0
.text 571876 572180 304 0.1
shell LP_CC2652R7 (read only) 683534 683774 240 0.0
.bss 76044 76052 8 0.0
.text 574192 574440 248 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 604074 604378 304 0.1
.app_xip_area 462644 462940 296 0.1
.bss 84384 84392 8 0.0
lock cyw930739m2evb_01 (read/write) 601174 601478 304 0.1
.app_xip_area 459608 459904 296 0.1
.bss 84552 84560 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600966 601366 400 0.1
.app_xip_area 460516 460908 392 0.1
.bss 83516 83524 8 0.0
efr32 lighting-app BRD4161A (read only) 915776 916160 384 0.0
(read/write) 133368 133376 8 0.0
.bss 131280 131288 8 0.0
.text 915768 916152 384 0.0
BRD4161A+rpc (read only) 949980 950364 384 0.0
(read/write) 150060 150068 8 0.0
.bss 147768 147776 8 0.0
.text 949972 950356 384 0.0
BRD4161A+rs911x (read only) 790892 791276 384 0.0
(read/write) 129652 129660 8 0.0
.bss 127556 127564 8 0.0
.text 790884 791268 384 0.0
lock-app BRD4161A+wf200 (read only) 959700 960036 336 0.0
(read/write) 129996 130004 8 0.0
.bss 127932 127940 8 0.0
.text 959692 960028 336 0.0
window-app BRD4161A (read only) 900848 901216 368 0.0
(read/write) 133456 133464 8 0.0
.bss 131368 131376 8 0.0
.text 900840 901208 368 0.0
esp32 all-clusters-app c3devkit (read only) 1008054 1008416 362 0.0
(read/write) 1482138 1482186 48 0.0
.dram0.bss 69360 69376 16 0.0
.flash.rodata 212696 212728 32 0.0
.flash.text 1008054 1008416 362 0.0
m5stack (read only) 1062871 1063215 344 0.0
(read/write) 484272 484328 56 0.0
.dram0.bss 74880 74896 16 0.0
.flash.rodata 243196 243236 40 0.0
.flash.text 1057487 1057831 344 0.0
k32w light k32w061+release (read/write) 654656 654992 336 0.1
.bss 69700 69708 8 0.0
.text 577152 577480 328 0.1
lock k32w061+release (read/write) 715892 716236 344 0.0
.bss 70140 70148 8 0.0
.text 637976 638312 336 0.1
linux all-clusters-app debug (read only) 2894065 2895737 1672 0.1
(read/write) 187928 187992 64 0.0
.bss 95744 95776 32 0.0
.data.rel.ro 83944 83992 48 0.1
.text 2463202 2464818 1616 0.1
all-clusters-minimal-app debug (read only) 2755609 2757265 1656 0.1
(read/write) 179544 179608 64 0.0
.bss 94912 94944 32 0.0
.data.rel.ro 76568 76616 48 0.1
.text 2325410 2327010 1600 0.1
bridge-app debug+rpc (read only) 2233857 2235513 1656 0.1
(read/write) 158376 158408 32 0.0
.data.rel.ro 65944 65992 48 0.1
.text 1884466 1886066 1600 0.1
chip-tool debug (read only) 9811781 9813405 1624 0.0
(read/write) 623232 623328 96 0.0
.bss 25408 25440 32 0.1
.data.rel.ro 590432 590488 56 0.0
.text 7864693 7866293 1600 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9558604 9560732 2128 0.0
(read/write) 689553 689665 112 0.0
.bss 43681 43697 16 0.0
.data.rel.ro 625888 625944 56 0.0
.got 15032 15064 32 0.2
.rodata 468860 468956 96 0.0
.text 7514340 7516164 1824 0.0
lighting-app debug+rpc (read only) 2483913 2485537 1624 0.1
(read/write) 163040 163072 32 0.0
.data.rel.ro 70872 70920 48 0.1
.text 2110114 2111714 1600 0.1
lock-app debug (read only) 2429961 2431585 1624 0.1
(read/write) 158176 158208 32 0.0
.data.rel.ro 67832 67880 48 0.1
.text 2047042 2048642 1600 0.1
ota-provider-app debug (read only) 2205313 2206937 1624 0.1
(read/write) 151136 151232 96 0.1
.bss 82400 82432 32 0.0
.data.rel.ro 61192 61240 48 0.1
.text 1852850 1854450 1600 0.1
ota-requestor-app debug (read only) 2266977 2268601 1624 0.1
(read/write) 154184 154280 96 0.1
.bss 83168 83200 32 0.0
.data.rel.ro 63288 63352 64 0.1
.text 1907090 1908690 1600 0.1
shell debug (read only) 2585705 2587329 1624 0.1
(read/write) 219008 219072 64 0.0
.bss 134536 134568 32 0.0
.data.rel.ro 77368 77424 56 0.1
.text 2198178 2199778 1600 0.1
thermostat-no-ble arm64 (read only) 2545180 2547324 2144 0.1
(read/write) 190961 191057 96 0.1
.bss 99313 99329 16 0.0
.data.rel.ro 82120 82176 56 0.1
.got 4992 5024 32 0.6
.rodata 160564 160660 96 0.1
.text 2147760 2149584 1824 0.1
tv-app debug (read only) 3037449 3039105 1656 0.1
(read/write) 289520 289584 64 0.0
.data.rel.ro 78216 78264 48 0.1
.text 2610450 2612050 1600 0.1
tv-casting-app debug (read only) 5336617 5338273 1656 0.0
(read/write) 231904 231968 64 0.0
.data.rel.ro 135216 135280 64 0.0
.text 4644610 4646210 1600 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2430168 2430528 360 0.0
.bss 208956 208964 8 0.0
.text 1392812 1393172 360 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192767 1193107 340 0.0
bss 141554 141562 8 0.0
rodata 154768 154804 36 0.0
text 817576 817880 304 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1140511 1140831 320 0.0
bss 140771 140779 8 0.0
rodata 131264 131296 32 0.0
text 789656 789956 300 0.0
p6 all-clusters-app default (read/write) 2545832 2546216 384 0.0
.bss 143384 143392 8 0.0
.text 1504096 1504480 384 0.0
all-clusters-minimal-app default (read/write) 2490640 2491024 384 0.0
.bss 142592 142600 8 0.0
.text 1448904 1449288 384 0.0
light-app default (read/write) 2422008 2422392 384 0.0
.bss 135696 135704 8 0.0
.text 1380272 1380656 384 0.0
lock-app default (read/write) 2442400 2442784 384 0.0
.bss 135520 135528 8 0.0
.text 1400664 1401048 384 0.0
telink light-switch-app tlsr9518adk80d (read/write) 783144 783544 400 0.1
bss 70828 70836 8 0.0
text 553718 554078 360 0.1
lighting-app tlsr9518adk80d (read/write) 803156 803564 408 0.1
bss 71080 71096 16 0.0
text 570436 570798 362 0.1
Decreases (18 builds for cc13x2_26x2, linux)
platform target config section 10a5389 124d9091 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159616 159376 -240 -0.2
.rodata 112431 112423 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 .rodata 89479 89463 -16 -0.0
lock-ftd LP_CC2652R7 (read/write) 157168 156928 -240 -0.2
.rodata 98295 98287 -8 -0.0
lock-mtd LP_CC2652R7 .rodata 98183 98175 -8 -0.0
pump-app LP_CC2652R7 (read/write) 176748 176412 -336 -0.2
pump-controller-app LP_CC2652R7 (read/write) 186284 185956 -328 -0.2
shell LP_CC2652R7 (read/write) 162816 162584 -232 -0.1
.rodata 109030 109022 -8 -0.0
linux all-clusters-app debug .rodata 256413 256349 -64 -0.0
all-clusters-minimal-app debug .rodata 257757 257693 -64 -0.0
bridge-app debug+rpc .rodata 190080 190016 -64 -0.0
chip-tool debug .rodata 506997 506901 -96 -0.0
lighting-app debug+rpc .rodata 206280 206184 -96 -0.0
lock-app debug .rodata 220392 220296 -96 -0.0
ota-provider-app debug .rodata 192856 192760 -96 -0.0
ota-requestor-app debug .rodata 196224 196128 -96 -0.0
shell debug .rodata 228978 228882 -96 -0.0
tv-app debug .rodata 241888 241824 -64 -0.0
tv-casting-app debug .rodata 341408 341344 -64 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 10a5389 124d9091 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691239 691487 248 0.0
(read/write) 159616 159376 -240 -0.2
.bss 73748 73756 8 0.0
.data 3392 3392 0 0.0
.rodata 112431 112423 -8 -0.0
.text 578496 578752 256 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641895 642135 240 0.0
(read/write) 157220 157228 8 0.0
.bss 72972 72980 8 0.0
.data 3332 3332 0 0.0
.rodata 89479 89463 -16 -0.0
.text 552096 552352 256 0.0
lock-ftd LP_CC2652R7 (read only) 684751 684999 248 0.0
(read/write) 157168 156928 -240 -0.2
.bss 71700 71708 8 0.0
.data 3256 3256 0 0.0
.rodata 98295 98287 -8 -0.0
.text 585972 586228 256 0.0
lock-mtd LP_CC2652R7 (read only) 634175 634423 248 0.0
(read/write) 144808 144816 8 0.0
.bss 67436 67444 8 0.0
.data 3256 3256 0 0.0
.rodata 98183 98175 -8 -0.0
.text 535500 535756 256 0.0
pump-app LP_CC2652R7 (read only) 666083 666427 344 0.1
(read/write) 176748 176412 -336 -0.2
.bss 71844 71852 8 0.0
.data 3292 3292 0 0.0
.rodata 86403 86435 32 0.0
.text 579196 579508 312 0.1
pump-controller-app LP_CC2652R7 (read only) 656651 656987 336 0.1
(read/write) 186284 185956 -328 -0.2
.bss 71948 71956 8 0.0
.data 3252 3252 0 0.0
.rodata 84291 84323 32 0.0
.text 571876 572180 304 0.1
shell LP_CC2652R7 (read only) 683534 683774 240 0.0
(read/write) 162816 162584 -232 -0.1
.bss 76044 76052 8 0.0
.data 3396 3396 0 0.0
.rodata 109030 109022 -8 -0.0
.text 574192 574440 248 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 604074 604378 304 0.1
.app_xip_area 462644 462940 296 0.1
.bss 84384 84392 8 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 601174 601478 304 0.1
.app_xip_area 459608 459904 296 0.1
.bss 84552 84560 8 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600966 601366 400 0.1
.app_xip_area 460516 460908 392 0.1
.bss 83516 83524 8 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915776 916160 384 0.0
(read/write) 133368 133376 8 0.0
.bss 131280 131288 8 0.0
.data 2088 2088 0 0.0
.text 915768 916152 384 0.0
BRD4161A+rpc (read only) 949980 950364 384 0.0
(read/write) 150060 150068 8 0.0
.bss 147768 147776 8 0.0
.data 2292 2292 0 0.0
.text 949972 950356 384 0.0
BRD4161A+rs911x (read only) 790892 791276 384 0.0
(read/write) 129652 129660 8 0.0
.bss 127556 127564 8 0.0
.data 2096 2096 0 0.0
.text 790884 791268 384 0.0
lock-app BRD4161A+wf200 (read only) 959700 960036 336 0.0
(read/write) 129996 130004 8 0.0
.bss 127932 127940 8 0.0
.data 2064 2064 0 0.0
.text 959692 960028 336 0.0
window-app BRD4161A (read only) 900848 901216 368 0.0
(read/write) 133456 133464 8 0.0
.bss 131368 131376 8 0.0
.data 2084 2084 0 0.0
.text 900840 901208 368 0.0
esp32 all-clusters-app c3devkit (read only) 1008054 1008416 362 0.0
(read/write) 1482138 1482186 48 0.0
.dram0.bss 69360 69376 16 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212696 212728 32 0.0
.flash.text 1008054 1008416 362 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062871 1063215 344 0.0
(read/write) 484272 484328 56 0.0
.dram0.bss 74880 74896 16 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243196 243236 40 0.0
.flash.text 1057487 1057831 344 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 654656 654992 336 0.1
.bss 69700 69708 8 0.0
.data 2004 2004 0 0.0
.text 577152 577480 328 0.1
lock k32w061+release (read/write) 715892 716236 344 0.0
.bss 70140 70148 8 0.0
.data 1976 1976 0 0.0
.text 637976 638312 336 0.1
linux all-clusters-app debug (read only) 2894065 2895737 1672 0.1
(read/write) 187928 187992 64 0.0
.bss 95744 95776 32 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83944 83992 48 0.1
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256413 256349 -64 -0.0
.text 2463202 2464818 1616 0.1
all-clusters-minimal-app debug (read only) 2755609 2757265 1656 0.1
(read/write) 179544 179608 64 0.0
.bss 94912 94944 32 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76568 76616 48 0.1
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 257757 257693 -64 -0.0
.text 2325410 2327010 1600 0.1
bridge-app debug+rpc (read only) 2233857 2235513 1656 0.1
(read/write) 158376 158408 32 0.0
.bss 82944 82944 0 0.0
.data 3696 3696 0 0.0
.data.rel.ro 65944 65992 48 0.1
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 190080 190016 -64 -0.0
.text 1884466 1886066 1600 0.1
chip-tool debug (read only) 9811781 9813405 1624 0.0
(read/write) 623232 623328 96 0.0
.bss 25408 25440 32 0.1
.data 1088 1088 0 0.0
.data.rel.ro 590432 590488 56 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 506997 506901 -96 -0.0
.text 7864693 7866293 1600 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9558604 9560732 2128 0.0
(read/write) 689553 689665 112 0.0
.bss 43681 43697 16 0.0
.data 1152 1152 0 0.0
.data.rel.ro 625888 625944 56 0.0
.dynamic 528 528 0 0.0
.got 15032 15064 32 0.2
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468860 468956 96 0.0
.text 7514340 7516164 1824 0.0
lighting-app debug+rpc (read only) 2483913 2485537 1624 0.1
(read/write) 163040 163072 32 0.0
.bss 84224 84224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70872 70920 48 0.1
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 206280 206184 -96 -0.0
.text 2110114 2111714 1600 0.1
lock-app debug (read only) 2429961 2431585 1624 0.1
(read/write) 158176 158208 32 0.0
.bss 82944 82944 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67832 67880 48 0.1
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 220392 220296 -96 -0.0
.text 2047042 2048642 1600 0.1
ota-provider-app debug (read only) 2205313 2206937 1624 0.1
(read/write) 151136 151232 96 0.1
.bss 82400 82432 32 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61192 61240 48 0.1
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192856 192760 -96 -0.0
.text 1852850 1854450 1600 0.1
ota-requestor-app debug (read only) 2266977 2268601 1624 0.1
(read/write) 154184 154280 96 0.1
.bss 83168 83200 32 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63288 63352 64 0.1
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 196224 196128 -96 -0.0
.text 1907090 1908690 1600 0.1
shell debug (read only) 2585705 2587329 1624 0.1
(read/write) 219008 219072 64 0.0
.bss 134536 134568 32 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77368 77424 56 0.1
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228978 228882 -96 -0.0
.text 2198178 2199778 1600 0.1
thermostat-no-ble arm64 (read only) 2545180 2547324 2144 0.1
(read/write) 190961 191057 96 0.1
.bss 99313 99329 16 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82176 56 0.1
.dynamic 528 528 0 0.0
.got 4992 5024 32 0.6
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160564 160660 96 0.1
.text 2147760 2149584 1824 0.1
tv-app debug (read only) 3037449 3039105 1656 0.1
(read/write) 289520 289584 64 0.0
.bss 200200 200200 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78216 78264 48 0.1
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241888 241824 -64 -0.0
.text 2610450 2612050 1600 0.1
tv-casting-app debug (read only) 5336617 5338273 1656 0.0
(read/write) 231904 231968 64 0.0
.bss 88040 88040 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135216 135280 64 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 341408 341344 -64 -0.0
.text 4644610 4646210 1600 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430168 2430528 360 0.0
.bss 208956 208964 8 0.0
.data 5872 5872 0 0.0
.text 1392812 1393172 360 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192767 1193107 340 0.0
bss 141554 141562 8 0.0
rodata 154768 154804 36 0.0
text 817576 817880 304 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1140511 1140831 320 0.0
bss 140771 140779 8 0.0
rodata 131264 131296 32 0.0
text 789656 789956 300 0.0
p6 all-clusters-app default (read/write) 2545832 2546216 384 0.0
.bss 143384 143392 8 0.0
.data 2808 2808 0 0.0
.text 1504096 1504480 384 0.0
all-clusters-minimal-app default (read/write) 2490640 2491024 384 0.0
.bss 142592 142600 8 0.0
.data 2752 2752 0 0.0
.text 1448904 1449288 384 0.0
light-app default (read/write) 2422008 2422392 384 0.0
.bss 135696 135704 8 0.0
.data 2600 2600 0 0.0
.text 1380272 1380656 384 0.0
lock-app default (read/write) 2442400 2442784 384 0.0
.bss 135520 135528 8 0.0
.data 2576 2576 0 0.0
.text 1400664 1401048 384 0.0
telink light-switch-app tlsr9518adk80d (read/write) 783144 783544 400 0.1
bss 70828 70836 8 0.0
noinit 40416 40416 0 0.0
text 553718 554078 360 0.1
lighting-app tlsr9518adk80d (read/write) 803156 803564 408 0.1
bss 71080 71096 16 0.0
noinit 40416 40416 0 0.0
text 570436 570798 362 0.1

@andy31415 andy31415 merged commit d2a2f07 into project-chip:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @andy31415 @bzbarsky-apple