-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SystemLayerImplLibevent #19396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The libevent-based implementation of `System::Layer` is unused, untested in CI, and probably stale. (It was originally written as a sanity check on System::Layer APIs, chosen as a representative substrate independent of any active platform.) #### Change overview Remove `SystemLayerImplLibevent`. #### Testing CI to confirm build edits.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
erjiaqing
June 9, 2022 16:47
pullapprove
bot
requested review from
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 9, 2022 16:47
woody-apple
approved these changes
Jun 9, 2022
Damian-Nordic
approved these changes
Jun 9, 2022
PR #19396: Size comparison from ac7e2f7 to 9484912 Increases (4 builds for cc13x2_26x2, esp32)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
#### Problem The libevent-based implementation of `System::Layer` is unused, untested in CI, and probably stale. (It was originally written as a sanity check on System::Layer APIs, chosen as a representative substrate independent of any active platform.) #### Change overview Remove `SystemLayerImplLibevent`. #### Testing CI to confirm build edits.
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jun 15, 2022
#### Problem The libevent-based implementation of `System::Layer` is unused, untested in CI, and probably stale. (It was originally written as a sanity check on System::Layer APIs, chosen as a representative substrate independent of any active platform.) #### Change overview Remove `SystemLayerImplLibevent`. #### Testing CI to confirm build edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The libevent-based implementation of
System::Layer
is unused, untestedin CI, and probably stale. (It was originally written as a sanity check on
System::Layer APIs, chosen as a representative substrate independent of
any active platform.)
Change overview
Remove
SystemLayerImplLibevent
.Testing
CI to confirm build edits.