-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate pending CASESession establishment when Fabric changes #19346
Invalidate pending CASESession establishment when Fabric changes #19346
Conversation
PR #19346: Size comparison from 2b5ec74 to 0fbf786 Increases (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (9 builds for cc13x2_26x2, linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Perhaps related to #19328 and slack discussion: https://csamembers.slack.com/archives/C031EJZJ1L2/p1654726870300589 ? |
I don't have access to that channel can you please add me. My understanding is that #19328 is for invalidating sessions that are established. My PR invalidates sessions that are not yet established but were in the process of establishing |
PR #19346: Size comparison from e38e2a6 to 4ceff6b Increases (10 builds for cyw30739, k32w, linux, mbed, telink)
Full report (10 builds for cyw30739, k32w, linux, mbed, telink)
|
PR #19346: Size comparison from e38e2a6 to cdb8b10 Increases (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
|
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
8508a8b
to
ad4d136
Compare
PR #19346: Size comparison from dcec35a to ad4d136 Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19346: Size comparison from dcec35a to 5fe85ab Increases above 0.2%:
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
/rebase |
PR #19346: Size comparison from 48fbfb6 to 7abbb1a Increases above 0.2%:
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
FabricTable fabrics; | ||
// In normal operation scope of FabricTable outlives CASESession. Without this scoping we hit | ||
// ASAN test issue since FabricTable is not normally on the stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't really need the scoping, just the ordering change...
Problem
Change overview
OnFabricHasChanged
is called to do update. These are TODO in the current codeTestCASESession.cpp
to test out that pending sessions are killed when OnFabricHasChanged is calledTestCASESession.cpp
a little more to figure out if the commented lines should be removedTesting