Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run media cluster tests in tv-app in CI. #19325

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Run media cluster tests in tv-app in CI. #19325

merged 2 commits into from
Jun 9, 2022
+41 −38

Conversation

bzbarsky-apple
Copy link
Contributor

all-clusters-app does not have the media clusters configured in a
spec-compliant way (e.g. is missing mandatory things), and definitely
does not have them implemented in a spec-compliant way.

Problem

Tests running against an example app that cannot possibly have them pass sanely.

Change overview

Run against a different example app.

Testing

See how CI does.

@boring-cyborg boring-cyborg bot added the scripts label Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19325: Size comparison from 10f620e to 7b467cf

Increases (3 builds for cc13x2_26x2, esp32, nrfconnect)
platform target config section 10f620e 7b467cf change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 664867 664875 8 0.0
.text 578028 578036 8 0.0
esp32 all-clusters-app c3devkit (read only) 1007724 1007726 2 0.0
.flash.text 1007724 1007726 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192011 1192027 16 0.0
text 817092 817096 4 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 10f620e 7b467cf change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 178876 178868 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801700 801692 -8 -0.0
text 569290 569286 -4 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 10f620e 7b467cf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689927 689927 0 0.0
(read/write) 161840 161840 0 0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112319 112319 0 0.0
.text 577296 577296 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640543 640543 0 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89359 89359 0 0.0
.text 550864 550864 0 0.0
lock-ftd LP_CC2652R7 (read only) 683431 683431 0 0.0
(read/write) 159400 159400 0 0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98175 98175 0 0.0
.text 584772 584772 0 0.0
lock-mtd LP_CC2652R7 (read only) 632847 632847 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98063 98063 0 0.0
.text 534292 534292 0 0.0
pump-app LP_CC2652R7 (read only) 664867 664875 8 0.0
(read/write) 178876 178868 -8 -0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86355 86355 0 0.0
.text 578028 578036 8 0.0
pump-controller-app LP_CC2652R7 (read only) 655459 655459 0 0.0
(read/write) 188388 188388 0 0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84243 84243 0 0.0
.text 570732 570732 0 0.0
shell LP_CC2652R7 (read only) 682206 682206 0 0.0
(read/write) 165056 165056 0 0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108918 108918 0 0.0
.text 572976 572976 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602546 0 0.0
.app_xip_area 461492 461492 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599630 599630 0 0.0
.app_xip_area 458440 458440 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599430 599430 0 0.0
.app_xip_area 459356 459356 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915016 915016 0 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915008 915008 0 0.0
BRD4161A+rpc (read only) 949236 949236 0 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949228 949228 0 0.0
BRD4161A+rs911x (read only) 790204 790204 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790196 790196 0 0.0
lock-app BRD4161A+wf200 (read only) 958444 958444 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958436 958436 0 0.0
window-app BRD4161A (read only) 900088 900088 0 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900080 900080 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007724 1007726 2 0.0
(read/write) 1481826 1481826 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212576 212576 0 0.0
.flash.text 1007724 1007726 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062495 1062495 0 0.0
(read/write) 483960 483960 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243076 243076 0 0.0
.flash.text 1057111 1057111 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653760 653760 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575912 575912 0 0.0
lock k32w061+release (read/write) 714852 714852 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636592 636592 0 0.0
linux all-clusters-app debug (read only) 2892393 2892393 0 0.0
(read/write) 180024 180024 0 0.0
.bss 87840 87840 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255485 255485 0 0.0
.text 2462386 2462386 0 0.0
all-clusters-minimal-app debug (read only) 2753857 2753857 0 0.0
(read/write) 171640 171640 0 0.0
.bss 87008 87008 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256765 256765 0 0.0
.text 2324578 2324578 0 0.0
bridge-app debug+rpc (read only) 2197921 2197921 0 0.0
(read/write) 149528 149528 0 0.0
.bss 74496 74496 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187840 187840 0 0.0
.text 1851170 1851170 0 0.0
chip-tool debug (read only) 9736965 9736965 0 0.0
(read/write) 608032 608032 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575240 575240 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505437 505437 0 0.0
.text 7829525 7829525 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474668 9474668 0 0.0
(read/write) 674257 674257 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14928 14928 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467596 467596 0 0.0
.text 7470068 7470068 0 0.0
lighting-app debug+rpc (read only) 2482305 2482305 0 0.0
(read/write) 155136 155136 0 0.0
.bss 76320 76320 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205384 205384 0 0.0
.text 2109330 2109330 0 0.0
lock-app debug (read only) 2428257 2428257 0 0.0
(read/write) 150272 150272 0 0.0
.bss 75040 75040 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219400 219400 0 0.0
.text 2046258 2046258 0 0.0
ota-provider-app debug (read only) 2203721 2203721 0 0.0
(read/write) 143264 143264 0 0.0
.bss 74496 74496 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 191960 191960 0 0.0
.text 1852082 1852082 0 0.0
ota-requestor-app debug (read only) 2265353 2265353 0 0.0
(read/write) 146312 146312 0 0.0
.bss 75264 75264 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195296 195296 0 0.0
.text 1906322 1906322 0 0.0
shell debug (read only) 2584017 2584017 0 0.0
(read/write) 203200 203200 0 0.0
.bss 118728 118728 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228050 228050 0 0.0
.text 2197346 2197346 0 0.0
thermostat-no-ble arm64 (read only) 2543948 2543948 0 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160116 160116 0 0.0
.text 2146896 2146896 0 0.0
tv-app debug (read only) 3030409 3030409 0 0.0
(read/write) 281904 281904 0 0.0
.bss 192616 192616 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 240672 240672 0 0.0
.text 2604674 2604674 0 0.0
tv-casting-app debug (read only) 5334001 5334001 0 0.0
(read/write) 223968 223968 0 0.0
.bss 80136 80136 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135168 135168 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340512 340512 0 0.0
.text 4643010 4643010 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429648 2429648 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392292 1392292 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192011 1192027 16 0.0
bss 141362 141362 0 0.0
rodata 154636 154636 0 0.0
text 817092 817096 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139735 1139735 0 0.0
bss 140579 140579 0 0.0
rodata 131128 131128 0 0.0
text 789148 789148 0 0.0
p6 all-clusters-app default (read/write) 2544512 2544512 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502776 1502776 0 0.0
all-clusters-minimal-app default (read/write) 2489384 2489384 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447648 1447648 0 0.0
light-app default (read/write) 2421288 2421288 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379552 1379552 0 0.0
lock-app default (read/write) 2441624 2441624 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399888 1399888 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781680 781680 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552568 552568 0 0.0
lighting-app tlsr9518adk80d (read/write) 801700 801692 -8 -0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569290 569286 -4 -0.0

@bzbarsky-apple
Copy link
Contributor Author

@lazarkov @chrisdecenzo The YAML tests are expecting "Application Basic" on endpoint 1, which is not the case for tv-app, of course. Should that just be changed to use endpoint 3 by default?

@chrisdecenzo
Copy link
Contributor

@lazarkov @chrisdecenzo The YAML tests are expecting "Application Basic" on endpoint 1, which is not the case for tv-app, of course. Should that just be changed to use endpoint 3 by default?

Yes, that should work

@boring-cyborg boring-cyborg bot added the app label Jun 8, 2022
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review June 8, 2022 21:34
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19325: Size comparison from 2593ab9 to 32bd54e

Increases (1 build for nrfconnect)
platform target config section 2593ab9 32bd54e change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 817128 817132 4 0.0
Decreases (2 builds for linux, telink)
platform target config section 2593ab9 32bd54e change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9499564 9499484 -80 -0.0
.text 7483284 7483204 -80 -0.0
telink light-switch-app tlsr9518adk80d text 552596 552594 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2593ab9 32bd54e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 689983 0 0.0
(read/write) 161784 161784 0 0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112335 112335 0 0.0
.text 577336 577336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640599 640599 0 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89375 89375 0 0.0
.text 550904 550904 0 0.0
lock-ftd LP_CC2652R7 (read only) 683487 683487 0 0.0
(read/write) 159344 159344 0 0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98191 98191 0 0.0
.text 584812 584812 0 0.0
lock-mtd LP_CC2652R7 (read only) 632895 632895 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98079 98079 0 0.0
.text 534324 534324 0 0.0
pump-app LP_CC2652R7 (read only) 664931 664931 0 0.0
(read/write) 178812 178812 0 0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86371 86371 0 0.0
.text 578076 578076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655507 655507 0 0.0
(read/write) 188340 188340 0 0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84259 84259 0 0.0
.text 570764 570764 0 0.0
shell LP_CC2652R7 (read only) 682262 682262 0 0.0
(read/write) 165000 165000 0 0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108934 108934 0 0.0
.text 573016 573016 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602578 0 0.0
.app_xip_area 461524 461524 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599662 599662 0 0.0
.app_xip_area 458472 458472 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599462 0 0.0
.app_xip_area 459388 459388 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915064 915064 0 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915056 915056 0 0.0
BRD4161A+rpc (read only) 949268 949268 0 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949260 949260 0 0.0
BRD4161A+rs911x (read only) 790252 790252 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790244 790244 0 0.0
lock-app BRD4161A+wf200 (read only) 958508 958508 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958500 958500 0 0.0
window-app BRD4161A (read only) 900136 900136 0 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900128 900128 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007742 1007742 0 0.0
(read/write) 1481842 1481842 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212592 212592 0 0.0
.flash.text 1007742 1007742 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062535 1062535 0 0.0
(read/write) 483976 483976 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243092 243092 0 0.0
.flash.text 1057151 1057151 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653792 653792 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575944 575944 0 0.0
lock k32w061+release (read/write) 714900 714900 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636640 636640 0 0.0
linux all-clusters-app debug (read only) 2892457 2892457 0 0.0
(read/write) 180024 180024 0 0.0
.bss 87840 87840 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255485 255485 0 0.0
.text 2462450 2462450 0 0.0
all-clusters-minimal-app debug (read only) 2753937 2753937 0 0.0
(read/write) 171640 171640 0 0.0
.bss 87008 87008 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256765 256765 0 0.0
.text 2324658 2324658 0 0.0
bridge-app debug+rpc (read only) 2198001 2198001 0 0.0
(read/write) 149528 149528 0 0.0
.bss 74496 74496 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187840 187840 0 0.0
.text 1851250 1851250 0 0.0
chip-tool debug (read only) 9754501 9754501 0 0.0
(read/write) 611840 611840 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579032 579032 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505789 505789 0 0.0
.text 7835333 7835333 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9499564 9499484 -80 -0.0
(read/write) 678065 678065 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614488 614488 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467884 467884 0 0.0
.text 7483284 7483204 -80 -0.0
lighting-app debug+rpc (read only) 2482385 2482385 0 0.0
(read/write) 155136 155136 0 0.0
.bss 76320 76320 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205384 205384 0 0.0
.text 2109410 2109410 0 0.0
lock-app debug (read only) 2428353 2428353 0 0.0
(read/write) 150272 150272 0 0.0
.bss 75040 75040 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219432 219432 0 0.0
.text 2046322 2046322 0 0.0
ota-provider-app debug (read only) 2203785 2203785 0 0.0
(read/write) 143264 143264 0 0.0
.bss 74496 74496 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 191960 191960 0 0.0
.text 1852146 1852146 0 0.0
ota-requestor-app debug (read only) 2265417 2265417 0 0.0
(read/write) 146312 146312 0 0.0
.bss 75264 75264 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195296 195296 0 0.0
.text 1906386 1906386 0 0.0
shell debug (read only) 2584081 2584081 0 0.0
(read/write) 203200 203200 0 0.0
.bss 118728 118728 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228050 228050 0 0.0
.text 2197410 2197410 0 0.0
thermostat-no-ble arm64 (read only) 2544028 2544028 0 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160132 160132 0 0.0
.text 2146960 2146960 0 0.0
tv-app debug (read only) 3035985 3035985 0 0.0
(read/write) 281648 281648 0 0.0
.bss 192296 192296 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241056 241056 0 0.0
.text 2609746 2609746 0 0.0
tv-casting-app debug (read only) 5335041 5335041 0 0.0
(read/write) 224032 224032 0 0.0
.bss 80136 80136 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135248 135248 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340512 340512 0 0.0
.text 4643858 4643858 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429664 2429664 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392308 1392308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192075 0 0.0
bss 141362 141362 0 0.0
rodata 154652 154652 0 0.0
text 817128 817132 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139783 0 0.0
bss 140579 140579 0 0.0
rodata 131144 131144 0 0.0
text 789180 789180 0 0.0
p6 all-clusters-app default (read/write) 2544544 2544544 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502808 1502808 0 0.0
all-clusters-minimal-app default (read/write) 2489416 2489416 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447680 1447680 0 0.0
light-app default (read/write) 2421336 2421336 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379600 1379600 0 0.0
lock-app default (read/write) 2441672 2441672 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399936 1399936 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 781728 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552596 552594 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 801740 801740 0 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569316 569316 0 0.0

chrisdecenzo
chrisdecenzo approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@chrisdecenzo chrisdecenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments, but otherwise approved.

@bzbarsky-apple
Run media cluster tests in tv-app in CI.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
GPG key ID: D8B9F5AEAE84E4CF
Expired
Verified
Learn about vigilant mode
0efe8e6 
all-clusters-app does not have the media clusters configured in a
spec-compliant way (e.g. is missing mandatory things), and definitely
does not have them implemented in a spec-compliant way.
@bzbarsky-apple
Address review comments.
ee2f718
@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

PR #19325: Size comparison from ac7e2f7 to ee2f718

Increases (4 builds for cc13x2_26x2, esp32)
platform target config section ac7e2f7 ee2f718 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 683455 683463 8 0.0
.text 584788 584796 8 0.0
pump-app LP_CC2652R7 (read only) 664899 664907 8 0.0
.text 578052 578060 8 0.0
pump-controller-app LP_CC2652R7 (read only) 655483 655491 8 0.0
.text 570748 570756 8 0.0
esp32 all-clusters-app c3devkit (read only) 1007740 1007742 2 0.0
.flash.text 1007740 1007742 2 0.0
Decreases (5 builds for cc13x2_26x2, linux, telink)
platform target config section ac7e2f7 ee2f718 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 159376 159368 -8 -0.0
pump-app LP_CC2652R7 (read/write) 178844 178836 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188364 188356 -8 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9502940 9502876 -64 -0.0
.text 7486692 7486628 -64 -0.0
telink lighting-app tlsr9518adk80d (read/write) 801716 801708 -8 -0.0
text 569298 569296 -2 -0.0
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ac7e2f7 ee2f718 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689943 689943 0 0.0
(read/write) 161824 161824 0 0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112327 112327 0 0.0
.text 577304 577304 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640599 640599 0 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89367 89367 0 0.0
.text 550912 550912 0 0.0
lock-ftd LP_CC2652R7 (read only) 683455 683463 8 0.0
(read/write) 159376 159368 -8 -0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98183 98183 0 0.0
.text 584788 584796 8 0.0
lock-mtd LP_CC2652R7 (read only) 632879 632879 0 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98071 98071 0 0.0
.text 534316 534316 0 0.0
pump-app LP_CC2652R7 (read only) 664899 664907 8 0.0
(read/write) 178844 178836 -8 -0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86363 86363 0 0.0
.text 578052 578060 8 0.0
pump-controller-app LP_CC2652R7 (read only) 655483 655491 8 0.0
(read/write) 188364 188356 -8 -0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84251 84251 0 0.0
.text 570748 570756 8 0.0
shell LP_CC2652R7 (read only) 682230 682230 0 0.0
(read/write) 165032 165032 0 0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108926 108926 0 0.0
.text 572992 572992 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602562 602562 0 0.0
.app_xip_area 461508 461508 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599646 599646 0 0.0
.app_xip_area 458456 458456 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599446 599446 0 0.0
.app_xip_area 459372 459372 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007740 1007742 2 0.0
(read/write) 1481834 1481834 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212584 212584 0 0.0
.flash.text 1007740 1007742 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062491 1062491 0 0.0
(read/write) 483968 483968 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243084 243084 0 0.0
.flash.text 1057107 1057107 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653784 653784 0 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575936 575936 0 0.0
lock k32w061+release (read/write) 714876 714876 0 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636616 636616 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9502940 9502876 -64 -0.0
(read/write) 678033 678033 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614464 614464 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467916 467916 0 0.0
.text 7486692 7486628 -64 -0.0
thermostat-no-ble arm64 (read only) 2544060 2544060 0 0.0
(read/write) 183057 183057 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82120 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160164 160164 0 0.0
.text 2147040 2147040 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429656 2429656 0 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392300 1392300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192051 1192051 0 0.0
bss 141362 141362 0 0.0
rodata 154644 154644 0 0.0
text 817112 817112 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139775 1139775 0 0.0
bss 140579 140579 0 0.0
rodata 131136 131136 0 0.0
text 789188 789188 0 0.0
p6 all-clusters-app default (read/write) 2544632 2544632 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502896 1502896 0 0.0
all-clusters-minimal-app default (read/write) 2489440 2489440 0 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447704 1447704 0 0.0
light-app default (read/write) 2421312 2421312 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379576 1379576 0 0.0
lock-app default (read/write) 2441648 2441648 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399912 1399912 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781696 781696 0 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552576 552576 0 0.0
lighting-app tlsr9518adk80d (read/write) 801716 801708 -8 -0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569298 569296 -2 -0.0

@woody-apple woody-apple merged commit fbe49dd into project-chip:master Jun 9, 2022
@bzbarsky-apple bzbarsky-apple deleted the media-cluster-tests branch June 9, 2022 17:42
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@bzbarsky-apple @mkardous-silabs
Run media cluster tests in tv-app in CI. (project-chip#19325)
4fc69c8 
* Run media cluster tests in tv-app in CI.

all-clusters-app does not have the media clusters configured in a
spec-compliant way (e.g. is missing mandatory things), and definitely
does not have them implemented in a spec-compliant way.

* Address review comments.
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Jun 15, 2022
@bzbarsky-apple @rochaferraz
Run media cluster tests in tv-app in CI. (project-chip#19325)
f6754fb 
* Run media cluster tests in tv-app in CI.

all-clusters-app does not have the media clusters configured in a
spec-compliant way (e.g. is missing mandatory things), and definitely
does not have them implemented in a spec-compliant way.

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple

@chrisdecenzo chrisdecenzo

@anush-apple anush-apple

@arkq arkq

@Byungjoo-Lee Byungjoo-Lee

@carol-apple carol-apple

@chshu chshu

@chulspro chulspro

@Damian-Nordic Damian-Nordic

@dhrishi dhrishi

@electrocucaracha electrocucaracha

@emargolis emargolis

@erjiaqing erjiaqing

@franck-apple franck-apple

@gjc13 gjc13

@harimau-qirex harimau-qirex

@hawk248 hawk248

@harsha-rajendran harsha-rajendran

@isiu-apple isiu-apple

@jelderton jelderton

@jepenven-silabs jepenven-silabs

@jmartinez-silabs jmartinez-silabs

@jtung-apple jtung-apple

@kpschoedel kpschoedel

@lazarkov lazarkov

@LuDuda LuDuda

@mlepage-google mlepage-google

@msandstedt msandstedt

@rgoliver rgoliver

@robszewczyk robszewczyk

@sagar-apple sagar-apple

@saurabhst saurabhst

@selissia selissia

@tcarmelveilleux tcarmelveilleux

@tecimovic tecimovic

@tehampson tehampson

@vijs vijs

@vivien-apple vivien-apple

@wbschiller wbschiller

@xylophone21 xylophone21

@yufengwangca yufengwangca

Assignees
No one assigned
Labels
app review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bzbarsky-apple @chrisdecenzo @woody-apple