-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TestListStructOctet to use member names that are generic #19321
Merged
tehampson
merged 6 commits into
project-chip:master
from
tehampson:fix-fabric-idx-type-11286
Jun 9, 2022
Merged
Update TestListStructOctet to use member names that are generic #19321
tehampson
merged 6 commits into
project-chip:master
from
tehampson:fix-fabric-idx-type-11286
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
June 8, 2022 15:27
Ops I did the wrong thing here. I need to make it a Fabric ID not index |
tehampson
commented
Jun 8, 2022
tehampson
changed the title
Update test-cluster to use fabric_idx type for fabricIndex
Update test-cluster fabricIndex to fabricId
Jun 8, 2022
PR #19321: Size comparison from 5362125 to 834d061 Decreases (2 builds for telink)
Full report (8 builds for cyw30739, k32w, mbed, telink)
|
tehampson
changed the title
Update test-cluster fabricIndex to fabricId
Update TestListStructOctet to use member names that are generic
Jun 8, 2022
PR #19321: Size comparison from 5362125 to 2b45f34 Increases (11 builds for cyw30739, efr32, k32w, mbed, telink)
Full report (13 builds for cyw30739, efr32, k32w, mbed, telink)
|
tcarmelveilleux
approved these changes
Jun 8, 2022
PR #19321: Size comparison from 5362125 to f93fe6e Increases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (21 builds for cc13x2_26x2, cyw30739, esp32, linux, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 9, 2022
PR #19321: Size comparison from ac7e2f7 to 3b1b9f8 Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, linux, p6)
Decreases (6 builds for cc13x2_26x2, nrfconnect, telink)
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
…ect-chip#19321) Update TestListStructOctet to use member names that are generic
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jun 15, 2022
…ect-chip#19321) Update TestListStructOctet to use member names that are generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fabric_idx
is not used uniformly #11286Change overview
Update test-cluster to use fabric_idx type for fabricIndex
Testing