Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove client-api.cpp and dependent clusters #19291

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Remove client-api.cpp and dependent clusters #19291

merged 6 commits into from
Jun 14, 2022

Conversation

mrjerryjohns
Copy link
Contributor

@mrjerryjohns mrjerryjohns commented Jun 7, 2022 •
edited
Loading

Problem

client-api.cpp contains a lot of legacy ZCL bits, including Matter spec non-compliant stuff around manufacturer-specific stuff.

Solution

Remove that, and anything that references it (which today, is exclusively the IAS Zone cluster). Since the IAS zone cluster isn't actually in the Matter list of valid clusters, as well as having an implementation in the SDK which hews to the Zigbee version, remove it from the XMLs, as well as skip compiling the cluster implementation as part of existing Matter builds.

I've kept the cluster impl source in the SDK for now in case it gets refreshed in the future.

@restyled-io restyled-io bot mentioned this pull request Jun 7, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19291: Size comparison from c868f81 to 309273c

Increases above 0.2%:

platform target config section c868f81 309273c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161520 164264 2744 1.7
shell LP_CC2652R7 (read/write) 164736 167480 2744 1.7
Increases (2 builds for cc13x2_26x2)
platform target config section c868f81 309273c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161520 164264 2744 1.7
shell LP_CC2652R7 (read/write) 164736 167480 2744 1.7
Decreases (29 builds for cc13x2_26x2, cyw30739, k32w, linux, p6)
platform target config section c868f81 309273c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690335 687503 -2832 -0.4
.bss 74748 74660 -88 -0.1
.data 3392 3356 -36 -1.1
.rodata 112311 111503 -808 -0.7
.text 577712 575688 -2024 -0.4
all-clusters-minimal-app LP_CC2652R7 (read only) 640951 640887 -64 -0.0
(read/write) 158220 158188 -32 -0.0
.bss 73972 73940 -32 -0.0
.text 551280 551216 -64 -0.0
lock-ftd LP_CC2652R7 (read only) 683847 683783 -64 -0.0
(read/write) 159072 158080 -992 -0.6
.bss 72700 71644 -1056 -1.5
.text 585196 585132 -64 -0.0
lock-mtd LP_CC2652R7 (read only) 633263 633199 -64 -0.0
(read/write) 145808 144752 -1056 -0.7
.bss 68436 67380 -1056 -1.5
.text 534716 534652 -64 -0.0
pump-app LP_CC2652R7 (read only) 665299 665235 -64 -0.0
(read/write) 178532 177532 -1000 -0.6
.bss 72844 71780 -1064 -1.5
.text 578468 578404 -64 -0.0
pump-controller-app LP_CC2652R7 (read only) 655875 655811 -64 -0.0
(read/write) 188060 187068 -992 -0.5
.bss 72948 71892 -1056 -1.4
.text 571156 571092 -64 -0.0
shell LP_CC2652R7 (read only) 682614 679782 -2832 -0.4
.bss 77044 76956 -88 -0.1
.data 3396 3360 -36 -1.1
.rodata 108910 108102 -808 -0.7
.text 573392 571368 -2024 -0.4
cyw30739 light cyw930739m2evb_01 (read/write) 602578 601458 -1120 -0.2
.app_xip_area 461524 461460 -64 -0.0
.bss 84008 82952 -1056 -1.3
lock cyw930739m2evb_01 (read/write) 599662 598542 -1120 -0.2
.app_xip_area 458472 458408 -64 -0.0
.bss 84176 83120 -1056 -1.3
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599398 598278 -1120 -0.2
.app_xip_area 459324 459260 -64 -0.0
.bss 83140 82084 -1056 -1.3
k32w light k32w061+release (read/write) 653976 652856 -1120 -0.2
.bss 70052 68996 -1056 -1.5
.text 576120 576056 -64 -0.0
lock k32w061+release (read/write) 715068 713948 -1120 -0.2
.bss 70492 69436 -1056 -1.5
.text 636800 636736 -64 -0.0
linux all-clusters-app debug (read only) 2893417 2884881 -8536 -0.3
(read/write) 180056 179600 -456 -0.3
.bss 87872 87712 -160 -0.2
.data 2016 1952 -64 -3.2
.data.rel.ro 83960 83736 -224 -0.3
.init_array 1040 1032 -8 -0.8
.rodata 255549 254525 -1024 -0.4
.text 2463346 2456146 -7200 -0.3
all-clusters-minimal-app debug (read only) 2754929 2754681 -248 -0.0
(read/write) 171672 171632 -40 -0.0
.bss 87040 87008 -32 -0.0
.init_array 1040 1032 -8 -0.8
.text 2325554 2325330 -224 -0.0
bridge-app debug+rpc (read only) 2198961 2198713 -248 -0.0
(read/write) 149560 148464 -1096 -0.7
.bss 74528 73440 -1088 -1.5
.init_array 720 712 -8 -1.1
.text 1852146 1851922 -224 -0.0
chip-tool debug (read only) 9737285 9661037 -76248 -0.8
(read/write) 608064 603800 -4264 -0.7
.bss 25440 24352 -1088 -4.3
.data.rel.ro 575240 572072 -3168 -0.6
.init_array 664 656 -8 -1.2
.rodata 505405 502333 -3072 -0.6
.text 7829877 7764501 -65376 -0.8
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9411404 -63584 -0.7
(read/write) 674321 669873 -4448 -0.7
.bss 43729 42657 -1072 -2.5
.data.rel.ro 610696 607528 -3168 -0.5
.got 14936 14736 -200 -1.3
.rodata 467548 464892 -2656 -0.6
.text 7470420 7417860 -52560 -0.7
lighting-app debug+rpc (read only) 2483377 2483129 -248 -0.0
(read/write) 155168 154072 -1096 -0.7
.bss 76352 75264 -1088 -1.4
.init_array 824 816 -8 -1.0
.text 2110306 2110082 -224 -0.0
lock-app debug (read only) 2429329 2429081 -248 -0.0
(read/write) 150304 149208 -1096 -0.7
.bss 75072 73984 -1088 -1.4
.init_array 792 784 -8 -1.0
.text 2047234 2047010 -224 -0.0
ota-provider-app debug (read only) 2204761 2204513 -248 -0.0
(read/write) 143296 142232 -1064 -0.7
.bss 74528 73472 -1056 -1.4
.init_array 664 656 -8 -1.2
.text 1853058 1852834 -224 -0.0
ota-requestor-app debug (read only) 2266409 2266161 -248 -0.0
(read/write) 146344 145280 -1064 -0.7
.bss 75296 74240 -1056 -1.4
.init_array 704 696 -8 -1.1
.text 1907282 1907058 -224 -0.0
shell debug (read only) 2585089 2576601 -8488 -0.3
(read/write) 203232 202776 -456 -0.2
.bss 118760 118600 -160 -0.1
.data 1328 1264 -64 -4.8
.data.rel.ro 77392 77168 -224 -0.3
.init_array 944 936 -8 -0.8
.rodata 228146 227186 -960 -0.4
.text 2198322 2191106 -7216 -0.3
thermostat-no-ble arm64 (read only) 2544956 2544700 -256 -0.0
(read/write) 183153 183073 -80 -0.0
.bss 91457 91409 -48 -0.1
.got 5000 4960 -40 -0.8
.text 2147776 2147648 -128 -0.0
tv-app debug (read only) 3031449 3031185 -264 -0.0
(read/write) 281936 280840 -1096 -0.4
.bss 192648 191560 -1088 -0.6
.init_array 960 952 -8 -0.8
.text 2605650 2605410 -240 -0.0
tv-casting-app debug (read only) 5335041 5255689 -79352 -1.5
(read/write) 224000 220728 -3272 -1.5
.bss 80168 80040 -128 -0.2
.data 2416 2352 -64 -2.6
.data.rel.ro 135168 132096 -3072 -2.3
.init_array 880 872 -8 -0.9
.rodata 340576 336544 -4032 -1.2
.text 4643986 4575890 -68096 -1.5
p6 all-clusters-app default (read/write) 2544928 2541424 -3504 -0.1
.bss 137208 137120 -88 -0.1
.data 2808 2776 -32 -1.1
.text 1503192 1499688 -3504 -0.2
all-clusters-minimal-app default (read/write) 2489792 2489728 -64 -0.0
.bss 136416 136384 -32 -0.0
.text 1448056 1447992 -64 -0.0
light-app default (read/write) 2421704 2421624 -80 -0.0
.bss 129520 128456 -1064 -0.8
.text 1379968 1379888 -80 -0.0
lock-app default (read/write) 2442040 2441960 -80 -0.0
.bss 129344 128280 -1064 -0.8
.text 1400304 1400224 -80 -0.0
Full report (29 builds for cc13x2_26x2, cyw30739, k32w, linux, p6)
platform target config section c868f81 309273c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690335 687503 -2832 -0.4
(read/write) 161520 164264 2744 1.7
.bss 74748 74660 -88 -0.1
.data 3392 3356 -36 -1.1
.rodata 112311 111503 -808 -0.7
.text 577712 575688 -2024 -0.4
all-clusters-minimal-app LP_CC2652R7 (read only) 640951 640887 -64 -0.0
(read/write) 158220 158188 -32 -0.0
.bss 73972 73940 -32 -0.0
.data 3332 3332 0 0.0
.rodata 89351 89351 0 0.0
.text 551280 551216 -64 -0.0
lock-ftd LP_CC2652R7 (read only) 683847 683783 -64 -0.0
(read/write) 159072 158080 -992 -0.6
.bss 72700 71644 -1056 -1.5
.data 3256 3256 0 0.0
.rodata 98167 98167 0 0.0
.text 585196 585132 -64 -0.0
lock-mtd LP_CC2652R7 (read only) 633263 633199 -64 -0.0
(read/write) 145808 144752 -1056 -0.7
.bss 68436 67380 -1056 -1.5
.data 3256 3256 0 0.0
.rodata 98055 98055 0 0.0
.text 534716 534652 -64 -0.0
pump-app LP_CC2652R7 (read only) 665299 665235 -64 -0.0
(read/write) 178532 177532 -1000 -0.6
.bss 72844 71780 -1064 -1.5
.data 3292 3292 0 0.0
.rodata 86347 86347 0 0.0
.text 578468 578404 -64 -0.0
pump-controller-app LP_CC2652R7 (read only) 655875 655811 -64 -0.0
(read/write) 188060 187068 -992 -0.5
.bss 72948 71892 -1056 -1.4
.data 3252 3252 0 0.0
.rodata 84235 84235 0 0.0
.text 571156 571092 -64 -0.0
shell LP_CC2652R7 (read only) 682614 679782 -2832 -0.4
(read/write) 164736 167480 2744 1.7
.bss 77044 76956 -88 -0.1
.data 3396 3360 -36 -1.1
.rodata 108910 108102 -808 -0.7
.text 573392 571368 -2024 -0.4
cyw30739 light cyw930739m2evb_01 (read/write) 602578 601458 -1120 -0.2
.app_xip_area 461524 461460 -64 -0.0
.bss 84008 82952 -1056 -1.3
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599662 598542 -1120 -0.2
.app_xip_area 458472 458408 -64 -0.0
.bss 84176 83120 -1056 -1.3
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599398 598278 -1120 -0.2
.app_xip_area 459324 459260 -64 -0.0
.bss 83140 82084 -1056 -1.3
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 653976 652856 -1120 -0.2
.bss 70052 68996 -1056 -1.5
.data 2004 2004 0 0.0
.text 576120 576056 -64 -0.0
lock k32w061+release (read/write) 715068 713948 -1120 -0.2
.bss 70492 69436 -1056 -1.5
.data 1976 1976 0 0.0
.text 636800 636736 -64 -0.0
linux all-clusters-app debug (read only) 2893417 2884881 -8536 -0.3
(read/write) 180056 179600 -456 -0.3
.bss 87872 87712 -160 -0.2
.data 2016 1952 -64 -3.2
.data.rel.ro 83960 83736 -224 -0.3
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1032 -8 -0.8
.rodata 255549 254525 -1024 -0.4
.text 2463346 2456146 -7200 -0.3
all-clusters-minimal-app debug (read only) 2754929 2754681 -248 -0.0
(read/write) 171672 171632 -40 -0.0
.bss 87040 87008 -32 -0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1032 -8 -0.8
.rodata 256861 256861 0 0.0
.text 2325554 2325330 -224 -0.0
bridge-app debug+rpc (read only) 2198961 2198713 -248 -0.0
(read/write) 149560 148464 -1096 -0.7
.bss 74528 73440 -1088 -1.5
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 712 -8 -1.1
.rodata 187904 187904 0 0.0
.text 1852146 1851922 -224 -0.0
chip-tool debug (read only) 9737285 9661037 -76248 -0.8
(read/write) 608064 603800 -4264 -0.7
.bss 25440 24352 -1088 -4.3
.data 1088 1088 0 0.0
.data.rel.ro 575240 572072 -3168 -0.6
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 656 -8 -1.2
.rodata 505405 502333 -3072 -0.6
.text 7829877 7764501 -65376 -0.8
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9411404 -63584 -0.7
(read/write) 674321 669873 -4448 -0.7
.bss 43729 42657 -1072 -2.5
.data 1152 1152 0 0.0
.data.rel.ro 610696 607528 -3168 -0.5
.dynamic 528 528 0 0.0
.got 14936 14736 -200 -1.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 464892 -2656 -0.6
.text 7470420 7417860 -52560 -0.7
lighting-app debug+rpc (read only) 2483377 2483129 -248 -0.0
(read/write) 155168 154072 -1096 -0.7
.bss 76352 75264 -1088 -1.4
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 816 -8 -1.0
.rodata 205480 205480 0 0.0
.text 2110306 2110082 -224 -0.0
lock-app debug (read only) 2429329 2429081 -248 -0.0
(read/write) 150304 149208 -1096 -0.7
.bss 75072 73984 -1088 -1.4
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 784 -8 -1.0
.rodata 219496 219496 0 0.0
.text 2047234 2047010 -224 -0.0
ota-provider-app debug (read only) 2204761 2204513 -248 -0.0
(read/write) 143296 142232 -1064 -0.7
.bss 74528 73472 -1056 -1.4
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 656 -8 -1.2
.rodata 192024 192024 0 0.0
.text 1853058 1852834 -224 -0.0
ota-requestor-app debug (read only) 2266409 2266161 -248 -0.0
(read/write) 146344 145280 -1064 -0.7
.bss 75296 74240 -1056 -1.4
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 696 -8 -1.1
.rodata 195392 195392 0 0.0
.text 1907282 1907058 -224 -0.0
shell debug (read only) 2585089 2576601 -8488 -0.3
(read/write) 203232 202776 -456 -0.2
.bss 118760 118600 -160 -0.1
.data 1328 1264 -64 -4.8
.data.rel.ro 77392 77168 -224 -0.3
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 936 -8 -0.8
.rodata 228146 227186 -960 -0.4
.text 2198322 2191106 -7216 -0.3
thermostat-no-ble arm64 (read only) 2544956 2544700 -256 -0.0
(read/write) 183153 183073 -80 -0.0
.bss 91457 91409 -48 -0.1
.data 1512 1512 0 0.0
.data.rel.ro 82168 82168 0 0.0
.dynamic 528 528 0 0.0
.got 5000 4960 -40 -0.8
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160196 160196 0 0.0
.text 2147776 2147648 -128 -0.0
tv-app debug (read only) 3031449 3031185 -264 -0.0
(read/write) 281936 280840 -1096 -0.4
.bss 192648 191560 -1088 -0.6
.data 4656 4656 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 952 -8 -0.8
.rodata 240736 240736 0 0.0
.text 2605650 2605410 -240 -0.0
tv-casting-app debug (read only) 5335041 5255689 -79352 -1.5
(read/write) 224000 220728 -3272 -1.5
.bss 80168 80040 -128 -0.2
.data 2416 2352 -64 -2.6
.data.rel.ro 135168 132096 -3072 -2.3
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 872 -8 -0.9
.rodata 340576 336544 -4032 -1.2
.text 4643986 4575890 -68096 -1.5
p6 all-clusters-app default (read/write) 2544928 2541424 -3504 -0.1
.bss 137208 137120 -88 -0.1
.data 2808 2776 -32 -1.1
.text 1503192 1499688 -3504 -0.2
all-clusters-minimal-app default (read/write) 2489792 2489728 -64 -0.0
.bss 136416 136384 -32 -0.0
.data 2752 2752 0 0.0
.text 1448056 1447992 -64 -0.0
light-app default (read/write) 2421704 2421624 -80 -0.0
.bss 129520 128456 -1064 -0.8
.data 2600 2600 0 0.0
.text 1379968 1379888 -80 -0.0
lock-app default (read/write) 2442040 2441960 -80 -0.0
.bss 129344 128280 -1064 -0.8
.data 2576 2576 0 0.0
.text 1400304 1400224 -80 -0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! This has long needed doing.

@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 14, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

PR #19291: Size comparison from 4b6fc80 to ca87edd

Increases above 0.2%:

platform target config section 4b6fc80 ca87edd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191784 193736 1952 1.0
shell LP_CC2652R7 (read/write) 157128 159872 2744 1.7
Increases (2 builds for cc13x2_26x2)
platform target config section 4b6fc80 ca87edd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191784 193736 1952 1.0
shell LP_CC2652R7 (read/write) 157128 159872 2744 1.7
Decreases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b6fc80 ca87edd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 657079 -2040 -0.3
.bss 73796 73708 -88 -0.1
.data 3416 3380 -36 -1.1
.rodata 87047 86759 -288 -0.3
.text 571760 570008 -1752 -0.3
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645603 -64 -0.0
(read/write) 157292 157260 -32 -0.0
.bss 73020 72988 -32 -0.0
.text 555280 555216 -64 -0.0
lock-ftd LP_CC2652R7 (read only) 688531 688467 -64 -0.0
(read/write) 153444 152452 -992 -0.6
.bss 71756 70700 -1056 -1.5
.text 589164 589100 -64 -0.0
lock-mtd LP_CC2652R7 (read only) 637939 637875 -64 -0.0
(read/write) 144888 143832 -1056 -0.7
.bss 67492 66436 -1056 -1.6
.text 538684 538620 -64 -0.0
pump-app LP_CC2652R7 (read only) 669747 669683 -64 -0.0
(read/write) 173124 172124 -1000 -0.6
.bss 71884 70820 -1064 -1.5
.text 582284 582220 -64 -0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660407 -64 -0.0
(read/write) 182520 181528 -992 -0.5
.bss 72004 70948 -1056 -1.5
.text 575084 575020 -64 -0.0
shell LP_CC2652R7 (read only) 689270 686438 -2832 -0.4
.bss 76092 76004 -88 -0.1
.data 3420 3384 -36 -1.1
.rodata 110126 109318 -808 -0.7
.text 578832 576808 -2024 -0.3
cyw30739 light cyw930739m2evb_01 (read/write) 612202 611082 -1120 -0.2
.app_xip_area 467836 467772 -64 -0.0
.bss 87288 86232 -1056 -1.2
lock cyw930739m2evb_01 (read/write) 609318 608198 -1120 -0.2
.app_xip_area 464808 464744 -64 -0.0
.bss 87464 86408 -1056 -1.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 614254 -1128 -0.2
.app_xip_area 471928 471864 -64 -0.0
.bss 86464 85400 -1064 -1.2
efr32 lighting-app BRD4161A (read only) 920584 920520 -64 -0.0
(read/write) 133456 132400 -1056 -0.8
.bss 131336 130280 -1056 -0.8
.text 920576 920512 -64 -0.0
BRD4161A+rpc (read only) 956240 956176 -64 -0.0
(read/write) 150328 149272 -1056 -0.7
.bss 148008 146952 -1056 -0.7
.text 956232 956168 -64 -0.0
BRD4161A+rs911x (read only) 795700 795636 -64 -0.0
(read/write) 129736 128672 -1064 -0.8
.bss 127612 126548 -1064 -0.8
.text 795692 795628 -64 -0.0
lock-app BRD4161A+wf200 (read only) 963596 963532 -64 -0.0
(read/write) 130076 129012 -1064 -0.8
.bss 127988 126924 -1064 -0.8
.text 963588 963524 -64 -0.0
window-app BRD4161A (read only) 905472 905392 -80 -0.0
(read/write) 133528 132472 -1056 -0.8
.bss 131416 130360 -1056 -0.8
.text 905464 905384 -80 -0.0
esp32 all-clusters-app c3devkit (read only) 1013900 1011586 -2314 -0.2
(read/write) 1483522 1482570 -952 -0.1
.dram0.bss 69424 69344 -80 -0.1
.dram0.data 14696 14656 -40 -0.3
.flash.rodata 213968 213144 -824 -0.4
.flash.text 1013900 1011586 -2314 -0.2
m5stack (read only) 1068115 1065767 -2348 -0.2
(read/write) 485616 484680 -936 -0.2
.dram0.bss 74952 74864 -88 -0.1
.dram0.data 34224 34176 -48 -0.1
.flash.rodata 244444 243644 -800 -0.3
.flash.text 1062731 1060383 -2348 -0.2
k32w light k32w061+release (read/write) 658328 657208 -1120 -0.2
.bss 69764 68708 -1056 -1.5
.text 580736 580672 -64 -0.0
lock k32w061+release (read/write) 719940 718820 -1120 -0.2
.bss 70196 69140 -1056 -1.5
.text 641944 641880 -64 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9580764 9517164 -63600 -0.7
(read/write) 690049 685617 -4432 -0.6
.bss 43697 42625 -1072 -2.5
.data.rel.ro 626288 623120 -3168 -0.5
.got 15104 14904 -200 -1.3
.rodata 470924 468252 -2672 -0.6
.text 7533236 7480676 -52560 -0.7
thermostat-no-ble arm64 (read only) 2560628 2560388 -240 -0.0
(read/write) 191489 191393 -96 -0.1
.bss 99393 99345 -48 -0.0
.got 5080 5040 -40 -0.8
.text 2161472 2161360 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2434816 2434752 -64 -0.0
.bss 209212 208148 -1064 -0.5
.text 1397460 1397396 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1196107 -3004 -0.3
bss 141633 141554 -79 -0.1
rodata 156128 155332 -796 -0.5
text 822412 820372 -2040 -0.2
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144155 -192 -0.0
bss 140824 140794 -30 -0.0
text 792752 792692 -60 -0.0
p6 all-clusters-app default (read/write) 2552984 2549448 -3536 -0.1
.bss 143424 143344 -80 -0.1
.data 2832 2800 -32 -1.1
.text 1511248 1507712 -3536 -0.2
all-clusters-minimal-app default (read/write) 2495472 2495408 -64 -0.0
.bss 142640 142608 -32 -0.0
.text 1453736 1453672 -64 -0.0
light-app default (read/write) 2426848 2426784 -64 -0.0
.bss 135752 134688 -1064 -0.8
.text 1385112 1385048 -64 -0.0
lock-app default (read/write) 2447256 2447176 -80 -0.0
.bss 135576 134512 -1064 -0.8
.text 1405520 1405440 -80 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 786720 -1120 -0.1
bss 70892 69836 -1056 -1.5
text 557712 557646 -66 -0.0
lighting-app tlsr9518adk80d (read/write) 807828 806708 -1120 -0.1
bss 71144 70088 -1056 -1.5
text 574404 574338 -66 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b6fc80 ca87edd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659119 657079 -2040 -0.3
(read/write) 191784 193736 1952 1.0
.bss 73796 73708 -88 -0.1
.data 3416 3380 -36 -1.1
.rodata 87047 86759 -288 -0.3
.text 571760 570008 -1752 -0.3
all-clusters-minimal-app LP_CC2652R7 (read only) 645667 645603 -64 -0.0
(read/write) 157292 157260 -32 -0.0
.bss 73020 72988 -32 -0.0
.data 3356 3356 0 0.0
.rodata 90067 90067 0 0.0
.text 555280 555216 -64 -0.0
lock-ftd LP_CC2652R7 (read only) 688531 688467 -64 -0.0
(read/write) 153444 152452 -992 -0.6
.bss 71756 70700 -1056 -1.5
.data 3280 3280 0 0.0
.rodata 98883 98883 0 0.0
.text 589164 589100 -64 -0.0
lock-mtd LP_CC2652R7 (read only) 637939 637875 -64 -0.0
(read/write) 144888 143832 -1056 -0.7
.bss 67492 66436 -1056 -1.6
.data 3280 3280 0 0.0
.rodata 98763 98763 0 0.0
.text 538684 538620 -64 -0.0
pump-app LP_CC2652R7 (read only) 669747 669683 -64 -0.0
(read/write) 173124 172124 -1000 -0.6
.bss 71884 70820 -1064 -1.5
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 582284 582220 -64 -0.0
pump-controller-app LP_CC2652R7 (read only) 660471 660407 -64 -0.0
(read/write) 182520 181528 -992 -0.5
.bss 72004 70948 -1056 -1.5
.data 3276 3276 0 0.0
.rodata 84903 84903 0 0.0
.text 575084 575020 -64 -0.0
shell LP_CC2652R7 (read only) 689270 686438 -2832 -0.4
(read/write) 157128 159872 2744 1.7
.bss 76092 76004 -88 -0.1
.data 3420 3384 -36 -1.1
.rodata 110126 109318 -808 -0.7
.text 578832 576808 -2024 -0.3
cyw30739 light cyw930739m2evb_01 (read/write) 612202 611082 -1120 -0.2
.app_xip_area 467836 467772 -64 -0.0
.bss 87288 86232 -1056 -1.2
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 609318 608198 -1120 -0.2
.app_xip_area 464808 464744 -64 -0.0
.bss 87464 86408 -1056 -1.2
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 615382 614254 -1128 -0.2
.app_xip_area 471928 471864 -64 -0.0
.bss 86464 85400 -1064 -1.2
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920584 920520 -64 -0.0
(read/write) 133456 132400 -1056 -0.8
.bss 131336 130280 -1056 -0.8
.data 2116 2116 0 0.0
.text 920576 920512 -64 -0.0
BRD4161A+rpc (read only) 956240 956176 -64 -0.0
(read/write) 150328 149272 -1056 -0.7
.bss 148008 146952 -1056 -0.7
.data 2320 2320 0 0.0
.text 956232 956168 -64 -0.0
BRD4161A+rs911x (read only) 795700 795636 -64 -0.0
(read/write) 129736 128672 -1064 -0.8
.bss 127612 126548 -1064 -0.8
.data 2124 2124 0 0.0
.text 795692 795628 -64 -0.0
lock-app BRD4161A+wf200 (read only) 963596 963532 -64 -0.0
(read/write) 130076 129012 -1064 -0.8
.bss 127988 126924 -1064 -0.8
.data 2088 2088 0 0.0
.text 963588 963524 -64 -0.0
window-app BRD4161A (read only) 905472 905392 -80 -0.0
(read/write) 133528 132472 -1056 -0.8
.bss 131416 130360 -1056 -0.8
.data 2108 2108 0 0.0
.text 905464 905384 -80 -0.0
esp32 all-clusters-app c3devkit (read only) 1013900 1011586 -2314 -0.2
(read/write) 1483522 1482570 -952 -0.1
.dram0.bss 69424 69344 -80 -0.1
.dram0.data 14696 14656 -40 -0.3
.flash.rodata 213968 213144 -824 -0.4
.flash.text 1013900 1011586 -2314 -0.2
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068115 1065767 -2348 -0.2
(read/write) 485616 484680 -936 -0.2
.dram0.bss 74952 74864 -88 -0.1
.dram0.data 34224 34176 -48 -0.1
.flash.rodata 244444 243644 -800 -0.3
.flash.text 1062731 1060383 -2348 -0.2
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658328 657208 -1120 -0.2
.bss 69764 68708 -1056 -1.5
.data 2028 2028 0 0.0
.text 580736 580672 -64 -0.0
lock k32w061+release (read/write) 719940 718820 -1120 -0.2
.bss 70196 69140 -1056 -1.5
.data 2000 2000 0 0.0
.text 641944 641880 -64 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9580764 9517164 -63600 -0.7
(read/write) 690049 685617 -4432 -0.6
.bss 43697 42625 -1072 -2.5
.data 1152 1152 0 0.0
.data.rel.ro 626288 623120 -3168 -0.5
.dynamic 528 528 0 0.0
.got 15104 14904 -200 -1.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 470924 468252 -2672 -0.6
.text 7533236 7480676 -52560 -0.7
thermostat-no-ble arm64 (read only) 2560628 2560388 -240 -0.0
(read/write) 191489 191393 -96 -0.1
.bss 99393 99345 -48 -0.0
.data 1560 1560 0 0.0
.data.rel.ro 82432 82432 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5040 -40 -0.8
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161356 161356 0 0.0
.text 2161472 2161360 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434816 2434752 -64 -0.0
.bss 209212 208148 -1064 -0.5
.data 5864 5864 0 0.0
.text 1397460 1397396 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199111 1196107 -3004 -0.3
bss 141633 141554 -79 -0.1
rodata 156128 155332 -796 -0.5
text 822412 820372 -2040 -0.2
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144347 1144155 -192 -0.0
bss 140824 140794 -30 -0.0
rodata 131860 131860 0 0.0
text 792752 792692 -60 -0.0
p6 all-clusters-app default (read/write) 2552984 2549448 -3536 -0.1
.bss 143424 143344 -80 -0.1
.data 2832 2800 -32 -1.1
.text 1511248 1507712 -3536 -0.2
all-clusters-minimal-app default (read/write) 2495472 2495408 -64 -0.0
.bss 142640 142608 -32 -0.0
.data 2776 2776 0 0.0
.text 1453736 1453672 -64 -0.0
light-app default (read/write) 2426848 2426784 -64 -0.0
.bss 135752 134688 -1064 -0.8
.data 2624 2624 0 0.0
.text 1385112 1385048 -64 -0.0
lock-app default (read/write) 2447256 2447176 -80 -0.0
.bss 135576 134512 -1064 -0.8
.data 2600 2600 0 0.0
.text 1405520 1405440 -80 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 787840 786720 -1120 -0.1
bss 70892 69836 -1056 -1.5
noinit 40416 40416 0 0.0
text 557712 557646 -66 -0.0
lighting-app tlsr9518adk80d (read/write) 807828 806708 -1120 -0.1
bss 71144 70088 -1056 -1.5
noinit 40416 40416 0 0.0
text 574404 574338 -66 -0.0

@andy31415 andy31415 merged commit 104d1c4 into project-chip:master Jun 14, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrjerryjohns @andy31415 @woody-apple @bzbarsky-apple