-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mei data in all clusters #19274
Mei data in all clusters #19274
Conversation
PR #19274: Size comparison from 8cc291d to a32c3ae Increases (6 builds for cc13x2_26x2, linux, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…re why however assuming constants generated separately in different codegen paths
PR #19274: Size comparison from 8cc291d to a565dc1 Increases above 0.2%:
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (9 builds for cc13x2_26x2, cyw30739, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19274: Size comparison from ac7e2f7 to 17823c2 Increases (1 build for nrfconnect)
Decreases (2 builds for telink)
Full report (7 builds for cyw30739, nrfconnect, telink)
|
PR #19274: Size comparison from ac7e2f7 to f9748f0 Increases (9 builds for cc13x2_26x2, esp32, nrfconnect, p6)
Decreases (6 builds for cc13x2_26x2)
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19274: Size comparison from ac7e2f7 to e2a8a90 Increases (12 builds for cc13x2_26x2, esp32, nrfconnect, p6)
Decreases (8 builds for cc13x2_26x2, cyw30739, k32w, telink)
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Extending attributes "works" as long as you then don't try to use cluster-objects generated bits for them, which don't exist without regenerating app-common. That means no using the typeinfo. And the attributes better not have structs in them. And if you regenerate app-common, extending commands works too. |
PR #19274: Size comparison from 8443529 to 78ff9d8 Increases (11 builds for cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Problem
Have some sample manufacturer specific attributes and commands in Mode select cluster in all-clusters-app
Fixes #16886
Testing
Codegen looks like it generated extra attributes and commands.