-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Linux app - Fix idl_lint.py warnings #19264
Merged
lazarkov
merged 2 commits into
project-chip:master
from
lazarkov:feature/tv-app-cluster-issue-19174
Jun 7, 2022
Merged
TV Linux app - Fix idl_lint.py warnings #19264
lazarkov
merged 2 commits into
project-chip:master
from
lazarkov:feature/tv-app-cluster-issue-19174
Jun 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #19264: Size comparison from 55ab764 to b0958cb Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kghost
June 7, 2022 09:35
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 7, 2022 09:35
andy31415
changed the title
TV Linux app - Fix for issue 19174
TV Linux app - Fix idl_lint.py warnings
Jun 7, 2022
andy31415
approved these changes
Jun 7, 2022
chrisdecenzo
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
see above
Issue(s) fixed:
19174
Testing
Run
.environment/pigweed-venv/bin/python3 scripts/idl_lint.py --log-level warn ./examples/tv-app/tv-common/tv-app.matter