Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix computation of min/max interval for subscriptions to be spec comp… #19262

Merged
merged 3 commits into from
Jun 11, 2022
Merged

Fix computation of min/max interval for subscriptions to be spec comp… #19262

merged 3 commits into from
Jun 11, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Jun 7, 2022 •
edited
Loading

Problem

Recent changes to the spec now alter the way the final min/max intervals are computed:
MinIntervalFloor ≤ MaxInterval ≤ MAX(SUBSCRIPTION_MAX_INTERVAL_PUBLISHER_LIMIT, MaxIntervalCeiling)
Where SUBSCRIPTION_MAX_INTERVAL_PUBLISHER_LIMIT is set to 60m in the spec.
Fixes #19129
spec change is https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5297

Change overview

Remove MinInterval from the Subscribe Response and update the APIs to automatically compute this based on the requested value from the client.
Alter the ReadHandler::SetReportingIntervals to correctly handle the above constraints

Testing

Subscriber requesting a number of different values for max-interval:

  1. Max interval equal to client-requested min-interval.
  2. Max interval greater than client-requested min-interval but lower than 60m:
    a. With no server adjustment.
    b. With server adjustment to a value greater than client-requested, but less than 60m (allowed).
    c. With server adjustment to a value greater than client-requested, but greater than 60 (not allowed).
  3. Max interval greater than client-requested min-interval but greater than 60m:
    a. With no server adjustment.
    b. With server adjustment to a value lower than 60m.
    c. With server adjustment to a value larger than 60m, but less than max interval .
    d. With server adjustment to a value larger than max interval .
  4. Validate client is not requesting max-interval < min-interval.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19262: Size comparison from 55ab764 to aff91d0

Increases (5 builds for cc13x2_26x2)
platform target config section 55ab764 aff91d0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162220 162252 32 0.0
lock-ftd LP_CC2652R7 (read/write) 159804 159836 32 0.0
pump-app LP_CC2652R7 (read/write) 179636 179660 24 0.0
pump-controller-app LP_CC2652R7 (read/write) 188588 188620 32 0.0
shell LP_CC2652R7 (read/write) 165420 165452 32 0.0
Decreases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 55ab764 aff91d0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689547 689515 -32 -0.0
.text 577444 577412 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640171 640139 -32 -0.0
.text 551020 550988 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 683027 682995 -32 -0.0
.text 584896 584864 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 632435 632411 -24 -0.0
.text 534416 534392 -24 -0.0
pump-app LP_CC2652R7 (read only) 664099 664075 -24 -0.0
.text 577768 577744 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655227 -32 -0.0
.text 570880 570848 -32 -0.0
shell LP_CC2652R7 (read only) 681842 681810 -32 -0.0
.text 573132 573100 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602218 -24 -0.0
.app_xip_area 461268 461244 -24 -0.0
lock cyw930739m2evb_01 (read/write) 599294 599270 -24 -0.0
.app_xip_area 458184 458160 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596878 -32 -0.0
.app_xip_area 456932 456900 -32 -0.0
efr32 lighting-app BRD4161A (read only) 916152 916120 -32 -0.0
.text 916144 916112 -32 -0.0
BRD4161A+rpc (read only) 950380 950332 -48 -0.0
.text 950372 950324 -48 -0.0
BRD4161A+rs911x (read only) 791364 791332 -32 -0.0
.text 791356 791324 -32 -0.0
lock-app BRD4161A+wf200 (read only) 958152 958136 -16 -0.0
.text 958144 958128 -16 -0.0
window-app BRD4161A (read only) 901208 901176 -32 -0.0
.text 901200 901168 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007758 -40 -0.0
.flash.text 1007798 1007758 -40 -0.0
m5stack (read only) 1062743 1062719 -24 -0.0
.flash.text 1057359 1057335 -24 -0.0
k32w light k32w061+release (read/write) 653400 653368 -32 -0.0
.text 575624 575592 -32 -0.0
lock k32w061+release (read/write) 714380 714348 -32 -0.0
.text 636192 636160 -32 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409140 -624 -0.0
.text 7412116 7411492 -624 -0.0
thermostat-no-ble arm64 (read only) 2368932 2368772 -160 -0.0
.text 1990432 1990272 -160 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191475 -32 -0.0
text 817100 817076 -24 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139195 -32 -0.0
text 789152 789124 -28 -0.0
p6 all-clusters-app default (read/write) 2545728 2545680 -48 -0.0
.text 1503992 1503944 -48 -0.0
all-clusters-minimal-app default (read/write) 2490592 2490560 -32 -0.0
.text 1448856 1448824 -32 -0.0
light-app default (read/write) 2422488 2422456 -32 -0.0
.text 1380752 1380720 -32 -0.0
lock-app default (read/write) 2442808 2442776 -32 -0.0
.text 1401072 1401040 -32 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 781016 780976 -40 -0.0
text 552406 552366 -40 -0.0
lighting-app tlsr9518adk80d (read/write) 801052 801012 -40 -0.0
text 569148 569108 -40 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 55ab764 aff91d0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689547 689515 -32 -0.0
(read/write) 162220 162252 32 0.0
.bss 74660 74660 0 0.0
.data 3404 3404 0 0.0
.rodata 111787 111787 0 0.0
.text 577444 577412 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640171 640139 -32 -0.0
(read/write) 158136 158136 0 0.0
.bss 73876 73876 0 0.0
.data 3344 3344 0 0.0
.rodata 88827 88827 0 0.0
.text 551020 550988 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 683027 682995 -32 -0.0
(read/write) 159804 159836 32 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97651 97651 0 0.0
.text 584896 584864 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 632435 632411 -24 -0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97531 97531 0 0.0
.text 534416 534392 -24 -0.0
pump-app LP_CC2652R7 (read only) 664099 664075 -24 -0.0
(read/write) 179636 179660 24 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85851 85851 0 0.0
.text 577768 577744 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655227 -32 -0.0
(read/write) 188588 188620 32 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83899 83899 0 0.0
.text 570880 570848 -32 -0.0
shell LP_CC2652R7 (read only) 681842 681810 -32 -0.0
(read/write) 165420 165452 32 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 108394 108394 0 0.0
.text 573132 573100 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602218 -24 -0.0
.app_xip_area 461268 461244 -24 -0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599270 -24 -0.0
.app_xip_area 458184 458160 -24 -0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596878 -32 -0.0
.app_xip_area 456932 456900 -32 -0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916152 916120 -32 -0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916144 916112 -32 -0.0
BRD4161A+rpc (read only) 950380 950332 -48 -0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950372 950324 -48 -0.0
BRD4161A+rs911x (read only) 791364 791332 -32 -0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791356 791324 -32 -0.0
lock-app BRD4161A+wf200 (read only) 958152 958136 -16 -0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958144 958128 -16 -0.0
window-app BRD4161A (read only) 901208 901176 -32 -0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901200 901168 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007758 -40 -0.0
(read/write) 1481490 1481490 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212240 212240 0 0.0
.flash.text 1007798 1007758 -40 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062743 1062719 -24 -0.0
(read/write) 483660 483660 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242776 242776 0 0.0
.flash.text 1057359 1057335 -24 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653400 653368 -32 -0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575592 -32 -0.0
lock k32w061+release (read/write) 714380 714348 -32 -0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636160 -32 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409140 -624 -0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7411492 -624 -0.0
thermostat-no-ble arm64 (read only) 2368932 2368772 -160 -0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990272 -160 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191475 -32 -0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817076 -24 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139195 -32 -0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789124 -28 -0.0
p6 all-clusters-app default (read/write) 2545728 2545680 -48 -0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503944 -48 -0.0
all-clusters-minimal-app default (read/write) 2490592 2490560 -32 -0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448824 -32 -0.0
light-app default (read/write) 2422488 2422456 -32 -0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380720 -32 -0.0
lock-app default (read/write) 2442808 2442776 -32 -0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401040 -32 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 781016 780976 -40 -0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552406 552366 -40 -0.0
lighting-app tlsr9518adk80d (read/write) 801052 801012 -40 -0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569148 569108 -40 -0.0

mrjerryjohns
mrjerryjohns reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@mrjerryjohns mrjerryjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic isn't quite right.

src/app/ReadHandler.h Outdated Show resolved Hide resolved
src/controller/tests/data_model/TestRead.cpp Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Jun 7, 2022
Closed
mrjerryjohns
mrjerryjohns reviewed Jun 7, 2022
View reviewed changes
src/app/ReadHandler.h Show resolved Hide resolved
src/app/ReadHandler.h Outdated Show resolved Hide resolved
src/app/ReadHandler.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/fix_max_computation branch from 03c9f05 to f1dfa08 Compare June 10, 2022 22:08
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19262: Size comparison from d1d5ca8 to f1dfa08

Increases (2 builds for linux)
platform target config section d1d5ca8 f1dfa08 change % change
linux chip-tool-no-interactive-ipv6only arm64 .rodata 468756 468788 32 0.0
thermostat-no-ble arm64 .rodata 161316 161332 16 0.0
Decreases (7 builds for cyw30739, linux, telink)
platform target config section d1d5ca8 f1dfa08 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606546 -16 -0.0
.app_xip_area 465068 465052 -16 -0.0
lock cyw930739m2evb_01 (read/write) 603670 603646 -24 -0.0
.app_xip_area 462032 462008 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611350 -40 -0.0
.app_xip_area 470824 470784 -40 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9563860 -592 -0.0
.text 7519604 7518980 -624 -0.0
thermostat-no-ble arm64 (read only) 2558364 2557916 -448 -0.0
.text 2159376 2158912 -464 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786764 -32 -0.0
text 556712 556674 -38 -0.0
lighting-app tlsr9518adk80d (read/write) 806808 806768 -40 -0.0
text 573428 573386 -42 -0.0
Full report (8 builds for cyw30739, linux, mbed, telink)
platform target config section d1d5ca8 f1dfa08 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606546 -16 -0.0
.app_xip_area 465068 465052 -16 -0.0
.bss 84424 84424 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603670 603646 -24 -0.0
.app_xip_area 462032 462008 -24 -0.0
.bss 84600 84600 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611350 -40 -0.0
.app_xip_area 470824 470784 -40 -0.0
.bss 83608 83608 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9563860 -592 -0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468788 32 0.0
.text 7519604 7518980 -624 -0.0
thermostat-no-ble arm64 (read only) 2558364 2557916 -448 -0.0
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161332 16 0.0
.text 2159376 2158912 -464 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786764 -32 -0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556712 556674 -38 -0.0
lighting-app tlsr9518adk80d (read/write) 806808 806768 -40 -0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573428 573386 -42 -0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_max_computation branch from f1dfa08 to 5ecf97a Compare June 10, 2022 22:31
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19262: Size comparison from d1d5ca8 to 5ecf97a

Increases (7 builds for cc13x2_26x2, linux)
platform target config section d1d5ca8 5ecf97a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 194536 194568 32 0.0
lock-ftd LP_CC2652R7 (read/write) 154244 154276 32 0.0
pump-app LP_CC2652R7 (read/write) 173796 173820 24 0.0
pump-controller-app LP_CC2652R7 (read/write) 183320 183352 32 0.0
shell LP_CC2652R7 (read/write) 159904 159928 24 0.0
linux chip-tool-no-interactive-ipv6only arm64 .rodata 468756 468788 32 0.0
thermostat-no-ble arm64 .rodata 161316 161332 16 0.0
Decreases (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section d1d5ca8 5ecf97a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656351 656319 -32 -0.0
.text 569512 569480 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644851 644819 -32 -0.0
.text 554496 554464 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 687715 687683 -32 -0.0
.text 588372 588340 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 637115 637091 -24 -0.0
.text 537884 537860 -24 -0.0
pump-app LP_CC2652R7 (read only) 669075 669051 -24 -0.0
.text 581612 581588 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659623 -32 -0.0
.text 574292 574260 -32 -0.0
shell LP_CC2652R7 (read only) 686478 686454 -24 -0.0
.text 576568 576544 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606546 -16 -0.0
.app_xip_area 465068 465052 -16 -0.0
lock cyw930739m2evb_01 (read/write) 603670 603646 -24 -0.0
.app_xip_area 462032 462008 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611358 -32 -0.0
.app_xip_area 470824 470792 -32 -0.0
efr32 lighting-app BRD4161A (read only) 919312 919280 -32 -0.0
.text 919304 919272 -32 -0.0
BRD4161A+rpc (read only) 953492 953460 -32 -0.0
.text 953484 953452 -32 -0.0
BRD4161A+rs911x (read only) 794396 794364 -32 -0.0
.text 794388 794356 -32 -0.0
lock-app BRD4161A+wf200 (read only) 962700 962652 -48 -0.0
.text 962692 962644 -48 -0.0
window-app BRD4161A (read only) 904368 904336 -32 -0.0
.text 904360 904328 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1011026 1010984 -42 -0.0
.flash.text 1011026 1010984 -42 -0.0
m5stack (read only) 1065471 1065439 -32 -0.0
.flash.text 1060087 1060055 -32 -0.0
k32w light k32w061+release (read/write) 657304 657272 -32 -0.0
.text 579736 579704 -32 -0.0
lock k32w061+release (read/write) 718916 718884 -32 -0.0
.text 640944 640912 -32 -0.0
linux all-clusters-app debug (read only) 2919449 2918857 -592 -0.0
.rodata 258269 258205 -64 -0.0
.text 2485554 2485026 -528 -0.0
all-clusters-minimal-app debug (read only) 2769785 2769193 -592 -0.0
.rodata 258685 258621 -64 -0.0
.text 2337986 2337458 -528 -0.0
bridge-app debug+rpc (read only) 2248145 2247553 -592 -0.0
.rodata 191104 191040 -64 -0.0
.text 1897058 1896530 -528 -0.0
chip-tool debug (read only) 9816789 9815973 -816 -0.0
.rodata 506869 506805 -64 -0.0
.text 7869301 7868549 -752 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9563860 -592 -0.0
.text 7519604 7518980 -624 -0.0
lighting-app debug+rpc (read only) 2498073 2497497 -576 -0.0
.rodata 207176 207144 -32 -0.0
.text 2122706 2122162 -544 -0.0
lock-app debug (read only) 2444073 2443465 -608 -0.0
.rodata 221256 221192 -64 -0.0
.text 2059618 2059074 -544 -0.0
ota-provider-app debug (read only) 2282321 2281729 -592 -0.0
.rodata 197400 197336 -64 -0.0
.text 1923730 1923202 -528 -0.0
ota-requestor-app debug (read only) 2329849 2329289 -560 -0.0
.rodata 199552 199520 -32 -0.0
.text 1965266 1964738 -528 -0.0
shell debug (read only) 2600209 2599937 -272 -0.0
.rodata 229842 229778 -64 -0.0
.text 2211074 2210866 -208 -0.0
thermostat-no-ble arm64 (read only) 2558364 2557916 -448 -0.0
.text 2159376 2158912 -464 -0.0
tv-app debug (read only) 3051705 3050873 -832 -0.0
.rodata 242784 242720 -64 -0.0
.text 2623138 2622370 -768 -0.0
tv-casting-app debug (read only) 5350793 5349977 -816 -0.0
.rodata 342432 342368 -64 -0.0
.text 4657090 4656338 -752 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195819 1195803 -16 -0.0
text 819936 819916 -20 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143579 1143563 -16 -0.0
text 792020 791992 -28 -0.0
p6 all-clusters-app default (read/write) 2549376 2549328 -48 -0.0
.text 1507640 1507592 -48 -0.0
all-clusters-minimal-app default (read/write) 2494176 2494128 -48 -0.0
.text 1452440 1452392 -48 -0.0
light-app default (read/write) 2425608 2425576 -32 -0.0
.text 1383872 1383840 -32 -0.0
lock-app default (read/write) 2446016 2445968 -48 -0.0
.text 1404280 1404232 -48 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786764 -32 -0.0
text 556712 556676 -36 -0.0
lighting-app tlsr9518adk80d (read/write) 806808 806768 -40 -0.0
text 573428 573388 -40 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1d5ca8 5ecf97a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656351 656319 -32 -0.0
(read/write) 194536 194568 32 0.0
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 86527 86527 0 0.0
.text 569512 569480 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644851 644819 -32 -0.0
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554496 554464 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 687715 687683 -32 -0.0
(read/write) 154244 154276 32 0.0
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588372 588340 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 637115 637091 -24 -0.0
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 537860 -24 -0.0
pump-app LP_CC2652R7 (read only) 669075 669051 -24 -0.0
(read/write) 173796 173820 24 0.0
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581612 581588 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 659655 659623 -32 -0.0
(read/write) 183320 183352 32 0.0
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574260 -32 -0.0
shell LP_CC2652R7 (read only) 686478 686454 -24 -0.0
(read/write) 159904 159928 24 0.0
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 109598 109598 0 0.0
.text 576568 576544 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606562 606546 -16 -0.0
.app_xip_area 465068 465052 -16 -0.0
.bss 84424 84424 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603670 603646 -24 -0.0
.app_xip_area 462032 462008 -24 -0.0
.bss 84600 84600 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611390 611358 -32 -0.0
.app_xip_area 470824 470792 -32 -0.0
.bss 83608 83608 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919312 919280 -32 -0.0
(read/write) 133432 133432 0 0.0
.bss 131320 131320 0 0.0
.data 2112 2112 0 0.0
.text 919304 919272 -32 -0.0
BRD4161A+rpc (read only) 953492 953460 -32 -0.0
(read/write) 150124 150124 0 0.0
.bss 147808 147808 0 0.0
.data 2316 2316 0 0.0
.text 953484 953452 -32 -0.0
BRD4161A+rs911x (read only) 794396 794364 -32 -0.0
(read/write) 129716 129716 0 0.0
.bss 127596 127596 0 0.0
.data 2120 2120 0 0.0
.text 794388 794356 -32 -0.0
lock-app BRD4161A+wf200 (read only) 962700 962652 -48 -0.0
(read/write) 130060 130060 0 0.0
.bss 127972 127972 0 0.0
.data 2088 2088 0 0.0
.text 962692 962644 -48 -0.0
window-app BRD4161A (read only) 904368 904336 -32 -0.0
(read/write) 133512 133512 0 0.0
.bss 131400 131400 0 0.0
.data 2108 2108 0 0.0
.text 904360 904328 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1011026 1010984 -42 -0.0
(read/write) 1482794 1482794 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213240 213240 0 0.0
.flash.text 1011026 1010984 -42 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065471 1065439 -32 -0.0
(read/write) 484896 484896 0 0.0
.dram0.bss 74936 74936 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243740 243740 0 0.0
.flash.text 1060087 1060055 -32 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657304 657272 -32 -0.0
.bss 69740 69740 0 0.0
.data 2028 2028 0 0.0
.text 579736 579704 -32 -0.0
lock k32w061+release (read/write) 718916 718884 -32 -0.0
.bss 70172 70172 0 0.0
.data 2000 2000 0 0.0
.text 640944 640912 -32 -0.0
linux all-clusters-app debug (read only) 2919449 2918857 -592 -0.0
(read/write) 188560 188560 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84520 84520 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258269 258205 -64 -0.0
.text 2485554 2485026 -528 -0.0
all-clusters-minimal-app debug (read only) 2769785 2769193 -592 -0.0
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258621 -64 -0.0
.text 2337986 2337458 -528 -0.0
bridge-app debug+rpc (read only) 2248145 2247553 -592 -0.0
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191040 -64 -0.0
.text 1897058 1896530 -528 -0.0
chip-tool debug (read only) 9816789 9815973 -816 -0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506805 -64 -0.0
.text 7869301 7868549 -752 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564452 9563860 -592 -0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468788 32 0.0
.text 7519604 7518980 -624 -0.0
lighting-app debug+rpc (read only) 2498073 2497497 -576 -0.0
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207144 -32 -0.0
.text 2122706 2122162 -544 -0.0
lock-app debug (read only) 2444073 2443465 -608 -0.0
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221192 -64 -0.0
.text 2059618 2059074 -544 -0.0
ota-provider-app debug (read only) 2282321 2281729 -592 -0.0
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197336 -64 -0.0
.text 1923730 1923202 -528 -0.0
ota-requestor-app debug (read only) 2329849 2329289 -560 -0.0
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199520 -32 -0.0
.text 1965266 1964738 -528 -0.0
shell debug (read only) 2600209 2599937 -272 -0.0
(read/write) 219416 219416 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77704 77704 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229778 -64 -0.0
.text 2211074 2210866 -208 -0.0
thermostat-no-ble arm64 (read only) 2558364 2557916 -448 -0.0
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161332 16 0.0
.text 2159376 2158912 -464 -0.0
tv-app debug (read only) 3051705 3050873 -832 -0.0
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242720 -64 -0.0
.text 2623138 2622370 -768 -0.0
tv-casting-app debug (read only) 5350793 5349977 -816 -0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342368 -64 -0.0
.text 4657090 4656338 -752 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2432808 0 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1395452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195819 1195803 -16 -0.0
bss 141591 141591 0 0.0
rodata 155316 155316 0 0.0
text 819936 819916 -20 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143579 1143563 -16 -0.0
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 792020 791992 -28 -0.0
p6 all-clusters-app default (read/write) 2549376 2549328 -48 -0.0
.bss 143416 143416 0 0.0
.data 2832 2832 0 0.0
.text 1507640 1507592 -48 -0.0
all-clusters-minimal-app default (read/write) 2494176 2494128 -48 -0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452440 1452392 -48 -0.0
light-app default (read/write) 2425608 2425576 -32 -0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383872 1383840 -32 -0.0
lock-app default (read/write) 2446016 2445968 -48 -0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404280 1404232 -48 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 786796 786764 -32 -0.0
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556712 556676 -36 -0.0
lighting-app tlsr9518adk80d (read/write) 806808 806768 -40 -0.0
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573428 573388 -40 -0.0

@bzbarsky-apple bzbarsky-apple merged commit 8066e35 into project-chip:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix computation of min/max interval for subscriptions to be spec compliant
5 participants
@yunhanw-google @msandstedt @mrjerryjohns @woody-apple @bzbarsky-apple