Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve identify all clusters #19060 #19247

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Resolve identify all clusters #19060 #19247

merged 4 commits into from
Jun 7, 2022

Conversation

adabreuti
Copy link
Contributor

Problem

All clusters & Shell applications crash on startup
Identify cluster fails to implement certain attributes in all clusters application

Change overview

  • Resolve shell and all-clusters application crashes
  • Add support for identify cluster stubs for all clusters app

Testing

Verified builds for shell, all clusters app (Min)
Verified shell example is able to boot
Verified all clusters identify cluster is working as expected in TC_I_2_3.
tc_I_2_3.log

@restyled-io restyled-io bot mentioned this pull request Jun 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 6, 2022 •
edited
Loading

PR #19247: Size comparison from 588c6fa to eb4caa7

Increases above 0.2%:

platform target config section 588c6fa eb4caa7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 689547 37884 5.8
(read/write) 158924 162220 3296 2.1
.rodata 85527 111787 26260 30.7
.text 565904 577444 11540 2.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 640171 22484 3.6
.rodata 74959 88827 13868 18.5
.text 542496 551020 8524 1.6
shell LP_CC2652R7 (read only) 644702 681842 37140 5.8
(read/write) 154480 165420 10940 7.1
.rodata 82510 108394 25884 31.4
.text 561956 573132 11176 2.0
Increases (3 builds for cc13x2_26x2)
platform target config section 588c6fa eb4caa7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 689547 37884 5.8
(read/write) 158924 162220 3296 2.1
.bss 74604 74660 56 0.1
.rodata 85527 111787 26260 30.7
.text 565904 577444 11540 2.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 640171 22484 3.6
(read/write) 158080 158136 56 0.0
.bss 73820 73876 56 0.1
.rodata 74959 88827 13868 18.5
.text 542496 551020 8524 1.6
shell LP_CC2652R7 (read only) 644702 681842 37140 5.8
(read/write) 154480 165420 10940 7.1
.rodata 82510 108394 25884 31.4
.text 561956 573132 11176 2.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 588c6fa eb4caa7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 689547 37884 5.8
(read/write) 158924 162220 3296 2.1
.bss 74604 74660 56 0.1
.data 3404 3404 0 0.0
.rodata 85527 111787 26260 30.7
.text 565904 577444 11540 2.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 640171 22484 3.6
(read/write) 158080 158136 56 0.0
.bss 73820 73876 56 0.1
.data 3344 3344 0 0.0
.rodata 74959 88827 13868 18.5
.text 542496 551020 8524 1.6
lock-ftd LP_CC2652R7 (read only) 683027 683027 0 0.0
(read/write) 159804 159804 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97651 97651 0 0.0
.text 584896 584896 0 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632435 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97531 97531 0 0.0
.text 534416 534416 0 0.0
pump-app LP_CC2652R7 (read only) 664099 664099 0 0.0
(read/write) 179636 179636 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85851 85851 0 0.0
.text 577768 577768 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655259 0 0.0
(read/write) 188588 188588 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83899 83899 0 0.0
.text 570880 570880 0 0.0
shell LP_CC2652R7 (read only) 644702 681842 37140 5.8
(read/write) 154480 165420 10940 7.1
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 82510 108394 25884 31.4
.text 561956 573132 11176 2.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602242 0 0.0
.app_xip_area 461268 461268 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599294 0 0.0
.app_xip_area 458184 458184 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596910 0 0.0
.app_xip_area 456932 456932 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916152 916152 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916144 916144 0 0.0
BRD4161A+rpc (read only) 950380 950380 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950372 950372 0 0.0
BRD4161A+rs911x (read only) 791364 791364 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791356 791356 0 0.0
lock-app BRD4161A+wf200 (read only) 958152 958152 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958144 958144 0 0.0
window-app BRD4161A (read only) 901208 901208 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901200 901200 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007798 0 0.0
(read/write) 1481490 1481490 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212240 212240 0 0.0
.flash.text 1007798 1007798 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062743 1062743 0 0.0
(read/write) 483660 483660 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242776 242776 0 0.0
.flash.text 1057359 1057359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653400 653400 0 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575624 0 0.0
lock k32w061+release (read/write) 714380 714380 0 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636192 0 0.0
linux all-clusters-app debug (read only) 2779289 2779289 0 0.0
(read/write) 178568 178568 0 0.0
.bss 86368 86368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 246205 246205 0 0.0
.text 2359154 2359154 0 0.0
all-clusters-minimal-app debug (read only) 2654849 2654849 0 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2234258 2234258 0 0.0
bridge-app debug+rpc (read only) 2032521 2032521 0 0.0
(read/write) 147960 147960 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65544 65544 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1706130 1706130 0 0.0
chip-tool debug (read only) 9660453 9660453 0 0.0
(read/write) 606448 606448 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 575064 575064 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497277 497277 0 0.0
.text 7761349 7761349 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409764 0 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412116 0 0.0
lighting-app debug+rpc (read only) 2322777 2322777 0 0.0
(read/write) 153632 153632 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71064 71064 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1968210 1968210 0 0.0
lock-app debug (read only) 2266001 2266001 0 0.0
(read/write) 148736 148736 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1902546 1902546 0 0.0
ota-provider-app debug (read only) 2067105 2067105 0 0.0
(read/write) 141616 141616 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61032 61032 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726722 1726722 0 0.0
ota-requestor-app debug (read only) 2095025 2095025 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1757266 1757266 0 0.0
shell debug (read only) 2584129 2584129 0 0.0
(read/write) 201976 201976 0 0.0
.bss 117224 117224 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77632 77632 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 226258 226258 0 0.0
.text 2198450 2198450 0 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
tv-app debug (read only) 2880833 2880833 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223072 223072 0 0.0
.text 2475106 2475106 0 0.0
tv-casting-app debug (read only) 5330409 5330409 0 0.0
(read/write) 222704 222704 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135440 135440 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337408 337408 0 0.0
.text 4641762 4641762 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191507 0 0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139227 0 0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789152 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545728 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503992 0 0.0
all-clusters-minimal-app default (read/write) 2490592 2490592 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448856 0 0.0
light-app default (read/write) 2422488 2422488 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380752 0 0.0
lock-app default (read/write) 2442808 2442808 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401072 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781008 781008 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552400 552400 0 0.0
lighting-app tlsr9518adk80d (read/write) 801052 801052 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569142 569142 0 0.0

@andy31415 andy31415 merged commit 55ab764 into project-chip:master Jun 7, 2022
@adabreuti adabreuti deleted the Resolve_Identify_All_clusters_19060 branch June 7, 2022 18:59
@adabreuti adabreuti changed the title Resolve identify all clusters 19060 Resolve identify all clusters #19060 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adabreuti @andy31415 @bzbarsky-apple